D8316: Add a pure virtual method to Platform to describe the supported compositors
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY So far KWin does not know which Compositors the platform actually supports. This results in KWin happily trying to use the OpenGL compositor on fbdev or the QPainter compositor on hwcomposer although that is obviously going to fail as the platform doesn't support this. By adding a pure virtual method all Platforms can define what they support. In a later step the Compositor can use this to create an appropriate scene and also perform proper fallback handling in case the scene creation fails. TEST PLAN Compiles REPOSITORY R108 KWin BRANCH platform-supported-compositors REVISION DETAIL https://phabricator.kde.org/D8316 AFFECTED FILES platform.h plugins/platforms/drm/drm_backend.cpp plugins/platforms/drm/drm_backend.h plugins/platforms/fbdev/fb_backend.h plugins/platforms/hwcomposer/hwcomposer_backend.h plugins/platforms/virtual/virtual_backend.h plugins/platforms/wayland/wayland_backend.cpp plugins/platforms/wayland/wayland_backend.h plugins/platforms/x11/standalone/x11_platform.cpp plugins/platforms/x11/standalone/x11_platform.h plugins/platforms/x11/windowed/x11windowed_backend.h To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D8316: Add a pure virtual method to Platform to describe the supported compositors
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH platform-supported-compositors REVISION DETAIL https://phabricator.kde.org/D8316 To: graesslin, #kwin, #plasma, davidedmundson Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
D8316: Add a pure virtual method to Platform to describe the supported compositors
This revision was automatically updated to reflect the committed changes. Closed by commit R108:09489a4c2b5b: Add a pure virtual method to Platform to describe the supported compositors (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8316?vs=20819&id=20961#toc REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8316?vs=20819&id=20961 REVISION DETAIL https://phabricator.kde.org/D8316 AFFECTED FILES platform.h plugins/platforms/drm/drm_backend.cpp plugins/platforms/drm/drm_backend.h plugins/platforms/fbdev/fb_backend.h plugins/platforms/hwcomposer/hwcomposer_backend.h plugins/platforms/virtual/virtual_backend.h plugins/platforms/wayland/wayland_backend.cpp plugins/platforms/wayland/wayland_backend.h plugins/platforms/x11/standalone/x11_platform.cpp plugins/platforms/x11/standalone/x11_platform.h plugins/platforms/x11/windowed/x11windowed_backend.h To: graesslin, #kwin, #plasma, davidedmundson Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
