D8443: Revert "Make the kde-gtk-config kcm better at checking global gtk settings"
apol added a comment. Well this breaks supporting having configuration over in `/etc`, so indeed this wasn't tested. It's unfortunate that the only solution we always end up in is reverting stuff rather than actual investigation. Oh well, I'll spend some time on this at some point. :( REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D8443 To: fvogt, #plasma, apol, davidedmundson Cc: ngraham, davidedmundson, rikmills, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8443: Revert "Make the kde-gtk-config kcm better at checking global gtk settings"
This revision was automatically updated to reflect the committed changes. Closed by commit R99:0d0f812a1704: Revert Make the kde-gtk-config kcm better at checking global gtk settings (authored by fvogt). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8443?vs=21230=21234 REVISION DETAIL https://phabricator.kde.org/D8443 AFFECTED FILES CMakeLists.txt src/abstractappearance.h src/appearancegtk2.cpp src/appearancegtk2.h src/appearancegtk3.cpp src/appearancegtk3.h src/appearencegtk.cpp tests/CMakeLists.txt tests/configsavetest.cpp tests/configsavetest.h To: fvogt, #plasma, apol, davidedmundson Cc: ngraham, davidedmundson, rikmills, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8443: Revert "Make the kde-gtk-config kcm better at checking global gtk settings"
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Heh, so much for unit tests. Hopefully we can revisit this for master and try and fix whatever the original one was doing. REPOSITORY R99 KDE Gtk Configuration Tool BRANCH revert REVISION DETAIL https://phabricator.kde.org/D8443 To: fvogt, #plasma, apol, davidedmundson Cc: davidedmundson, rikmills, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8443: Revert "Make the kde-gtk-config kcm better at checking global gtk settings"
rikmills added a comment. I made the same revert to test earlier this morning, and on **brief** testing it seems to have solved the issue, and tests still pass. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D8443 To: fvogt, #plasma, apol Cc: rikmills, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8443: Revert "Make the kde-gtk-config kcm better at checking global gtk settings"
fvogt created this revision. fvogt added reviewers: Plasma, apol. Restricted Application added a project: Plasma. REVISION SUMMARY This reverts commit https://phabricator.kde.org/R99:34357f74ee2d98128ff423b0ec6ddcbf4232c475. Reverting this fixes loading of the actually used GTK settings. BUG: 382291 TEST PLAN Opened kcmshell5 kde-gtk-config with and without this revert. Without, it shows Adwaita as theme, with it shows breeze. GTK uses breeze, so the behaviour with the revert is correct. REPOSITORY R99 KDE Gtk Configuration Tool BRANCH revert REVISION DETAIL https://phabricator.kde.org/D8443 AFFECTED FILES CMakeLists.txt src/abstractappearance.h src/appearancegtk2.cpp src/appearancegtk2.h src/appearancegtk3.cpp src/appearancegtk3.h src/appearencegtk.cpp tests/CMakeLists.txt tests/configsavetest.cpp tests/configsavetest.h To: fvogt, #plasma, apol Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
