D8564: Disallow drop of task manager icons outside of plasmoid when widgets are locked
ngraham added a comment. This came up again recently as a user pain point: https://www.reddit.com/r/kde/comments/7vnxhc/plasma_512_is_out_and_it_is_faster_stabler_and/dttyqwi/?utm_content=permalink&utm_medium=front&utm_source=reddit&utm_name=kde REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8564 To: emateli, plasma-devel, #plasma, #vdg Cc: ngraham, davidedmundson, romangg, hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8564: Disallow drop of task manager icons outside of plasmoid when widgets are locked
hein added a comment. Sorry Emirald. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8564 To: emateli, plasma-devel, #plasma, #vdg Cc: ngraham, davidedmundson, romangg, hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8564: Disallow drop of task manager icons outside of plasmoid when widgets are locked
emateli abandoned this revision. emateli added a comment. Closing this since we're unable to reach a consensus. None of the proposed changes are how I envision the patch to work. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8564 To: emateli, plasma-devel, #plasma, #vdg Cc: ngraham, davidedmundson, romangg, hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8564: Disallow drop of task manager icons outside of plasmoid when widgets are locked
ngraham added a reviewer: VDG. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8564 To: emateli, plasma-devel, #plasma, #vdg Cc: ngraham, davidedmundson, romangg, hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8564: Disallow drop of task manager icons outside of plasmoid when widgets are locked
ngraham added a comment. We discussed the matter in the VDG Telegram room this morning and came up with some alternative ideas: - Ignore drag operations that fall below a certain threshold, to only allow clear and purposeful drags and filter out accidental drags caused by imprecise input devices or low mousing skills - Activate Taskbar button on click, not release Both of these together would probably be pretty nice, and also mirror the draggable tab behavior in most apps. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8564 To: emateli, plasma-devel, #plasma Cc: ngraham, davidedmundson, romangg, hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8564: Disallow drop of task manager icons outside of plasmoid when widgets are locked
emateli added a comment. In https://phabricator.kde.org/D8564#179707, @ngraham wrote: > I found at least one user during my triaging of Task Manager bug who was sufficiently motivated to file a bug that this would resolve: https://bugs.kde.org/show_bug.cgi?id=361984 I don't think that just because we have a bug report, that should influence on which direction this patch takes. I personally view it as a basic usability problem. It's easily reproducible on laptop touchpads, and happens every once in a while in desktops as well (especially when the system hangs even for half a second at the moment you click a task icon). The feature(??) this provides is such a rarely used case(if ever) for it to be on such a prominent place. Anyhow, since we're at it, let's discuss it once more and see if we can reach a decision whether this is a positive change that we want to go in or not. I've made my case on why this should go in in the previous comments. Other than that, if the implementation is the correct one or not, it's an entirely different matter. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8564 To: emateli, plasma-devel, #plasma Cc: ngraham, davidedmundson, romangg, hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8564: Disallow drop of task manager icons outside of plasmoid when widgets are locked
ngraham added a comment. I found at least one user during my triaging of Task Manager bug who was sufficiently motivated to file a bug that this would resolve: https://bugs.kde.org/show_bug.cgi?id=361984 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8564 To: emateli, plasma-devel, #plasma Cc: ngraham, davidedmundson, romangg, hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8564: Disallow drop of task manager icons outside of plasmoid when widgets are locked
ngraham edited the summary of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8564 To: emateli, plasma-devel, #plasma Cc: ngraham, davidedmundson, romangg, hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8564: Disallow drop of task manager icons outside of plasmoid when widgets are locked
ngraham added a comment. I think the question we need to ask ourselves is whether the ability to create .desktop shortcuts by dragging from the task manager is useful to enough people to outweigh the confusion and frustration to other people caused by unwanted drags. As a compromise, maybe we could only start a drag operation if the mouse goes 50-100 pixels beyond the task manager? This is what the macOS Dock does to prevent unwanted drags: If you drag-and-drop within a hundred pixels of the Dock, the icon springs back. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8564 To: emateli, plasma-devel, #plasma Cc: ngraham, davidedmundson, subdiff, hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8564: Disallow drop of task manager icons outside of plasmoid when widgets are locked
emateli added a comment. > To be honest - dropping the patch. I feel as that's the easy part. > Sure. The URL to the .desktop file is the exchange-ready representation for an app, which the task item is a delegate for. I don't see a good reason not to be able to drag one, considering you can do elsewhere in UI (launchers, file view items, ...). It's just consistent DND support in the system. But is it necessary though to be performed from the Task Manager? That leads only to unwanted behavior. If one really wants to do that or has a use case for it then I assume KRunner or the Application Launcher can pick up the slack. Also I think it's note worthy that as you probably know no major (and I say major to cover my bases, but it's probably all of them) DE supports this kind of behavior. Maybe they missed the memo on this being a useful feature. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8564 To: emateli, plasma-devel, #plasma Cc: ngraham, davidedmundson, subdiff, hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8564: Disallow drop of task manager icons outside of plasmoid when widgets are locked
hein added a comment. > What would you propose? To be honest - dropping the patch. > But is the dragging around into external applications of .desktop files a feature that we want? Sure. The URL to the .desktop file is the exchange-ready representation for an app, which the task item is a delegate for. I don't see a good reason not to be able to drag one, considering you can do elsewhere in UI (launchers, file view items, ...). It's just consistent DND support in the system. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8564 To: emateli, plasma-devel, #plasma Cc: ngraham, davidedmundson, subdiff, hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8564: Disallow drop of task manager icons outside of plasmoid when widgets are locked
ngraham added a comment. FWIW, I do approve of the goal here. I can't imagine that any more than a very very tiny fraction of all drags to the desktop or into a web browser or text editor window are intentional. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8564 To: emateli, plasma-devel, #plasma Cc: ngraham, davidedmundson, subdiff, hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8564: Disallow drop of task manager icons outside of plasmoid when widgets are locked
emateli added a comment. > Task Manager items are not widgets, it's content, and the widget mutability state should not affect content drags. I don't see why it can't. Task manager items can be aware of the panel state if that's needed. > "If widgets are locked, stop adding a certain kind of data to the drag" is a pretty bad hack. What would you propose? I tried cancelling the drag once it moved outside of the panel but it wouldn't work. Right now the task manager doesnt need the URL list for it's operations to work. By removing it, external apps do not accept the drop which is kind of what we want. Also as previously mentioned the only valid drop target I can see for them is the desktop, which in it's current state does not create the shortcut if widgets are locked anyways. --- Also please help me out here since maybe I'm missing something. But is the dragging around into external applications of `.desktop` files a feature that we want? I always assumed it was a sort of bug or something that was simply not handled since I really don't see a use for it, but I'm also not well versed in everything Plasma does. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8564 To: emateli, plasma-devel, #plasma Cc: davidedmundson, subdiff, hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8564: Disallow drop of task manager icons outside of plasmoid when widgets are locked
subdiff added a comment. In https://phabricator.kde.org/D8564#162797, @emateli wrote: > I feel like the long press can mess with the manual ordering of task manager icons. **Short press** Press -> start timer release -> single click on task timer stops Press -> start timer cursor leaves task but stays in task manager area start drag confined to task manager release-> manual reorder tasks timer stops Press -> start timer cursor leaves taskbar release -> single click on task timer stops Press -> start timer cursor leaves taskbar timer stops release -> noop **Long press** Press -> start timer timer stops start drag cursor leaves task but stays in task manager area release-> manual reorder tasks Press -> start timer timer stops start drag cursor leaves taskbar release->drag REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8564 To: emateli, plasma-devel, #plasma Cc: davidedmundson, subdiff, hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8564: Disallow drop of task manager icons outside of plasmoid when widgets are locked
davidedmundson added a comment. Sounds like we want what is something similar to https://phabricator.kde.org/R296:86bbebdee213f08ae615d7459304cbd17f6b7d7d in kdeclarative's DragArea REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8564 To: emateli, plasma-devel, #plasma Cc: davidedmundson, subdiff, hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8564: Disallow drop of task manager icons outside of plasmoid when widgets are locked
emateli added a comment. I feel like the long press can mess with the manual ordering of task manager icons. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8564 To: emateli, plasma-devel, #plasma Cc: subdiff, hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8564: Disallow drop of task manager icons outside of plasmoid when widgets are locked
subdiff added a comment. That said accidental drags from the task manager are really a common issue. Could we do some sort of double-tap-and-drag instead of just drag to minimize the risk for an accidental drag? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8564 To: emateli, plasma-devel, #plasma Cc: subdiff, hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8564: Disallow drop of task manager icons outside of plasmoid when widgets are locked
hein added a comment. I still don't like it, sorry - the patch also feels technically and semantically wrong to me. "If widgets are locked, stop adding a certain kind of data to the drag" is a pretty bad hack. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8564 To: emateli, plasma-devel, #plasma Cc: hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8564: Disallow drop of task manager icons outside of plasmoid when widgets are locked
emateli added a comment. Hi @hein, thanks for your input and I understand that this might break some functionality that I'm unaware of (such as the drop of task manager icons into the pager widget). The current revision allows drop into the pager widget and other plasma widgets(needs more testing on this) and the incoming drops are accepted. So from the launcher one can still drop icons to create shortcuts. This patch is mostly so that drops from the task manager do not go into external programs. Also, even in it's current form dropping task manager icons to a desktop with locked widgets will not create the shortcut regardless. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8564 To: emateli, plasma-devel, #plasma Cc: hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8564: Disallow drop of task manager icons outside of plasmoid when widgets are locked
emateli updated this revision to Diff 21689. emateli added a comment. Remove empty line REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8564?vs=21688&id=21689 BRANCH disable-drop REVISION DETAIL https://phabricator.kde.org/D8564 AFFECTED FILES applets/taskmanager/package/contents/ui/Task.qml applets/taskmanager/plugin/draghelper.cpp To: emateli, plasma-devel, #plasma Cc: hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8564: Disallow drop of task manager icons outside of plasmoid when widgets are locked
emateli updated this revision to Diff 21688. emateli added a comment. Allow task items to be dropped onto other widgets REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8564?vs=21606&id=21688 BRANCH disable-drop REVISION DETAIL https://phabricator.kde.org/D8564 AFFECTED FILES applets/taskmanager/package/contents/ui/Task.qml applets/taskmanager/plugin/draghelper.cpp To: emateli, plasma-devel, #plasma Cc: hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8564: Disallow drop of task manager icons outside of plasmoid when widgets are locked
hein added a comment. As-is I would not accept this patch, I'm sorry. Task Manager items are not widgets, it's content, and the widget mutability state should not affect content drags. This particular drag is used for workspace features some people do rely on, e.g.: - moving a window to a different virtual desktop or activity by dropping it somewhere on the Pager widget - adding a launcher button or menu favorite somewhere If accidental drags are a frequent issue, perhaps we need to address it in some other way. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8564 To: emateli, plasma-devel, #plasma Cc: hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8564: Disallow drop of task manager icons outside of plasmoid when widgets are locked
emateli added a reviewer: Plasma. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8564 To: emateli, plasma-devel, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8564: Disallow drop of task manager icons outside of plasmoid when widgets are locked
emateli added a subscriber: plasma-devel. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8564 To: emateli, plasma-devel Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8564: Disallow drop of task manager icons outside of plasmoid when widgets are locked
emateli retitled this revision from "Disallow drop of task manager widgets outside of plasmoid when locked" to "Disallow drop of task manager icons outside of plasmoid when widgets are locked". REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8564 To: emateli, plasma-devel Cc: ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
