D8820: Don't notify about value changes if we are still in the constructor

2017-11-15 Thread Aleix Pol Gonzalez 
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:09efedec8c71: Don't notify about value changes if we 
are still in the constructor (authored by apol).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8820?vs=22368&id=22395

REVISION DETAIL
  https://phabricator.kde.org/D8820

AFFECTED FILES
  src/libkirigami/platformtheme.cpp

To: apol, #frameworks, davidedmundson
Cc: davidedmundson, broulik, plasma-devel, apol, mart, hein

D8820: Don't notify about value changes if we are still in the constructor

2017-11-15 Thread David Edmundson 
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8820

To: apol, #frameworks, davidedmundson
Cc: davidedmundson, broulik, plasma-devel, apol, mart, hein

D8820: Don't notify about value changes if we are still in the constructor

2017-11-15 Thread Aleix Pol Gonzalez 
apol added a comment.


  > If you're emitting something in the constructor, how could a UI be 
connected to it?
  
  There's a timer.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D8820

To: apol, #frameworks
Cc: davidedmundson, broulik, plasma-devel, apol, mart, hein

D8820: Don't notify about value changes if we are still in the constructor

2017-11-15 Thread David Edmundson 
davidedmundson added a comment.


  > it will make the UI react to it at some point
  
  If you're emitting something in the constructor, how could a UI be connected 
to it?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D8820

To: apol, #frameworks
Cc: davidedmundson, broulik, plasma-devel, apol, mart, hein

D8820: Don't notify about value changes if we are still in the constructor

2017-11-14 Thread Aleix Pol Gonzalez 
apol updated this revision to Diff 22368.
apol added a comment.


  Remove debug variable

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8820?vs=22359&id=22368

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8820

AFFECTED FILES
  src/libkirigami/platformtheme.cpp

To: apol, #frameworks
Cc: broulik, plasma-devel, apol, davidedmundson, mart, hein

D8820: Don't notify about value changes if we are still in the constructor

2017-11-14 Thread Kai Uwe Broulik 
broulik added inline comments.

INLINE COMMENTS

> platformtheme.cpp:159
> +if (!d->m_init) {
> +static int i = 0;
> +emit colorSetChanged(colorSet);

Unused

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D8820

To: apol, #frameworks
Cc: broulik, plasma-devel, apol, davidedmundson, mart, hein

D8820: Don't notify about value changes if we are still in the constructor

2017-11-14 Thread Aleix Pol Gonzalez 
apol created this revision.
apol added a reviewer: Frameworks.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Since we are using the timer, it will make the UI react to it at some point
  despite it not really changing.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8820

AFFECTED FILES
  src/libkirigami/platformtheme.cpp

To: apol, #frameworks
Cc: plasma-devel, apol, davidedmundson, mart, hein