D9019: [Calendar] Adjust the calendar toolbar anchors
This revision was automatically updated to reflect the committed changes. Closed by commit R242:55efe5ae6357: [Calendar] Adjust the calendar toolbar anchors (authored by akulichalexandr). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9019?vs=23032&id=25449 REVISION DETAIL https://phabricator.kde.org/D9019 AFFECTED FILES src/declarativeimports/calendar/qml/DaysCalendar.qml To: akulichalexandr, #plasma, broulik Cc: aacid, davidedmundson, broulik, plasma-devel, #plasma, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9019: [Calendar] Adjust the calendar toolbar anchors
aacid added a comment. In https://phabricator.kde.org/D9019#172645, @akulichalexandr wrote: > In https://phabricator.kde.org/D9019#172612, @broulik wrote: > > > Thanks! It's the little things that make it feel polished :) > > > > Do you have commit access? > > > Yes, I have the access, but I did not contribute for a long time and still have to get used to Phabricator. > Thank you for the review, I'll push the commit once I'll figure out how to do it properly nowadays. :-) Since you seem to have used arc properly, this will do arc patch https://phabricator.kde.org/D9019 arc land I can do it for you if you want REPOSITORY R242 Plasma Framework (Library) BRANCH upstreaming REVISION DETAIL https://phabricator.kde.org/D9019 To: akulichalexandr, #plasma, broulik Cc: aacid, davidedmundson, broulik, plasma-devel, #plasma, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9019: [Calendar] Adjust the calendar toolbar anchors
davidedmundson added a comment. > but I did not contribute for a long time Good to have you back! REPOSITORY R242 Plasma Framework (Library) BRANCH upstreaming REVISION DETAIL https://phabricator.kde.org/D9019 To: akulichalexandr, #plasma, broulik Cc: davidedmundson, broulik, plasma-devel, #plasma, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9019: [Calendar] Adjust the calendar toolbar anchors
akulichalexandr added a comment. In https://phabricator.kde.org/D9019#172612, @broulik wrote: > Thanks! It's the little things that make it feel polished :) > > Do you have commit access? Yes, I have the access, but I did not contribute for a long time and still have to get used to Phabricator. Thank you for the review, I'll push the commit once I'll figure out how to do it properly nowadays. :-) REPOSITORY R242 Plasma Framework (Library) BRANCH upstreaming REVISION DETAIL https://phabricator.kde.org/D9019 To: akulichalexandr, #plasma, broulik Cc: broulik, plasma-devel, #plasma, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9019: [Calendar] Adjust the calendar toolbar anchors
broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Thanks! It's the little things that make it feel polished :) Do you have commit access? REPOSITORY R242 Plasma Framework (Library) BRANCH upstreaming REVISION DETAIL https://phabricator.kde.org/D9019 To: akulichalexandr, #plasma, broulik Cc: broulik, plasma-devel, #plasma, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9019: [Calendar] Adjust the calendar toolbar anchors
akulichalexandr edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9019 To: akulichalexandr, #plasma Cc: plasma-devel, #plasma, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9019: [Calendar] Adjust the calendar toolbar anchors
akulichalexandr retitled this revision from "Plasma: Adjust the calendar toolbar layout" to "[Calendar] Adjust the calendar toolbar anchors". akulichalexandr edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9019 To: akulichalexandr, #plasma Cc: plasma-devel, #plasma, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9019: [Calendar] Adjust the calendar toolbar anchors
akulichalexandr edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9019 To: akulichalexandr, #plasma Cc: plasma-devel, #plasma, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart