D9638: [effects] add 'Slide Desktops' effect

[Vlad Zagorodniy]

zzag updated this revision to Diff 25273.
zzag added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  Replace old slide effect with this one.

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9638?vs=24932=25273

BRANCH
  effects/slide

REVISION DETAIL
  https://phabricator.kde.org/D9638

AFFECTED FILES
  effects/effect_builtins.cpp
  effects/slide/slide.cpp
  effects/slide/slide.h
  effects/slide/slide.kcfg
  effects/slide/slide_config.cpp
  effects/slide/slide_config.h
  effects/slide/slide_config.ui

To: zzag, #vdg, #kwin, #plasma
Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, iodelay, bwowk, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, 
apol

D9638: [effects] add 'Slide Desktops' effect

[Vlad Zagorodniy]

zzag added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  In https://phabricator.kde.org/D9638#190031, @graesslin wrote:
  
  > as we had quite positive feedback on the replacement idea: could you please 
rework the patch to replace the old effect?
  
  
  OK.
  
  Correct me if I'm wrong. This effect should be renamed to `Slide`.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D9638: [effects] add 'Slide Desktops' effect

[Martin Flöser]

graesslin added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  as we had quite positive feedback on the replacement idea: could you please 
rework the patch to replace the old effect?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, iodelay, bwowk, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, 
apol

D9638: [effects] add 'Slide Desktops' effect

[Marco Martin]

mart added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  In https://phabricator.kde.org/D9638#185720, @graesslin wrote:
  
  > Just putting it as an idea: maybe we should just drop the "old" slide 
desktop effect and replace it with this one?
  
  
  +1

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D9638: [effects] add 'Slide Desktops' effect

[Vlad Zagorodniy]

zzag added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  Added 'Slide docks' option:
  
  F5629578: new-option.png 
  
  We need to disable sliding docks, for example, when using latte-dock.
  
  F5629577: slidedesktops-dont-slide-docks.mp4 


REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: graesslin, abetts, ngraham, plasma-devel, kwin, iodelay, bwowk, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, apol, mart

D9638: [effects] add 'Slide Desktops' effect

[Vlad Zagorodniy]

zzag updated this revision to Diff 24932.
zzag added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  Updating https://phabricator.kde.org/D9638: [effects] add 'Slide Desktops' 
effect
  
  - Add 'Slide docks' option

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9638?vs=24699=24932

BRANCH
  effects/slidedesktops

REVISION DETAIL
  https://phabricator.kde.org/D9638

AFFECTED FILES
  autotests/test_builtin_effectloader.cpp
  autotests/test_plugin_effectloader.cpp
  autotests/test_scripted_effectloader.cpp
  effects/CMakeLists.txt
  effects/effect_builtins.cpp
  effects/effect_builtins.h
  effects/slidedesktops/CMakeLists.txt
  effects/slidedesktops/slidedesktops.cpp
  effects/slidedesktops/slidedesktops.h
  effects/slidedesktops/slidedesktops.kcfg
  effects/slidedesktops/slidedesktops_config.cpp
  effects/slidedesktops/slidedesktops_config.desktop
  effects/slidedesktops/slidedesktops_config.h
  effects/slidedesktops/slidedesktops_config.ui
  effects/slidedesktops/slidedesktopsconfig.kcfgc

To: zzag, #vdg, #kwin, #plasma
Cc: graesslin, abetts, ngraham, plasma-devel, kwin, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D9638: [effects] add 'Slide Desktops' effect

[Vlad Zagorodniy]

zzag added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  Memory allocations in `SlideDesktopsEffect::paintScreen()` creep me out. We 
should not allocate memory during paint calls! If you have any ideas how to 
solve this, please let me know. Currently, I'm thinking about reusing a 
vector(for `visibleDesktops`) and a boolean matrix(for 
`m_paintCtx.fullscreenWindows`; I guess name should be changed).

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: graesslin, abetts, ngraham, plasma-devel, kwin, iodelay, bwowk, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, apol, mart

D9638: [effects] add 'Slide Desktops' effect

[Vlad Zagorodniy]

zzag added inline comments.
Restricted Application edited projects, added Plasma; removed KWin.

INLINE COMMENTS

> zzag wrote in slidedesktops.h:60
> Yeah, I know `slots`/`Q_SLOTS` keyword is optional with Qt 5, but I would 
> like to keep it to avoid some misunderstandings(e.g. "who the hell calls this 
> method", etc)

`*` in Qt 5

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: graesslin, abetts, ngraham, plasma-devel, kwin, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D9638: [effects] add 'Slide Desktops' effect

[Vlad Zagorodniy]

zzag updated this revision to Diff 24699.
zzag added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  Updating https://phabricator.kde.org/D9638: [effects] add 'Slide Desktops' 
effect
  
  Squash commits.

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9638?vs=24698=24699

BRANCH
  effects/slidedesktops

REVISION DETAIL
  https://phabricator.kde.org/D9638

AFFECTED FILES
  autotests/test_builtin_effectloader.cpp
  autotests/test_plugin_effectloader.cpp
  autotests/test_scripted_effectloader.cpp
  effects/CMakeLists.txt
  effects/effect_builtins.cpp
  effects/effect_builtins.h
  effects/slidedesktops/CMakeLists.txt
  effects/slidedesktops/slidedesktops.cpp
  effects/slidedesktops/slidedesktops.h
  effects/slidedesktops/slidedesktops.kcfg
  effects/slidedesktops/slidedesktops_config.cpp
  effects/slidedesktops/slidedesktops_config.desktop
  effects/slidedesktops/slidedesktops_config.h
  effects/slidedesktops/slidedesktops_config.ui
  effects/slidedesktops/slidedesktopsconfig.kcfgc

To: zzag, #vdg, #kwin, #plasma
Cc: graesslin, abetts, ngraham, plasma-devel, kwin, iodelay, bwowk, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, apol, mart

D9638: [effects] add 'Slide Desktops' effect

[Vlad Zagorodniy]

zzag marked 6 inline comments as done.
Restricted Application edited projects, added Plasma; removed KWin.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: graesslin, abetts, ngraham, plasma-devel, kwin, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D9638: [effects] add 'Slide Desktops' effect

[Vlad Zagorodniy]

zzag updated this revision to Diff 24698.
zzag added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  Updating https://phabricator.kde.org/D9638: [effects] add 'Slide Desktops' 
effect
  
  Use QVector instead of QList, replace Q_FOREACH with range-based for loops.

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9638?vs=24667=24698

BRANCH
  effects/slidedesktops

REVISION DETAIL
  https://phabricator.kde.org/D9638

AFFECTED FILES
  effects/slidedesktops/slidedesktops.cpp

To: zzag, #vdg, #kwin, #plasma
Cc: graesslin, abetts, ngraham, plasma-devel, kwin, iodelay, bwowk, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, apol, mart

D9638: [effects] add 'Slide Desktops' effect

[Vlad Zagorodniy]

zzag added inline comments.
Restricted Application edited projects, added Plasma; removed KWin.

INLINE COMMENTS

> graesslin wrote in slidedesktops.h:60
> As you use modern connect syntax you don't need the Q_SLOTS keyword anymore.

Yeah, I know `slots`/`Q_SLOTS` keyword is optional with Qt 5, but I would like 
to keep it to avoid some misunderstandings(e.g. "who the hell calls this 
method", etc)

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: graesslin, abetts, ngraham, plasma-devel, kwin, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D9638: [effects] add 'Slide Desktops' effect

[Nathaniel Graham]

ngraham added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  In https://phabricator.kde.org/D9638#185720, @graesslin wrote:
  
  > Just putting it as an idea: maybe we should just drop the "old" slide 
desktop effect and replace it with this one?
  
  
  +1

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: graesslin, abetts, ngraham, plasma-devel, kwin, iodelay, bwowk, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, apol, mart

D9638: [effects] add 'Slide Desktops' effect

[Martin Flöser]

graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  Just putting it as an idea: maybe we should just drop the "old" slide desktop 
effect and replace it with this one?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: graesslin, abetts, ngraham, plasma-devel, kwin, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D9638: [effects] add 'Slide Desktops' effect

[Martin Flöser]

graesslin added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  Overall code looks good for me and the video looks really promising. I fear 
it's too late for 5.12, which is a pity.

INLINE COMMENTS

> slidedesktops.cpp:144
> +QRegion clipRegion = buildClipRegion(currentPos, w, h);
> +QList visibleDesktops;
> +for (int i = 1; i <= effects->numberOfDesktops(); i++) {

Please use QVector for new code. See 
https://marcmutz.wordpress.com/effective-qt/containers/

> slidedesktops.cpp:160
> +m_paintCtx.fullscreenWindows.clear();
> +foreach (EffectWindow* w, effects->stackingOrder()) {
> +if (! w->isFullScreen()) {

Please don't use Q_FOREACH in new code. Prefer for (auto w : 
qAsConst(effects->stackingOrder()))

> slidedesktops.cpp:169
> +const int lastDesktop = visibleDesktops.last();
> +foreach (int desktop, visibleDesktops) {
> +m_paintCtx.desktop = desktop;

same here

> slidedesktops.cpp:213
> +if (w->isDock()) {
> +foreach (EffectWindow* fw, m_paintCtx.fullscreenWindows) {
> +if (fw->isOnDesktop(m_paintCtx.desktop)

and here

> slidedesktops.cpp:339
> +
> +foreach (EffectWindow* w, effects->stackingOrder()) {
> +w->setData(WindowForceBlurRole, QVariant(true));

and here

> slidedesktops.cpp:360
> +{
> +foreach (EffectWindow* w, effects->stackingOrder()) {
> +w->setData(WindowForceBlurRole, QVariant(false));

and here as well

> slidedesktops.h:60
> +
> +private Q_SLOTS:
> +void desktopChanged(int old, int current, EffectWindow* with);

As you use modern connect syntax you don't need the Q_SLOTS keyword anymore.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: graesslin, abetts, ngraham, plasma-devel, kwin, iodelay, bwowk, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, apol, mart

D9638: [effects] add 'Slide Desktops' effect

[Vlad Zagorodniy]

zzag added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  > This is good to know. It doesn't look bad right now. Maybe the speed can 
also clue in the user of what's happening behind. That should be an easier 
method.
  
  So, what do you propose to do?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: abetts, ngraham, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D9638: [effects] add 'Slide Desktops' effect

[Andres Betts]

abetts added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  In https://phabricator.kde.org/D9638#185606, @zzag wrote:
  
  > In https://phabricator.kde.org/D9638#185547, @abetts wrote:
  >
  > > What I would maybe want to add would be some sort of effect, darkening, 
or slight zooming in/out when moving a window from one desktop to another.
  >
  >
  > Well, I was trying to animate moving windows some time ago. It didn't work 
out well because `EffectsHandler` doesn't tell us when user has stopped moving 
a window. This leads to some inconsistencies:
  
  
  This is good to know. It doesn't look bad right now. Maybe the speed can also 
clue in the user of what's happening behind. That should be an easier method.
  
  > F5615875: 2018-01-03 18-43-56.mp4 
  > 
  > //(I move windows between desktops with `Meta + Shift + `).//
  > 
  > I hold `Meta + Shift` till the end of the video. It is expected that 
dolphin window be translucent till the end of the video.
  > 
  > At this moment, I would prefer not to animate moving windows.
  > 
  >> Also, to make transitions even smoother, is there a way that Plasma can 
know the framerate that the computer is capable of?
  > 
  > If you;re about choppy animations on videos above, don't worry, that's a 
screen recorder issue(+I have very old laptop).

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: abetts, ngraham, plasma-devel, kwin, iodelay, bwowk, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, apol, mart

D9638: [effects] add 'Slide Desktops' effect

[Vlad Zagorodniy]

zzag added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  In https://phabricator.kde.org/D9638#185547, @abetts wrote:
  
  > What I would maybe want to add would be some sort of effect, darkening, or 
slight zooming in/out when moving a window from one desktop to another.
  
  
  Well, I was trying to animate moving windows some time ago. It didn't work 
out well because `EffectsHandler` doesn't tell us when user has stopped moving 
a window. This leads to some inconsistencies:
  
  F5615875: 2018-01-03 18-43-56.mp4 
  
  //(I move windows between desktops with `Meta + Shift + `).//
  
  I hold `Meta + Shift` till the end of the video. It is expected that dolphin 
window be translucent till the end of the video, too.
  
  > Also, to make transitions even smoother, is there a way that Plasma can 
know the framerate that the computer is capable of?
  
  If you;re about choppy animations on videos above, don't worry, that's a 
screen recorder issue(+I have very old laptop).

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: abetts, ngraham, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D9638: [effects] add 'Slide Desktops' effect

[Andres Betts]

abetts added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  This is great work. I like the results. I like the gap as well. It makes for 
a good idea of separation. What I would maybe want to add would be some sort of 
effect, darkening, or slight zooming in/out when moving a window from one 
desktop to another. Also, to make transitions even smoother, is there a way 
that Plasma can know the framerate that the computer is capable of?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: abetts, ngraham, plasma-devel, kwin, iodelay, bwowk, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, apol, mart

D9638: [effects] add 'Slide Desktops' effect

[Diego Gangl]

Restricted Application edited projects, added Plasma; removed KWin.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: ngraham, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9638: [effects] add 'Slide Desktops' effect

[Nathaniel Graham]

Restricted Application edited projects, added KWin; removed Plasma.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: ngraham, plasma-devel, kwin, iodelay, bwowk, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D9638: [effects] add 'Slide Desktops' effect

[Vlad Zagorodniy]

zzag added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  I've made this effect because I am very disappointed with the Slide effect. 
Let me list some of the biggest problems with slide effect:
  
  - It's not intuitive
  
  - It has poor(like my English) visual feedback when switching between empty 
virtual desktops
  
  F5615540: slide-empty-desktops.mp4 
  I've just cycled through 4 virtual desktops, surprise!
  
  - Switching between virtual desktops with fullscreen windows is not pleasant
  
  F5615542: slide-fullscreen.mp4 
  Panels should not flick, should they?
  *Please note that "panel flickering" is not a bug.*
  
  Meet the 'Slide Desktops' effect
  
  
  F5615545: slidedesktops-demo.mp4 
  
  Gorgeous!
  
  As you can see desktop background and panels ain't static anymore. They move 
together with virtual desktops, which is expected and intuitive. Also, you may 
have noticed gaps between virtual desktops. Their purpose is to make users feel 
like each virtual desktop is a separate entity. In addition to the purpose 
above, gaps are very useful when you have a plain color as the desktop 
background.
  
  If you don't like gaps, you can set them to 0.
  
  F5615546: options.png 
  
  Demos
  =
  
  Switching between empty virtual desktops:
  -
  
  F5615550: slidedesktops-empty-desktops.mp4 

  
  *Now we see that we're switching between virtual desktops.*
  
  Switching between virtual desktops with fullscreen windows:
  ---
  
  F5615551: slidedesktops-fullscreen.mp4 
  
  *Panels aren't flickering anymore!*
  
  Navigating a desktop grid:
  --
  
  F5615552: slidedesktops-grid.mp4 
  
  Move a window to another virtual desktop:
  -
  
  F5615553: slidedesktops-moving-window.mp4 

  
  Slide Desktops on Wayland:
  --
  
  F5615554: slidedesktops-wayland.mp4 
  
  Switch virtual desktops on a setup with several screens:
  
  
  F5615556: slidedesktops-several-screens.mp4 

  
  *I don't really know why you need virtual desktops in this case.*
  
  Next steps
  ==
  
  - Optimize it: Try to decrease a number of memory allocations during paint 
calls?
  - Simplify code?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9638: [effects] add 'Slide Desktops' effect

[Vlad Zagorodniy]

zzag added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  Motivation behind this effect and demos will be soon.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: plasma-devel, kwin, iodelay, bwowk, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D9638: [effects] add 'Slide Desktops' effect

[Vlad Zagorodniy]

zzag created this revision.
zzag added reviewers: VDG, KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application edited projects, added Plasma; removed KWin.

REVISION SUMMARY
  Slide Desktops animates switching between virtual desktops. As the name
  suggests, this effect moves whole desktops during animation.

TEST PLAN
  - switch between virtual desktops
  - or, move a window to another virtual desktop

REPOSITORY
  R108 KWin

BRANCH
  effects/slidedesktops

REVISION DETAIL
  https://phabricator.kde.org/D9638

AFFECTED FILES
  autotests/test_builtin_effectloader.cpp
  autotests/test_plugin_effectloader.cpp
  autotests/test_scripted_effectloader.cpp
  effects/CMakeLists.txt
  effects/effect_builtins.cpp
  effects/effect_builtins.h
  effects/slidedesktops/CMakeLists.txt
  effects/slidedesktops/slidedesktops.cpp
  effects/slidedesktops/slidedesktops.h
  effects/slidedesktops/slidedesktops.kcfg
  effects/slidedesktops/slidedesktops_config.cpp
  effects/slidedesktops/slidedesktops_config.desktop
  effects/slidedesktops/slidedesktops_config.h
  effects/slidedesktops/slidedesktops_config.ui
  effects/slidedesktops/slidedesktopsconfig.kcfgc

To: zzag, #vdg, #kwin, #plasma
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart