D9638: [effects] replace old slide effect with a new one

[Melvin Vermeeren]

vermeeren added a comment.


  In D9638#282890 , @zzag wrote:
  
  > In D9638#282881 , @vermeeren 
wrote:
  >
  > > I just upgraded my system and got the update with this new change. Is it 
possible to add an option `Slide wallpaper` similar to the current option 
`Slide docks`?
  > >  On my 31" display at home the sliding of the wallpaper is a bit too 
much, though I do like it when the applications themselves slide like in the 
old version.
  >
  >
  > In 5.14, there will be "Slide desktop background" option.
  >
  > > Something minor I noticed: In the `Virtual Desktops` systems settings 
module there is also a `Switching` tab. Next to the `Animation:` selector the 
settings button is greyed out however, had to access it via the regular desktop 
effects.
  >
  > Already fixed.
  
  
  Thanks for the quick reply! I will await 5.14's release then. :)

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma, graesslin, ngraham
Cc: vermeeren, mart, graesslin, abetts, ngraham, plasma-devel, kwin, ragreen, 
jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, sebas, apol

D9638: [effects] replace old slide effect with a new one

[Vlad Zagorodniy]

zzag added a comment.


  In D9638#282881 , @vermeeren wrote:
  
  > I just upgraded my system and got the update with this new change. Is it 
possible to add an option `Slide wallpaper` similar to the current option 
`Slide docks`?
  >  On my 31" display at home the sliding of the wallpaper is a bit too much, 
though I do like it when the applications themselves slide like in the old 
version.
  
  
  In 5.14, there will be "Slide desktop background" option.
  
  > Something minor I noticed: In the `Virtual Desktops` systems settings 
module there is also a `Switching` tab. Next to the `Animation:` selector the 
settings button is greyed out however, had to access it via the regular desktop 
effects.
  
  Already fixed.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma, graesslin, ngraham
Cc: vermeeren, mart, graesslin, abetts, ngraham, plasma-devel, kwin, ragreen, 
jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, sebas, apol

D9638: [effects] replace old slide effect with a new one

[Melvin Vermeeren]

vermeeren added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  Hello,
  
  I just upgraded my system and got the update with this new change. Is it 
possible to add an option `Slide wallpaper` similar to the current option 
`Slide docks`?
  On my 31" display at home the sliding of the wallpaper is a bit too much, 
though I do like it when the applications themselves slide like in the old 
version.
  
  Something minor I noticed: In the `Virtual Desktops` systems settings module 
there is also a `Switching` tab. Next to the `Animation:` selector the settings 
button is greyed out however, had to access it via the regular desktop effects.
  
  F5956946: Screenshot_20180625_214232.png 

  
  Thanks!

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma, graesslin, ngraham
Cc: vermeeren, mart, graesslin, abetts, ngraham, plasma-devel, kwin, ragreen, 
jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, sebas, apol

D9638: [effects] replace old slide effect with a new one

[Vlad Zagorodniy]

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:ddd406dfd91c: [effects] replace old slide effect with a 
new one (authored by zzag).
Restricted Application edited projects, added Plasma; removed KWin.

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9638?vs=27190=27317

REVISION DETAIL
  https://phabricator.kde.org/D9638

AFFECTED FILES
  effects/effect_builtins.cpp
  effects/slide/slide.cpp
  effects/slide/slide.h
  effects/slide/slide.kcfg
  effects/slide/slide_config.cpp
  effects/slide/slide_config.h
  effects/slide/slide_config.ui

To: zzag, #vdg, #kwin, #plasma, graesslin, ngraham
Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, iodelay, bwowk, hardening

D9638: [effects] replace old slide effect with a new one

[Fabian Riethmayer]

Restricted Application edited projects, added Plasma; removed KWin.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma, graesslin, ngraham
Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, iodelay, bwowk, hardening

D9638: [effects] replace old slide effect with a new one

[Vlad Zagorodniy]

zzag updated this revision to Diff 27190.
zzag added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  rebase on master

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9638?vs=26788=27190

BRANCH
  effects/slide

REVISION DETAIL
  https://phabricator.kde.org/D9638

AFFECTED FILES
  effects/effect_builtins.cpp
  effects/slide/slide.cpp
  effects/slide/slide.h
  effects/slide/slide.kcfg
  effects/slide/slide_config.cpp
  effects/slide/slide_config.h
  effects/slide/slide_config.ui

To: zzag, #vdg, #kwin, #plasma, graesslin, ngraham
Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, iodelay, bwowk, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, 
apol

D9638: [effects] replace old slide effect with a new one

[Vlad Zagorodniy]

zzag added reviewers: graesslin, ngraham.
Restricted Application edited projects, added Plasma; removed KWin.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma, graesslin, ngraham
Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D9638: [effects] replace old slide effect with a new one

[Vlad Zagorodniy]

zzag updated this revision to Diff 26788.
zzag added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  rebase onto master

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9638?vs=26137=26788

BRANCH
  effects/slide

REVISION DETAIL
  https://phabricator.kde.org/D9638

AFFECTED FILES
  effects/effect_builtins.cpp
  effects/slide/slide.cpp
  effects/slide/slide.h
  effects/slide/slide.kcfg
  effects/slide/slide_config.cpp
  effects/slide/slide_config.h
  effects/slide/slide_config.ui

To: zzag, #vdg, #kwin, #plasma
Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, iodelay, bwowk, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, 
apol

D9638: [effects] replace old slide effect with a new one

[Vlad Zagorodniy]

zzag added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  @graesslin: could you please review code?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D9638: [effects] replace old slide effect with a new one

[Vlad Zagorodniy]

zzag updated this revision to Diff 26137.
zzag edited projects, added Plasma; removed KWin.
zzag added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  - rebase on master
  - finish work on `shouldForceBlur()` and `shouldForceBackgroundContrast()`

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9638?vs=26015=26137

BRANCH
  effects/slide

REVISION DETAIL
  https://phabricator.kde.org/D9638

AFFECTED FILES
  effects/effect_builtins.cpp
  effects/slide/slide.cpp
  effects/slide/slide.h
  effects/slide/slide.kcfg
  effects/slide/slide_config.cpp
  effects/slide/slide_config.h
  effects/slide/slide_config.ui

To: zzag, #vdg, #kwin, #plasma
Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, iodelay, bwowk, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, 
apol

D9638: [effects] replace old slide effect with a new one

[Vlad Zagorodniy]

zzag added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  I've got full(or some part) KDE Plasma wayland session working. Here's what I 
did:
  
  - source `~/.config/kde-env-master.sh` (you should have 
`install-environment-driver true` in your `.kdesrc-buildrc`)
  - start kwin_wayland with Konsole
  - change some environment variables, like `XDG_DATA_DIRS`
  - and then launch /usr/lib/startplasma (I'm using plasma shell provided by my 
distro)
  
  Hacky, but it's working.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, iodelay, bwowk, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, 
apol

D9638: [effects] replace old slide effect with a new one

[Vlad Zagorodniy]

zzag added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  ... and it didn't work. I'll ask for help on `#plasma` IRC.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D9638: [effects] replace old slide effect with a new one

[Vlad Zagorodniy]

zzag added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  I'll try to build Plasma on my host. I hope `startplasmacompositor` will 
launch full Plasma session.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, iodelay, bwowk, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, 
apol

D9638: [effects] replace old slide effect with a new one

[Martin Flöser]

graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  In https://phabricator.kde.org/D9638#196539, @zzag wrote:
  
  > If you know how to start wayland session, please let me know. Till then, I 
can't do too much (I'm familiar with effects part only).
  
  
  I cannot help you with the docker setup, but I can describe how I do my 
testing:
  
export $(dbus-launch)
cd build/kde/workspace/kwin/bin
gdb --args ./kwin_wayland --socket wayland-1
  
  Then from other konsole tab
  
WAYLAND_DISPLAY=wayland-1 kwrite
  
  or any other application I want to try. For testing something like the effect 
I would probably launch qdbusviewer together with kwin_wayland and use it to 
switch desktops.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D9638: [effects] replace old slide effect with a new one

[Vlad Zagorodniy]

zzag added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  I would like to test this effect in "full KDE Plasma wayland session", but I 
can't start plasma. After splash screen there is only black screen.
  
  Sometimes, there are messages like this
  
kscreen.kwayland: Connection to Wayland server at socket: "wayland-0" timed 
out.
  
  Does anyone know how to fix this?
  
  ---
  
  My workflow
  
xhost +

sudo docker run --rm \
-v /tmp/.X11-unix:/tmp/.X11-unix \
-e DISPLAY=:0 \
--device /dev/dri \
--device /dev/snd \
--device /dev/video0 \
--cap-add ALL \
-v /home/vlad/KDE/build:/home/neon/build \
-v /home/vlad/KDE/log:/home/neon/log \
-v /home/vlad/KDE/src:/home/neon/src \
-v /home/vlad/KDE/usr:/home/neon/usr \
-v /home/vlad/KDE/.kdesrc-buildrc:/home/neon/.kdesrc-buildrc \
-v /home/vlad/KDE/.kdesrc-build:/home/neon/.kdesrc-build \
-ti kdebuilder:v2 bash

# inside container

$ kdesrc-build --include-dependencies plasma-desktop
$ source kde-env-master.sh
$ startplasmacompositor
  
  (`kdebuilder:v2` is an image based on `kdeneon/plasma:dev-unstable` with some 
-dev packages preinstalled)

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D9638: [effects] replace old slide effect with a new one

[Martin Flöser]

graesslin added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  In https://phabricator.kde.org/D9638#196184, @zzag wrote:
  
  > @graesslin: do elevated windows have order? (e.g. docks are above 
fullscreen windows, etc)
  
  
  They are above all other windows.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, iodelay, bwowk, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, 
apol

D9638: [effects] replace old slide effect with a new one

[Vlad Zagorodniy]

zzag added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  If you know how to start wayland session, please let me know. Till then, I 
can't do too much (I'm familiar with effects part only).

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, iodelay, bwowk, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, 
apol

D9638: [effects] replace old slide effect with a new one

[Vlad Zagorodniy]

zzag updated this revision to Diff 26015.
zzag added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  - clip with the PaintClipper
  - elevate docks when `Slide docks` is unchecked
  - rewritten logic which forces blur and background contrast
  
  (tested only on X11)
  
  PS. I wish I could test Wayland part.

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9638?vs=25915=26015

BRANCH
  effects/slide

REVISION DETAIL
  https://phabricator.kde.org/D9638

AFFECTED FILES
  effects/effect_builtins.cpp
  effects/slide/slide.cpp
  effects/slide/slide.h
  effects/slide/slide.kcfg
  effects/slide/slide_config.cpp
  effects/slide/slide_config.h
  effects/slide/slide_config.ui

To: zzag, #vdg, #kwin, #plasma
Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D9638: [effects] replace old slide effect with a new one

[Vlad Zagorodniy]

zzag added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  @graesslin: do elevated windows have order? (e.g. docks are above fullscreen 
windows, etc)

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, iodelay, bwowk, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, 
apol

D9638: [effects] replace old slide effect with a new one

[Vlad Zagorodniy]

zzag added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  In https://phabricator.kde.org/D9638#196143, @graesslin wrote:
  
  > The region in this method is later on used for clipping. Given that you 
need that paintclipper fragment.
  
  
  I think `PaintClipper pc(QRegion(effects->virtualScreenGeometry()));` should 
be enough.(given that the slide effect only translates windows)

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D9638: [effects] replace old slide effect with a new one

[Vlad Zagorodniy]

zzag added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  In https://phabricator.kde.org/D9638#196145, @graesslin wrote:
  
  > > Docks are drawn above all windows by the following code:
  > > 
  > >   for (EffectWindow* w : windows) {
  > >   if (! w->isDock()) {
  > >   continue;
  > >   }
  > >   WindowPaintData dockData(w);
  > >   int dockMask = mask
  > >   | (w->hasAlpha() ? PAINT_WINDOW_TRANSLUCENT
  > >: PAINT_WINDOW_OPAQUE);
  > >   effects->drawWindow(w, dockMask, infiniteRegion(), dockData);
  > >   }
  > >
  > > 
  > > (`WindowForceBackgroundContrastRole` and `WindowForceBlurRole` are set at 
the beginning of the slide animation)
  > > 
  > > Am I missing something?
  >
  > I have an idea: the problem might be how you create the WindowPaintData. 
The ctor you use creates the WindowPaintData with an identity 
screenProjectionMatrix. This might be wrong in this case. The blur effect seems 
to use it.
  
  
  Maybe just elevate docks? E.g. at the beginning for each dock call 
`effects->setElevatedWindow(w, true)` and paint docks with the last visible 
virtual desktop?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, iodelay, bwowk, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, 
apol

D9638: [effects] replace old slide effect with a new one

[Martin Flöser]

graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  > Docks are drawn above all windows by the following code:
  > 
  >   for (EffectWindow* w : windows) {
  >   if (! w->isDock()) {
  >   continue;
  >   }
  >   WindowPaintData dockData(w);
  >   int dockMask = mask
  >   | (w->hasAlpha() ? PAINT_WINDOW_TRANSLUCENT
  >: PAINT_WINDOW_OPAQUE);
  >   effects->drawWindow(w, dockMask, infiniteRegion(), dockData);
  >   }
  >
  > 
  > (`WindowForceBackgroundContrastRole` and `WindowForceBlurRole` are set at 
the beginning of the slide animation)
  > 
  > Am I missing something?
  
  I have an idea: the problem might be how you create the WindowPaintData. The 
ctor you use creates the WindowPaintData with an identity 
screenProjectionMatrix. This might be wrong in this case. The blur effect seems 
to use it.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D9638: [effects] replace old slide effect with a new one

[Martin Flöser]

graesslin added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  In https://phabricator.kde.org/D9638#196026, @zzag wrote:
  
  > In https://phabricator.kde.org/D9638#195979, @graesslin wrote:
  >
  > > What you could try is using the PaintClipper to perform clipping. But I 
don't know whether it's still fully functional on OpenGL.
  >
  >
  > So, adding
  >
  >   PaintClipper pc(QRegion(
  > QPoint(0, 0),
  > effects->virtualScreenSize()
  >   ));
  >
  >
  > in `SlideEffect::paintScreen` would be enough? Doesn't KWin do something 
like that somewhere else? I've just realized, maybe, this effect doesn't need 
to clip...
  
  
  I just looked into the source (relevant method Scene::paintScreen). For 
PAINT_SCREEN_WITH_TRANSFORMED_WINDOWS the region is set to infinite region.
  
if (*mask & (PAINT_SCREEN_TRANSFORMED | 
PAINT_SCREEN_WITH_TRANSFORMED_WINDOWS)) {
// Region painting is not possible with transformations,
// because screen damage doesn't match transformed positions.
*mask &= ~PAINT_SCREEN_REGION;
region = infiniteRegion();
  
  The region in this method is later on used for clipping. Given that you need 
that paintclipper fragment.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, iodelay, bwowk, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, 
apol

D9638: [effects] replace old slide effect with a new one

[Vlad Zagorodniy]

zzag added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  In https://phabricator.kde.org/D9638#195979, @graesslin wrote:
  
  > What you could try is using the PaintClipper to perform clipping. But I 
don't know whether it's still fully functional on OpenGL.
  
  
  So, adding
  
PaintClipper pc(QRegion(
  QPoint(0, 0),
  effects->virtualScreenSize()
));
  
  in `SlideEffect::paintScreen` would be enough? Doesn't KWin do something like 
that somewhere else? I've just realized, maybe, this effect doesn't need to 
clip...
  
  ---
  
  Also, I've noticed that there is no blur behind docks when docks are painted 
above all windows(`Slide docks` checkbox is unchecked).
  
  F5674581: 2018-01-25 17-55-02.mp4 
  
  Effect chain positions:
  
  - slide effect: 50
  - blur: 75
  - background contrast: 76
  
  Docks are drawn above all windows by the following code:
  
for (EffectWindow* w : windows) {
if (! w->isDock()) {
continue;
}
WindowPaintData dockData(w);
int dockMask = mask
| (w->hasAlpha() ? PAINT_WINDOW_TRANSLUCENT
 : PAINT_WINDOW_OPAQUE);
effects->drawWindow(w, dockMask, infiniteRegion(), dockData);
}
  
  (`WindowForceBackgroundContrastRole` and `WindowForceBlurRole` are set at the 
beginning of the slide animation)
  
  Am I missing something?
  
  ---
  
  Quick side note: when the `Slide docks` checkbox is unchecked, docks are 
drawn above other windows so they can properly animate themselves if an user 
enters or leaves a virtual desktop with a window in full screen mode.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D9638: [effects] replace old slide effect with a new one

[Martin Flöser]

graesslin added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  What you could try is using the PaintClipper to perform clipping. But I don't 
know whether it's still fully functional on OpenGL.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, iodelay, bwowk, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, 
apol

D9638: [effects] replace old slide effect with a new one

[Martin Flöser]

graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  In https://phabricator.kde.org/D9638#195793, @zzag wrote:
  
  > I think this effect is ready for testing.
  >
  > Yet, I would like to have some clipping but it seems like there is no way 
to do this with current implementation of `Scene::paintGenericScreen`.
  
  
  That's quite likely

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D9638: [effects] replace old slide effect with a new one

[Vlad Zagorodniy]

zzag added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  I think this effect is ready for testing.
  
  Yet, I would like to have some clipping but it seems like there is no way to 
do this with current implementation of `Scene::paintGenericScreen`.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, iodelay, bwowk, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, 
apol

D9638: [effects] replace old slide effect with a new one

[Vlad Zagorodniy]

zzag updated this revision to Diff 25915.
zzag added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  - Rebase onto master
  - Do not populate a list of fullscreen windows if the 'Slide docks' checkbox 
is unchecked.

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9638?vs=25283=25915

BRANCH
  effects/slide

REVISION DETAIL
  https://phabricator.kde.org/D9638

AFFECTED FILES
  effects/effect_builtins.cpp
  effects/slide/slide.cpp
  effects/slide/slide.h
  effects/slide/slide.kcfg
  effects/slide/slide_config.cpp
  effects/slide/slide_config.h
  effects/slide/slide_config.ui

To: zzag, #vdg, #kwin, #plasma
Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D9638: [effects] replace old slide effect with a new one

[Vlad Zagorodniy]

zzag marked an inline comment as done.
Restricted Application edited projects, added KWin; removed Plasma.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, iodelay, bwowk, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, 
apol

D9638: [effects] replace old slide effect with a new one

[Vlad Zagorodniy]

zzag updated this revision to Diff 25283.
zzag added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  Use default duration value when `Duration` is 0.

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9638?vs=25274=25283

BRANCH
  effects/slide

REVISION DETAIL
  https://phabricator.kde.org/D9638

AFFECTED FILES
  effects/effect_builtins.cpp
  effects/slide/slide.cpp
  effects/slide/slide.h
  effects/slide/slide.kcfg
  effects/slide/slide_config.cpp
  effects/slide/slide_config.h
  effects/slide/slide_config.ui

To: zzag, #vdg, #kwin, #plasma
Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D9638: [effects] replace old slide effect with a new one

[Martin Flöser]

graesslin added inline comments.
Restricted Application edited projects, added KWin; removed Plasma.

INLINE COMMENTS

> slide.cpp:62
>  
> -const auto d = animationTime(
> -SlideConfig::duration() != 0 ? SlideConfig::duration() : 250);
> -mTimeLine.setDuration(d);
> +m_timeline.setDuration(animationTime(SlideConfig::duration()));
> +m_hGap = SlideConfig::horizontalGap();

So far the interpretation of the config values was: 0 means default settings, 
anything else means taken from the config. As we have old configs this change 
would basically disable the animation for everybody with default settings. 
Given that I suggest to keep the approach as in the old variant.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, iodelay, bwowk, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, 
apol

D9638: [effects] replace old slide effect with a new one

[Vlad Zagorodniy]

zzag added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  @graesslin: I did some changes to `reconfigure()`(file 
`effects/slide/slide.cpp`, lines 59-66). Could you please review them?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9638

To: zzag, #vdg, #kwin, #plasma
Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D9638: [effects] replace old slide effect with a new one

[Vlad Zagorodniy]

zzag updated this revision to Diff 25274.
zzag retitled this revision from "[effects] add 'Slide Desktops' effect" to 
"[effects] replace old slide effect with a new one".
zzag edited the summary of this revision.
zzag edited projects, added Plasma; removed KWin.
zzag added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  Update title and summary.

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9638?vs=25273=25274

BRANCH
  effects/slide

REVISION DETAIL
  https://phabricator.kde.org/D9638

AFFECTED FILES
  effects/effect_builtins.cpp
  effects/slide/slide.cpp
  effects/slide/slide.h
  effects/slide/slide.kcfg
  effects/slide/slide_config.cpp
  effects/slide/slide_config.h
  effects/slide/slide_config.ui

To: zzag, #vdg, #kwin, #plasma
Cc: mart, graesslin, abetts, ngraham, plasma-devel, kwin, iodelay, bwowk, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, 
apol