D9671: Show only available profiles in Pulseaudio KCM

2018-02-03 Thread Nicolas Fella 
nicolasfella added a comment.


  In https://phabricator.kde.org/D9671#200326, @broulik wrote:
  
  > This breaks the context menu of output devices:
  >
  >   org.kde.plasma.volume/contents/ui/ListItemBase.qml:315: ReferenceError: 
Port is not defined
  >
  
  
  see https://phabricator.kde.org/D10280

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D9671

To: nicolasfella, #plasma, drosca
Cc: broulik, plasma-devel, #plasma, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9671: Show only available profiles in Pulseaudio KCM

2018-02-03 Thread Kai Uwe Broulik 
broulik added a comment.


  This breaks the context menu of output devices:
  
org.kde.plasma.volume/contents/ui/ListItemBase.qml:315: ReferenceError: 
Port is not defined

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D9671

To: nicolasfella, #plasma, drosca
Cc: broulik, plasma-devel, #plasma, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9671: Show only available profiles in Pulseaudio KCM

2018-01-27 Thread David Rosca 
This revision was not accepted when it landed; it landed in state "Changes 
Planned".
This revision was automatically updated to reflect the committed changes.
Closed by commit R115:206a00f95858: Move availability property from Port to 
Profile (authored by nicolasfella, committed by drosca).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D9671?vs=24746=26082#toc

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9671?vs=24746=26082

REVISION DETAIL
  https://phabricator.kde.org/D9671

AFFECTED FILES
  src/port.cpp
  src/port.h
  src/profile.cpp
  src/profile.h
  src/qml/plugin.cpp

To: nicolasfella, #plasma, drosca
Cc: plasma-devel, #plasma, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9671: Show only available profiles in Pulseaudio KCM

2018-01-24 Thread Nicolas Fella 
nicolasfella added a comment.


  Feel free to take over, I can't promise to finish it anytime soon

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D9671

To: nicolasfella, #plasma, drosca
Cc: plasma-devel, #plasma, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9671: Show only available profiles in Pulseaudio KCM

2018-01-24 Thread David Rosca 
drosca added a comment.


  I'd like to have this in, do you think you could finish it? If not, I will 
take over.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D9671

To: nicolasfella, #plasma, drosca
Cc: plasma-devel, #plasma, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9671: Show only available profiles in Pulseaudio KCM

2018-01-05 Thread David Rosca 
drosca requested changes to this revision.
drosca added a comment.


  I'm ok with the part of the patch that moves availability property from Port 
to Profile. Adding availableProfiles is not a good way to achieve what you want 
though. Profiles should be filtered on QML side.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D9671

To: nicolasfella, #plasma, drosca
Cc: plasma-devel, #plasma, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart