D9678: Delay loading most used model

2018-04-27 Thread Kai Uwe Broulik 
broulik planned changes to this revision.
broulik added a comment.


  Will look whether we can exploit the `canFetchMore` capability for lazyloadng

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D9678

To: broulik, #plasma, mart, davidedmundson
Cc: davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9678: Delay loading most used model

2018-01-08 Thread David Edmundson 
davidedmundson requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D9678

To: broulik, #plasma, mart, davidedmundson
Cc: davidedmundson, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9678: Delay loading most used model

2018-01-08 Thread David Edmundson 
davidedmundson added a comment.


  It's not graphics.
  
  I had a working system settings, applied this got a crash
  
  
  
  #0  QQmlData::wasDeleted (object=0xfffefffe)
  
at 
../../include/QtQml/5.10.0/QtQml/private/../../../../../../../qt5/qtdeclarative/src/qml/qml/qqmldata_p.h:301
  
  #1  QV4::QObjectWrapper::wrap (engine=0x55b04a70, object=0xfffefffe)
  
at 
/run/media/david/15cbf614-32ad-44e8-9fdc-466f76304ed7/projects/qt5/qtdeclarative/src/qml/jsruntime/qv4qobjectwrapper_p.h:210
  
  #2  0x71e0a33c in loadProperty (v4=v4@entry=0x55b04a70, 
object=object@entry=0x55b259c0, property=...)
  
at 
/run/media/david/15cbf614-32ad-44e8-9fdc-466f76304ed7/projects/qt5/qtdeclarative/src/qml/jsruntime/qv4qobjectwrapper.cpp:130
  
  It's good, because we can now reproduce a Qt crash, but we shouldn't be 
putting it in. Sorry.
  
  Given it's a model, you should be able to do the important part of your 
change internally within MostUsedModel?

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D9678

To: broulik, #plasma, mart
Cc: davidedmundson, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9678: Delay loading most used model

2018-01-08 Thread Kai Uwe Broulik 
broulik added a comment.


  The crashes I was seeing were graphics hardware issues, shouldn't be caused 
by this patch.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D9678

To: broulik, #plasma, mart
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9678: Delay loading most used model

2018-01-05 Thread Kai Uwe Broulik 
broulik added a comment.


  Seems to cause weird crashes regularly for me :/ (probably the `callLater`?)
  
#0  0x722611b5 in QV4::QObjectWrapper::wrap(QV4::ExecutionEngine*, 
QObject*) () from /usr/lib/x86_64-linux-gnu/libQt5Qml.so.5
#1  0x722d9816 in ?? () from 
/usr/lib/x86_64-linux-gnu/libQt5Qml.so.5
#2  0x722da786 in 
QV4::QObjectWrapper::getQmlProperty(QQmlContextData*, QV4::String*, 
QV4::QObjectWrapper::RevisionMode, bool*, bool) const () from 
/usr/lib/x86_64-linux-gnu/libQt5Qml.so.5
#3  0x722f11d7 in 
QV4::Runtime::method_getProperty(QV4::ExecutionEngine*, QV4::Value const&, int) 
() from /usr/lib/x86_64-linux-gnu/libQt5Qml.so.5

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D9678

To: broulik, #plasma, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart