D9684: Load config specified by the LnF theme

2018-01-08 Thread David Edmundson 
This revision was automatically updated to reflect the committed changes.
Closed by commit R133:e36101cd1b48: Load config specified by the LnF theme 
(authored by davidedmundson).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D9684?vs=24791&id=24938#toc

REPOSITORY
  R133 KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9684?vs=24791&id=24938

REVISION DETAIL
  https://phabricator.kde.org/D9684

AFFECTED FILES
  greeter/CMakeLists.txt
  greeter/greeterapp.cpp
  greeter/greeterapp.h
  greeter/lnf_integration.cpp
  greeter/lnf_integration.h
  kcm/CMakeLists.txt
  kcm/config.qml
  kcm/kcm.cpp
  kcm/kcm.h
  kcm/kcm.ui
  kcm/lnfconfig.qml
  kcm/resources.qrc
  kcm/wallpaperconfig.qml

To: davidedmundson, #plasma, broulik
Cc: zzag, broulik, graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9684: Load config specified by the LnF theme

2018-01-08 Thread Vlad Zagorodniy 
zzag added inline comments.

INLINE COMMENTS

> lnf_integration.cpp:62
> +
> +qDebug() << m_package.isValid() << xmlPath;
> +const KConfigGroup cfg = m_config->group("Greeter").group("LnF");

Maybe it should be deleted.

REPOSITORY
  R133 KScreenLocker

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9684

To: davidedmundson, #plasma, broulik
Cc: zzag, broulik, graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9684: Load config specified by the LnF theme

2018-01-08 Thread Kai Uwe Broulik 
broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R133 KScreenLocker

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9684

To: davidedmundson, #plasma, broulik
Cc: broulik, graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9684: Load config specified by the LnF theme

2018-01-08 Thread Kai Uwe Broulik 
broulik added a comment.


  I like that a lot.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D9684

To: davidedmundson, #plasma
Cc: broulik, graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9684: Load config specified by the LnF theme

2018-01-05 Thread Martin Flöser 
graesslin added a comment.


  I like it!

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D9684

To: davidedmundson, #plasma
Cc: graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9684: Load config specified by the LnF theme

2018-01-05 Thread David Edmundson 
davidedmundson updated this revision to Diff 24791.
davidedmundson added a comment.


  Debug--

REPOSITORY
  R133 KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9684?vs=24788&id=24791

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9684

AFFECTED FILES
  greeter/CMakeLists.txt
  greeter/greeterapp.cpp
  greeter/greeterapp.h
  greeter/lnf_integration.cpp
  greeter/lnf_integration.h
  kcm/CMakeLists.txt
  kcm/config.qml
  kcm/kcm.cpp
  kcm/kcm.h
  kcm/kcm.ui
  kcm/lnfconfig.qml
  kcm/resources.qrc
  kcm/wallpaperconfig.qml

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9684: Load config specified by the LnF theme

2018-01-05 Thread David Edmundson 
davidedmundson updated this revision to Diff 24788.
davidedmundson added a comment.


  Remove unintended change to .ui file

REPOSITORY
  R133 KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9684?vs=24787&id=24788

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9684

AFFECTED FILES
  greeter/CMakeLists.txt
  greeter/greeterapp.cpp
  greeter/greeterapp.h
  greeter/lnf_integration.cpp
  greeter/lnf_integration.h
  kcm/CMakeLists.txt
  kcm/config.qml
  kcm/kcm.cpp
  kcm/kcm.h
  kcm/kcm.ui
  kcm/lnfconfig.qml
  kcm/resources.qrc
  kcm/wallpaperconfig.qml

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9684: Load config specified by the LnF theme

2018-01-05 Thread David Edmundson 
davidedmundson added a comment.


  F5622292: Spectacle.fjteac.png 

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D9684

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9684: Load config specified by the LnF theme

2018-01-05 Thread David Edmundson 
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  This is loaded in a QQuickView like the wallpaper, rest of the code is
  mostly based on something quite similar.
  
  Only differences is that wallpapers packages can change during the
  config, whereas the base package cannot; which simplifies some code.
  
  BUG: 384264

TEST PLAN
  Started playing some tunes
  Locked screen, still had my controls
  Changed setting
  Locked screen, didn't have my controls
  Changed wallpaper to confirm I hadn't broken anything

REPOSITORY
  R133 KScreenLocker

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9684

AFFECTED FILES
  greeter/CMakeLists.txt
  greeter/greeterapp.cpp
  greeter/greeterapp.h
  greeter/lnf_integration.cpp
  greeter/lnf_integration.h
  kcm/CMakeLists.txt
  kcm/config.qml
  kcm/kcm.cpp
  kcm/kcm.h
  kcm/kcm.ui
  kcm/lnfconfig.qml
  kcm/resources.qrc
  kcm/wallpaperconfig.qml

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart