Re: Fwd: Plasma Framework problems
On Thursday 23 October 2014 13:20:06 David Edmundson wrote: > On Thu, Oct 23, 2014 at 9:33 AM, David Faure wrote: > > On Monday 20 October 2014 02:52:58 David Edmundson wrote: > > > >Give me the sha1 to cherry-pick and I'll make a 5.3.1 with it. > > > > > > a3932843386a29faa3c62bf2934a173a3781d56c > > > > That doesn't make sense, that commit is from September 15 and is already > > in > > 5.3.0. > > > > Sorry, that was a hash to revert. Oh, I see, I thought the revert had happened in git... OK, done and packaged. Packagers: it's up. plasma-framework v5.3.1 9811b13f24d05211facc17eeb0566a3c997a4fb7 0ded7edd62471347b10796ed3d9ba4b47e7f71ab881fd3de5261171fa3976ffd sources/plasma-framework-5.3.1.tar.xz -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Fwd: Plasma Framework problems
On Thu, Oct 23, 2014 at 9:33 AM, David Faure wrote: > On Monday 20 October 2014 02:52:58 David Edmundson wrote: > > >Give me the sha1 to cherry-pick and I'll make a 5.3.1 with it. > > > > a3932843386a29faa3c62bf2934a173a3781d56c > That doesn't make sense, that commit is from September 15 and is already in > 5.3.0. > > Sorry, that was a hash to revert. David ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Fwd: Plasma Framework problems
On Monday 20 October 2014 02:52:58 David Edmundson wrote: > >Give me the sha1 to cherry-pick and I'll make a 5.3.1 with it. > > a3932843386a29faa3c62bf2934a173a3781d56c That doesn't make sense, that commit is from September 15 and is already in 5.3.0. PS: please CC me for urgent requests... -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Fwd: Plasma Framework problems
>Give me the sha1 to cherry-pick and I'll make a 5.3.1 with it. a3932843386a29faa3c62bf2934a173a3781d56c ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Fwd: Plasma Framework problems
On Tuesday 14 October 2014 22:17:38 Marco Martin wrote: > On Monday 13 October 2014, Marco Martin wrote: > > > I need approval from Marco and other David. > > > > after a quick chat with David E this morning, I would revert that patch > > (and then remove the plugin in plasma-workspace master) > > *but* this only if there will be a 5.3.1 (there should be a fix in > > kwindowsystem as well as far i understood, so would be good a 5.3.1 > > release > > with both fixes) > > Updates on this? how to proceed? it would be released from the current > master, 5.3 status plus one comit, or..? Give me the sha1 to cherry-pick and I'll make a 5.3.1 with it. Sorry for the delay. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Fwd: Plasma Framework problems
On Monday 13 October 2014, Marco Martin wrote: > > I need approval from Marco and other David. > > after a quick chat with David E this morning, I would revert that patch > (and then remove the plugin in plasma-workspace master) > *but* this only if there will be a 5.3.1 (there should be a fix in > kwindowsystem as well as far i understood, so would be good a 5.3.1 release > with both fixes) Updates on this? how to proceed? it would be released from the current master, 5.3 status plus one comit, or..? -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Fwd: Plasma Framework problems
On Monday 13 of October 2014 13:07:35 Marco Martin wrote: > On Sunday 12 October 2014, David Edmundson wrote: > > On 12 Oct 2014 18:04, "šumski" wrote: > > > On Sunday 12 of October 2014 11:58:44 David Edmundson wrote: > > > > > I'll report back when I've confirmed this and then we can work out > > > > how we > > > > > > > proceed. > > > > > > > > > > Reverting a3932843386a29faa3c62bf2934a173a3781d56c does indeed make > > > > > > > > everything work. > > > > > > > > Assuming we don't have a time machine our options are: > > > > - revert this commit and release plasma-framework 5.3.1 really > > > > quickly > > > > > > Please go with this option... > > > > I need approval from Marco and other David. > > after a quick chat with David E this morning, I would revert that patch > (and then remove the plugin in plasma-workspace master) > *but* this only if there will be a 5.3.1 (there should be a fix in > kwindowsystem as well as far i understood, so would be good a 5.3.1 release > with both fixes) this sounds like a good plan (though i don't know if reverting in plasma- workspace is needed, and why only master, 5.1.0 is not out yet) though kwindowsystem is uploaded 2 days ago to 5.3.0 dir Cheers, Hrvoje signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Fwd: Plasma Framework problems
On Sunday 12 October 2014, David Edmundson wrote: > On 12 Oct 2014 18:04, "šumski" wrote: > > On Sunday 12 of October 2014 11:58:44 David Edmundson wrote: > > > > I'll report back when I've confirmed this and then we can work out > > how we > > > > > proceed. > > > > > > > > Reverting a3932843386a29faa3c62bf2934a173a3781d56c does indeed make > > > > > > everything work. > > > > > > Assuming we don't have a time machine our options are: > > > - revert this commit and release plasma-framework 5.3.1 really quickly > > > > Please go with this option... > > I need approval from Marco and other David. after a quick chat with David E this morning, I would revert that patch (and then remove the plugin in plasma-workspace master) *but* this only if there will be a 5.3.1 (there should be a fix in kwindowsystem as well as far i understood, so would be good a 5.3.1 release with both fixes) -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Fwd: Plasma Framework problems
On Sunday 12 October 2014, David Edmundson wrote: > > > > > > Assuming we don't have a time machine our options are: > > > - revert this commit and release plasma-framework 5.3.1 really quickly > > > > Please go with this option... > > I need approval from Marco and other David. > > David eh no, that commit was correct. that code was moved in a plugin, so it must not be in two places. either it stays as is , or the plugin is removed from plasma-workspace, causing other similar problems of synchronization between p-f and p-w -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Re: Fwd: Plasma Framework problems
On Sunday 12 October 2014 20:48:36 David Edmundson wrote: > On 12 Oct 2014 18:04, "šumski" wrote: > > On Sunday 12 of October 2014 11:58:44 David Edmundson wrote: > > > > I'll report back when I've confirmed this and then we can work out > > how we > > > > > proceed. > > > > > > > > Reverting a3932843386a29faa3c62bf2934a173a3781d56c does indeed make > > > > > > everything work. > > > > > > Assuming we don't have a time machine our options are: > > > - revert this commit and release plasma-framework 5.3.1 really quickly > > > > Please go with this option... How will this affect Plasma 5.1? Given the review it looks like it was moved into workspace - is it a problem to have the code twice? Anyway if you revert, please deprecate the code, add a TODO KF6 and a comment on why it cannot be removed. I find it kind of scary that a change in the private implementation detail breaks the released software. Cheers Martin signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Fwd: Plasma Framework problems
On 12 Oct 2014 18:04, "šumski" wrote: > > On Sunday 12 of October 2014 11:58:44 David Edmundson wrote: > > > I'll report back when I've confirmed this and then we can work out how we > > > proceed. > > > > > > Reverting a3932843386a29faa3c62bf2934a173a3781d56c does indeed make > > > > everything work. > > > > Assuming we don't have a time machine our options are: > > - revert this commit and release plasma-framework 5.3.1 really quickly > Please go with this option... I need approval from Marco and other David. David ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Fwd: Plasma Framework problems
On Sunday 12 of October 2014 11:58:44 David Edmundson wrote: > > I'll report back when I've confirmed this and then we can work out how we > > proceed. > > > > Reverting a3932843386a29faa3c62bf2934a173a3781d56c does indeed make > > everything work. > > Assuming we don't have a time machine our options are: > - revert this commit and release plasma-framework 5.3.1 really quickly Please go with this option... > - communicate the breakage. Plasma 5.1 is out soon anyway IMO it is not at all relevant when release of one of p-f's consumers would be - unless you really want to move it to Workspace umbrella. Cheers, Hrvoje signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Fwd: Plasma Framework problems
> > > I'll report back when I've confirmed this and then we can work out how we > proceed. > > Reverting a3932843386a29faa3c62bf2934a173a3781d56c does indeed make everything work. Assuming we don't have a time machine our options are: - revert this commit and release plasma-framework 5.3.1 really quickly - communicate the breakage. Plasma 5.1 is out soon anyway ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Fwd: Plasma Framework problems
On Sat, Oct 11, 2014 at 8:10 PM, David Faure wrote: > On Friday 10 October 2014 16:24:52 David Edmundson wrote: > > Packagers, > > > > It seems Plasma 5.0 does NOT run smoothly against Plasma Framework 5.3. > > > > It would be easiest if distros hold off shipping frameworks 5.3 until > > Plasma 5.1 when Plasma5.1 is released. > > > > Clearly this is a screw-up and we need to come up with some better > policies > > when we plan Plasma 5.2 > > > > Sorry about this. > > Verbose++ ? What's the actual problem? > > This mail is as informative as a bug report that says "it doesn't work !!!" > :-) > "It doesn't work!!!" was pretty much all I have. A G+ post [1] and a flurry of incoming people on IRC complaining of a black screen on login. Why it was broken didn't really matter as I just wanted to stop distros rolling 5.3 into their stable repos ASAP. Apparently users get: Warning: corona package invalid Invalid home screen package I /believe/ it's a3932843386a29faa3c62bf2934a173a3781d56c [2] in plasma-framework that's causing the issue. There was a plasma package structure that was hardcoded, this was moved into a plugin in Plasma Workspaces 5.1. I'm currently rebuilding this combo of packages into a clean prefix so I can prove it is this. I'll report back when I've confirmed this and then we can work out how we proceed. David [1] https://plus.google.com/u/0/+PaulHinchbergerIII/posts/PCtMbdJAkag [2] https://gerrit.vesnicky.cesnet.cz/r/#/c/37/ ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
