Re: Merging KCM Touchpad

2015-02-17 Thread Albert Astals Cid
El Divendres, 13 de febrer de 2015, a les 00:17:41, Aleix Pol va escriure:
 On Thu, Feb 12, 2015 at 8:51 PM, David Edmundson
 
 da...@davidedmundson.co.uk wrote:
  I'm super happy with the touchpad KCM, I'd like to merge it soon to
  maximise testing before the 5.3 release.
  
  Any objections to me merging into plasma-desktop with the other KCMs? I
  don't think there's a reason to keep it in a separate repo now it's ready
  for usage.
  
  I'll filter branch to keep the history.
  
  ktouchpadenabler will then be dropped as this provides the same feature
  only more configurable and with future proofed with libinput support.
 
 +1
 
 CC'ing Albert, who is the ktouchpadenabler maintainer, IIRC.

The code of kcm-touchpad looks *very* scary compared to the one in 
ktouchpadenabler 

But if you guys are going to maintain it, well it's less work for me :)

Cheers,
  Albert

 
 Aleix

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Merging KCM Touchpad

2015-02-17 Thread David Edmundson
On Tue, Feb 17, 2015 at 10:17 PM, Albert Astals Cid aa...@kde.org wrote:

 El Divendres, 13 de febrer de 2015, a les 00:17:41, Aleix Pol va escriure:
  On Thu, Feb 12, 2015 at 8:51 PM, David Edmundson
 
  da...@davidedmundson.co.uk wrote:
   I'm super happy with the touchpad KCM, I'd like to merge it soon to
   maximise testing before the 5.3 release.
  
   Any objections to me merging into plasma-desktop with the other KCMs? I
   don't think there's a reason to keep it in a separate repo now it's
 ready
   for usage.
  
   I'll filter branch to keep the history.
  
   ktouchpadenabler will then be dropped as this provides the same feature
   only more configurable and with future proofed with libinput support.
 
  +1
 
  CC'ing Albert, who is the ktouchpadenabler maintainer, IIRC.

 The code of kcm-touchpad looks *very* scary compared to the one in
 ktouchpadenabler

 But if you guys are going to maintain it, well it's less work for me :)

 ktouchpadenabler wouldn't work in the next Fedora anyway due to libinput
being preferred over synaptics.
Once we start adding in that abstraction we would start to get complex in
ktouchpadenabler too.

David
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Merging KCM Touchpad

2015-02-12 Thread David Edmundson
I'm super happy with the touchpad KCM, I'd like to merge it soon to
maximise testing before the 5.3 release.

Any objections to me merging into plasma-desktop with the other KCMs? I
don't think there's a reason to keep it in a separate repo now it's ready
for usage.

I'll filter branch to keep the history.

ktouchpadenabler will then be dropped as this provides the same feature
only more configurable and with future proofed with libinput support.

David
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Merging KCM Touchpad

2015-02-12 Thread Marco Martin
On Thursday 12 February 2015, David Edmundson wrote:
 I'm super happy with the touchpad KCM, I'd like to merge it soon to
 maximise testing before the 5.3 release.
 
 Any objections to me merging into plasma-desktop with the other KCMs? I
 don't think there's a reason to keep it in a separate repo now it's ready
 for usage.
 
 I'll filter branch to keep the history.
 
 ktouchpadenabler will then be dropped as this provides the same feature
 only more configurable and with future proofed with libinput support.

if it's only a kcm without other stuff like daemons, +1 from here

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Merging KCM Touchpad

2015-02-12 Thread David Edmundson
On Fri, Feb 13, 2015 at 12:19 AM, Lukáš Tinkl lu...@kde.org wrote:

 Dne 12.2.2015 v 23:07 Marco Martin napsal(a):

 On Thursday 12 February 2015, David Edmundson wrote:

 I'm super happy with the touchpad KCM, I'd like to merge it soon to
 maximise testing before the 5.3 release.

 Any objections to me merging into plasma-desktop with the other KCMs? I
 don't think there's a reason to keep it in a separate repo now it's ready
 for usage.

 I'll filter branch to keep the history.

 ktouchpadenabler will then be dropped as this provides the same feature
 only more configurable and with future proofed with libinput support.


 if it's only a kcm without other stuff like daemons, +1 from here


 It also has a kded module which is surprisingly linked together with the
 kcm


Currently so does the keyboard KCM, so it's not super weird.

Mouse also has something that runs on startup.



 --
 Lukáš Tinkl lu...@kde.org

 ___
 Plasma-devel mailing list
 Plasma-devel@kde.org
 https://mail.kde.org/mailman/listinfo/plasma-devel

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Merging KCM Touchpad

2015-02-12 Thread Lukáš Tinkl

Dne 12.2.2015 v 23:07 Marco Martin napsal(a):

On Thursday 12 February 2015, David Edmundson wrote:

I'm super happy with the touchpad KCM, I'd like to merge it soon to
maximise testing before the 5.3 release.

Any objections to me merging into plasma-desktop with the other KCMs? I
don't think there's a reason to keep it in a separate repo now it's ready
for usage.

I'll filter branch to keep the history.

ktouchpadenabler will then be dropped as this provides the same feature
only more configurable and with future proofed with libinput support.


if it's only a kcm without other stuff like daemons, +1 from here



It also has a kded module which is surprisingly linked together with the kcm

--
Lukáš Tinkl lu...@kde.org
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Merging KCM Touchpad

2015-02-12 Thread Aleix Pol
On Thu, Feb 12, 2015 at 8:51 PM, David Edmundson
da...@davidedmundson.co.uk wrote:
 I'm super happy with the touchpad KCM, I'd like to merge it soon to maximise
 testing before the 5.3 release.

 Any objections to me merging into plasma-desktop with the other KCMs? I
 don't think there's a reason to keep it in a separate repo now it's ready
 for usage.

 I'll filter branch to keep the history.

 ktouchpadenabler will then be dropped as this provides the same feature only
 more configurable and with future proofed with libinput support.

+1

CC'ing Albert, who is the ktouchpadenabler maintainer, IIRC.

Aleix
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel