Re: Papercuts from review at sprint
On Thursday, February 26, 2015 16:16:59 Martin Gräßlin wrote: On Thursday 26 February 2015 16:01:57 Sebastian Kügler wrote: On Thursday, February 26, 2015 08:30:46 Martin Gräßlin wrote: On Wednesday 25 February 2015 18:45:27 Sebastian Kügler wrote: To explain how this works: the question mark is shown in the window decoration when the window signals that it supports the provides context help mode. The window decoration cannot know whether there is something actually providing it. So if it's wrongly shown this means fixing in the application. But the complete feature is questionably as it's a non-standard protocol between Qt and KWin. To my knowledge no other window manager supports it and no other toolkit supports it. Which means that it's a dangerous feature to put help into in a cross-desktop application. So we'd have to gauge its usefulness overall, and see if it makes sense. Are there any apps which really use it, i.e. also provide whatsthis hints consistently? There are many KCMs setting them. E.g. lots of KWin KCMs have such a hint (which might not be surprising as AFAIK the API was implemented by Matthias). Otherwise, perhaps we should review those apps that request the ?, and in case it's nonsensical (such as in systemsettings), remove it. In systemsettings it's only nonsensical for the kcms which do not have it. For the ones from KWin it makes sense. We were looking at the overview. So the ? only makes sense for some module. I guess that's OK then. Do you know how to find this provides context help API? For example in ui files: property name=whatsThis stringHere you can set that windows will be only snapped if you try to overlap them, i.e. they will not be snapped if the windows comes only near another window or border./string /property And QWidget::setWhatsThis Ah, okay, that. -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Re: Papercuts from review at sprint
On Thursday 26 February 2015 16:01:57 Sebastian Kügler wrote: On Thursday, February 26, 2015 08:30:46 Martin Gräßlin wrote: On Wednesday 25 February 2015 18:45:27 Sebastian Kügler wrote: On Monday, February 23, 2015 08:00:40 Martin Gräßlin wrote: On Saturday 21 February 2015 17:56:38 Sebastian Kügler wrote: The button is only shown if the window provides context help. So it is already quite conditionally. Where is that a problem? We took the note when looking at systemsettings. The overview page gets the question mark in the toolbar, yet when I hover with the ? cursor, context help is nowhere to be found. I guess that's one example, there may be others. It made us question the usefulness of that question mark button in the window decoration. To explain how this works: the question mark is shown in the window decoration when the window signals that it supports the provides context help mode. The window decoration cannot know whether there is something actually providing it. So if it's wrongly shown this means fixing in the application. But the complete feature is questionably as it's a non-standard protocol between Qt and KWin. To my knowledge no other window manager supports it and no other toolkit supports it. Which means that it's a dangerous feature to put help into in a cross-desktop application. So we'd have to gauge its usefulness overall, and see if it makes sense. Are there any apps which really use it, i.e. also provide whatsthis hints consistently? There are many KCMs setting them. E.g. lots of KWin KCMs have such a hint (which might not be surprising as AFAIK the API was implemented by Matthias). Otherwise, perhaps we should review those apps that request the ?, and in case it's nonsensical (such as in systemsettings), remove it. In systemsettings it's only nonsensical for the kcms which do not have it. For the ones from KWin it makes sense. Do you know how to find this provides context help API? For example in ui files: property name=whatsThis stringHere you can set that windows will be only snapped if you try to overlap them, i.e. they will not be snapped if the windows comes only near another window or border./string /property And QWidget::setWhatsThis Cheers Martin signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Papercuts from review at sprint
On Thursday, February 26, 2015 08:30:46 Martin Gräßlin wrote: On Wednesday 25 February 2015 18:45:27 Sebastian Kügler wrote: On Monday, February 23, 2015 08:00:40 Martin Gräßlin wrote: On Saturday 21 February 2015 17:56:38 Sebastian Kügler wrote: The button is only shown if the window provides context help. So it is already quite conditionally. Where is that a problem? We took the note when looking at systemsettings. The overview page gets the question mark in the toolbar, yet when I hover with the ? cursor, context help is nowhere to be found. I guess that's one example, there may be others. It made us question the usefulness of that question mark button in the window decoration. To explain how this works: the question mark is shown in the window decoration when the window signals that it supports the provides context help mode. The window decoration cannot know whether there is something actually providing it. So if it's wrongly shown this means fixing in the application. But the complete feature is questionably as it's a non-standard protocol between Qt and KWin. To my knowledge no other window manager supports it and no other toolkit supports it. Which means that it's a dangerous feature to put help into in a cross-desktop application. So we'd have to gauge its usefulness overall, and see if it makes sense. Are there any apps which really use it, i.e. also provide whatsthis hints consistently? Otherwise, perhaps we should review those apps that request the ?, and in case it's nonsensical (such as in systemsettings), remove it. Do you know how to find this provides context help API? -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Papercuts from review at sprint
On Monday, February 23, 2015 08:00:40 Martin Gräßlin wrote: On Saturday 21 February 2015 17:56:38 Sebastian Kügler wrote: * Whatsthis (?) button in the window decoration is almost never used (can this button be either hidden, or shown conditionally) The button is only shown if the window provides context help. So it is already quite conditionally. Where is that a problem? We took the note when looking at systemsettings. The overview page gets the question mark in the toolbar, yet when I hover with the ? cursor, context help is nowhere to be found. I guess that's one example, there may be others. It made us question the usefulness of that question mark button in the window decoration. -- sebas Sebastian Kügler|http://vizZzion.org| http://kde.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Papercuts from review at sprint
On Monday, February 23, 2015 00:12:08 Lukáš Tinkl wrote: Dne 21.2.2015 v 17:56 Sebastian Kügler napsal(a): * Application Color Scheme KCM has [ ] Apply colors to non-KDE4 applications This is what krdb obeys and it basically applies color schemes and/or themes to gtk apps. Or was just the wording the problem? Just the wording that needs to be rethought. -- sebas Sebastian Kügler|http://vizZzion.org| http://kde.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Papercuts from review at sprint
On 02/21/2015 05:56 PM, Sebastian Kügler wrote: * Is the joystick KCM really useful, can it be killed? (If anybody can be found who is actually using a joystick, let's just kill it) I got a joystick as an xmas present, but haven't tested it with the KCM yet. Might take a look. Cheers, Eike ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Re: Papercuts from review at sprint
On Wednesday 25 February 2015 18:45:27 Sebastian Kügler wrote: On Monday, February 23, 2015 08:00:40 Martin Gräßlin wrote: On Saturday 21 February 2015 17:56:38 Sebastian Kügler wrote: * Whatsthis (?) button in the window decoration is almost never used (can this button be either hidden, or shown conditionally) The button is only shown if the window provides context help. So it is already quite conditionally. Where is that a problem? We took the note when looking at systemsettings. The overview page gets the question mark in the toolbar, yet when I hover with the ? cursor, context help is nowhere to be found. I guess that's one example, there may be others. It made us question the usefulness of that question mark button in the window decoration. To explain how this works: the question mark is shown in the window decoration when the window signals that it supports the provides context help mode. The window decoration cannot know whether there is something actually providing it. So if it's wrongly shown this means fixing in the application. But the complete feature is questionably as it's a non-standard protocol between Qt and KWin. To my knowledge no other window manager supports it and no other toolkit supports it. Which means that it's a dangerous feature to put help into in a cross-desktop application. Cheers Martin signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Papercuts from review at sprint
Dne 21.2.2015 v 17:56 Sebastian Kügler napsal(a): * Application Color Scheme KCM has [ ] Apply colors to non-KDE4 applications This is what krdb obeys and it basically applies color schemes and/or themes to gtk apps. Or was just the wording the problem? -- Lukáš Tinkl lu...@kde.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Papercuts from review at sprint
On Saturday 21 February 2015 17:56:38 Sebastian Kügler wrote: * Whatsthis (?) button in the window decoration is almost never used (can this button be either hidden, or shown conditionally) The button is only shown if the window provides context help. So it is already quite conditionally. Where is that a problem? signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Papercuts from review at sprint
Hola, We've sat down at the Plasma sprint and reviewed Plasma 5 from our armchairs. Here are the notes I've taken during that session. = Plasma 5 Review = == Specific Bugs == * New default wallpaper not applied to login manager and splash screen * Pager should collapse when number of virtual desktops 2 * Let's try to fade out the toolbox button's background, some highlight on mouse over * toolbox button is not visually centered correctly * left spacing in pager's tooltip is missing * Blue highlight line on top of K logo when kickoff is opened is missing spacing (bug already reported) * [kickoff] Application in Kickoff tabs is elided (Change to Apps) * [kickoff] Recently used - History * [kickoff] shorter tab switching animations * panel popups have shadow contrast-blurred, are not quite visually merged with the panel, shadow shines through as lighter background * Device Notifier has animated moving highlight * KRunner uses wrong SVG (namely that for non-compositing), leads to jagged corners and missing shadow (turning compositing off and on again fixes it) * Systemsettings background doesn't look Breezish * Remove title at the top of KCM pages * Application Color Scheme KCM has [ ] Apply colors to non-KDE4 applications * Whatsthis (?) button in the window decoration is almost never used (can this button be either hidden, or shown conditionally) * Konqueror KCMs show up in systemsettings | Network * Touchpad settings KCM has very messy layout * Mouse KCM has KDE3-style Mouse logo, and out of place * Mouse Controls Reverse scroll direction doesn't follow HIG-command-style labels, only affects vertical scrolling * Button order is in a groupbox with invisible frame, screws up alignment with checkbox underneath * Automatically select icons after delay doesn't work * Is the joystick KCM really useful, can it be killed? (If anybody can be found who is actually using a joystick, let's just kill it) * In Date Time KCM, the table to pick timezone should be a map (perhaps steal from ubiquity?) * In general, we should treat any missing keyboard navigation as bugs You'll notice that these are pretty much all papercut bugs, not serious showstoppers. Good work, everybody! Cheers, -- sebas Sebastian Kügler|http://vizZzion.org| http://kde.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
