Plasma 5 releases for 2022

[Jonathan Riddell]

I've made a schedule of releases for 2022 using the same formula as
previously.  Three releases a year.

https://community.kde.org/Schedules/Plasma_5

https://phabricator.kde.org/calendar/query/KhNLCxe1xjoI/2021/11/

https://calendar.google.com/calendar/u/0?cid=MDMxZ2tncWcxaGpmOGxjbWowZW0xZDJzajhAZ3JvdXAuY2FsZW5kYXIuZ29vZ2xlLmNvbQ

This might all change if KF6 development gets to a state when it's stable
to develop against.  So far they are unclear on any timetable for this.
The notes from the Frameworks meeting yesterday say:
"""
KF6 Timeline
- Plasma needs to know for release planning for 2022
- possible next KF6 phase would be a branching/porting sprint in Q1 or Q2
2022, now that Qt 6.2 is released
- beta release details to be decided, once KF6 API is stable enough to be
ported to
"""

We'll discuss this at the kickoff meeting.  Poll for meeting open now
https://doodle.com/poll/ws3h2nvunx3yz3yb

Jonathan

D20898: WIP: [kcms/desktoptheme] Switch knsrc to "Plasma 5 Theme" category

[Friedrich W. H. Kossebau]

kossebau abandoned this revision.
kossebau added a comment.


  There is no agreement that splitting off a separate category is the way to 
move forward, so discarding.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20898

To: kossebau, #plasma, apol, leinir, mart
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20898: WIP: [kcms/desktoptheme] Switch knsrc to "Plasma 5 Theme" category

[Friedrich W. H. Kossebau]

kossebau added a comment.


  So, to give context, this is the seemingly needed change on Plasma code side 
for the currently planned way forward with T8126#181349 

  
  Just uploaded here already as note to self and when needed to have something 
to point to when approaching people for further preparation action.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20898

To: kossebau, #plasma, apol, leinir
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20898: WIP: [kcms/desktoptheme] Switch knsrc to "Plasma 5 Theme" category

[Friedrich W. H. Kossebau]

kossebau added a comment.


  The plan was to not have reviewers yet, but oh well ;)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20898

To: kossebau, #plasma, apol, leinir
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20898: WIP: [kcms/desktoptheme] Switch knsrc to "Plasma 5 Theme" category

[Friedrich W. H. Kossebau]

kossebau created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Prepared for execution plan draft of T8126#181349 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20898

AFFECTED FILES
  kcms/desktoptheme/plasma-themes.knsrc

To: kossebau
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Powerdevil] [Bug 379643] When I turn on my notebook, after the full startup of KDE Plasma 5, I verify that the battery monitor is disabled, as if the battery was not present.

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=379643

Christoph Feck  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|UNCONFIRMED |RESOLVED

--- Comment #1 from Christoph Feck  ---
Reported as bug 379644.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 379643] New: When I turn on my notebook, after the full startup of KDE Plasma 5, I verify that the battery monitor is disabled, as if the battery was not present.

[Adriano Balani]

https://bugs.kde.org/show_bug.cgi?id=379643

Bug ID: 379643
   Summary: When I turn on my notebook, after the full startup of
KDE Plasma 5, I verify that the battery monitor is
disabled, as if the battery was not present.
   Product: Powerdevil
   Version: 5.9.5
  Platform: Slackware Packages
OS: Linux
Status: UNCONFIRMED
  Severity: crash
  Priority: NOR
 Component: general
  Assignee: plasma-devel@kde.org
  Reporter: adrianobal...@yahoo.com.br
  Target Milestone: ---

Created attachment 105404
  --> https://bugs.kde.org/attachment.cgi?id=105404=edit
Baloo_file_extractor error

I have verified that it has hours that it works and most of the time not, with
it working or not when I connect the battery charger, it presents an error in
baloo_file_extractor.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 376601] New: Plasma 5 "Leave" overlay does not respect Polkit rule

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=376601

Bug ID: 376601
   Summary: Plasma 5 "Leave" overlay does not respect Polkit rule
   Product: Powerdevil
   Version: unspecified
  Platform: Archlinux Packages
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: plasma-devel@kde.org
  Reporter: patrickrif...@yandex.com
  Target Milestone: ---

When a custom Polkit rule is set to disable sleep and hibernation the buttons
for both sleep and hibernate are removed from the Application Launcher's
"Leave" menu. However, upon selecting an option from the "Leave" menu the
splash screen that appears still has a "Suspend" button (although it doesn't
function). I would recommend that the splash screen respect the same Polkit
rule the Application Launcher does for consistency.

System Information:
OS: Arch Linux x86_64
KDE Plasma Version: 5.9.2
KDE Frameworks Version: 5.31.0
Qt Version: 5.8.0

Polkit rule contents (/etc/polkit-1/rules.d/10-disable-suspend.rules):

polkit.addRule(function(action, subject) {
if (action.id == "org.freedesktop.login1.suspend" ||
action.id == "org.freedesktop.login1.suspend-multiple-sessions" ||
action.id == "org.freedesktop.login1.hibernate" ||
action.id == "org.freedesktop.login1.hibernate-multiple-sessions")
{
return polkit.Result.NO;
}
});

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Review Request 126016: fix: properly recognise Plasma 5 KCM modules (wmClass=kcmshell5)

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126016/#review102489
---



please post this again on phabricator if is still relevant

- Marco Martin


On Nov. 10, 2015, 6:54 p.m., Johan Ouwerkerk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126016/
> ---
> 
> (Updated Nov. 10, 2015, 6:54 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Previously the taskmanager library contained a special case logic for windows 
> of KDE-4 KCM modules (only).
> These modules were recognised by finding wmClass=Kcmshell4.
> This logic is extended to cover kcmshell5 windows as well, meaning that KCMs 
> written for Plasma 5 are properly recognised now.
> The net benefit is that these KCMs are displayed in the task manager with 
> their proper KCM program icons.
> 
> This patch can be pulled from the kcmshell5-task-url-fixes branch at: 
> g...@github.com:cmacq2/plasma-workspace.git
> 
> 
> Diffs
> -
> 
>   libtaskmanager/taskitem.cpp 3b2a4188fc8ed087a331999aee279ecd919c628e 
> 
> Diff: https://git.reviewboard.kde.org/r/126016/diff/
> 
> 
> Testing
> ---
> 
> Built with kdesrc-build, and tested using: `plasmawindowed 
> org.kde.plasma.icontasks`.
> I checked the change works as expected by running `which kcmshell5` style as 
> well as `kcmshell5 style`: the icon of the window matches that in system 
> settings (as expected).
> 
> 
> Thanks,
> 
> Johan Ouwerkerk
> 
>

Re: Review Request 126016: fix: properly recognise Plasma 5 KCM modules (wmClass=kcmshell5)

[Johan Ouwerkerk]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126016/
---

(Updated Feb. 8, 2017, 4:02 p.m.)


Status
--

This change has been discarded.


Review request for Plasma.


Repository: plasma-workspace


Description
---

Previously the taskmanager library contained a special case logic for windows 
of KDE-4 KCM modules (only).
These modules were recognised by finding wmClass=Kcmshell4.
This logic is extended to cover kcmshell5 windows as well, meaning that KCMs 
written for Plasma 5 are properly recognised now.
The net benefit is that these KCMs are displayed in the task manager with their 
proper KCM program icons.

This patch can be pulled from the kcmshell5-task-url-fixes branch at: 
g...@github.com:cmacq2/plasma-workspace.git


Diffs
-

  libtaskmanager/taskitem.cpp 3b2a4188fc8ed087a331999aee279ecd919c628e 

Diff: https://git.reviewboard.kde.org/r/126016/diff/


Testing
---

Built with kdesrc-build, and tested using: `plasmawindowed 
org.kde.plasma.icontasks`.
I checked the change works as expected by running `which kcmshell5` style as 
well as `kcmshell5 style`: the icon of the window matches that in system 
settings (as expected).


Thanks,

Johan Ouwerkerk

Re: Review Request 122494: KDE Plasma 5 system tray expaned applets resized to take less space on notebooks low resolution screens.

[Blaga Florentin Gabriel]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122494/
---

(Updated Feb. 8, 2017, 12:03 p.m.)


Status
--

This change has been discarded.


Review request for Plasma and KDE Usability.


Repository: plasma-workspace


Description
---

KDE Plasma 5 system tray expanded applets resize for notebooks


Diffs
-

  .reviewboardrc 771837c982012f580f10923aa83d83b181afc881 
  applets/systemtray/package/contents/ui/main.qml 
553ad7a23d8d18974a02f35dc64b3f7dd4816585 

Diff: https://git.reviewboard.kde.org/r/122494/diff/


Testing
---

Hello I've modified the size of the expanded system tray applets using the file 
main.qml located at: 
/usr/share/plasma/plasmoids/org.kde.plasma.systemtray/contents/ui/main.qml (I 
have uploaded a copy of the modified file below), thus when expanded they take 
less space on notebook screens with low resolution (15 inch 1376x768), I also 
tested it with a high resolution monitor (19 inch) and it definitely improves 
the space there too. Below there are some screenshots with the "before" and 
"after" the edit.

Kind regards!


File Attachments


battery_unmod_laptop.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/05de2078-6dce-4578-a6a4-06bb6811e7e1__battery_unmod_laptop.png
battery_modif_laptop.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/2c497b47-5180-420e-93bb-09a0225acd3b__battery_modif_laptop.png
networks_unmodif_laptop.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/4752ba6f-329b-461b-bab9-b3cf6c6707ae__networks_unmodif_laptop.png
networks_modif_laptop.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/b614adf0-9d88-4c64-a448-07c9f5d39fd5__networks_modif_laptop.png
high_unmodif_bat.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/1600dac7-9516-4ec9-b66e-ce595c82d10a__high_unmodif_bat.png
high_modif_bat.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/7f00e424-1c76-490a-a698-ec25e148101c__high_modif_bat.png
wireless_unmodif_hires.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/71a32e89-ffdd-49c4-9db2-8a0e02b1c777__wireless_unmodif_hires.png
wireless_modif_hires.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/469148e3-9ac6-4e0e-aafc-91431e87a48d__wireless_modif_hires.png


Thanks,

Blaga Florentin Gabriel

Re: Using javascript-api extension LaunchApp and plasmoid.runCommand in Plasma 5 plasmoid

[Marco Martin]

On Saturday 24 December 2016 02:07:21 Aditya Mehra wrote:
> Hi,
> 
> Not sure where to find support for this, but i am trying to use the
> LaunchApp javascript-api extension in a plasmoid, to launch a shell script
> via a button in my main.qml file. I came across this api extension on
> https://techbase.kde.org/Development/Tutorials/Plasma4/JavaScript/API-Launch
> App which is for plasma 4. Is this still valid for plasma 5 ?

no, it was a completely different way to do applets with pure javascript 
(before QML existed) that has been removed completely


-- 
Marco Martin

[Powerdevil] [Bug 344456] Plasma 5 desktop does not suspend with only upower, no systemd

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=344456

--- Comment #39 from adam.miku...@centrum.cz ---
Hi, I'm happy to report that the problem seems to be finally fixed with plasma
5.8 (just confirmed by my experience, not changelog).

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Help: Creating a plasma 5 widget/plasmoid using QML and C++

[Kevin Krammer]

On Sunday, 2016-07-03, 15:01:22, Aditya Mehra wrote:
> Iv looked into this and was using the same minimal template, The issue
> still is I cant find a way to initialize the DBus adaptor without having a
> main, I did follow the KDE4 DBus tutorials initially on getting the DBus to
> work as KDE 5 has no DBus documentation yet for plasmoids.

You don't need a main() for that, any C++ method that is executed will do, 
e.g. your applet's constructor.

From the template it seems that should already be instantiated.
Can you access the "nativeText" property in your QML file?

Cheers,
Kevin
-- 
Kevin Krammer, KDE developer, xdg-utils developer
KDE user support, developer mentoring


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Help: Creating a plasma 5 widget/plasmoid using QML and C++

[Aditya Mehra]

Iv looked into this and was using the same minimal template, The issue
still is I cant find a way to initialize the DBus adaptor without having a
main, I did follow the KDE4 DBus tutorials initially on getting the DBus to
work as KDE 5 has no DBus documentation yet for plasmoids.

Seems like a no go for plasmoid so launched it as a Qt5 Application
instead. https://github.com/AIIX/Mycroft-Ai-QtApplication

Thanks for replying tho i was running around in circles with getting the
main function to work.

On Sun, Jul 3, 2016 at 4:41 AM, Marco Martin <notm...@gmail.com> wrote:

> On Friday 01 July 2016, Aditya Mehra wrote:
> > Request you to please guide me on why the main function doesn't work
> > in plasma5 and how can i fix it.
> > There is no documentation available on C++/QML plasmoid/widgets for
> > plasma 5 so asking for help here.
> >
> > Thanks,
> > Aditya
>
> look at
>
> https://quickgit.kde.org/?p=plasma-framework.git=tree=747500851adcb1e5ccbb1a902865c6aee9327d83=990662800da9e7e39066bae41f34efcd8316b50f=templates%2Fcpp-plasmoid%2Fsrc
> for a minimal template (kdevelop should also have a new qml/c++ plasmoid
> template that uses this).
> and yes, as Kevin says, it has no main, is something that gets loaded by
> plasmashell
>
> --
> Marco Martin
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Help: Creating a plasma 5 widget/plasmoid using QML and C++

[Marco Martin]

On Friday 01 July 2016, Aditya Mehra wrote:
> Request you to please guide me on why the main function doesn't work
> in plasma5 and how can i fix it.
> There is no documentation available on C++/QML plasmoid/widgets for
> plasma 5 so asking for help here.
> 
> Thanks,
> Aditya

look at
https://quickgit.kde.org/?p=plasma-framework.git=tree=747500851adcb1e5ccbb1a902865c6aee9327d83=990662800da9e7e39066bae41f34efcd8316b50f=templates%2Fcpp-plasmoid%2Fsrc
for a minimal template (kdevelop should also have a new qml/c++ plasmoid 
template that uses this).
and yes, as Kevin says, it has no main, is something that gets loaded by 
plasmashell

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Help: Creating a plasma 5 widget/plasmoid using QML and C++

[Kevin Krammer]

Hi Aditya,

On Friday, 2016-07-01, 23:00:27, Aditya Mehra wrote:
> Hi, I am currently trying to create a plasma 5 widget/plasmoid for
> interaction with a python application using Dbus. I am using Qml/C++ for
> building the plasmoid. I am trying to use K Develop 5 to build the widget
> but am facing many errors in the process.
> 
> The plasmoid sends and receives string values to the python application
> using QT DBus. The plasmoid builds without error inside KDevelop 5 but the
> dbus adaptor is not being initialized and neither are my other classes
> within the main function of the plasmoid. Only the QML file is displayed
> with no connection to my main function when added to the desktop or tested
> with execute in KDevelop 5.

A Plasma Applet is a plugin, which gets loaded by the Plasma host application, 
e.g. Plasma Shell.

As a plugin it doesn't have a "main" function like a program would have, i.e. 
even if your code has a main() function somewhere it won't be executed since 
the plugin is not run like an application would.

The plugin loader will use some meta data provided by the plugin to decide 
which class to instantiate when it loads the plugin.

You'll need to put your initialization code into that class.

I am not an expert on Plasma plugins but from the description of the behavior 
you are seeing my guess would be that the host application thinks you plugin 
is loaded through your main QML file.
Maybe it will try to instantiate your applet class if you remove the QML hints 
from your .desktop file.

Cheers,
Kevin
-- 
Kevin Krammer, KDE developer, xdg-utils developer
KDE user support, developer mentoring


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Help: Creating a plasma 5 widget/plasmoid using QML and C++

[Aditya Mehra]

Hi, I am currently trying to create a plasma 5 widget/plasmoid for
interaction with a python application using Dbus. I am using Qml/C++ for
building the plasmoid. I am trying to use K Develop 5 to build the widget
but am facing many errors in the process.

The plasmoid sends and receives string values to the python application
using QT DBus. The plasmoid builds without error inside KDevelop 5 but the
dbus adaptor is not being initialized and neither are my other classes
within the main function of the plasmoid. Only the QML file is displayed
with no connection to my main function when added to the desktop or tested
with execute in KDevelop 5.

The main.cpp:

#include "testplasmoid.h"
#include 
#include 
#include 
#include 
#include "ExampleAdaptor.h"
#include "scriptlauncher.h"
#include 
#include 
#include 
#include 
#include 
#include 
#include 
#include 
#include 
#include 

testplasmoid::testplasmoid(QObject *parent, const QVariantList )
: Plasma::Applet(parent, args),
 m_nativeText(i18n("Text coming from C++ plugin"))
{
}

testplasmoid::~testplasmoid()
{
}

QString testplasmoid::nativeText() const
{
  return m_nativeText;
 }

int main(int argc, char *argv[])
{
 QApplication app(argc, argv);
 KDEDbusAdaptor KDEDbusAdaptor(); [<- Initializing the
Class/Dbus Adaptor]
 ScriptLauncher launcher; [<-- Initializing the Class]
 QQmlApplicationEngine engine;
 engine.rootContext()->setContextProperty("KDEDbusAdaptor",
);
 engine.rootContext()->setContextProperty("scriptLauncher", );
 QObject *topLevel = engine.rootObjects().value(0);
 QObject::connect(topLevel,SIGNAL(submitTextField(QString)),
,SLOT(sendQueryFunctionSlot(QString)));
 QObject::connect(topLevel,SIGNAL(senddbussignal(QString)),
,SLOT(emptyslot(QString)));
 return app.exec();
}

K_EXPORT_PLASMA_APPLET_WITH_JSON(testplasmoid, testplasmoid,
"metadata.json")
#include "testplasmoid.moc"


The CMakeList.txt is set as the follows:

add_definitions(-DTRANSLATION_DOMAIN=\"plasma_applet_org.kde.testplasmoid\")
set(CMAKE_AUTOMOC ON)
set(CMAKE_INCLUDE_CURRENT_DIR ON)

set(testplasmoid_SRCS
main.cpp
scriptlauncher.cpp
ExampleAdaptor.cpp)

set(testplasmoid_HEADERS
testplasmoid.h
scriptlauncher.h
ExampleAdaptor.h)

find_package(Qt5 ${QT_MIN_VERSION} CONFIG REQUIRED COMPONENTS
Quick
Core
DBus
Widgets
)

add_library(plasma_applet_testplasmoid MODULE ${testplasmoid_SRCS}
${testplasmoid_HEADERS})
kcoreaddons_desktop_to_json(plasma_applet_testplasmoid
package/metadata.desktop SERVICE_TYPES plasma-applet.desktop)
target_link_libraries(plasma_applet_testplasmoid
   Qt5::DBus
   Qt5::Gui
   Qt5::Qml
   Qt5::Quick
   Qt5::Widgets
   KF5::Plasma
   KF5::I18n)

 target_link_libraries(plasma_applet_testplasmoid
${QT_QTDECLARATIVE_LIBRARY})
 install(TARGETS plasma_applet_testplasmod DESTINATION
${KDE_INSTALL_PLUGINDIR}/plasma/applets)
 plasma_install_package(package org.kde.testplasmoid)

Request you to please guide me on why the main function doesn't work
in plasma5 and how can i fix it.
There is no documentation available on C++/QML plasmoid/widgets for
plasma 5 so asking for help here.

Thanks,
Aditya
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: translation threshold for Plasma 5

[Martin Graesslin]

On Thursday, June 2, 2016 8:56:42 PM CEST Burkhard Lück wrote:
> Hi,
> 
> I am updating the translation-howto and want to add the info for a
> translation threshold for shipping with plasma 5.
> 
> I found some mails on kde-i18n-...@kde.org but no definite percentage.
> 
> Is there a translation threshold for Plasma 5?

It's something we never (at least I cannot remember) discussed. So I would say 
the same threshold as used to by for KDE SC.

Thanks for looking into this.

Cheers
Martin


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

translation threshold for Plasma 5

[Burkhard Lück]

Hi,

I am updating the translation-howto and want to add the info for a translation 
threshold for shipping with plasma 5.

I found some mails on   kde-i18n-...@kde.org but no definite percentage.

Is there a translation threshold for Plasma 5?

-- 
Burkhard Lück

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Unable to start Plasma 5 on CentOS 7

[rafranco.2014]

Hi guys,I' m new to this mailing list and to the KDE community. I' m a newby in 
KDE development but I have a not so bad knowledge of Linux and I' d like to 
contribute anyway to the KDE development.
To get start I begun building KF5 on a CentOS7 machine following instructions at
https://community.kde.org/Guidelines_and_HOWTOs/Build_from_source

With some hints from the kde-devel mailing list' s guys and after several 
manual software installations and upgrades I finally finished building the 
whole framework, but I'm not able to start Plasma 5.To do it I'm following 
instructions at 
https://community.kde.org/Guidelines_and_HOWTOs/Build_from_source/Test_plasma

but I have following problems:
1) Creating files as stating in the "Configure dbus paragraph" break my system: 
on restarting it hangs on loading screen and I never get to the login screen.
2) Skipping instructions about configuring dbus and trying to start Plasma as 
reported in paragraph "From the command line" I get to the loading screen of 
Plasma but after that system hangs on a dark screen.
3) Same problem with the fisrt approach stated in paragraph "Using a login 
manager": system hangs after the Plasma 5 loading screen.

I' ve already submitted the question to the  kde-devel but still no aswers.



May be a dbus configuration problem? Any one can point me to a solution or to 
some documentation to fix or debug it?

Any help would be greatly appreciated.
Raffaele.___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 344456] Plasma 5 desktop does not suspend with only upower, no systemd

[Anton Filimonov via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=344456

Anton Filimonov  changed:

   What|Removed |Added

 CC||anton.filimo...@gmail.com

--- Comment #38 from Anton Filimonov  ---
Had same problem with suspend in Gentoo with plasma 5.5.5. Localauthority files
mentioned above didn't help. Managed to solve missing suspend issue by adding
polkit rule instead:

polkit.addRule(function(action, subject) {
if (action.id == "org.freedesktop.upower.suspend")
{
return polkit.Result.YES;
}
});

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 344456] Plasma 5 desktop does not suspend with only upower, no systemd

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=344456

--- Comment #37 from adam.miku...@centrum.cz ---
$ ck-list-sessions
Session2:
unix-user = '1000'
realname = '(null)'
seat = 'Seat1'
session-type = ''
active = TRUE
x11-display = ':0'
x11-display-device = '/dev/tty7'
display-device = ''
remote-host-name = ''
is-local = TRUE
on-since = '2016-01-31T09:53:12.970020Z'
login-session-id = ''

I believe I have everything right regarding
https://wiki.gentoo.org/wiki/KDE/Plasma_5_upgrade#Missing_shutdown.2C_reboot.2C_suspend_and_hibernate_buttons_when_using_OpenRC

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 344456] Plasma 5 desktop does not suspend with only upower, no systemd

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=344456

--- Comment #36 from andreas.sturmlech...@gmail.com ---
Please check your consolekit setup w/ '$ ck-list-sessions' from inside your
plasma session.

Make sure your system-login file is valid:
https://wiki.gentoo.org/wiki/KDE/Plasma_5_upgrade#Missing_shutdown.2C_reboot.2C_suspend_and_hibernate_buttons_when_using_OpenRC

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 344456] Plasma 5 desktop does not suspend with only upower, no systemd

[Kai Uwe Broulik via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=344456

--- Comment #34 from Kai Uwe Broulik  ---
Check whether the dbus service org.freedesktop.ConsoleKit is running and it has
permission to access it. That message is from the inhibition manager and
unrelated to suspend, though.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 344456] Plasma 5 desktop does not suspend with only upower, no systemd

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=344456

--- Comment #35 from adam.miku...@centrum.cz ---
I believe so, it returns this:

qdbus --system org.freedesktop.ConsoleKit
/
/org
/org/freedesktop
/org/freedesktop/ConsoleKit
/org/freedesktop/ConsoleKit/Manager
/org/freedesktop/ConsoleKit/Seat1
/org/freedesktop/ConsoleKit/Session2

I've tried with fresh new user and it is still the same. Only difference is
that new user when click restart (restart computer) only X session is actually
restarted, this user is only member of "users" group, while my actual user is
member of more groups. I see that slackware and gentoo are using different
groups power and users, and that user above who has reported same symptoms
resolved it by adding user to group "users". Maybe I have some group rights
wrong somewhere in filesystem, process, socket, anything, or is is solely a way
for authorization by those polkit rules? Is there any way to debug why
powerdevil can't contact consolekit?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126016: fix: properly recognise Plasma 5 KCM modules (wmClass=kcmshell5)

[Martin Gräßlin]

> On Nov. 11, 2015, 8:14 a.m., Martin Gräßlin wrote:
> > personal comment from X world: this is horrible, horrible ;-) What we 
> > should try is to make the desktop file available to the window. With KF 
> > 5.16 we will have all that's needed available. Let's try to improve this in 
> > Plasma 5.5 and scratch the code completely.
> 
> Eike Hein wrote:
> +1, I want to get rid of hacks, not pile on them
> 
> Johan Ouwerkerk wrote:
> > With KF 5.16 we will have all that's needed available. Let's try to 
> improve this in Plasma 5.5 and scratch the code completely.
> 
> Great and I agree that the code is not great --all those wasted service 
> lookups and subtly broken caching of the answer-- but: where is this 
> alternative code that fixes everything? ;) Right now, I think this change 
> amounts to a trivial fix (just one forgotten case in the if-clause) to an 
> existing 'feature'/workaround that has a fairly immediate benefit (something 
> works again) and little cost: it's hardly a new one.
> 
> Martin Gräßlin wrote:
> yeah sure, this was not meant as a "blocking" comment. I think the change 
> should go in, but leave the decision to Eike.
> 
> I btw. already started working on the improvement by proposing a new 
> addition to the NETWM spec and implementing it in KWindowSystem.
> 
> Johan Ouwerkerk wrote:
> Eike: what's your verdict? To ship or not to ship?
> 
> (In the case of shipping it: please note that I do not have commit access 
> (just a KDE identity account) so please pull these changes because I cannot 
> commit them.)
> 
> Johan Ouwerkerk wrote:
> Now that my developer account has been approved (that took a few weeks), 
> let's revisit this:
> 
> @Eike: should I push to master or not?
> 
> Eike Hein wrote:
> Martin, what's the status of your prop-based way?

I need to update the proposal again to incorporate the feedback. Didn't find 
time for that yet.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126016/#review88236
---


On Nov. 10, 2015, 7:54 p.m., Johan Ouwerkerk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126016/
> ---
> 
> (Updated Nov. 10, 2015, 7:54 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Previously the taskmanager library contained a special case logic for windows 
> of KDE-4 KCM modules (only).
> These modules were recognised by finding wmClass=Kcmshell4.
> This logic is extended to cover kcmshell5 windows as well, meaning that KCMs 
> written for Plasma 5 are properly recognised now.
> The net benefit is that these KCMs are displayed in the task manager with 
> their proper KCM program icons.
> 
> This patch can be pulled from the kcmshell5-task-url-fixes branch at: 
> g...@github.com:cmacq2/plasma-workspace.git
> 
> 
> Diffs
> -
> 
>   libtaskmanager/taskitem.cpp 3b2a4188fc8ed087a331999aee279ecd919c628e 
> 
> Diff: https://git.reviewboard.kde.org/r/126016/diff/
> 
> 
> Testing
> ---
> 
> Built with kdesrc-build, and tested using: `plasmawindowed 
> org.kde.plasma.icontasks`.
> I checked the change works as expected by running `which kcmshell5` style as 
> well as `kcmshell5 style`: the icon of the window matches that in system 
> settings (as expected).
> 
> 
> Thanks,
> 
> Johan Ouwerkerk
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: How to handle drag-and-drop to the desktop in Plasma 5?

[Eike Hein]

On 12/03/2015 12:04 PM, Weng Xuetian wrote:
> Just tried to debug it a little bit, looks like FolderModel::drop is
> not called at all.
> 
> From the observed visual behavior, plasmashell seems to takes the drop
> as a new plasmoid request so FolderModel doesn't get the drop event.
> 
> Probably it is blocked by following code in desktop containment.
> if (isFolder && event.mimeData.hasUrls)

The .hasUrls prop is a recent change after changes
in plasma-framework, so it might explain the regression.


Cheers,
Eike
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: How to handle drag-and-drop to the desktop in Plasma 5?

[Weng Xuetian]

Just tried to debug it a little bit, looks like FolderModel::drop is
not called at all.

From the observed visual behavior, plasmashell seems to takes the drop
as a new plasmoid request so FolderModel doesn't get the drop event.

Probably it is blocked by following code in desktop containment.
if (isFolder && event.mimeData.hasUrls)

On Tue, Dec 1, 2015 at 5:46 AM, Elvis Angelaccio
<elvis.angelac...@kdemail.net> wrote:
>
>
> 2015-12-01 14:13 GMT+01:00 Bhushan Shah <bhus...@gmail.com>:
>>
>> Hello,
>>
>> On Tue, Dec 1, 2015 at 6:39 PM, Marco Martin <notm...@gmail.com> wrote:
>> >>
>> >> In Plasma 5 this does not work anymore, as kde-base repo has not been
>> >> ported. But I see that drag-and-dropping files from Dolphin to the
>> >> desktop
>> >> works, so: where is Ark supposed to "register" this dbus method, in
>> >> Plasma
>> >> 5?
>> >
>> > Hi,
>> > folderview is now in the plasma-desktop repository, in
>> > plasma-desktop/applets/folder
>> > It has been completely rewritten so something may have been lost in
>> > translation.
>> > What was it doing exactly? was it folderview invoking a dbus method
>> > explicitly on Ark?
>
>
> Yes, it was invoking the method extractSelectedFilesTo of dbus interface
> org.kde.ark.DndExtract, from line 2362 of
> kde-base/plasma/applets/folderview/iconview.cpp
>
>
>>
>>
>> plasma-desktop still have code specific to ark
>>
>> plasma-desktop/containments/desktop/plugins/folder/foldermodel.cpp
>> L744 and ahead..
>>
>
> I see. Then I wonder what might be going wrong. From my limited dbus
> knowledge I cannot tell whether it's Ark's or Plasma's fault.
> Any help on this would be very appreciated, as dragging from Ark to the
> desktop can be considered a major feature, currently broken.
>
> Just a recap on the situation:
> - Ark defines this dbus method in: ark/part/dnddbusinterface.xml
> - Drag-and-dropping from Ark to Dolphin works
> - Drag-and-dropping from Ark to Desktop or Folder View plasmoid does not
> work - the dbus method seems to not be called at all
>
>
>
>> Also if I remember correctly, this used to work in initial plasma
>> release..
>>
>> --
>> Bhushan Shah
>>
>> http://bhush9.github.io
>> IRC Nick : bshah on Freenode
>
>
> Cheers,
> Elvis
>
>
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: How to handle drag-and-drop to the desktop in Plasma 5?

[Eike Hein]

4018e27a in plasma-desktop fixes the FV side.

It's still not really working for the Desktop folder though.
Ark claims to be extracting to desktop:/, but just dumps the
file into $HOME. It's the same with desktop:/ in Dolphin though.


Cheers,
Eike
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: How to handle drag-and-drop to the desktop in Plasma 5?

[Eike Hein]

This fixes the Ark side, please review:

https://git.reviewboard.kde.org/r/126233/


Cheers,
Eike
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126016: fix: properly recognise Plasma 5 KCM modules (wmClass=kcmshell5)

[Eike Hein]

> On Nov. 11, 2015, 7:14 a.m., Martin Gräßlin wrote:
> > personal comment from X world: this is horrible, horrible ;-) What we 
> > should try is to make the desktop file available to the window. With KF 
> > 5.16 we will have all that's needed available. Let's try to improve this in 
> > Plasma 5.5 and scratch the code completely.
> 
> Eike Hein wrote:
> +1, I want to get rid of hacks, not pile on them
> 
> Johan Ouwerkerk wrote:
> > With KF 5.16 we will have all that's needed available. Let's try to 
> improve this in Plasma 5.5 and scratch the code completely.
> 
> Great and I agree that the code is not great --all those wasted service 
> lookups and subtly broken caching of the answer-- but: where is this 
> alternative code that fixes everything? ;) Right now, I think this change 
> amounts to a trivial fix (just one forgotten case in the if-clause) to an 
> existing 'feature'/workaround that has a fairly immediate benefit (something 
> works again) and little cost: it's hardly a new one.
> 
> Martin Gräßlin wrote:
> yeah sure, this was not meant as a "blocking" comment. I think the change 
> should go in, but leave the decision to Eike.
> 
> I btw. already started working on the improvement by proposing a new 
> addition to the NETWM spec and implementing it in KWindowSystem.
> 
> Johan Ouwerkerk wrote:
> Eike: what's your verdict? To ship or not to ship?
> 
> (In the case of shipping it: please note that I do not have commit access 
> (just a KDE identity account) so please pull these changes because I cannot 
> commit them.)
> 
> Johan Ouwerkerk wrote:
> Now that my developer account has been approved (that took a few weeks), 
> let's revisit this:
> 
> @Eike: should I push to master or not?

Martin, what's the status of your prop-based way?


- Eike


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126016/#review88236
---


On Nov. 10, 2015, 6:54 p.m., Johan Ouwerkerk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126016/
> ---
> 
> (Updated Nov. 10, 2015, 6:54 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Previously the taskmanager library contained a special case logic for windows 
> of KDE-4 KCM modules (only).
> These modules were recognised by finding wmClass=Kcmshell4.
> This logic is extended to cover kcmshell5 windows as well, meaning that KCMs 
> written for Plasma 5 are properly recognised now.
> The net benefit is that these KCMs are displayed in the task manager with 
> their proper KCM program icons.
> 
> This patch can be pulled from the kcmshell5-task-url-fixes branch at: 
> g...@github.com:cmacq2/plasma-workspace.git
> 
> 
> Diffs
> -
> 
>   libtaskmanager/taskitem.cpp 3b2a4188fc8ed087a331999aee279ecd919c628e 
> 
> Diff: https://git.reviewboard.kde.org/r/126016/diff/
> 
> 
> Testing
> ---
> 
> Built with kdesrc-build, and tested using: `plasmawindowed 
> org.kde.plasma.icontasks`.
> I checked the change works as expected by running `which kcmshell5` style as 
> well as `kcmshell5 style`: the icon of the window matches that in system 
> settings (as expected).
> 
> 
> Thanks,
> 
> Johan Ouwerkerk
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126016: fix: properly recognise Plasma 5 KCM modules (wmClass=kcmshell5)

[Johan Ouwerkerk]

> On Nov. 11, 2015, 7:14 a.m., Martin Gräßlin wrote:
> > personal comment from X world: this is horrible, horrible ;-) What we 
> > should try is to make the desktop file available to the window. With KF 
> > 5.16 we will have all that's needed available. Let's try to improve this in 
> > Plasma 5.5 and scratch the code completely.
> 
> Eike Hein wrote:
> +1, I want to get rid of hacks, not pile on them
> 
> Johan Ouwerkerk wrote:
> > With KF 5.16 we will have all that's needed available. Let's try to 
> improve this in Plasma 5.5 and scratch the code completely.
> 
> Great and I agree that the code is not great --all those wasted service 
> lookups and subtly broken caching of the answer-- but: where is this 
> alternative code that fixes everything? ;) Right now, I think this change 
> amounts to a trivial fix (just one forgotten case in the if-clause) to an 
> existing 'feature'/workaround that has a fairly immediate benefit (something 
> works again) and little cost: it's hardly a new one.
> 
> Martin Gräßlin wrote:
> yeah sure, this was not meant as a "blocking" comment. I think the change 
> should go in, but leave the decision to Eike.
> 
> I btw. already started working on the improvement by proposing a new 
> addition to the NETWM spec and implementing it in KWindowSystem.
> 
> Johan Ouwerkerk wrote:
> Eike: what's your verdict? To ship or not to ship?
> 
> (In the case of shipping it: please note that I do not have commit access 
> (just a KDE identity account) so please pull these changes because I cannot 
> commit them.)

Now that my developer account has been approved (that took a few weeks), let's 
revisit this:

@Eike: should I push to master or not?


- Johan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126016/#review88236
---


On Nov. 10, 2015, 6:54 p.m., Johan Ouwerkerk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126016/
> ---
> 
> (Updated Nov. 10, 2015, 6:54 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Previously the taskmanager library contained a special case logic for windows 
> of KDE-4 KCM modules (only).
> These modules were recognised by finding wmClass=Kcmshell4.
> This logic is extended to cover kcmshell5 windows as well, meaning that KCMs 
> written for Plasma 5 are properly recognised now.
> The net benefit is that these KCMs are displayed in the task manager with 
> their proper KCM program icons.
> 
> This patch can be pulled from the kcmshell5-task-url-fixes branch at: 
> g...@github.com:cmacq2/plasma-workspace.git
> 
> 
> Diffs
> -
> 
>   libtaskmanager/taskitem.cpp 3b2a4188fc8ed087a331999aee279ecd919c628e 
> 
> Diff: https://git.reviewboard.kde.org/r/126016/diff/
> 
> 
> Testing
> ---
> 
> Built with kdesrc-build, and tested using: `plasmawindowed 
> org.kde.plasma.icontasks`.
> I checked the change works as expected by running `which kcmshell5` style as 
> well as `kcmshell5 style`: the icon of the window matches that in system 
> settings (as expected).
> 
> 
> Thanks,
> 
> Johan Ouwerkerk
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: How to handle drag-and-drop to the desktop in Plasma 5?

[Marco Martin]

On Wed, Nov 25, 2015 at 4:49 PM, Elvis Angelaccio
<elvis.angelac...@kdemail.net> wrote:
> Hi guys, in KDE 4 Ark used to be notified of dropEvents() to the desktop, by
> having a dbus method called from
> kde-base/plasma/applets/folderview/iconview.cpp (in particular from the
> IconView::dropEvent() function).
>
> In Plasma 5 this does not work anymore, as kde-base repo has not been
> ported. But I see that drag-and-dropping files from Dolphin to the desktop
> works, so: where is Ark supposed to "register" this dbus method, in Plasma
> 5?

Hi,
folderview is now in the plasma-desktop repository, in
plasma-desktop/applets/folder
It has been completely rewritten so something may have been lost in translation.
What was it doing exactly? was it folderview invoking a dbus method
explicitly on Ark?

--
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: How to handle drag-and-drop to the desktop in Plasma 5?

[Eike Hein]

On 12/01/2015 02:13 PM, Bhushan Shah wrote:
> plasma-desktop still have code specific to ark

Yeah, FolderModel basically contains the same D-Bus code
as iconview did before, but I couldn't really test it at
the time. Debugging from an Ark dev very welcome.


Cheers,
Eike
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: How to handle drag-and-drop to the desktop in Plasma 5?

[Elvis Angelaccio]

2015-12-01 14:13 GMT+01:00 Bhushan Shah <bhus...@gmail.com>:

> Hello,
>
> On Tue, Dec 1, 2015 at 6:39 PM, Marco Martin <notm...@gmail.com> wrote:
> >>
> >> In Plasma 5 this does not work anymore, as kde-base repo has not been
> >> ported. But I see that drag-and-dropping files from Dolphin to the
> desktop
> >> works, so: where is Ark supposed to "register" this dbus method, in
> Plasma
> >> 5?
> >
> > Hi,
> > folderview is now in the plasma-desktop repository, in
> > plasma-desktop/applets/folder
> > It has been completely rewritten so something may have been lost in
> translation.
> > What was it doing exactly? was it folderview invoking a dbus method
> > explicitly on Ark?
>

Yes, it was invoking the method extractSelectedFilesTo of dbus interface
org.kde.ark.DndExtract, from line 2362 of
kde-base/plasma/applets/folderview/iconview.cpp



>
> plasma-desktop still have code specific to ark
>
> plasma-desktop/containments/desktop/plugins/folder/foldermodel.cpp
> L744 and ahead..
>
>
I see. Then I wonder what might be going wrong. From my limited dbus
knowledge I cannot tell whether it's Ark's or Plasma's fault.
Any help on this would be very appreciated, as dragging from Ark to the
desktop can be considered a major feature, currently broken.

Just a recap on the situation:
- Ark defines this dbus method in: ark/part/dnddbusinterface.xml
- Drag-and-dropping from Ark to Dolphin works
- Drag-and-dropping from Ark to Desktop or Folder View plasmoid does not
work - the dbus method seems to not be called at all



Also if I remember correctly, this used to work in initial plasma release..
>
> --
> Bhushan Shah
>
> http://bhush9.github.io
> IRC Nick : bshah on Freenode
>

Cheers,
Elvis
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

How to handle drag-and-drop to the desktop in Plasma 5?

[Elvis Angelaccio]

Hi guys, in KDE 4 Ark used to be notified of dropEvents() to the desktop,
by having a dbus method called from
kde-base/plasma/applets/folderview/iconview.cpp (in particular from the
IconView::dropEvent() function).

In Plasma 5 this does not work anymore, as kde-base repo has not been
ported. But I see that drag-and-dropping files from Dolphin to the desktop
works, so: where is Ark supposed to "register" this dbus method, in Plasma
5?

Cheers,
Elvis

P.S.
I'm not subscribed to this list, so please add me to CC
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126016: fix: properly recognise Plasma 5 KCM modules (wmClass=kcmshell5)

[Johan Ouwerkerk]

> On Nov. 11, 2015, 7:14 a.m., Martin Gräßlin wrote:
> > personal comment from X world: this is horrible, horrible ;-) What we 
> > should try is to make the desktop file available to the window. With KF 
> > 5.16 we will have all that's needed available. Let's try to improve this in 
> > Plasma 5.5 and scratch the code completely.
> 
> Eike Hein wrote:
> +1, I want to get rid of hacks, not pile on them
> 
> Johan Ouwerkerk wrote:
> > With KF 5.16 we will have all that's needed available. Let's try to 
> improve this in Plasma 5.5 and scratch the code completely.
> 
> Great and I agree that the code is not great --all those wasted service 
> lookups and subtly broken caching of the answer-- but: where is this 
> alternative code that fixes everything? ;) Right now, I think this change 
> amounts to a trivial fix (just one forgotten case in the if-clause) to an 
> existing 'feature'/workaround that has a fairly immediate benefit (something 
> works again) and little cost: it's hardly a new one.
> 
> Martin Gräßlin wrote:
> yeah sure, this was not meant as a "blocking" comment. I think the change 
> should go in, but leave the decision to Eike.
> 
> I btw. already started working on the improvement by proposing a new 
> addition to the NETWM spec and implementing it in KWindowSystem.

Eike: what's your verdict? To ship or not to ship?

(In the case of shipping it: please note that I do not have commit access (just 
a KDE identity account) so please pull these changes because I cannot commit 
them.)


- Johan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126016/#review88236
---


On Nov. 10, 2015, 6:54 p.m., Johan Ouwerkerk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126016/
> ---
> 
> (Updated Nov. 10, 2015, 6:54 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Previously the taskmanager library contained a special case logic for windows 
> of KDE-4 KCM modules (only).
> These modules were recognised by finding wmClass=Kcmshell4.
> This logic is extended to cover kcmshell5 windows as well, meaning that KCMs 
> written for Plasma 5 are properly recognised now.
> The net benefit is that these KCMs are displayed in the task manager with 
> their proper KCM program icons.
> 
> This patch can be pulled from the kcmshell5-task-url-fixes branch at: 
> g...@github.com:cmacq2/plasma-workspace.git
> 
> 
> Diffs
> -
> 
>   libtaskmanager/taskitem.cpp 3b2a4188fc8ed087a331999aee279ecd919c628e 
> 
> Diff: https://git.reviewboard.kde.org/r/126016/diff/
> 
> 
> Testing
> ---
> 
> Built with kdesrc-build, and tested using: `plasmawindowed 
> org.kde.plasma.icontasks`.
> I checked the change works as expected by running `which kcmshell5` style as 
> well as `kcmshell5 style`: the icon of the window matches that in system 
> settings (as expected).
> 
> 
> Thanks,
> 
> Johan Ouwerkerk
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126016: fix: properly recognise Plasma 5 KCM modules (wmClass=kcmshell5)

[Johan Ouwerkerk]

> On Nov. 11, 2015, 7:14 a.m., Martin Gräßlin wrote:
> > libtaskmanager/taskitem.cpp, line 627
> > <https://git.reviewboard.kde.org/r/126016/diff/1/?file=416095#file416095line627>
> >
> > don't we have to change to kdeinit5 here?

No. The commandline is /path/used/to/launch/kcmshell5 style. The "kcmshell5 
style" portion is eventually matched to the desktop file in 
getServiceLauncherUrl.


- Johan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126016/#review88236
---


On Nov. 10, 2015, 6:54 p.m., Johan Ouwerkerk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126016/
> ---
> 
> (Updated Nov. 10, 2015, 6:54 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Previously the taskmanager library contained a special case logic for windows 
> of KDE-4 KCM modules (only).
> These modules were recognised by finding wmClass=Kcmshell4.
> This logic is extended to cover kcmshell5 windows as well, meaning that KCMs 
> written for Plasma 5 are properly recognised now.
> The net benefit is that these KCMs are displayed in the task manager with 
> their proper KCM program icons.
> 
> This patch can be pulled from the kcmshell5-task-url-fixes branch at: 
> g...@github.com:cmacq2/plasma-workspace.git
> 
> 
> Diffs
> -
> 
>   libtaskmanager/taskitem.cpp 3b2a4188fc8ed087a331999aee279ecd919c628e 
> 
> Diff: https://git.reviewboard.kde.org/r/126016/diff/
> 
> 
> Testing
> ---
> 
> Built with kdesrc-build, and tested using: `plasmawindowed 
> org.kde.plasma.icontasks`.
> I checked the change works as expected by running `which kcmshell5` style as 
> well as `kcmshell5 style`: the icon of the window matches that in system 
> settings (as expected).
> 
> 
> Thanks,
> 
> Johan Ouwerkerk
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126016: fix: properly recognise Plasma 5 KCM modules (wmClass=kcmshell5)

[Martin Gräßlin]

> On Nov. 11, 2015, 8:14 a.m., Martin Gräßlin wrote:
> > personal comment from X world: this is horrible, horrible ;-) What we 
> > should try is to make the desktop file available to the window. With KF 
> > 5.16 we will have all that's needed available. Let's try to improve this in 
> > Plasma 5.5 and scratch the code completely.
> 
> Eike Hein wrote:
> +1, I want to get rid of hacks, not pile on them
> 
> Johan Ouwerkerk wrote:
> > With KF 5.16 we will have all that's needed available. Let's try to 
> improve this in Plasma 5.5 and scratch the code completely.
> 
> Great and I agree that the code is not great --all those wasted service 
> lookups and subtly broken caching of the answer-- but: where is this 
> alternative code that fixes everything? ;) Right now, I think this change 
> amounts to a trivial fix (just one forgotten case in the if-clause) to an 
> existing 'feature'/workaround that has a fairly immediate benefit (something 
> works again) and little cost: it's hardly a new one.

yeah sure, this was not meant as a "blocking" comment. I think the change 
should go in, but leave the decision to Eike.

I btw. already started working on the improvement by proposing a new addition 
to the NETWM spec and implementing it in KWindowSystem.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126016/#review88236
---


On Nov. 10, 2015, 7:54 p.m., Johan Ouwerkerk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126016/
> ---
> 
> (Updated Nov. 10, 2015, 7:54 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Previously the taskmanager library contained a special case logic for windows 
> of KDE-4 KCM modules (only).
> These modules were recognised by finding wmClass=Kcmshell4.
> This logic is extended to cover kcmshell5 windows as well, meaning that KCMs 
> written for Plasma 5 are properly recognised now.
> The net benefit is that these KCMs are displayed in the task manager with 
> their proper KCM program icons.
> 
> This patch can be pulled from the kcmshell5-task-url-fixes branch at: 
> g...@github.com:cmacq2/plasma-workspace.git
> 
> 
> Diffs
> -
> 
>   libtaskmanager/taskitem.cpp 3b2a4188fc8ed087a331999aee279ecd919c628e 
> 
> Diff: https://git.reviewboard.kde.org/r/126016/diff/
> 
> 
> Testing
> ---
> 
> Built with kdesrc-build, and tested using: `plasmawindowed 
> org.kde.plasma.icontasks`.
> I checked the change works as expected by running `which kcmshell5` style as 
> well as `kcmshell5 style`: the icon of the window matches that in system 
> settings (as expected).
> 
> 
> Thanks,
> 
> Johan Ouwerkerk
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126016: fix: properly recognise Plasma 5 KCM modules (wmClass=kcmshell5)

[Eike Hein]

> On Nov. 11, 2015, 7:14 a.m., Martin Gräßlin wrote:
> > personal comment from X world: this is horrible, horrible ;-) What we 
> > should try is to make the desktop file available to the window. With KF 
> > 5.16 we will have all that's needed available. Let's try to improve this in 
> > Plasma 5.5 and scratch the code completely.

+1, I want to get rid of hacks, not pile on them


- Eike


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126016/#review88236
---


On Nov. 10, 2015, 6:54 p.m., Johan Ouwerkerk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126016/
> ---
> 
> (Updated Nov. 10, 2015, 6:54 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Previously the taskmanager library contained a special case logic for windows 
> of KDE-4 KCM modules (only).
> These modules were recognised by finding wmClass=Kcmshell4.
> This logic is extended to cover kcmshell5 windows as well, meaning that KCMs 
> written for Plasma 5 are properly recognised now.
> The net benefit is that these KCMs are displayed in the task manager with 
> their proper KCM program icons.
> 
> This patch can be pulled from the kcmshell5-task-url-fixes branch at: 
> g...@github.com:cmacq2/plasma-workspace.git
> 
> 
> Diffs
> -
> 
>   libtaskmanager/taskitem.cpp 3b2a4188fc8ed087a331999aee279ecd919c628e 
> 
> Diff: https://git.reviewboard.kde.org/r/126016/diff/
> 
> 
> Testing
> ---
> 
> Built with kdesrc-build, and tested using: `plasmawindowed 
> org.kde.plasma.icontasks`.
> I checked the change works as expected by running `which kcmshell5` style as 
> well as `kcmshell5 style`: the icon of the window matches that in system 
> settings (as expected).
> 
> 
> Thanks,
> 
> Johan Ouwerkerk
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126016: fix: properly recognise Plasma 5 KCM modules (wmClass=kcmshell5)

[Johan Ouwerkerk]

> On Nov. 11, 2015, 7:14 a.m., Martin Gräßlin wrote:
> > personal comment from X world: this is horrible, horrible ;-) What we 
> > should try is to make the desktop file available to the window. With KF 
> > 5.16 we will have all that's needed available. Let's try to improve this in 
> > Plasma 5.5 and scratch the code completely.
> 
> Eike Hein wrote:
> +1, I want to get rid of hacks, not pile on them

> With KF 5.16 we will have all that's needed available. Let's try to improve 
> this in Plasma 5.5 and scratch the code completely.

Great and I agree that the code is not great --all those wasted service lookups 
and subtly broken caching of the answer-- but: where is this alternative code 
that fixes everything? ;) Right now, I think this change amounts to a trivial 
fix (just one forgotten case in the if-clause) to an existing 
'feature'/workaround that has a fairly immediate benefit (something works 
again) and little cost: it's hardly a new one.


- Johan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126016/#review88236
---


On Nov. 10, 2015, 6:54 p.m., Johan Ouwerkerk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126016/
> ---
> 
> (Updated Nov. 10, 2015, 6:54 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Previously the taskmanager library contained a special case logic for windows 
> of KDE-4 KCM modules (only).
> These modules were recognised by finding wmClass=Kcmshell4.
> This logic is extended to cover kcmshell5 windows as well, meaning that KCMs 
> written for Plasma 5 are properly recognised now.
> The net benefit is that these KCMs are displayed in the task manager with 
> their proper KCM program icons.
> 
> This patch can be pulled from the kcmshell5-task-url-fixes branch at: 
> g...@github.com:cmacq2/plasma-workspace.git
> 
> 
> Diffs
> -
> 
>   libtaskmanager/taskitem.cpp 3b2a4188fc8ed087a331999aee279ecd919c628e 
> 
> Diff: https://git.reviewboard.kde.org/r/126016/diff/
> 
> 
> Testing
> ---
> 
> Built with kdesrc-build, and tested using: `plasmawindowed 
> org.kde.plasma.icontasks`.
> I checked the change works as expected by running `which kcmshell5` style as 
> well as `kcmshell5 style`: the icon of the window matches that in system 
> settings (as expected).
> 
> 
> Thanks,
> 
> Johan Ouwerkerk
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126016: fix: properly recognise Plasma 5 KCM modules (wmClass=kcmshell5)

[Johan Ouwerkerk]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126016/
---

(Updated Nov. 10, 2015, 6:54 p.m.)


Review request for Plasma.


Repository: plasma-workspace


Description
---

Previously the taskmanager library contained a special case logic for windows 
of KDE-4 KCM modules (only).
These modules were recognised by finding wmClass=Kcmshell4.
This logic is extended to cover kcmshell5 windows as well, meaning that KCMs 
written for Plasma 5 are properly recognised now.
The net benefit is that these KCMs are displayed in the task manager with their 
proper KCM program icons.

This patch can be pulled from the kcmshell5-task-url-fixes branch at: 
g...@github.com:cmacq2/plasma-workspace.git


Diffs
-

  libtaskmanager/taskitem.cpp 3b2a4188fc8ed087a331999aee279ecd919c628e 

Diff: https://git.reviewboard.kde.org/r/126016/diff/


Testing (updated)
---

Built with kdesrc-build, and tested using: `plasmawindowed 
org.kde.plasma.icontasks`.
I checked the change works as expected by running `which kcmshell5` style as 
well as `kcmshell5 style`: the icon of the window matches that in system 
settings (as expected).


Thanks,

Johan Ouwerkerk

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126016: fix: properly recognise Plasma 5 KCM modules (wmClass=kcmshell5)

[Johan Ouwerkerk]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126016/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

Previously the taskmanager library contained a special case logic for windows 
of KDE-4 KCM modules (only).
These modules were recognised by finding wmClass=Kcmshell4.
This logic is extended to cover kcmshell5 windows as well, meaning that KCMs 
written for Plasma 5 are properly recognised now.
The net benefit is that these KCMs are displayed in the task manager with their 
proper KCM program icons.

This patch can be pulled from the kcmshell5-task-url-fixes branch at: 
g...@github.com:cmacq2/plasma-workspace.git


Diffs
-

  libtaskmanager/taskitem.cpp 3b2a4188fc8ed087a331999aee279ecd919c628e 

Diff: https://git.reviewboard.kde.org/r/126016/diff/


Testing
---

Built with kdesrc-build, and tested using: `plasmawindowed 
org.kde.plasma.icontasks`.
I checked the change works as expected by running ``which kcmshell5` style` as 
well as `kcmshell5 style`: the icon of the window matches that in system 
settings (as expected).


Thanks,

Johan Ouwerkerk

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126016: fix: properly recognise Plasma 5 KCM modules (wmClass=kcmshell5)

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126016/#review88236
---


personal comment from X world: this is horrible, horrible ;-) What we should 
try is to make the desktop file available to the window. With KF 5.16 we will 
have all that's needed available. Let's try to improve this in Plasma 5.5 and 
scratch the code completely.


libtaskmanager/taskitem.cpp (line 627)
<https://git.reviewboard.kde.org/r/126016/#comment60505>

don't we have to change to kdeinit5 here?


- Martin Gräßlin


On Nov. 10, 2015, 7:54 p.m., Johan Ouwerkerk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126016/
> ---
> 
> (Updated Nov. 10, 2015, 7:54 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Previously the taskmanager library contained a special case logic for windows 
> of KDE-4 KCM modules (only).
> These modules were recognised by finding wmClass=Kcmshell4.
> This logic is extended to cover kcmshell5 windows as well, meaning that KCMs 
> written for Plasma 5 are properly recognised now.
> The net benefit is that these KCMs are displayed in the task manager with 
> their proper KCM program icons.
> 
> This patch can be pulled from the kcmshell5-task-url-fixes branch at: 
> g...@github.com:cmacq2/plasma-workspace.git
> 
> 
> Diffs
> -
> 
>   libtaskmanager/taskitem.cpp 3b2a4188fc8ed087a331999aee279ecd919c628e 
> 
> Diff: https://git.reviewboard.kde.org/r/126016/diff/
> 
> 
> Testing
> ---
> 
> Built with kdesrc-build, and tested using: `plasmawindowed 
> org.kde.plasma.icontasks`.
> I checked the change works as expected by running `which kcmshell5` style as 
> well as `kcmshell5 style`: the icon of the window matches that in system 
> settings (as expected).
> 
> 
> Thanks,
> 
> Johan Ouwerkerk
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125222: Plasma 5 Quicklaunch applet

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125222/
---

Review request for Plasma.


Repository: kdeplasma-addons


Description
---

This is a reimplementation of Quicklaunch applet in QML.

I have tried to make it as similar to the original applet as possible.

Missing features: 
 - popup drawer for launchers
 - option for automatically determining number of rows/cols (must be set 
manually)


Diffs
-

  applets/CMakeLists.txt 2e29bbe 
  applets/quicklaunch/CMakeLists.txt PRE-CREATION 
  applets/quicklaunch/Messages.sh PRE-CREATION 
  applets/quicklaunch/package/contents/code/layout.js PRE-CREATION 
  applets/quicklaunch/package/contents/config/config.qml PRE-CREATION 
  applets/quicklaunch/package/contents/config/main.xml PRE-CREATION 
  applets/quicklaunch/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
  applets/quicklaunch/package/contents/ui/IconItem.qml PRE-CREATION 
  applets/quicklaunch/package/contents/ui/main.qml PRE-CREATION 
  applets/quicklaunch/package/metadata.desktop PRE-CREATION 
  applets/quicklaunch/plugin/CMakeLists.txt PRE-CREATION 
  applets/quicklaunch/plugin/qmldir PRE-CREATION 
  applets/quicklaunch/plugin/quicklaunch_p.h PRE-CREATION 
  applets/quicklaunch/plugin/quicklaunch_p.cpp PRE-CREATION 
  applets/quicklaunch/plugin/quicklaunchplugin.h PRE-CREATION 
  applets/quicklaunch/plugin/quicklaunchplugin.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/125222/diff/


Testing
---


File Attachments


Empty applet
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/dfcae20f-6b05-458c-ae4f-62b1132faf04__empty.png
On desktop (2 rows)
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/18812a01-686a-4e6a-9442-0c9de5fc5ee4__desktop-2-rows.png
On desktop with names + dragging
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/89e9d9fc-170e-43e6-963f-7724c2967ba7__desktop-1row-drag.png
In vertical panel
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/5980b593-1209-43c0-b378-2b1ebdfe56d9__panel-vertical.png
Context menu
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/92b8f012-98ff-43e5-a808-7d9625dc85ae__context-menu.png


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125174: Plasma 5 Quicklaunch applet

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125174/
---

(Updated Sept. 14, 2015, 11:11 a.m.)


Status
--

This change has been discarded.


Review request for Plasma.


Repository: plasma-workspace


Description
---

This is a reimplementation of Quicklaunch applet in QML.

I have tried to make it as similar to the original applet as possible.

Missing features: 
 - popup drawer for launchers
 - option for automatically determining number of rows/cols (must be set 
manually)


For the review purposes, I have generated diff with code in "quicklaunch-qml" 
directory, but it should go to the original "quicklaunch" dir.


Diffs
-

  applets/CMakeLists.txt 40c2e05 
  applets/quicklaunch-qml/CMakeLists.txt PRE-CREATION 
  applets/quicklaunch-qml/Messages.sh PRE-CREATION 
  applets/quicklaunch-qml/package/contents/code/layout.js PRE-CREATION 
  applets/quicklaunch-qml/package/contents/config/config.qml PRE-CREATION 
  applets/quicklaunch-qml/package/contents/config/main.xml PRE-CREATION 
  applets/quicklaunch-qml/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
  applets/quicklaunch-qml/package/contents/ui/IconItem.qml PRE-CREATION 
  applets/quicklaunch-qml/package/contents/ui/main.qml PRE-CREATION 
  applets/quicklaunch-qml/package/metadata.desktop PRE-CREATION 
  applets/quicklaunch-qml/plugin/CMakeLists.txt PRE-CREATION 
  applets/quicklaunch-qml/plugin/qmldir PRE-CREATION 
  applets/quicklaunch-qml/plugin/quicklaunch_p.h PRE-CREATION 
  applets/quicklaunch-qml/plugin/quicklaunch_p.cpp PRE-CREATION 
  applets/quicklaunch-qml/plugin/quicklaunchplugin.h PRE-CREATION 
  applets/quicklaunch-qml/plugin/quicklaunchplugin.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/125174/diff/


Testing
---


File Attachments


Empty applet
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/555b9762-e399-42f2-9a85-380f55749132__empty.png
On desktop (2 rows)
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/2874569c-3a2e-44f7-a537-021046226789__desktop-2-rows.png
On desktop with names + dragging
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/1bce2c1f-91e8-4300-81fa-fd1334e8c281__desktop-1row-drag.png
In vertical panel
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/9f55dc04-1aae-4a5a-a70c-7158c527f0e7__panel-vertical.png
Context menu
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/7fe10753-5d23-4480-8701-4022dc162943__context-menu.png


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125222: Plasma 5 Quicklaunch applet

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125222/
---

(Updated Sept. 14, 2015, 3:54 p.m.)


Review request for Plasma.


Changes
---

Force the launcher items to be square + move Model logic to UrlModel.qml


Repository: kdeplasma-addons


Description
---

This is a reimplementation of Quicklaunch applet in QML.

I have tried to make it as similar to the original applet as possible.

Missing features: 
 - popup drawer for launchers
 - option for automatically determining number of rows/cols (must be set 
manually)


Diffs (updated)
-

  applets/CMakeLists.txt 2e29bbe 
  applets/quicklaunch/CMakeLists.txt PRE-CREATION 
  applets/quicklaunch/Messages.sh PRE-CREATION 
  applets/quicklaunch/package/contents/code/layout.js PRE-CREATION 
  applets/quicklaunch/package/contents/config/config.qml PRE-CREATION 
  applets/quicklaunch/package/contents/config/main.xml PRE-CREATION 
  applets/quicklaunch/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
  applets/quicklaunch/package/contents/ui/IconItem.qml PRE-CREATION 
  applets/quicklaunch/package/contents/ui/UrlModel.qml PRE-CREATION 
  applets/quicklaunch/package/contents/ui/main.qml PRE-CREATION 
  applets/quicklaunch/package/metadata.desktop PRE-CREATION 
  applets/quicklaunch/plugin/CMakeLists.txt PRE-CREATION 
  applets/quicklaunch/plugin/qmldir PRE-CREATION 
  applets/quicklaunch/plugin/quicklaunch_p.h PRE-CREATION 
  applets/quicklaunch/plugin/quicklaunch_p.cpp PRE-CREATION 
  applets/quicklaunch/plugin/quicklaunchplugin.h PRE-CREATION 
  applets/quicklaunch/plugin/quicklaunchplugin.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/125222/diff/


Testing
---


File Attachments


Empty applet
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/dfcae20f-6b05-458c-ae4f-62b1132faf04__empty.png
On desktop (2 rows)
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/18812a01-686a-4e6a-9442-0c9de5fc5ee4__desktop-2-rows.png
On desktop with names + dragging
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/89e9d9fc-170e-43e6-963f-7724c2967ba7__desktop-1row-drag.png
In vertical panel
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/5980b593-1209-43c0-b378-2b1ebdfe56d9__panel-vertical.png
Context menu
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/92b8f012-98ff-43e5-a808-7d9625dc85ae__context-menu.png


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125222: Plasma 5 Quicklaunch applet

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125222/#review85380
---



applets/quicklaunch/package/contents/code/layout.js (line 39)


can you verify that if grid.count changes dinamically, this cols() gets 
re-evaluated immediately?


- Marco Martin


On Sept. 14, 2015, 3:54 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125222/
> ---
> 
> (Updated Sept. 14, 2015, 3:54 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> This is a reimplementation of Quicklaunch applet in QML.
> 
> I have tried to make it as similar to the original applet as possible.
> 
> Missing features: 
>  - popup drawer for launchers
>  - option for automatically determining number of rows/cols (must be set 
> manually)
> 
> 
> Diffs
> -
> 
>   applets/CMakeLists.txt 2e29bbe 
>   applets/quicklaunch/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch/Messages.sh PRE-CREATION 
>   applets/quicklaunch/package/contents/code/layout.js PRE-CREATION 
>   applets/quicklaunch/package/contents/config/config.qml PRE-CREATION 
>   applets/quicklaunch/package/contents/config/main.xml PRE-CREATION 
>   applets/quicklaunch/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
>   applets/quicklaunch/package/contents/ui/IconItem.qml PRE-CREATION 
>   applets/quicklaunch/package/contents/ui/UrlModel.qml PRE-CREATION 
>   applets/quicklaunch/package/contents/ui/main.qml PRE-CREATION 
>   applets/quicklaunch/package/metadata.desktop PRE-CREATION 
>   applets/quicklaunch/plugin/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch/plugin/qmldir PRE-CREATION 
>   applets/quicklaunch/plugin/quicklaunch_p.h PRE-CREATION 
>   applets/quicklaunch/plugin/quicklaunch_p.cpp PRE-CREATION 
>   applets/quicklaunch/plugin/quicklaunchplugin.h PRE-CREATION 
>   applets/quicklaunch/plugin/quicklaunchplugin.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125222/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Empty applet
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/dfcae20f-6b05-458c-ae4f-62b1132faf04__empty.png
> On desktop (2 rows)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/18812a01-686a-4e6a-9442-0c9de5fc5ee4__desktop-2-rows.png
> On desktop with names + dragging
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/89e9d9fc-170e-43e6-963f-7724c2967ba7__desktop-1row-drag.png
> In vertical panel
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/5980b593-1209-43c0-b378-2b1ebdfe56d9__panel-vertical.png
> Context menu
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/92b8f012-98ff-43e5-a808-7d9625dc85ae__context-menu.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125222: Plasma 5 Quicklaunch applet

[David Rosca]

> On Sept. 14, 2015, 4:09 p.m., Marco Martin wrote:
> > applets/quicklaunch/package/contents/code/layout.js, line 39
> > 
> >
> > can you verify that if grid.count changes dinamically, this cols() gets 
> > re-evaluated immediately?

I'm not really sure how to test it, but I added debug output and got this right 
after adding item to model:

```
(qml) appendUrl: adding item to model
(qml) appendUrl: added item to model
(qml) onCountChanged: grid count changed
(qml) cols: cols called
(qml) cols: cols called
(qml) cols: cols called
(qml) cols: cols called
```


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125222/#review85380
---


On Sept. 14, 2015, 3:54 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125222/
> ---
> 
> (Updated Sept. 14, 2015, 3:54 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> This is a reimplementation of Quicklaunch applet in QML.
> 
> I have tried to make it as similar to the original applet as possible.
> 
> Missing features: 
>  - popup drawer for launchers
>  - option for automatically determining number of rows/cols (must be set 
> manually)
> 
> 
> Diffs
> -
> 
>   applets/CMakeLists.txt 2e29bbe 
>   applets/quicklaunch/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch/Messages.sh PRE-CREATION 
>   applets/quicklaunch/package/contents/code/layout.js PRE-CREATION 
>   applets/quicklaunch/package/contents/config/config.qml PRE-CREATION 
>   applets/quicklaunch/package/contents/config/main.xml PRE-CREATION 
>   applets/quicklaunch/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
>   applets/quicklaunch/package/contents/ui/IconItem.qml PRE-CREATION 
>   applets/quicklaunch/package/contents/ui/UrlModel.qml PRE-CREATION 
>   applets/quicklaunch/package/contents/ui/main.qml PRE-CREATION 
>   applets/quicklaunch/package/metadata.desktop PRE-CREATION 
>   applets/quicklaunch/plugin/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch/plugin/qmldir PRE-CREATION 
>   applets/quicklaunch/plugin/quicklaunch_p.h PRE-CREATION 
>   applets/quicklaunch/plugin/quicklaunch_p.cpp PRE-CREATION 
>   applets/quicklaunch/plugin/quicklaunchplugin.h PRE-CREATION 
>   applets/quicklaunch/plugin/quicklaunchplugin.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125222/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Empty applet
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/dfcae20f-6b05-458c-ae4f-62b1132faf04__empty.png
> On desktop (2 rows)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/18812a01-686a-4e6a-9442-0c9de5fc5ee4__desktop-2-rows.png
> On desktop with names + dragging
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/89e9d9fc-170e-43e6-963f-7724c2967ba7__desktop-1row-drag.png
> In vertical panel
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/5980b593-1209-43c0-b378-2b1ebdfe56d9__panel-vertical.png
> Context menu
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/92b8f012-98ff-43e5-a808-7d9625dc85ae__context-menu.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125222: Plasma 5 Quicklaunch applet

[Marco Martin]

> On Sept. 14, 2015, 4:09 p.m., Marco Martin wrote:
> > applets/quicklaunch/package/contents/code/layout.js, line 39
> > 
> >
> > can you verify that if grid.count changes dinamically, this cols() gets 
> > re-evaluated immediately?
> 
> David Rosca wrote:
> I'm not really sure how to test it, but I added debug output and got this 
> right after adding item to model:
> 
> ```
> (qml) appendUrl: adding item to model
> (qml) appendUrl: added item to model
> (qml) onCountChanged: grid count changed
> (qml) cols: cols called
> (qml) cols: cols called
> (qml) cols: cols called
> (qml) cols: cols called
> ```

yep, it works :)


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125222/#review85380
---


On Sept. 14, 2015, 3:54 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125222/
> ---
> 
> (Updated Sept. 14, 2015, 3:54 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> This is a reimplementation of Quicklaunch applet in QML.
> 
> I have tried to make it as similar to the original applet as possible.
> 
> Missing features: 
>  - popup drawer for launchers
>  - option for automatically determining number of rows/cols (must be set 
> manually)
> 
> 
> Diffs
> -
> 
>   applets/CMakeLists.txt 2e29bbe 
>   applets/quicklaunch/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch/Messages.sh PRE-CREATION 
>   applets/quicklaunch/package/contents/code/layout.js PRE-CREATION 
>   applets/quicklaunch/package/contents/config/config.qml PRE-CREATION 
>   applets/quicklaunch/package/contents/config/main.xml PRE-CREATION 
>   applets/quicklaunch/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
>   applets/quicklaunch/package/contents/ui/IconItem.qml PRE-CREATION 
>   applets/quicklaunch/package/contents/ui/UrlModel.qml PRE-CREATION 
>   applets/quicklaunch/package/contents/ui/main.qml PRE-CREATION 
>   applets/quicklaunch/package/metadata.desktop PRE-CREATION 
>   applets/quicklaunch/plugin/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch/plugin/qmldir PRE-CREATION 
>   applets/quicklaunch/plugin/quicklaunch_p.h PRE-CREATION 
>   applets/quicklaunch/plugin/quicklaunch_p.cpp PRE-CREATION 
>   applets/quicklaunch/plugin/quicklaunchplugin.h PRE-CREATION 
>   applets/quicklaunch/plugin/quicklaunchplugin.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125222/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Empty applet
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/dfcae20f-6b05-458c-ae4f-62b1132faf04__empty.png
> On desktop (2 rows)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/18812a01-686a-4e6a-9442-0c9de5fc5ee4__desktop-2-rows.png
> On desktop with names + dragging
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/89e9d9fc-170e-43e6-963f-7724c2967ba7__desktop-1row-drag.png
> In vertical panel
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/5980b593-1209-43c0-b378-2b1ebdfe56d9__panel-vertical.png
> Context menu
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/92b8f012-98ff-43e5-a808-7d9625dc85ae__context-menu.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125222: Plasma 5 Quicklaunch applet

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125222/#review85391
---

Ship it!


Ship It!

- Marco Martin


On Sept. 14, 2015, 3:54 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125222/
> ---
> 
> (Updated Sept. 14, 2015, 3:54 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> This is a reimplementation of Quicklaunch applet in QML.
> 
> I have tried to make it as similar to the original applet as possible.
> 
> Missing features: 
>  - popup drawer for launchers
>  - option for automatically determining number of rows/cols (must be set 
> manually)
> 
> 
> Diffs
> -
> 
>   applets/CMakeLists.txt 2e29bbe 
>   applets/quicklaunch/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch/Messages.sh PRE-CREATION 
>   applets/quicklaunch/package/contents/code/layout.js PRE-CREATION 
>   applets/quicklaunch/package/contents/config/config.qml PRE-CREATION 
>   applets/quicklaunch/package/contents/config/main.xml PRE-CREATION 
>   applets/quicklaunch/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
>   applets/quicklaunch/package/contents/ui/IconItem.qml PRE-CREATION 
>   applets/quicklaunch/package/contents/ui/UrlModel.qml PRE-CREATION 
>   applets/quicklaunch/package/contents/ui/main.qml PRE-CREATION 
>   applets/quicklaunch/package/metadata.desktop PRE-CREATION 
>   applets/quicklaunch/plugin/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch/plugin/qmldir PRE-CREATION 
>   applets/quicklaunch/plugin/quicklaunch_p.h PRE-CREATION 
>   applets/quicklaunch/plugin/quicklaunch_p.cpp PRE-CREATION 
>   applets/quicklaunch/plugin/quicklaunchplugin.h PRE-CREATION 
>   applets/quicklaunch/plugin/quicklaunchplugin.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125222/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Empty applet
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/dfcae20f-6b05-458c-ae4f-62b1132faf04__empty.png
> On desktop (2 rows)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/18812a01-686a-4e6a-9442-0c9de5fc5ee4__desktop-2-rows.png
> On desktop with names + dragging
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/89e9d9fc-170e-43e6-963f-7724c2967ba7__desktop-1row-drag.png
> In vertical panel
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/5980b593-1209-43c0-b378-2b1ebdfe56d9__panel-vertical.png
> Context menu
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/92b8f012-98ff-43e5-a808-7d9625dc85ae__context-menu.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125222: Plasma 5 Quicklaunch applet

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125222/
---

(Updated Sept. 14, 2015, 5:48 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 8cad97ac615b9875a0b65f4b9c797074f65eaf70 by David Rosca 
to branch master.


Repository: kdeplasma-addons


Description
---

This is a reimplementation of Quicklaunch applet in QML.

I have tried to make it as similar to the original applet as possible.

Missing features: 
 - popup drawer for launchers
 - option for automatically determining number of rows/cols (must be set 
manually)


Diffs
-

  applets/CMakeLists.txt 2e29bbe 
  applets/quicklaunch/CMakeLists.txt PRE-CREATION 
  applets/quicklaunch/Messages.sh PRE-CREATION 
  applets/quicklaunch/package/contents/code/layout.js PRE-CREATION 
  applets/quicklaunch/package/contents/config/config.qml PRE-CREATION 
  applets/quicklaunch/package/contents/config/main.xml PRE-CREATION 
  applets/quicklaunch/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
  applets/quicklaunch/package/contents/ui/IconItem.qml PRE-CREATION 
  applets/quicklaunch/package/contents/ui/UrlModel.qml PRE-CREATION 
  applets/quicklaunch/package/contents/ui/main.qml PRE-CREATION 
  applets/quicklaunch/package/metadata.desktop PRE-CREATION 
  applets/quicklaunch/plugin/CMakeLists.txt PRE-CREATION 
  applets/quicklaunch/plugin/qmldir PRE-CREATION 
  applets/quicklaunch/plugin/quicklaunch_p.h PRE-CREATION 
  applets/quicklaunch/plugin/quicklaunch_p.cpp PRE-CREATION 
  applets/quicklaunch/plugin/quicklaunchplugin.h PRE-CREATION 
  applets/quicklaunch/plugin/quicklaunchplugin.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/125222/diff/


Testing
---


File Attachments


Empty applet
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/dfcae20f-6b05-458c-ae4f-62b1132faf04__empty.png
On desktop (2 rows)
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/18812a01-686a-4e6a-9442-0c9de5fc5ee4__desktop-2-rows.png
On desktop with names + dragging
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/89e9d9fc-170e-43e6-963f-7724c2967ba7__desktop-1row-drag.png
In vertical panel
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/5980b593-1209-43c0-b378-2b1ebdfe56d9__panel-vertical.png
Context menu
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/14/92b8f012-98ff-43e5-a808-7d9625dc85ae__context-menu.png


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125174: Plasma 5 Quicklaunch applet

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125174/#review85351
---


Provided this gets maintained, I'm in favor of this (perhaps in 
kdeplasma-addons instead of a main workspace feature).
Since the behavior of a pure launcher is quite different from both a taskbar 
entry or a dock icon, so some people may prefer that behavior instead (I kindof 
do :p).

- Marco Martin


On Sept. 11, 2015, 7:48 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125174/
> ---
> 
> (Updated Sept. 11, 2015, 7:48 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This is a reimplementation of Quicklaunch applet in QML.
> 
> I have tried to make it as similar to the original applet as possible.
> 
> Missing features: 
>  - popup drawer for launchers
>  - option for automatically determining number of rows/cols (must be set 
> manually)
> 
> 
> For the review purposes, I have generated diff with code in "quicklaunch-qml" 
> directory, but it should go to the original "quicklaunch" dir.
> 
> 
> Diffs
> -
> 
>   applets/CMakeLists.txt 40c2e05 
>   applets/quicklaunch-qml/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch-qml/Messages.sh PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/code/layout.js PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/config/config.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/config/main.xml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/IconItem.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/main.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/metadata.desktop PRE-CREATION 
>   applets/quicklaunch-qml/plugin/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch-qml/plugin/qmldir PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunch_p.h PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunch_p.cpp PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunchplugin.h PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunchplugin.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125174/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Empty applet
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/555b9762-e399-42f2-9a85-380f55749132__empty.png
> On desktop (2 rows)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/2874569c-3a2e-44f7-a537-021046226789__desktop-2-rows.png
> On desktop with names + dragging
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/1bce2c1f-91e8-4300-81fa-fd1334e8c281__desktop-1row-drag.png
> In vertical panel
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/9f55dc04-1aae-4a5a-a70c-7158c527f0e7__panel-vertical.png
> Context menu
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/7fe10753-5d23-4480-8701-4022dc162943__context-menu.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125174: Plasma 5 Quicklaunch applet

[David Rosca]

> On Sept. 14, 2015, 8:24 a.m., Marco Martin wrote:
> > Provided this gets maintained, I'm in favor of this (perhaps in 
> > kdeplasma-addons instead of a main workspace feature).
> > Since the behavior of a pure launcher is quite different from both a 
> > taskbar entry or a dock icon, so some people may prefer that behavior 
> > instead (I kindof do :p).

Sure, having this in kdeplasma-addons is fine. I made this review against 
plasma-workspace because it originally was there (and still is, not buildable).
I'm willing to maintain it, so should I open a new RR against kdeplasma-addons?


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125174/#review85351
---


On Sept. 11, 2015, 7:48 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125174/
> ---
> 
> (Updated Sept. 11, 2015, 7:48 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This is a reimplementation of Quicklaunch applet in QML.
> 
> I have tried to make it as similar to the original applet as possible.
> 
> Missing features: 
>  - popup drawer for launchers
>  - option for automatically determining number of rows/cols (must be set 
> manually)
> 
> 
> For the review purposes, I have generated diff with code in "quicklaunch-qml" 
> directory, but it should go to the original "quicklaunch" dir.
> 
> 
> Diffs
> -
> 
>   applets/CMakeLists.txt 40c2e05 
>   applets/quicklaunch-qml/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch-qml/Messages.sh PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/code/layout.js PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/config/config.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/config/main.xml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/IconItem.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/main.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/metadata.desktop PRE-CREATION 
>   applets/quicklaunch-qml/plugin/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch-qml/plugin/qmldir PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunch_p.h PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunch_p.cpp PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunchplugin.h PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunchplugin.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125174/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Empty applet
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/555b9762-e399-42f2-9a85-380f55749132__empty.png
> On desktop (2 rows)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/2874569c-3a2e-44f7-a537-021046226789__desktop-2-rows.png
> On desktop with names + dragging
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/1bce2c1f-91e8-4300-81fa-fd1334e8c281__desktop-1row-drag.png
> In vertical panel
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/9f55dc04-1aae-4a5a-a70c-7158c527f0e7__panel-vertical.png
> Context menu
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/7fe10753-5d23-4480-8701-4022dc162943__context-menu.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125174: Plasma 5 Quicklaunch applet

[Marco Martin]

> On Sept. 14, 2015, 8:24 a.m., Marco Martin wrote:
> > Provided this gets maintained, I'm in favor of this (perhaps in 
> > kdeplasma-addons instead of a main workspace feature).
> > Since the behavior of a pure launcher is quite different from both a 
> > taskbar entry or a dock icon, so some people may prefer that behavior 
> > instead (I kindof do :p).
> 
> David Rosca wrote:
> Sure, having this in kdeplasma-addons is fine. I made this review against 
> plasma-workspace because it originally was there (and still is, not 
> buildable).
> I'm willing to maintain it, so should I open a new RR against 
> kdeplasma-addons?

yep, that would be great :)


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125174/#review85351
---


On Sept. 11, 2015, 7:48 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125174/
> ---
> 
> (Updated Sept. 11, 2015, 7:48 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This is a reimplementation of Quicklaunch applet in QML.
> 
> I have tried to make it as similar to the original applet as possible.
> 
> Missing features: 
>  - popup drawer for launchers
>  - option for automatically determining number of rows/cols (must be set 
> manually)
> 
> 
> For the review purposes, I have generated diff with code in "quicklaunch-qml" 
> directory, but it should go to the original "quicklaunch" dir.
> 
> 
> Diffs
> -
> 
>   applets/CMakeLists.txt 40c2e05 
>   applets/quicklaunch-qml/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch-qml/Messages.sh PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/code/layout.js PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/config/config.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/config/main.xml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/IconItem.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/main.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/metadata.desktop PRE-CREATION 
>   applets/quicklaunch-qml/plugin/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch-qml/plugin/qmldir PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunch_p.h PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunch_p.cpp PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunchplugin.h PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunchplugin.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125174/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Empty applet
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/555b9762-e399-42f2-9a85-380f55749132__empty.png
> On desktop (2 rows)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/2874569c-3a2e-44f7-a537-021046226789__desktop-2-rows.png
> On desktop with names + dragging
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/1bce2c1f-91e8-4300-81fa-fd1334e8c281__desktop-1row-drag.png
> In vertical panel
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/9f55dc04-1aae-4a5a-a70c-7158c527f0e7__panel-vertical.png
> Context menu
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/7fe10753-5d23-4480-8701-4022dc162943__context-menu.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125174: Plasma 5 Quicklaunch applet

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125174/#review85360
---



applets/quicklaunch-qml/package/contents/code/layout.js (line 23)


I guess the spacing here is half because it's used as margins for the items 
instead, so ends up being half+half..
Maybe should be called itemPadding()?

second, those being functions buried in a js file won't be updated in case 
one of the properties chnge..
should they be in  qml file exposed as properties instead?


- Marco Martin


On Sept. 11, 2015, 7:48 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125174/
> ---
> 
> (Updated Sept. 11, 2015, 7:48 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This is a reimplementation of Quicklaunch applet in QML.
> 
> I have tried to make it as similar to the original applet as possible.
> 
> Missing features: 
>  - popup drawer for launchers
>  - option for automatically determining number of rows/cols (must be set 
> manually)
> 
> 
> For the review purposes, I have generated diff with code in "quicklaunch-qml" 
> directory, but it should go to the original "quicklaunch" dir.
> 
> 
> Diffs
> -
> 
>   applets/CMakeLists.txt 40c2e05 
>   applets/quicklaunch-qml/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch-qml/Messages.sh PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/code/layout.js PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/config/config.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/config/main.xml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/IconItem.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/main.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/metadata.desktop PRE-CREATION 
>   applets/quicklaunch-qml/plugin/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch-qml/plugin/qmldir PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunch_p.h PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunch_p.cpp PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunchplugin.h PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunchplugin.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125174/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Empty applet
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/555b9762-e399-42f2-9a85-380f55749132__empty.png
> On desktop (2 rows)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/2874569c-3a2e-44f7-a537-021046226789__desktop-2-rows.png
> On desktop with names + dragging
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/1bce2c1f-91e8-4300-81fa-fd1334e8c281__desktop-1row-drag.png
> In vertical panel
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/9f55dc04-1aae-4a5a-a70c-7158c527f0e7__panel-vertical.png
> Context menu
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/7fe10753-5d23-4480-8701-4022dc162943__context-menu.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125174: Plasma 5 Quicklaunch applet

[David Rosca]

> On Sept. 14, 2015, 9:35 a.m., Marco Martin wrote:
> > applets/quicklaunch-qml/package/contents/code/layout.js, line 23
> > 
> >
> > I guess the spacing here is half because it's used as margins for the 
> > items instead, so ends up being half+half..
> > Maybe should be called itemPadding()?
> > 
> > second, those being functions buried in a js file won't be updated in 
> > case one of the properties chnge..
> > should they be in  qml file exposed as properties instead?

The code seems to work fine though, it correctly resize the launchers when size 
of applet is changed.

I'll rename the spacing() function.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125174/#review85360
---


On Sept. 11, 2015, 7:48 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125174/
> ---
> 
> (Updated Sept. 11, 2015, 7:48 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This is a reimplementation of Quicklaunch applet in QML.
> 
> I have tried to make it as similar to the original applet as possible.
> 
> Missing features: 
>  - popup drawer for launchers
>  - option for automatically determining number of rows/cols (must be set 
> manually)
> 
> 
> For the review purposes, I have generated diff with code in "quicklaunch-qml" 
> directory, but it should go to the original "quicklaunch" dir.
> 
> 
> Diffs
> -
> 
>   applets/CMakeLists.txt 40c2e05 
>   applets/quicklaunch-qml/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch-qml/Messages.sh PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/code/layout.js PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/config/config.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/config/main.xml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/IconItem.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/main.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/metadata.desktop PRE-CREATION 
>   applets/quicklaunch-qml/plugin/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch-qml/plugin/qmldir PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunch_p.h PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunch_p.cpp PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunchplugin.h PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunchplugin.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125174/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Empty applet
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/555b9762-e399-42f2-9a85-380f55749132__empty.png
> On desktop (2 rows)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/2874569c-3a2e-44f7-a537-021046226789__desktop-2-rows.png
> On desktop with names + dragging
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/1bce2c1f-91e8-4300-81fa-fd1334e8c281__desktop-1row-drag.png
> In vertical panel
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/9f55dc04-1aae-4a5a-a70c-7158c527f0e7__panel-vertical.png
> Context menu
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/7fe10753-5d23-4480-8701-4022dc162943__context-menu.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125174: Plasma 5 Quicklaunch applet

[David Rosca]

> On Sept. 12, 2015, 12:42 a.m., Martin Klapetek wrote:
> > Is there any disadvantage to using Icon-only task manager and adding 
> > launchers in there? It seems like this applet would do exactly the same 
> > minus the task switching, so perhaps some portions of the code could be 
> > shared?

You can't force number of rows/columns in icon-only task manager. Icon-only 
task manager is auto-expanding, so it will only use another row/column when 
there is not enough space. 

Also, it is a task manager and not a launcher. This is more like an Icon 
applet, but with more options.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125174/#review85224
---


On Sept. 11, 2015, 7:48 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125174/
> ---
> 
> (Updated Sept. 11, 2015, 7:48 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This is a reimplementation of Quicklaunch applet in QML.
> 
> I have tried to make it as similar to the original applet as possible.
> 
> Missing features: 
>  - popup drawer for launchers
>  - option for automatically determining number of rows/cols (must be set 
> manually)
> 
> 
> For the review purposes, I have generated diff with code in "quicklaunch-qml" 
> directory, but it should go to the original "quicklaunch" dir.
> 
> 
> Diffs
> -
> 
>   applets/CMakeLists.txt 40c2e05 
>   applets/quicklaunch-qml/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch-qml/Messages.sh PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/code/layout.js PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/config/config.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/config/main.xml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/IconItem.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/main.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/metadata.desktop PRE-CREATION 
>   applets/quicklaunch-qml/plugin/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch-qml/plugin/qmldir PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunch_p.h PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunch_p.cpp PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunchplugin.h PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunchplugin.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125174/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Empty applet
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/555b9762-e399-42f2-9a85-380f55749132__empty.png
> On desktop (2 rows)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/2874569c-3a2e-44f7-a537-021046226789__desktop-2-rows.png
> On desktop with names + dragging
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/1bce2c1f-91e8-4300-81fa-fd1334e8c281__desktop-1row-drag.png
> In vertical panel
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/9f55dc04-1aae-4a5a-a70c-7158c527f0e7__panel-vertical.png
> Context menu
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/7fe10753-5d23-4480-8701-4022dc162943__context-menu.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125174: Plasma 5 Quicklaunch applet

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125174/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

This is a reimplementation of Quicklaunch applet in QML.

I have tried to make it as similar to the original applet as possible.

Missing features: 
 - popup drawer for launchers
 - option for automatically determining number of rows/cols (must be set 
manually)


For the review purposes, I have generated diff with code in "quicklaunch-qml" 
directory, but it should go to the original "quicklaunch" dir.


Diffs
-

  applets/CMakeLists.txt 40c2e05 
  applets/quicklaunch-qml/CMakeLists.txt PRE-CREATION 
  applets/quicklaunch-qml/Messages.sh PRE-CREATION 
  applets/quicklaunch-qml/package/contents/code/layout.js PRE-CREATION 
  applets/quicklaunch-qml/package/contents/config/config.qml PRE-CREATION 
  applets/quicklaunch-qml/package/contents/config/main.xml PRE-CREATION 
  applets/quicklaunch-qml/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
  applets/quicklaunch-qml/package/contents/ui/IconItem.qml PRE-CREATION 
  applets/quicklaunch-qml/package/contents/ui/main.qml PRE-CREATION 
  applets/quicklaunch-qml/package/metadata.desktop PRE-CREATION 
  applets/quicklaunch-qml/plugin/CMakeLists.txt PRE-CREATION 
  applets/quicklaunch-qml/plugin/qmldir PRE-CREATION 
  applets/quicklaunch-qml/plugin/quicklaunch_p.h PRE-CREATION 
  applets/quicklaunch-qml/plugin/quicklaunch_p.cpp PRE-CREATION 
  applets/quicklaunch-qml/plugin/quicklaunchplugin.h PRE-CREATION 
  applets/quicklaunch-qml/plugin/quicklaunchplugin.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/125174/diff/


Testing
---


File Attachments


Empty applet
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/555b9762-e399-42f2-9a85-380f55749132__empty.png
On desktop (2 rows)
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/2874569c-3a2e-44f7-a537-021046226789__desktop-2-rows.png
On desktop with names + dragging
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/1bce2c1f-91e8-4300-81fa-fd1334e8c281__desktop-1row-drag.png
In vertical panel
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/9f55dc04-1aae-4a5a-a70c-7158c527f0e7__panel-vertical.png
Context menu
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/7fe10753-5d23-4480-8701-4022dc162943__context-menu.png


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125174: Plasma 5 Quicklaunch applet

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125174/#review85224
---


Is there any disadvantage to using Icon-only task manager and adding launchers 
in there? It seems like this applet would do exactly the same minus the task 
switching, so perhaps some portions of the code could be shared?

- Martin Klapetek


On Sept. 11, 2015, 9:48 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125174/
> ---
> 
> (Updated Sept. 11, 2015, 9:48 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This is a reimplementation of Quicklaunch applet in QML.
> 
> I have tried to make it as similar to the original applet as possible.
> 
> Missing features: 
>  - popup drawer for launchers
>  - option for automatically determining number of rows/cols (must be set 
> manually)
> 
> 
> For the review purposes, I have generated diff with code in "quicklaunch-qml" 
> directory, but it should go to the original "quicklaunch" dir.
> 
> 
> Diffs
> -
> 
>   applets/CMakeLists.txt 40c2e05 
>   applets/quicklaunch-qml/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch-qml/Messages.sh PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/code/layout.js PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/config/config.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/config/main.xml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/IconItem.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/main.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/metadata.desktop PRE-CREATION 
>   applets/quicklaunch-qml/plugin/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch-qml/plugin/qmldir PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunch_p.h PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunch_p.cpp PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunchplugin.h PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunchplugin.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125174/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Empty applet
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/555b9762-e399-42f2-9a85-380f55749132__empty.png
> On desktop (2 rows)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/2874569c-3a2e-44f7-a537-021046226789__desktop-2-rows.png
> On desktop with names + dragging
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/1bce2c1f-91e8-4300-81fa-fd1334e8c281__desktop-1row-drag.png
> In vertical panel
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/9f55dc04-1aae-4a5a-a70c-7158c527f0e7__panel-vertical.png
> Context menu
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/7fe10753-5d23-4480-8701-4022dc162943__context-menu.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124923: Plasma 5 color picker plasmoid

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124923/
---

(Updated Sept. 9, 2015, 8:21 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and KDE Usability.


Changes
---

Submitted with commit 6e663a9e85cf8017fc20e0c749e5a2d939cef98c by Kai Uwe 
Broulik to branch master.


Repository: kdeplasma-addons


Description
---

This is a rewrite of the old kolourpicker plasmoid, albeit a bit prettier.

Clicking the "drop" (it's color-picker, I would expect a pipette icon) enters 
picker mode, where you can click anywhere on the screen and have the color code 
(in a format you can configure) copied to your clipboard.
Clicking the color blob opens the history, showing the recentmost 9 colors (so 
it's a nice grid) which allow copying their respective color codes in various 
formats.
Activating the plasmoid (pressing the configured shortcut) will by default 
enter color picking mode, alternatively it brings up the popup like any other 
plasmoid.


Diffs
-

  applets/CMakeLists.txt c60c350 
  applets/colorpicker/CMakeLists.txt PRE-CREATION 
  applets/colorpicker/Messages.sh PRE-CREATION 
  applets/colorpicker/package/contents/code/logic.js PRE-CREATION 
  applets/colorpicker/package/contents/config/config.qml PRE-CREATION 
  applets/colorpicker/package/contents/config/main.xml PRE-CREATION 
  applets/colorpicker/package/contents/ui/configGeneral.qml PRE-CREATION 
  applets/colorpicker/package/contents/ui/main.qml PRE-CREATION 
  applets/colorpicker/package/metadata.desktop PRE-CREATION 
  applets/colorpicker/plugin/colorpickerplugin.h PRE-CREATION 
  applets/colorpicker/plugin/colorpickerplugin.cpp PRE-CREATION 
  applets/colorpicker/plugin/grabwidget.h PRE-CREATION 
  applets/colorpicker/plugin/grabwidget.cpp PRE-CREATION 
  applets/colorpicker/plugin/qmldir PRE-CREATION 
  applets/kolourpicker/CMakeLists.txt 522e0de 
  applets/kolourpicker/Messages.sh 072def0 
  applets/kolourpicker/config-kolourpicker.h.cmake 6cb43cc 
  applets/kolourpicker/kolourpicker.h bde3ff7 
  applets/kolourpicker/kolourpicker.cpp a4b0ea4 
  applets/kolourpicker/plasma-kolourpicker-default.desktop 4334ba1 

Diff: https://git.reviewboard.kde.org/r/124923/diff/


Testing
---

- I have the impression that the color picker is off by one pixel horizontally 
(QRect weirdness? or our Breeze crosshair cursor?)
- I didn't test with multiple screens


File Attachments


In a panel
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/62f4f2df-c435-4676-a4c2-c359d89eaa7d__colorpickerpanel.png
On the desktop
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/26b97307-2b19-4951-8b0c-fe26f960246b__colorpickerdesktop.png
History
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/b9ecab53-8f40-49df-92da-f0e8479bd9a6__colorpickerhistory.png
Formats menu
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/ab4720c0-e25c-486a-9f5a-3dbef5a25fa6__colorpickermenu.png
Settings
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/f051b3e9-28c3-4456-ae7a-9dad748519a9__colorpickersettings.png


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124923: Plasma 5 color picker plasmoid

[Thomas Pfeiffer]

> On Aug. 25, 2015, 9:22 p.m., Thomas Pfeiffer wrote:
> > Great work!
> > Two points:
> > 1. The two icons in the Plasmoid look like they're two separate Plasmoids, 
> > which is confusing. They should be more visually connected (we're still 
> > brainstorming ideas for how to do this in the VDG)
> > 2. Latex color doesn't have anything to do with fetish, but it's the color 
> > code that LaTeX uses (see 
> > https://en.wikibooks.org/wiki/LaTeX/Colors#Color_Models ). I don't know how 
> > many LaTeX users actually need this, but it might be premature to just 
> > remove it.
> 
> Kai Uwe Broulik wrote:
> 2.) I already got complaints about this on IRC, so I'll bring it back :D
> 
> Marco Martin wrote:
> I don't think it's an issue that it looks like two separate plasmoids: 
> those are two semi independent functions that if they happen to belong to the 
> same plasmoid or not is no concern to the user
> 
> Thomas Pfeiffer wrote:
> They are only _semi_-independent: They perform two different functions 
> when clicked, but the history button has absolutely no use without the color 
> picking button. Therefore, they still clearly belong together.

One suggestion to show that the two icons belong to the same function is to put 
a vertical bar between them like the digital clock in a low-height panel, 
instead of whitespace.


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124923/#review84368
---


On Aug. 26, 2015, 6:07 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124923/
> ---
> 
> (Updated Aug. 26, 2015, 6:07 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> This is a rewrite of the old kolourpicker plasmoid, albeit a bit prettier.
> 
> Clicking the "drop" (it's color-picker, I would expect a pipette icon) enters 
> picker mode, where you can click anywhere on the screen and have the color 
> code (in a format you can configure) copied to your clipboard.
> Clicking the color blob opens the history, showing the recentmost 9 colors 
> (so it's a nice grid) which allow copying their respective color codes in 
> various formats.
> Activating the plasmoid (pressing the configured shortcut) will by default 
> enter color picking mode, alternatively it brings up the popup like any other 
> plasmoid.
> 
> 
> Diffs
> -
> 
>   applets/CMakeLists.txt c60c350 
>   applets/colorpicker/CMakeLists.txt PRE-CREATION 
>   applets/colorpicker/Messages.sh PRE-CREATION 
>   applets/colorpicker/package/contents/code/logic.js PRE-CREATION 
>   applets/colorpicker/package/contents/config/config.qml PRE-CREATION 
>   applets/colorpicker/package/contents/config/main.xml PRE-CREATION 
>   applets/colorpicker/package/contents/ui/configGeneral.qml PRE-CREATION 
>   applets/colorpicker/package/contents/ui/main.qml PRE-CREATION 
>   applets/colorpicker/package/metadata.desktop PRE-CREATION 
>   applets/colorpicker/plugin/colorpickerplugin.h PRE-CREATION 
>   applets/colorpicker/plugin/colorpickerplugin.cpp PRE-CREATION 
>   applets/colorpicker/plugin/grabwidget.h PRE-CREATION 
>   applets/colorpicker/plugin/grabwidget.cpp PRE-CREATION 
>   applets/colorpicker/plugin/qmldir PRE-CREATION 
>   applets/kolourpicker/CMakeLists.txt 522e0de 
>   applets/kolourpicker/Messages.sh 072def0 
>   applets/kolourpicker/config-kolourpicker.h.cmake 6cb43cc 
>   applets/kolourpicker/kolourpicker.h bde3ff7 
>   applets/kolourpicker/kolourpicker.cpp a4b0ea4 
>   applets/kolourpicker/plasma-kolourpicker-default.desktop 4334ba1 
> 
> Diff: https://git.reviewboard.kde.org/r/124923/diff/
> 
> 
> Testing
> ---
> 
> - I have the impression that the color picker is off by one pixel 
> horizontally (QRect weirdness? or our Breeze crosshair cursor?)
> - I didn't test with multiple screens
> 
> 
> File Attachments
> 
> 
> In a panel
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/62f4f2df-c435-4676-a4c2-c359d89eaa7d__colorpickerpanel.png
> On the desktop
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/26b97307-2b19-4951-8b0c-fe26f960246b__colorpickerdesktop.png
> History
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/b9ecab53-8f40-49df-92da-f0e8479bd9a6__colorpickerhistory.png
> Formats menu
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/ab4720c0-e25c-486a-9f5a-3dbef5a25fa6__colorpickermenu.png
> Settings
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/f051b3e9-28c3-4456-ae7a-9dad748519a9__colorpickersettings.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

Re: Review Request 124923: Plasma 5 color picker plasmoid

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124923/#review84902
---


Ping

- Kai Uwe Broulik


On Aug. 26, 2015, 6:07 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124923/
> ---
> 
> (Updated Aug. 26, 2015, 6:07 nachm.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> This is a rewrite of the old kolourpicker plasmoid, albeit a bit prettier.
> 
> Clicking the "drop" (it's color-picker, I would expect a pipette icon) enters 
> picker mode, where you can click anywhere on the screen and have the color 
> code (in a format you can configure) copied to your clipboard.
> Clicking the color blob opens the history, showing the recentmost 9 colors 
> (so it's a nice grid) which allow copying their respective color codes in 
> various formats.
> Activating the plasmoid (pressing the configured shortcut) will by default 
> enter color picking mode, alternatively it brings up the popup like any other 
> plasmoid.
> 
> 
> Diffs
> -
> 
>   applets/CMakeLists.txt c60c350 
>   applets/colorpicker/CMakeLists.txt PRE-CREATION 
>   applets/colorpicker/Messages.sh PRE-CREATION 
>   applets/colorpicker/package/contents/code/logic.js PRE-CREATION 
>   applets/colorpicker/package/contents/config/config.qml PRE-CREATION 
>   applets/colorpicker/package/contents/config/main.xml PRE-CREATION 
>   applets/colorpicker/package/contents/ui/configGeneral.qml PRE-CREATION 
>   applets/colorpicker/package/contents/ui/main.qml PRE-CREATION 
>   applets/colorpicker/package/metadata.desktop PRE-CREATION 
>   applets/colorpicker/plugin/colorpickerplugin.h PRE-CREATION 
>   applets/colorpicker/plugin/colorpickerplugin.cpp PRE-CREATION 
>   applets/colorpicker/plugin/grabwidget.h PRE-CREATION 
>   applets/colorpicker/plugin/grabwidget.cpp PRE-CREATION 
>   applets/colorpicker/plugin/qmldir PRE-CREATION 
>   applets/kolourpicker/CMakeLists.txt 522e0de 
>   applets/kolourpicker/Messages.sh 072def0 
>   applets/kolourpicker/config-kolourpicker.h.cmake 6cb43cc 
>   applets/kolourpicker/kolourpicker.h bde3ff7 
>   applets/kolourpicker/kolourpicker.cpp a4b0ea4 
>   applets/kolourpicker/plasma-kolourpicker-default.desktop 4334ba1 
> 
> Diff: https://git.reviewboard.kde.org/r/124923/diff/
> 
> 
> Testing
> ---
> 
> - I have the impression that the color picker is off by one pixel 
> horizontally (QRect weirdness? or our Breeze crosshair cursor?)
> - I didn't test with multiple screens
> 
> 
> File Attachments
> 
> 
> In a panel
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/62f4f2df-c435-4676-a4c2-c359d89eaa7d__colorpickerpanel.png
> On the desktop
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/26b97307-2b19-4951-8b0c-fe26f960246b__colorpickerdesktop.png
> History
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/b9ecab53-8f40-49df-92da-f0e8479bd9a6__colorpickerhistory.png
> Formats menu
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/ab4720c0-e25c-486a-9f5a-3dbef5a25fa6__colorpickermenu.png
> Settings
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/f051b3e9-28c3-4456-ae7a-9dad748519a9__colorpickersettings.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124923: Plasma 5 color picker plasmoid

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124923/#review84907
---


I would be for pushing this. I'mnot sure how to solve the disconnected look og 
the two buttons, but code wise seems fine

- Marco Martin


On Aug. 26, 2015, 6:07 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124923/
> ---
> 
> (Updated Aug. 26, 2015, 6:07 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> This is a rewrite of the old kolourpicker plasmoid, albeit a bit prettier.
> 
> Clicking the "drop" (it's color-picker, I would expect a pipette icon) enters 
> picker mode, where you can click anywhere on the screen and have the color 
> code (in a format you can configure) copied to your clipboard.
> Clicking the color blob opens the history, showing the recentmost 9 colors 
> (so it's a nice grid) which allow copying their respective color codes in 
> various formats.
> Activating the plasmoid (pressing the configured shortcut) will by default 
> enter color picking mode, alternatively it brings up the popup like any other 
> plasmoid.
> 
> 
> Diffs
> -
> 
>   applets/CMakeLists.txt c60c350 
>   applets/colorpicker/CMakeLists.txt PRE-CREATION 
>   applets/colorpicker/Messages.sh PRE-CREATION 
>   applets/colorpicker/package/contents/code/logic.js PRE-CREATION 
>   applets/colorpicker/package/contents/config/config.qml PRE-CREATION 
>   applets/colorpicker/package/contents/config/main.xml PRE-CREATION 
>   applets/colorpicker/package/contents/ui/configGeneral.qml PRE-CREATION 
>   applets/colorpicker/package/contents/ui/main.qml PRE-CREATION 
>   applets/colorpicker/package/metadata.desktop PRE-CREATION 
>   applets/colorpicker/plugin/colorpickerplugin.h PRE-CREATION 
>   applets/colorpicker/plugin/colorpickerplugin.cpp PRE-CREATION 
>   applets/colorpicker/plugin/grabwidget.h PRE-CREATION 
>   applets/colorpicker/plugin/grabwidget.cpp PRE-CREATION 
>   applets/colorpicker/plugin/qmldir PRE-CREATION 
>   applets/kolourpicker/CMakeLists.txt 522e0de 
>   applets/kolourpicker/Messages.sh 072def0 
>   applets/kolourpicker/config-kolourpicker.h.cmake 6cb43cc 
>   applets/kolourpicker/kolourpicker.h bde3ff7 
>   applets/kolourpicker/kolourpicker.cpp a4b0ea4 
>   applets/kolourpicker/plasma-kolourpicker-default.desktop 4334ba1 
> 
> Diff: https://git.reviewboard.kde.org/r/124923/diff/
> 
> 
> Testing
> ---
> 
> - I have the impression that the color picker is off by one pixel 
> horizontally (QRect weirdness? or our Breeze crosshair cursor?)
> - I didn't test with multiple screens
> 
> 
> File Attachments
> 
> 
> In a panel
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/62f4f2df-c435-4676-a4c2-c359d89eaa7d__colorpickerpanel.png
> On the desktop
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/26b97307-2b19-4951-8b0c-fe26f960246b__colorpickerdesktop.png
> History
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/b9ecab53-8f40-49df-92da-f0e8479bd9a6__colorpickerhistory.png
> Formats menu
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/ab4720c0-e25c-486a-9f5a-3dbef5a25fa6__colorpickermenu.png
> Settings
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/f051b3e9-28c3-4456-ae7a-9dad748519a9__colorpickersettings.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124923: Plasma 5 color picker plasmoid

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124923/
---

(Updated Aug. 26, 2015, 6:07 nachm.)


Review request for Plasma and KDE Usability.


Changes
---

- Pick correct coordinates with QT_DEVICE_PIXEL_RATIO
- Fix first pick not being registered
- Restore LaTeX color


Repository: kdeplasma-addons


Description
---

This is a rewrite of the old kolourpicker plasmoid, albeit a bit prettier.

Clicking the drop (it's color-picker, I would expect a pipette icon) enters 
picker mode, where you can click anywhere on the screen and have the color code 
(in a format you can configure) copied to your clipboard.
Clicking the color blob opens the history, showing the recentmost 9 colors (so 
it's a nice grid) which allow copying their respective color codes in various 
formats.
Activating the plasmoid (pressing the configured shortcut) will by default 
enter color picking mode, alternatively it brings up the popup like any other 
plasmoid.


Diffs (updated)
-

  applets/CMakeLists.txt c60c350 
  applets/colorpicker/CMakeLists.txt PRE-CREATION 
  applets/colorpicker/Messages.sh PRE-CREATION 
  applets/colorpicker/package/contents/code/logic.js PRE-CREATION 
  applets/colorpicker/package/contents/config/config.qml PRE-CREATION 
  applets/colorpicker/package/contents/config/main.xml PRE-CREATION 
  applets/colorpicker/package/contents/ui/configGeneral.qml PRE-CREATION 
  applets/colorpicker/package/contents/ui/main.qml PRE-CREATION 
  applets/colorpicker/package/metadata.desktop PRE-CREATION 
  applets/colorpicker/plugin/colorpickerplugin.h PRE-CREATION 
  applets/colorpicker/plugin/colorpickerplugin.cpp PRE-CREATION 
  applets/colorpicker/plugin/grabwidget.h PRE-CREATION 
  applets/colorpicker/plugin/grabwidget.cpp PRE-CREATION 
  applets/colorpicker/plugin/qmldir PRE-CREATION 
  applets/kolourpicker/CMakeLists.txt 522e0de 
  applets/kolourpicker/Messages.sh 072def0 
  applets/kolourpicker/config-kolourpicker.h.cmake 6cb43cc 
  applets/kolourpicker/kolourpicker.h bde3ff7 
  applets/kolourpicker/kolourpicker.cpp a4b0ea4 
  applets/kolourpicker/plasma-kolourpicker-default.desktop 4334ba1 

Diff: https://git.reviewboard.kde.org/r/124923/diff/


Testing (updated)
---

- I have the impression that the color picker is off by one pixel horizontally 
(QRect weirdness? or our Breeze crosshair cursor?)
- I didn't test with multiple screens


File Attachments


In a panel
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/62f4f2df-c435-4676-a4c2-c359d89eaa7d__colorpickerpanel.png
On the desktop
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/26b97307-2b19-4951-8b0c-fe26f960246b__colorpickerdesktop.png
History
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/b9ecab53-8f40-49df-92da-f0e8479bd9a6__colorpickerhistory.png
Formats menu
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/ab4720c0-e25c-486a-9f5a-3dbef5a25fa6__colorpickermenu.png
Settings
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/f051b3e9-28c3-4456-ae7a-9dad748519a9__colorpickersettings.png


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124923: Plasma 5 color picker plasmoid

[Thomas Pfeiffer]

 On Aug. 25, 2015, 9:22 p.m., Thomas Pfeiffer wrote:
  Great work!
  Two points:
  1. The two icons in the Plasmoid look like they're two separate Plasmoids, 
  which is confusing. They should be more visually connected (we're still 
  brainstorming ideas for how to do this in the VDG)
  2. Latex color doesn't have anything to do with fetish, but it's the color 
  code that LaTeX uses (see 
  https://en.wikibooks.org/wiki/LaTeX/Colors#Color_Models ). I don't know how 
  many LaTeX users actually need this, but it might be premature to just 
  remove it.
 
 Kai Uwe Broulik wrote:
 2.) I already got complaints about this on IRC, so I'll bring it back :D
 
 Marco Martin wrote:
 I don't think it's an issue that it looks like two separate plasmoids: 
 those are two semi independent functions that if they happen to belong to the 
 same plasmoid or not is no concern to the user

They are only _semi_-independent: They perform two different functions when 
clicked, but the history button has absolutely no use without the color picking 
button. Therefore, they still clearly belong together.


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124923/#review84368
---


On Aug. 25, 2015, 6:19 p.m., Kai Uwe Broulik wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124923/
 ---
 
 (Updated Aug. 25, 2015, 6:19 p.m.)
 
 
 Review request for Plasma and KDE Usability.
 
 
 Repository: kdeplasma-addons
 
 
 Description
 ---
 
 This is a rewrite of the old kolourpicker plasmoid, albeit a bit prettier.
 
 Clicking the drop (it's color-picker, I would expect a pipette icon) enters 
 picker mode, where you can click anywhere on the screen and have the color 
 code (in a format you can configure) copied to your clipboard.
 Clicking the color blob opens the history, showing the recentmost 9 colors 
 (so it's a nice grid) which allow copying their respective color codes in 
 various formats.
 Activating the plasmoid (pressing the configured shortcut) will by default 
 enter color picking mode, alternatively it brings up the popup like any other 
 plasmoid.
 
 
 Diffs
 -
 
   applets/CMakeLists.txt c60c350 
   applets/colorpicker/CMakeLists.txt PRE-CREATION 
   applets/colorpicker/Messages.sh PRE-CREATION 
   applets/colorpicker/package/contents/code/logic.js PRE-CREATION 
   applets/colorpicker/package/contents/config/config.qml PRE-CREATION 
   applets/colorpicker/package/contents/config/main.xml PRE-CREATION 
   applets/colorpicker/package/contents/ui/configGeneral.qml PRE-CREATION 
   applets/colorpicker/package/contents/ui/main.qml PRE-CREATION 
   applets/colorpicker/package/metadata.desktop PRE-CREATION 
   applets/colorpicker/plugin/colorpickerplugin.h PRE-CREATION 
   applets/colorpicker/plugin/colorpickerplugin.cpp PRE-CREATION 
   applets/colorpicker/plugin/grabwidget.h PRE-CREATION 
   applets/colorpicker/plugin/grabwidget.cpp PRE-CREATION 
   applets/colorpicker/plugin/qmldir PRE-CREATION 
   applets/kolourpicker/CMakeLists.txt 522e0de 
   applets/kolourpicker/Messages.sh 072def0 
   applets/kolourpicker/config-kolourpicker.h.cmake 6cb43cc 
   applets/kolourpicker/kolourpicker.h bde3ff7 
   applets/kolourpicker/kolourpicker.cpp a4b0ea4 
   applets/kolourpicker/plasma-kolourpicker-default.desktop 4334ba1 
 
 Diff: https://git.reviewboard.kde.org/r/124923/diff/
 
 
 Testing
 ---
 
 - I have the impression that the color picker is off by one pixel 
 horizontally (QRect weirdness?)
 - It breaks with QT_DEVICE_PIXEL_RATIO (Daviid?)
 - I didn't test with multiple screens
 - The first pick after startup of plasmashell/plasmoidviewer is not added to 
 the history for some reason I haven't figured out yet
 - I removed the Latex color, whatever that was, and added Qt.rgba instead :) 
 as well as CSS colors
 
 
 File Attachments
 
 
 In a panel
   
 https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/62f4f2df-c435-4676-a4c2-c359d89eaa7d__colorpickerpanel.png
 On the desktop
   
 https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/26b97307-2b19-4951-8b0c-fe26f960246b__colorpickerdesktop.png
 History
   
 https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/b9ecab53-8f40-49df-92da-f0e8479bd9a6__colorpickerhistory.png
 Formats menu
   
 https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/ab4720c0-e25c-486a-9f5a-3dbef5a25fa6__colorpickermenu.png
 Settings
   
 https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/f051b3e9-28c3-4456-ae7a-9dad748519a9__colorpickersettings.png
 
 
 Thanks,
 
 Kai Uwe Broulik
 


___
Plasma-devel mailing list

Re: Review Request 124923: Plasma 5 color picker plasmoid

[Marco Martin]

 On Aug. 25, 2015, 9:22 p.m., Thomas Pfeiffer wrote:
  Great work!
  Two points:
  1. The two icons in the Plasmoid look like they're two separate Plasmoids, 
  which is confusing. They should be more visually connected (we're still 
  brainstorming ideas for how to do this in the VDG)
  2. Latex color doesn't have anything to do with fetish, but it's the color 
  code that LaTeX uses (see 
  https://en.wikibooks.org/wiki/LaTeX/Colors#Color_Models ). I don't know how 
  many LaTeX users actually need this, but it might be premature to just 
  remove it.
 
 Kai Uwe Broulik wrote:
 2.) I already got complaints about this on IRC, so I'll bring it back :D

I don't think it's an issue that it looks like two separate plasmoids: those 
are two semi independent functions that if they happen to belong to the same 
plasmoid or not is no concern to the user


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124923/#review84368
---


On Aug. 25, 2015, 6:19 p.m., Kai Uwe Broulik wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124923/
 ---
 
 (Updated Aug. 25, 2015, 6:19 p.m.)
 
 
 Review request for Plasma and KDE Usability.
 
 
 Repository: kdeplasma-addons
 
 
 Description
 ---
 
 This is a rewrite of the old kolourpicker plasmoid, albeit a bit prettier.
 
 Clicking the drop (it's color-picker, I would expect a pipette icon) enters 
 picker mode, where you can click anywhere on the screen and have the color 
 code (in a format you can configure) copied to your clipboard.
 Clicking the color blob opens the history, showing the recentmost 9 colors 
 (so it's a nice grid) which allow copying their respective color codes in 
 various formats.
 Activating the plasmoid (pressing the configured shortcut) will by default 
 enter color picking mode, alternatively it brings up the popup like any other 
 plasmoid.
 
 
 Diffs
 -
 
   applets/CMakeLists.txt c60c350 
   applets/colorpicker/CMakeLists.txt PRE-CREATION 
   applets/colorpicker/Messages.sh PRE-CREATION 
   applets/colorpicker/package/contents/code/logic.js PRE-CREATION 
   applets/colorpicker/package/contents/config/config.qml PRE-CREATION 
   applets/colorpicker/package/contents/config/main.xml PRE-CREATION 
   applets/colorpicker/package/contents/ui/configGeneral.qml PRE-CREATION 
   applets/colorpicker/package/contents/ui/main.qml PRE-CREATION 
   applets/colorpicker/package/metadata.desktop PRE-CREATION 
   applets/colorpicker/plugin/colorpickerplugin.h PRE-CREATION 
   applets/colorpicker/plugin/colorpickerplugin.cpp PRE-CREATION 
   applets/colorpicker/plugin/grabwidget.h PRE-CREATION 
   applets/colorpicker/plugin/grabwidget.cpp PRE-CREATION 
   applets/colorpicker/plugin/qmldir PRE-CREATION 
   applets/kolourpicker/CMakeLists.txt 522e0de 
   applets/kolourpicker/Messages.sh 072def0 
   applets/kolourpicker/config-kolourpicker.h.cmake 6cb43cc 
   applets/kolourpicker/kolourpicker.h bde3ff7 
   applets/kolourpicker/kolourpicker.cpp a4b0ea4 
   applets/kolourpicker/plasma-kolourpicker-default.desktop 4334ba1 
 
 Diff: https://git.reviewboard.kde.org/r/124923/diff/
 
 
 Testing
 ---
 
 - I have the impression that the color picker is off by one pixel 
 horizontally (QRect weirdness?)
 - It breaks with QT_DEVICE_PIXEL_RATIO (Daviid?)
 - I didn't test with multiple screens
 - The first pick after startup of plasmashell/plasmoidviewer is not added to 
 the history for some reason I haven't figured out yet
 - I removed the Latex color, whatever that was, and added Qt.rgba instead :) 
 as well as CSS colors
 
 
 File Attachments
 
 
 In a panel
   
 https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/62f4f2df-c435-4676-a4c2-c359d89eaa7d__colorpickerpanel.png
 On the desktop
   
 https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/26b97307-2b19-4951-8b0c-fe26f960246b__colorpickerdesktop.png
 History
   
 https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/b9ecab53-8f40-49df-92da-f0e8479bd9a6__colorpickerhistory.png
 Formats menu
   
 https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/ab4720c0-e25c-486a-9f5a-3dbef5a25fa6__colorpickermenu.png
 Settings
   
 https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/f051b3e9-28c3-4456-ae7a-9dad748519a9__colorpickersettings.png
 
 
 Thanks,
 
 Kai Uwe Broulik
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 124923: Plasma 5 color picker plasmoid

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124923/
---

Review request for Plasma and KDE Usability.


Repository: kdeplasma-addons


Description
---

This is a rewrite of the old kolourpicker plasmoid, albeit a bit prettier.

Clicking the drop (it's color-picker, I would expect a pipette icon) enters 
picker mode, where you can click anywhere on the screen and have the color code 
(in a format you can configure) copied to your clipboard.
Clicking the color blob opens the history, showing the recentmost 9 colors (so 
it's a nice grid) which allow copying their respective color codes in various 
formats.
Activating the plasmoid (pressing the configured shortcut) will by default 
enter color picking mode, alternatively it brings up the popup like any other 
plasmoid.


Diffs
-

  applets/CMakeLists.txt c60c350 
  applets/colorpicker/CMakeLists.txt PRE-CREATION 
  applets/colorpicker/Messages.sh PRE-CREATION 
  applets/colorpicker/package/contents/code/logic.js PRE-CREATION 
  applets/colorpicker/package/contents/config/config.qml PRE-CREATION 
  applets/colorpicker/package/contents/config/main.xml PRE-CREATION 
  applets/colorpicker/package/contents/ui/configGeneral.qml PRE-CREATION 
  applets/colorpicker/package/contents/ui/main.qml PRE-CREATION 
  applets/colorpicker/package/metadata.desktop PRE-CREATION 
  applets/colorpicker/plugin/colorpickerplugin.h PRE-CREATION 
  applets/colorpicker/plugin/colorpickerplugin.cpp PRE-CREATION 
  applets/colorpicker/plugin/grabwidget.h PRE-CREATION 
  applets/colorpicker/plugin/grabwidget.cpp PRE-CREATION 
  applets/colorpicker/plugin/qmldir PRE-CREATION 
  applets/kolourpicker/CMakeLists.txt 522e0de 
  applets/kolourpicker/Messages.sh 072def0 
  applets/kolourpicker/config-kolourpicker.h.cmake 6cb43cc 
  applets/kolourpicker/kolourpicker.h bde3ff7 
  applets/kolourpicker/kolourpicker.cpp a4b0ea4 
  applets/kolourpicker/plasma-kolourpicker-default.desktop 4334ba1 

Diff: https://git.reviewboard.kde.org/r/124923/diff/


Testing
---

- I have the impression that the color picker is off by one pixel horizontally 
(QRect weirdness?)
- It breaks with QT_DEVICE_PIXEL_RATIO (Daviid?)
- I didn't test with multiple screens
- The first pick after startup of plasmashell/plasmoidviewer is not added to 
the history for some reason I haven't figured out yet
- I removed the Latex color, whatever that was, and added Qt.rgba instead :) as 
well as CSS colors


File Attachments


In a panel
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/62f4f2df-c435-4676-a4c2-c359d89eaa7d__colorpickerpanel.png
On the desktop
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/26b97307-2b19-4951-8b0c-fe26f960246b__colorpickerdesktop.png
History
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/b9ecab53-8f40-49df-92da-f0e8479bd9a6__colorpickerhistory.png
Formats menu
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/ab4720c0-e25c-486a-9f5a-3dbef5a25fa6__colorpickermenu.png
Settings
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/f051b3e9-28c3-4456-ae7a-9dad748519a9__colorpickersettings.png


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124923: Plasma 5 color picker plasmoid

[Thomas Pfeiffer]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124923/#review84368
---


Great work!
Two points:
1. The two icons in the Plasmoid look like they're two separate Plasmoids, 
which is confusing. They should be more visually connected (we're still 
brainstorming ideas for how to do this in the VDG)
2. Latex color doesn't have anything to do with fetish, but it's the color code 
that LaTeX uses (see https://en.wikibooks.org/wiki/LaTeX/Colors#Color_Models ). 
I don't know how many LaTeX users actually need this, but it might be premature 
to just remove it.

- Thomas Pfeiffer


On Aug. 25, 2015, 6:19 p.m., Kai Uwe Broulik wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124923/
 ---
 
 (Updated Aug. 25, 2015, 6:19 p.m.)
 
 
 Review request for Plasma and KDE Usability.
 
 
 Repository: kdeplasma-addons
 
 
 Description
 ---
 
 This is a rewrite of the old kolourpicker plasmoid, albeit a bit prettier.
 
 Clicking the drop (it's color-picker, I would expect a pipette icon) enters 
 picker mode, where you can click anywhere on the screen and have the color 
 code (in a format you can configure) copied to your clipboard.
 Clicking the color blob opens the history, showing the recentmost 9 colors 
 (so it's a nice grid) which allow copying their respective color codes in 
 various formats.
 Activating the plasmoid (pressing the configured shortcut) will by default 
 enter color picking mode, alternatively it brings up the popup like any other 
 plasmoid.
 
 
 Diffs
 -
 
   applets/CMakeLists.txt c60c350 
   applets/colorpicker/CMakeLists.txt PRE-CREATION 
   applets/colorpicker/Messages.sh PRE-CREATION 
   applets/colorpicker/package/contents/code/logic.js PRE-CREATION 
   applets/colorpicker/package/contents/config/config.qml PRE-CREATION 
   applets/colorpicker/package/contents/config/main.xml PRE-CREATION 
   applets/colorpicker/package/contents/ui/configGeneral.qml PRE-CREATION 
   applets/colorpicker/package/contents/ui/main.qml PRE-CREATION 
   applets/colorpicker/package/metadata.desktop PRE-CREATION 
   applets/colorpicker/plugin/colorpickerplugin.h PRE-CREATION 
   applets/colorpicker/plugin/colorpickerplugin.cpp PRE-CREATION 
   applets/colorpicker/plugin/grabwidget.h PRE-CREATION 
   applets/colorpicker/plugin/grabwidget.cpp PRE-CREATION 
   applets/colorpicker/plugin/qmldir PRE-CREATION 
   applets/kolourpicker/CMakeLists.txt 522e0de 
   applets/kolourpicker/Messages.sh 072def0 
   applets/kolourpicker/config-kolourpicker.h.cmake 6cb43cc 
   applets/kolourpicker/kolourpicker.h bde3ff7 
   applets/kolourpicker/kolourpicker.cpp a4b0ea4 
   applets/kolourpicker/plasma-kolourpicker-default.desktop 4334ba1 
 
 Diff: https://git.reviewboard.kde.org/r/124923/diff/
 
 
 Testing
 ---
 
 - I have the impression that the color picker is off by one pixel 
 horizontally (QRect weirdness?)
 - It breaks with QT_DEVICE_PIXEL_RATIO (Daviid?)
 - I didn't test with multiple screens
 - The first pick after startup of plasmashell/plasmoidviewer is not added to 
 the history for some reason I haven't figured out yet
 - I removed the Latex color, whatever that was, and added Qt.rgba instead :) 
 as well as CSS colors
 
 
 File Attachments
 
 
 In a panel
   
 https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/62f4f2df-c435-4676-a4c2-c359d89eaa7d__colorpickerpanel.png
 On the desktop
   
 https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/26b97307-2b19-4951-8b0c-fe26f960246b__colorpickerdesktop.png
 History
   
 https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/b9ecab53-8f40-49df-92da-f0e8479bd9a6__colorpickerhistory.png
 Formats menu
   
 https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/ab4720c0-e25c-486a-9f5a-3dbef5a25fa6__colorpickermenu.png
 Settings
   
 https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/f051b3e9-28c3-4456-ae7a-9dad748519a9__colorpickersettings.png
 
 
 Thanks,
 
 Kai Uwe Broulik
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124923: Plasma 5 color picker plasmoid

[Kai Uwe Broulik]

 On Aug. 25, 2015, 9:22 nachm., Thomas Pfeiffer wrote:
  Great work!
  Two points:
  1. The two icons in the Plasmoid look like they're two separate Plasmoids, 
  which is confusing. They should be more visually connected (we're still 
  brainstorming ideas for how to do this in the VDG)
  2. Latex color doesn't have anything to do with fetish, but it's the color 
  code that LaTeX uses (see 
  https://en.wikibooks.org/wiki/LaTeX/Colors#Color_Models ). I don't know how 
  many LaTeX users actually need this, but it might be premature to just 
  remove it.

2.) I already got complaints about this on IRC, so I'll bring it back :D


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124923/#review84368
---


On Aug. 25, 2015, 6:19 nachm., Kai Uwe Broulik wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124923/
 ---
 
 (Updated Aug. 25, 2015, 6:19 nachm.)
 
 
 Review request for Plasma and KDE Usability.
 
 
 Repository: kdeplasma-addons
 
 
 Description
 ---
 
 This is a rewrite of the old kolourpicker plasmoid, albeit a bit prettier.
 
 Clicking the drop (it's color-picker, I would expect a pipette icon) enters 
 picker mode, where you can click anywhere on the screen and have the color 
 code (in a format you can configure) copied to your clipboard.
 Clicking the color blob opens the history, showing the recentmost 9 colors 
 (so it's a nice grid) which allow copying their respective color codes in 
 various formats.
 Activating the plasmoid (pressing the configured shortcut) will by default 
 enter color picking mode, alternatively it brings up the popup like any other 
 plasmoid.
 
 
 Diffs
 -
 
   applets/CMakeLists.txt c60c350 
   applets/colorpicker/CMakeLists.txt PRE-CREATION 
   applets/colorpicker/Messages.sh PRE-CREATION 
   applets/colorpicker/package/contents/code/logic.js PRE-CREATION 
   applets/colorpicker/package/contents/config/config.qml PRE-CREATION 
   applets/colorpicker/package/contents/config/main.xml PRE-CREATION 
   applets/colorpicker/package/contents/ui/configGeneral.qml PRE-CREATION 
   applets/colorpicker/package/contents/ui/main.qml PRE-CREATION 
   applets/colorpicker/package/metadata.desktop PRE-CREATION 
   applets/colorpicker/plugin/colorpickerplugin.h PRE-CREATION 
   applets/colorpicker/plugin/colorpickerplugin.cpp PRE-CREATION 
   applets/colorpicker/plugin/grabwidget.h PRE-CREATION 
   applets/colorpicker/plugin/grabwidget.cpp PRE-CREATION 
   applets/colorpicker/plugin/qmldir PRE-CREATION 
   applets/kolourpicker/CMakeLists.txt 522e0de 
   applets/kolourpicker/Messages.sh 072def0 
   applets/kolourpicker/config-kolourpicker.h.cmake 6cb43cc 
   applets/kolourpicker/kolourpicker.h bde3ff7 
   applets/kolourpicker/kolourpicker.cpp a4b0ea4 
   applets/kolourpicker/plasma-kolourpicker-default.desktop 4334ba1 
 
 Diff: https://git.reviewboard.kde.org/r/124923/diff/
 
 
 Testing
 ---
 
 - I have the impression that the color picker is off by one pixel 
 horizontally (QRect weirdness?)
 - It breaks with QT_DEVICE_PIXEL_RATIO (Daviid?)
 - I didn't test with multiple screens
 - The first pick after startup of plasmashell/plasmoidviewer is not added to 
 the history for some reason I haven't figured out yet
 - I removed the Latex color, whatever that was, and added Qt.rgba instead :) 
 as well as CSS colors
 
 
 File Attachments
 
 
 In a panel
   
 https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/62f4f2df-c435-4676-a4c2-c359d89eaa7d__colorpickerpanel.png
 On the desktop
   
 https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/26b97307-2b19-4951-8b0c-fe26f960246b__colorpickerdesktop.png
 History
   
 https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/b9ecab53-8f40-49df-92da-f0e8479bd9a6__colorpickerhistory.png
 Formats menu
   
 https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/ab4720c0-e25c-486a-9f5a-3dbef5a25fa6__colorpickermenu.png
 Settings
   
 https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/f051b3e9-28c3-4456-ae7a-9dad748519a9__colorpickersettings.png
 
 
 Thanks,
 
 Kai Uwe Broulik
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 344456] Plasma 5 desktop does not suspend with only upower, no systemd

[Manuel Bärenz]

https://bugs.kde.org/show_bug.cgi?id=344456

--- Comment #30 from Manuel Bärenz man...@enigmage.de ---
For Gentoo, just adding the Polkit files will not suffice. Only after
respawning first kded5 and then plasmashell am I able to see Sleep and
Hibernate buttons at all. And even then the Sleep button does not work, but
only locks the screen after showing a black screen for a few seconds.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 344456] Plasma 5 desktop does not suspend with only upower, no systemd

[Manuel Bärenz]

https://bugs.kde.org/show_bug.cgi?id=344456

Manuel Bärenz man...@enigmage.de changed:

   What|Removed |Added

 CC||man...@enigmage.de

--- Comment #29 from Manuel Bärenz man...@enigmage.de ---
*** Bug 351447 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124347: Update desktopthemedetails kcm docbook to Plasma 5

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124347/
---

(Updated July 21, 2015, 10:14 a.m.)


Status
--

This change has been marked as submitted.


Review request for Documentation and Plasma.


Changes
---

Submitted with commit e14a0e6a80b4c9b8f0f129d411a2aefd8dcce73b by Burkhard Lück 
to branch master.


Repository: plasma-desktop


Description
---

Updated docbook content and screenshot


Diffs
-

  doc/kcontrol/desktopthemedetails/clicking-apply.png f57723b 
  doc/kcontrol/desktopthemedetails/customizing.png a16743f 
  doc/kcontrol/desktopthemedetails/index.docbook 19882ed 

Diff: https://git.reviewboard.kde.org/r/124347/diff/


Testing
---

builds


File Attachments


customizing.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/07/14/7f27c9f4-d283-4437-a52d-595f684fd68e__customizing.png


Thanks,

Burkhard Lück

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124352: Update kwinsceenedges to Plasma 5

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124352/
---

(Updated July 21, 2015, 10:02 a.m.)


Status
--

This change has been marked as submitted.


Review request for Documentation, Plasma and Martin Gräßlin.


Changes
---

Submitted with commit 4730812df89312f123f8506c480418ab883bec2c by Burkhard Lück 
to branch master.


Repository: kwin


Description
---

Question:
Do I need to enable the compositor to get that working?


Diffs
-

  doc/kwinscreenedges/index.docbook 671d60c 

Diff: https://git.reviewboard.kde.org/r/124352/diff/


Testing
---

builds


Thanks,

Burkhard Lück

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124347: Update desktopthemedetails kcm docbook to Plasma 5

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124347/#review82533
---

Ship it!


Ship It!

- Marco Martin


On July 14, 2015, 2:57 p.m., Burkhard Lück wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124347/
 ---
 
 (Updated July 14, 2015, 2:57 p.m.)
 
 
 Review request for Documentation and Plasma.
 
 
 Repository: plasma-desktop
 
 
 Description
 ---
 
 Updated docbook content and screenshot
 
 
 Diffs
 -
 
   doc/kcontrol/desktopthemedetails/clicking-apply.png f57723b 
   doc/kcontrol/desktopthemedetails/customizing.png a16743f 
   doc/kcontrol/desktopthemedetails/index.docbook 19882ed 
 
 Diff: https://git.reviewboard.kde.org/r/124347/diff/
 
 
 Testing
 ---
 
 builds
 
 
 File Attachments
 
 
 customizing.png
   
 https://git.reviewboard.kde.org/media/uploaded/files/2015/07/14/7f27c9f4-d283-4437-a52d-595f684fd68e__customizing.png
 
 
 Thanks,
 
 Burkhard Lück
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124352: Update kwinsceenedges to Plasma 5

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124352/#review82531
---

Ship it!


no, screen edges shouldn't need compositor

- Marco Martin


On July 14, 2015, 8:10 p.m., Burkhard Lück wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124352/
 ---
 
 (Updated July 14, 2015, 8:10 p.m.)
 
 
 Review request for Documentation, Plasma and Martin Gräßlin.
 
 
 Repository: kwin
 
 
 Description
 ---
 
 Question:
 Do I need to enable the compositor to get that working?
 
 
 Diffs
 -
 
   doc/kwinscreenedges/index.docbook 671d60c 
 
 Diff: https://git.reviewboard.kde.org/r/124352/diff/
 
 
 Testing
 ---
 
 builds
 
 
 Thanks,
 
 Burkhard Lück
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124283: Update kcmstyle docbook to Plasma 5

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124283/
---

(Updated July 12, 2015, 2:51 p.m.)


Status
--

This change has been marked as submitted.


Review request for Documentation and Plasma.


Changes
---

Submitted with commit 87d53433b511a0bab0f9ad2161e42546f356f70f by Burkhard Lück 
to branch master.


Repository: plasma-desktop


Description
---

see Summary

appmenu commented in docbook, because it is not available in Plasma 5, is this 
correct?


Diffs
-

  doc/kcontrol/kcmstyle/index.docbook a0b456b 

Diff: https://git.reviewboard.kde.org/r/124283/diff/


Testing
---

builds


Thanks,

Burkhard Lück

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124283: Update kcmstyle docbook to Plasma 5

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124283/#review82242
---


any comment from docbook team?

- Burkhard Lück


On Juli 7, 2015, 4:47 nachm., Burkhard Lück wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124283/
 ---
 
 (Updated Juli 7, 2015, 4:47 nachm.)
 
 
 Review request for Documentation and Plasma.
 
 
 Repository: plasma-desktop
 
 
 Description
 ---
 
 see Summary
 
 appmenu commented in docbook, because it is not available in Plasma 5, is 
 this correct?
 
 
 Diffs
 -
 
   doc/kcontrol/kcmstyle/index.docbook a0b456b 
 
 Diff: https://git.reviewboard.kde.org/r/124283/diff/
 
 
 Testing
 ---
 
 builds
 
 
 Thanks,
 
 Burkhard Lück
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124283: Update kcmstyle docbook to Plasma 5

[Luigi Toscano]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124283/#review82245
---

Ship it!


Not sure about the fate of appmenu as we still depend on dbusmenu, but maybe 
it's just not implemented there. If sebas says it's fine, then I'm fine.
I'm fine with committing as it is, but do we have an entity for plasma; ?

- Luigi Toscano


On Lug. 7, 2015, 6:47 p.m., Burkhard Lück wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124283/
 ---
 
 (Updated Lug. 7, 2015, 6:47 p.m.)
 
 
 Review request for Documentation and Plasma.
 
 
 Repository: plasma-desktop
 
 
 Description
 ---
 
 see Summary
 
 appmenu commented in docbook, because it is not available in Plasma 5, is 
 this correct?
 
 
 Diffs
 -
 
   doc/kcontrol/kcmstyle/index.docbook a0b456b 
 
 Diff: https://git.reviewboard.kde.org/r/124283/diff/
 
 
 Testing
 ---
 
 builds
 
 
 Thanks,
 
 Burkhard Lück
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124283: Update kcmstyle docbook to Plasma 5

[Burkhard Lück]

 On Juli 8, 2015, 9:52 nachm., Luigi Toscano wrote:
  Not sure about the fate of appmenu as we still depend on dbusmenu, but 
  maybe it's just not implemented there. If sebas says it's fine, then I'm 
  fine.
  I'm fine with committing as it is, but do we have an entity for plasma; ?

fate of appmenu:
https://forum.kde.org/viewtopic.php?f=285t=125058p=336313hilit=appmenu#p336313
https://bugs.kde.org/show_bug.cgi?id=341071#c9

I can add this info to the commented varlistentry Menubar Style

Yes we should have an entity plasma; but what is the proper markup?


- Burkhard


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124283/#review82245
---


On Juli 7, 2015, 4:47 nachm., Burkhard Lück wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124283/
 ---
 
 (Updated Juli 7, 2015, 4:47 nachm.)
 
 
 Review request for Documentation and Plasma.
 
 
 Repository: plasma-desktop
 
 
 Description
 ---
 
 see Summary
 
 appmenu commented in docbook, because it is not available in Plasma 5, is 
 this correct?
 
 
 Diffs
 -
 
   doc/kcontrol/kcmstyle/index.docbook a0b456b 
 
 Diff: https://git.reviewboard.kde.org/r/124283/diff/
 
 
 Testing
 ---
 
 builds
 
 
 Thanks,
 
 Burkhard Lück
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124283: Update kcmstyle docbook to Plasma 5

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124283/#review82188
---

Ship it!


Ship It!

- Sebastian Kügler


On July 7, 2015, 4:47 p.m., Burkhard Lück wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124283/
 ---
 
 (Updated July 7, 2015, 4:47 p.m.)
 
 
 Review request for Documentation and Plasma.
 
 
 Repository: plasma-desktop
 
 
 Description
 ---
 
 see Summary
 
 appmenu commented in docbook, because it is not available in Plasma 5, is 
 this correct?
 
 
 Diffs
 -
 
   doc/kcontrol/kcmstyle/index.docbook a0b456b 
 
 Diff: https://git.reviewboard.kde.org/r/124283/diff/
 
 
 Testing
 ---
 
 builds
 
 
 Thanks,
 
 Burkhard Lück
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 124283: Update kcmstyle docbook to Plasma 5

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124283/
---

Review request for Documentation and Plasma.


Repository: plasma-desktop


Description
---

see Summary

appmenu commented in docbook, because it is not available in Plasma 5, is this 
correct?


Diffs
-

  doc/kcontrol/kcmstyle/index.docbook a0b456b 

Diff: https://git.reviewboard.kde.org/r/124283/diff/


Testing
---

builds


Thanks,

Burkhard Lück

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma 5 is awesome...and some help required with build instructions

[David Edmundson]

On Tue, May 19, 2015 at 2:10 AM, Siddhartha sh.siddhar...@gmail.com wrote:

 On 18 May 2015 at 22:58, David Edmundson da...@davidedmundson.co.uk
 wrote:

 Just setting up on a new machine and thought I'd try following these
 instructions exactly, the way a new developer would.

 I got stuck on something I don't know how to solve.

 Under Kubuntu because Qt is compiled with a hardcoded plugindir for some
 reason.
 This means setting QT_PLUGIN_PATH env variables does nothing, which means
 you'll always be loading any plugins from /usr/ rather than the ones we
 just built.

 How did you get round that? Any ideas?


 By using Arch Linux? :P

 I did not do anything special in this regard, so I guess on my system
QT_PLUGIN_PATH is being picked up properly.


Yes, it's only a problem on Kubuntu.

But someone who wrote this must have been a Kubuntu user, there is a list
of dependencies.

It's also solvable by compiling Qt, but I don't really want to have to
force new devs to do that unless I have to.



Btw, you commented out QTDIR in the wiki script, so a few of the later
 variables will have weird paths (QTDIR/plugins=/plugins)


Ah, yes, it's better to have it try to access a folder that doesn't exist.
Thanks, fixed.




 ___
 Plasma-devel mailing list
 Plasma-devel@kde.org
 https://mail.kde.org/mailman/listinfo/plasma-devel


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma 5 is awesome...and some help required with build instructions

[Martin Klapetek]

On Tue, May 19, 2015 at 12:30 PM, David Edmundson 
da...@davidedmundson.co.uk wrote:


 But someone who wrote this must have been a Kubuntu user, there is a list
 of dependencies.


That was added by me about 2 weeks ago when I tried to follow
that setup as well on a clean system where I had to figure out all
the deps. So I thought it might come handy to others and added
it there.

Nevertheless, I also hit the same problem as you did. I didn't solve
it yet because my laptop has other (more severe) issues with
Linux currently.

Cheers
-- 
Martin Klapetek | KDE Developer
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma 5 is awesome...and some help required with build instructions

[Siddhartha]

On 19 May 2015 at 16:00, David Edmundson da...@davidedmundson.co.uk wrote:
 Yes, it's only a problem on Kubuntu.

 It's also solvable by compiling Qt, but I don't really want to have to force 
 new devs to do that unless I have to.

We should talk to the Kubuntu devs to see why its hardcoded that way,
and ask them to remove that config option if possible. If not, the
other way would be to use KDE_INSTALL_USE_QT_SYS_PATHS as Alex
mentioned and add 'make-install-prefix sudo' to the kdesrc-build
config.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma 5 is awesome...and some help required with build instructions

[David Edmundson]

Just setting up on a new machine and thought I'd try following these
instructions exactly, the way a new developer would.

I got stuck on something I don't know how to solve.

Under Kubuntu because Qt is compiled with a hardcoded plugindir for some
reason.
This means setting QT_PLUGIN_PATH env variables does nothing, which means
you'll always be loading any plugins from /usr/ rather than the ones we
just built.

How did you get round that? Any ideas?

David
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma 5 is awesome...and some help required with build instructions

[David Edmundson]

On Mon, May 18, 2015 at 7:05 PM, Aleix Pol aleix...@kde.org wrote:

 On Mon, May 18, 2015 at 7:28 PM, David Edmundson
 da...@davidedmundson.co.uk wrote:
  Just setting up on a new machine and thought I'd try following these
  instructions exactly, the way a new developer would.
 
  I got stuck on something I don't know how to solve.
 
  Under Kubuntu because Qt is compiled with a hardcoded plugindir for some
  reason.
  This means setting QT_PLUGIN_PATH env variables does nothing, which means
  you'll always be loading any plugins from /usr/ rather than the ones we
 just
  built.
 
  How did you get round that? Any ideas?
 
  David
 
  ___
  Plasma-devel mailing list
  Plasma-devel@kde.org
  https://mail.kde.org/mailman/listinfo/plasma-devel
 

 On Kubuntu, you probably want to enable KDE_INSTALL_USE_QT_SYS_PATHS
 cmake option.


but that will install to /usr
 ​


 Aleix
 ___
 Plasma-devel mailing list
 Plasma-devel@kde.org
 https://mail.kde.org/mailman/listinfo/plasma-devel

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma 5 is awesome...and some help required with build instructions

[Aleix Pol]

On Mon, May 18, 2015 at 7:28 PM, David Edmundson
da...@davidedmundson.co.uk wrote:
 Just setting up on a new machine and thought I'd try following these
 instructions exactly, the way a new developer would.

 I got stuck on something I don't know how to solve.

 Under Kubuntu because Qt is compiled with a hardcoded plugindir for some
 reason.
 This means setting QT_PLUGIN_PATH env variables does nothing, which means
 you'll always be loading any plugins from /usr/ rather than the ones we just
 built.

 How did you get round that? Any ideas?

 David

 ___
 Plasma-devel mailing list
 Plasma-devel@kde.org
 https://mail.kde.org/mailman/listinfo/plasma-devel


On Kubuntu, you probably want to enable KDE_INSTALL_USE_QT_SYS_PATHS
cmake option.

Aleix
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma 5 is awesome...and some help required with build instructions

[Aleix Pol]

On Mon, May 18, 2015 at 8:07 PM, David Edmundson
da...@davidedmundson.co.uk wrote:


 On Mon, May 18, 2015 at 7:05 PM, Aleix Pol aleix...@kde.org wrote:

 On Mon, May 18, 2015 at 7:28 PM, David Edmundson
 da...@davidedmundson.co.uk wrote:
  Just setting up on a new machine and thought I'd try following these
  instructions exactly, the way a new developer would.
 
  I got stuck on something I don't know how to solve.
 
  Under Kubuntu because Qt is compiled with a hardcoded plugindir for some
  reason.
  This means setting QT_PLUGIN_PATH env variables does nothing, which
  means
  you'll always be loading any plugins from /usr/ rather than the ones we
  just
  built.
 
  How did you get round that? Any ideas?
 
  David
 
  ___
  Plasma-devel mailing list
  Plasma-devel@kde.org
  https://mail.kde.org/mailman/listinfo/plasma-devel
 

 On Kubuntu, you probably want to enable KDE_INSTALL_USE_QT_SYS_PATHS
 cmake option.


 but that will install to /usr



 Aleix
 ___
 Plasma-devel mailing list
 Plasma-devel@kde.org
 https://mail.kde.org/mailman/listinfo/plasma-devel



 ___
 Plasma-devel mailing list
 Plasma-devel@kde.org
 https://mail.kde.org/mailman/listinfo/plasma-devel


That's the downside, yes.

Aleix
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma 5 is awesome...and some help required with build instructions

[Siddhartha]

On 18 May 2015 at 22:58, David Edmundson da...@davidedmundson.co.uk wrote:

 Just setting up on a new machine and thought I'd try following these
 instructions exactly, the way a new developer would.

 I got stuck on something I don't know how to solve.

 Under Kubuntu because Qt is compiled with a hardcoded plugindir for some
 reason.
 This means setting QT_PLUGIN_PATH env variables does nothing, which means
 you'll always be loading any plugins from /usr/ rather than the ones we
 just built.

 How did you get round that? Any ideas?


By using Arch Linux? :P

I did not do anything special in this regard, so I guess on my system
QT_PLUGIN_PATH is being picked up properly.

Btw, you commented out QTDIR in the wiki script, so a few of the later
variables will have weird paths (QTDIR/plugins=/plugins)
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 344456] Plasma 5 desktop does not suspend with only upower, no systemd

[Eric Hameleers]

https://bugs.kde.org/show_bug.cgi?id=344456

--- Comment #27 from Eric Hameleers al...@slackware.com ---
I have attached a polkit file which enables the missing suspend/hibernate
features in my Plasma 5 desktop.
Thanks to luis' comment in this blog article:
http://alien.slackbook.org/blog/kde-5_15-02-release-for-slackware-current/
I want to suggest that this bug report can be closed now that there is a
working solution.

In that same article, two other polkit files are proposed to enable the missing
shutdown/rebootfeatures without the need for removing the kwrapper5 command
from the KDE startup script /usr/bin/startkde.
For your reference, this is the content of those two files.
Note that i have altered them slightly compared to the proposals in my blog,
because I want to limit this functionality to users in the power group:

cat
/etc/polkit-1/localauthority/50-local.d/40-org.freedesktop.consolekit.system.stop-multiple-users.pkla
[Allow power users to shutdown]
Identity=unix-group:power
Action=org.freedesktop.consolekit.system.stop-multiple-users;org.freedesktop.consolekit.system.stop
ResultAny=yes
ResultInactive=no
ResultActive=yes

cat
/etc/polkit-1/localauthority/50-local.d/41-org.freedesktop.consolekit.system.restart-multiple-users.pkla
[Allow power users to restart]
Identity=unix-group:power
Action=org.freedesktop.consolekit.system.restart-multiple-users;org.freedesktop.consolekit.system.restart
ResultAny=yes
ResultInactive=no
ResultActive=yes

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 344456] Plasma 5 desktop does not suspend with only upower, no systemd

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=344456

Kai Uwe Broulik k...@privat.broulik.de changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |UPSTREAM

--- Comment #28 from Kai Uwe Broulik k...@privat.broulik.de ---
Thanks for your feedback and support!

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 344456] Plasma 5 desktop does not suspend with only upower, no systemd

[Eric Hameleers]

https://bugs.kde.org/show_bug.cgi?id=344456

--- Comment #26 from Eric Hameleers al...@slackware.com ---
Created attachment 92523
  -- https://bugs.kde.org/attachment.cgi?id=92523action=edit
Polkit configuration file for suspend/hibernate

If this file is added to /etc/polkit-1/localauthority/50-local.d/ (for instance
as 30-org.freedesktop.upower.pkla) it will enable the missing Suspend and
Hibernate options in the Plasma 5 desktop.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 344456] Plasma 5 desktop does not suspend with only upower, no systemd

[artoo]

https://bugs.kde.org/show_bug.cgi?id=344456

ar...@manjaro.org changed:

   What|Removed |Added

 CC||ar...@manjaro.org

--- Comment #25 from ar...@manjaro.org ---
Hi Eric,

the part with the missing restart/shutdown in the menu, can be also solved by
providing polkit rules for ck restart/shutdown.

Polkit rules for upower make also suspend/hibernate appear in menu.
But, I do get on gentoo the very same errors logged regarding powerdevil not
registering a ck session, thus no suspend.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 344456] Plasma 5 desktop does not suspend with only upower, no systemd

[Michael Palimaka]

https://bugs.kde.org/show_bug.cgi?id=344456

Michael Palimaka kensing...@gentoo.org changed:

   What|Removed |Added

Version|5.2.0   |5.2.2
 CC||kensing...@gentoo.org

--- Comment #20 from Michael Palimaka kensing...@gentoo.org ---
(In reply to Eric Hameleers from comment #19)
 You will get shutdown  reboot back by editing /usr/bin/startkde and
 changing the line:
 kwrapper5 ksmserver $KDEWM $KSMSERVEROPTIONS
 to
 ksmserver $KDEWM $KSMSERVEROPTIONS
 i.e. by removing the kwrapper5.

I can confirm that removing kwrapper causes shutdown/reboot entries to
reappear. It turns out that launching ksmserver with kwrapper5 causes
org.freedesktop.ConsoleKit.Manager.CanStop to return false. Not really sure
what the cause of that could be.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 344456] Plasma 5 desktop does not suspend with only upower, no systemd

[Michael Palimaka]

https://bugs.kde.org/show_bug.cgi?id=344456

--- Comment #22 from Michael Palimaka kensing...@gentoo.org ---
Created attachment 91963
  -- https://bugs.kde.org/attachment.cgi?id=91963action=edit
environment with krapper

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 344456] Plasma 5 desktop does not suspend with only upower, no systemd

[Michael Palimaka]

https://bugs.kde.org/show_bug.cgi?id=344456

--- Comment #23 from Michael Palimaka kensing...@gentoo.org ---
Created attachment 91964
  -- https://bugs.kde.org/attachment.cgi?id=91964action=edit
environment without kwrapper

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 344456] Plasma 5 desktop does not suspend with only upower, no systemd

[Michael Palimaka]

https://bugs.kde.org/show_bug.cgi?id=344456

Michael Palimaka kensing...@gentoo.org changed:

   What|Removed |Added

  Attachment #91963|environment with krapper|environment with kwrapper
description||

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 344456] Plasma 5 desktop does not suspend with only upower, no systemd

[Michael Palimaka]

https://bugs.kde.org/show_bug.cgi?id=344456

--- Comment #24 from Michael Palimaka kensing...@gentoo.org ---
Note that the environment with kwrapper is from kwrapper5 ksmserver and
ksmserver [kdeinit5] has none.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel