Re: Desktop Theme Details KCM
On Friday, August 21, 2015 09:13:11 PM Andrew Lake wrote: > My own opinion, having written the original code, is that we should simply > remove it altogether. I consider it an extreme corner case for > customization that, at best, belongs in a Plasma theme creation tool, not > system settings. > > Andrew I agree but, with the caveat that we really should look into some way to get work on a theme creator tool underfoot somehow (I have no idea what the most sensible way to do that would be) > > On Fri, Aug 21, 2015, 1:40 PM Kai Uwe Broulik wrote: > > Hi all, > > > > I was just looking at the Desktop Theme Details KCM (System Settings → > > Workspace Design → Details) and figured it's of not much use anymore. Imho > > the > > way the interaction with it worked wasn't particularly good to begin with, > > suddenly creating a "(Custom)" theme when you edited another one, but the > > one > > you selected in the list above isn't neccessarily the theme you're using, > > etc. > > > > So, let's look at the options it offers: > > > > * Color Scheme: Kinda works but given it also influences the background > > contrast, conflicts with the dialog/panel backgrounds > > * Panel background: Doesn't always work (panel stays the same somtimes) > > * Kickoff: No effect? What should it change anyway, it's up to the applet > > (it > > changes dialogs/kickoff, if that is even used anymore..) > > * Task items: Completely screws up the task manager if I touch that > > * Widget background: Seems okay > > * Translucent background: also okay > > * Dialog background: doesn't do anything > > * Analog Clock: works, seems kinda valid usecase; though all other DEs > > I've > > seen just provide that in the clock itself > > * Sticky Notes: Dunno, should work, but then I haven't seen a theme with > > different sticky notes - we still use the Oxygen ones even now :) One > > thing I > > would like to see is a default color for the notes, so a dark theme can > > have > > black notes by default > > * Tooltip: doesn't do anything > > * Pager: seems to work > > * Run dialog: Given KRunner is a regular dialog nowadays doesn't do > > anything > > * Logout dialog: Provided by LNF theme anyway > > * Icons: Kinda works, mostly seems to affect only system tray, as most > > icons > > are provided by the overall icon theme > > > > What should we do with this thing? > > > > PS: Air and even more Oxygen Plasma theme are pretty broken, we should > > either > > fix them (especially task manager, potentially revert the follow theme > > color > > stuff to provide a more 4.x-esque look) or kill them. > > ___ > > Plasma-devel mailing list > > Plasma-devel@kde.org > > https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Desktop Theme Details KCM
My own opinion, having written the original code, is that we should simply remove it altogether. I consider it an extreme corner case for customization that, at best, belongs in a Plasma theme creation tool, not system settings. Andrew On Fri, Aug 21, 2015, 1:40 PM Kai Uwe Broulik wrote: > Hi all, > > I was just looking at the Desktop Theme Details KCM (System Settings → > Workspace Design → Details) and figured it's of not much use anymore. Imho > the > way the interaction with it worked wasn't particularly good to begin with, > suddenly creating a "(Custom)" theme when you edited another one, but the > one > you selected in the list above isn't neccessarily the theme you're using, > etc. > > So, let's look at the options it offers: > > * Color Scheme: Kinda works but given it also influences the background > contrast, conflicts with the dialog/panel backgrounds > * Panel background: Doesn't always work (panel stays the same somtimes) > * Kickoff: No effect? What should it change anyway, it's up to the applet > (it > changes dialogs/kickoff, if that is even used anymore..) > * Task items: Completely screws up the task manager if I touch that > * Widget background: Seems okay > * Translucent background: also okay > * Dialog background: doesn't do anything > * Analog Clock: works, seems kinda valid usecase; though all other DEs I've > seen just provide that in the clock itself > * Sticky Notes: Dunno, should work, but then I haven't seen a theme with > different sticky notes - we still use the Oxygen ones even now :) One > thing I > would like to see is a default color for the notes, so a dark theme can > have > black notes by default > * Tooltip: doesn't do anything > * Pager: seems to work > * Run dialog: Given KRunner is a regular dialog nowadays doesn't do > anything > * Logout dialog: Provided by LNF theme anyway > * Icons: Kinda works, mostly seems to affect only system tray, as most > icons > are provided by the overall icon theme > > What should we do with this thing? > > PS: Air and even more Oxygen Plasma theme are pretty broken, we should > either > fix them (especially task manager, potentially revert the follow theme > color > stuff to provide a more 4.x-esque look) or kill them. > ___ > Plasma-devel mailing list > Plasma-devel@kde.org > https://mail.kde.org/mailman/listinfo/plasma-devel > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Desktop Theme Details kcm in kdereview
> From: Aaron J. Seigo <[EMAIL PROTECTED]> > On Saturday 11 October 2008, Jamboarder wrote: > > Converted this to a kcm as suggested. Allows user to > change individual > > cool; is it in playground? I actually put it in kdereview/plasma/tools/desktopthemedetails. Should I have put this in playground first? > > > patch is fine ... Patch committed. Let me know if there are any questions, Andrew ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Desktop Theme Details kcm in kdereview
On Saturday 11 October 2008, Jamboarder wrote: > Converted this to a kcm as suggested. Allows user to change individual cool; is it in playground? > Export theme button doesn't do anything yet, but most of the code is in > place. A DBUS interface to directly change the theme would be nice, but > I'm content to leave this as is until/if that becomes available. we need both a dbus interface for this in both plasma and krunner so that a change in one will end up being reflected in the other. it's probably enough to allow changing the theme in plasma, and then either have plasma contact krunner directly or emit a d-bus signal chich krunner listens to. > The attached diff is a one line patch for > workspace/plasma/shells/desktop/backgrounddialog.cpp to refresh the theme > selection droplist in Desktop Settings each time the dialog is opened. > This is necessary to show the customized theme created by the kcm. Let me > know if it's ok and I'll commit this patch. patch is fine ... -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Software signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel