Re: Firefox Bookmark runner

2009-11-12 Thread Aaron J. Seigo
On November 12, 2009, Marco Martin wrote:
> -the nepomuk runner excludes bookmarks, or

that really seems to me to be the most sensible thing to do. a "nepomuk 
runner" shouldn't return every imaginable thing stored in nepomuk, but should 
probably be focused by topic, much like every other runner currently is.

this assumes that nepomuk itself can gracefully handle multiple concurrent 
queries.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Firefox Bookmark runner

2009-11-12 Thread Marco Martin
On Thursday 12 November 2009, Eduardo Robles Elvira wrote:
> On Mon, Nov 2, 2009 at 9:50 PM, Aaron J. Seigo  wrote:
> > On November 2, 2009, Eduardo Robles Elvira wrote:
> >> http://github.com/edulix/gsoc/blob/master/kdebase-bookmarks.patch,
> >> take a look only at the workspace/plasma part of it). In case this new
> >> bookmarks system ships in, I don't know if mixing the firefox and
> >> konqueror bookmarks in nepomuk runner would be a good idea? What could
> >> be the best way in that case?
> >
> > the nice thing about having the Bookmarks as a separate runner is that we
> > can get those returns quicker or slower than other data sets as they get
> > their own thread to run in AND people can turn off Bookmarks searching
> > easier when it's a separate plugin.
> >
> > so my question is whether the Nepomuk search runner should really be
> > confined to "just" files on disk and other queries for things like
> > Bookmarks be added to separate runners (like the existing Bookmarks
> > runner)?
> 
> Hi people,
> 
> Now, thinking about this again, I wonder: lets say that in the near
> future, konqueror bookmarks are directly stored in Nepomuk (which
> quite possible). If we put bookmarks in a separate runner.. then both
> the Nepomuk runner and the Bookmarks runner will return the same
> entries when searching for a given bookmark. How could we deal with
> these duplicated entries?

hmm, thinking about it..
-an unique id for a result, regardlessof the runer that owns it (would it 
feasible? would depend from what rhe result does for  run()) so the results 
could be filtered
or more simply,
-the nepomuk runner excludes bookmarks, or
-if the bookmarks runner knows somehow that the default browser stores 
bookmarks in nepomuk and the nepomuk runer is enabled, it doesn't search, so 
needs a way to define exclusions for runenrs

Cheers,
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Firefox Bookmark runner

2009-11-12 Thread Eduardo Robles Elvira
On Mon, Nov 2, 2009 at 9:50 PM, Aaron J. Seigo  wrote:
> On November 2, 2009, Eduardo Robles Elvira wrote:
>> http://github.com/edulix/gsoc/blob/master/kdebase-bookmarks.patch,
>> take a look only at the workspace/plasma part of it). In case this new
>> bookmarks system ships in, I don't know if mixing the firefox and
>> konqueror bookmarks in nepomuk runner would be a good idea? What could
>> be the best way in that case?
>
> the nice thing about having the Bookmarks as a separate runner is that we can
> get those returns quicker or slower than other data sets as they get their own
> thread to run in AND people can turn off Bookmarks searching easier when it's
> a separate plugin.
>
> so my question is whether the Nepomuk search runner should really be confined
> to "just" files on disk and other queries for things like Bookmarks be added
> to separate runners (like the existing Bookmarks runner)?

Hi people,

Now, thinking about this again, I wonder: lets say that in the near
future, konqueror bookmarks are directly stored in Nepomuk (which
quite possible). If we put bookmarks in a separate runner.. then both
the Nepomuk runner and the Bookmarks runner will return the same
entries when searching for a given bookmark. How could we deal with
these duplicated entries?

Regards,
   Eduardo Robles Elvira.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Firefox Bookmark runner

2009-11-04 Thread Aaron J. Seigo
On November 4, 2009, Qwerty Maniac wrote:
> kreadconfig --file kdeglobals --group General --key BrowserApplication

yes, that works on the command line; in c++:

KConfigGroup generalGroup(KGlobal::config(), "General");
const QString browser = generalGroup.readEntry("BrowserApplication", 
QString());

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Firefox Bookmark runner

2009-11-04 Thread Qwerty Maniac
On Thu, Nov 5, 2009 at 1:21 AM, Jan Gerrit Marker
 wrote:
> Hello,
> The next questions:
> 1) Where should I copy Firefox's database file? I think somewhere to a cache
> directory, but I haven't got any idea, how to get a filepath or how to do this
> exactly.
> 2) How do I get the default browser?

I perform this command to get the browser string:
kreadconfig --file kdeglobals --group General --key BrowserApplication

>
> Thanks, Jan
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>



-- 
Harsh J
www.harshj.com
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Firefox Bookmark runner

2009-11-04 Thread Aaron J. Seigo
On November 4, 2009, Jan Gerrit Marker wrote:
> 1) Where should I copy Firefox's database file? I think somewhere to a
>  cache directory, but I haven't got any idea, how to get a filepath or how
>  to do this exactly.

KGlobal::dirs()->locateLocale("cache", filename);

or you could use a KTempFile ...

> 2) How do I get the default browser?

looking at 
kdebase/runtime/kcontrol/componentchooser/componentchooserbrowser.cpp it's 
apparently in kdeglobals' [General] group as BrowserApplication=

looking at krun.cpp there doesn't seem to be any convenience API for that.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Firefox Bookmark runner

2009-11-04 Thread Jan Gerrit Marker
Hello,
The next questions:
1) Where should I copy Firefox's database file? I think somewhere to a cache 
directory, but I haven't got any idea, how to get a filepath or how to do this 
exactly.
2) How do I get the default browser?

Thanks, Jan
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Firefox Bookmark runner

2009-11-03 Thread Jan Gerrit Marker
Am Dienstag 03 November 2009 21:12:23 schrieb Aaron J. Seigo:
> On November 3, 2009, Jan Gerrit Marker wrote:
> > Am Montag 02 November 2009 14:48:27 schrieb Sebastian Kügler:
> > > If you've questions, you can just ask here
> >
> > And asking starts...
> > Should the runner get the browser in the constructor or the match()
> > method?
> 
> in a slot connected to prepare()
> 
Ok, damn, I didn't think of that :( sorry
Thanks for the answer :)
-- 
Jan Gerrit Marker (jangmarker)
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Firefox Bookmark runner

2009-11-03 Thread Aaron J. Seigo
On November 3, 2009, Jan Gerrit Marker wrote:
> Ok, damn, I didn't think of that :( sorry
> Thanks for the answer :)

np, it's exactly why we have a mailing list and a whole bunch of crazy and/or 
smart people on it right? :)

looking forward to seeing the bookmark runner kicking it up a notch in 4.4 :)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Firefox Bookmark runner

2009-11-03 Thread Jan Gerrit Marker
Am Montag 02 November 2009 14:48:27 schrieb Sebastian Kügler:
> If you've questions, you can just ask here
And asking starts...
Should the runner get the browser in the constructor or the match() method?
Some information about it:
I store the QSqlDatabase in a variable m_db because this way I check for the 
driver and load the database only in the constructor. The database is opened 
and closed after the prepare()/teardown() signal is emitted (the database will 
be copyed if the prepare() signal is emitted). If I would get the browser in 
the constructor I wouldn't have to initialise the database if it isn't needed 
but then the runner needs to be "restarted" to get the right browser 
information. If I initialise it in the match() method I would need m_db 
because the database file would only be used in the match() method.

Thanks for comments,
-- 
Jan Gerrit Marker (jangmarker)
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Firefox Bookmark runner

2009-11-03 Thread Aaron J. Seigo
On November 3, 2009, Jan Gerrit Marker wrote:
> Am Montag 02 November 2009 14:48:27 schrieb Sebastian Kügler:
> > If you've questions, you can just ask here
> 
> And asking starts...
> Should the runner get the browser in the constructor or the match() method?

in a slot connected to prepare()

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Firefox Bookmark runner

2009-11-02 Thread Aaron J. Seigo
On November 2, 2009, Eduardo Robles Elvira wrote:
> http://github.com/edulix/gsoc/blob/master/kdebase-bookmarks.patch,
> take a look only at the workspace/plasma part of it). In case this new
> bookmarks system ships in, I don't know if mixing the firefox and
> konqueror bookmarks in nepomuk runner would be a good idea? What could
> be the best way in that case?

the nice thing about having the Bookmarks as a separate runner is that we can 
get those returns quicker or slower than other data sets as they get their own 
thread to run in AND people can turn off Bookmarks searching easier when it's 
a separate plugin.

so my question is whether the Nepomuk search runner should really be confined 
to "just" files on disk and other queries for things like Bookmarks be added 
to separate runners (like the existing Bookmarks runner)?

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Firefox Bookmark runner

2009-11-02 Thread Sebastian Kügler
On Monday 02 November 2009 13:53:35 Sebastian Kügler wrote:
> On Monday 02 November 2009 13:24:03 Jan Gerrit Marker wrote:
> > Am Montag 02 November 2009 10:24:05 schrieb Marco Martin:
> > > hmm, not sure if having something installed by default specific for
> > > firefox would be a soo good idea, what would be cool is having a single
> > > bookmark runner that would search in firefox if it's the default
> > > browser otherwise in konqueror as usual.
> > > would it have a too convoluted logic?
> >
> > 
> > You could have two methods:
> > QList firefoxBookmarks(QString& term);
> > QList konquerorBookmarks(QString& term);
> > 
> > The match Method tests if Firefox or Konqueror should be asked for
> >  bookmark  information and runs the methods. Then it calls
> >  context.addMatches() and adds the matches it got from the method.
> > 
> > But the idea of a single bookmark runner is good. That would be much
> >  easier.
> 
> I (as the original developer of the konqi bookmark runner) think it's a
>  good idea.

Just occurred to me that this isn't true. :D

I've been doing the history runner, not the bookmarks one (but touched the code 
at 
some point, IIRC).
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Firefox Bookmark runner

2009-11-02 Thread Will Stephenson
On Monday 02 November 2009 15:53:24 Eduardo Robles Elvira wrote:
> BTW, I'm working on the new konqueror bookmarks system. I'm not sure
> if it will be finally in KDE 4.4 because it still needs some work. In
> this bookmarks system, bookmarks are going to be stored in Nepomuk.
> Hence, I have a patch for the Nepomuk search runner that modifies it
> to show the bookmarks results a bit better (patch available in
> http://github.com/edulix/gsoc/blob/master/kdebase-bookmarks.patch,
> take a look only at the workspace/plasma part of it). In case this new
> bookmarks system ships in, I don't know if mixing the firefox and
> konqueror bookmarks in nepomuk runner would be a good idea? What could
> be the best way in that case?

Possibly just watching the FF bookmarks file and copying them into Nepomuk. 
This is effectively what Zeitgeist does with web browsing history- it has its 
own metadata database but they are talking about merging it with Tracker.  Of 
course watching the file, copying and reading it is inefficient.  Maybe the 
best way is to do this directly in FF with a FF KDE helper, as we use for the 
FF KDE file dialog integration in openSUSE.

Will
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Firefox Bookmark runner

2009-11-02 Thread Sebastian Kügler
On Monday 02 November 2009 15:02:30 Jan Gerrit Marker wrote:
> Am Montag 02 November 2009 14:48:27 schrieb Sebastian Kügler:
> > No problem. You can just make the changes to the runner (and possibly
> > give it a more generic name). If you got it working, post the patch to
> > reviewboard. Assuming it's OK, we'll merge it.
> 
> I think the right runner is this one:
> KDE/kdebase/workspace/plasma/generic/runners/bookmarks ?
> As far as I can see, it has got the name "Bookmarks", this one should be
>  ok. I would change Konqueror specific texts to "web browser" and that
>  should be enough.

Yep, that's what I can think of as well.

> > Since soft feature freeze is looming, if you intend to merge it after
> >  November 4th (likely), please add it to the feature plan on
> > http://techbase.kde.org/Schedules/KDE4/4.4_Feature_Plan
> 
> After getting an account I added it to the section KRunner in kdebase-
> workspace. I hope that's ok.

Perfect :)
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Firefox Bookmark runner

2009-11-02 Thread Eduardo Robles Elvira
On Mon, Nov 2, 2009 at 3:02 PM, Jan Gerrit Marker
 wrote:
> Am Montag 02 November 2009 14:48:27 schrieb Sebastian Kügler:
>> No problem. You can just make the changes to the runner (and possibly give
>>  it a more generic name). If you got it working, post the patch to
>>  reviewboard. Assuming it's OK, we'll merge it.
> I think the right runner is this one:
> KDE/kdebase/workspace/plasma/generic/runners/bookmarks ?
> As far as I can see, it has got the name "Bookmarks", this one should be ok. I
> would change Konqueror specific texts to "web browser" and that should be
> enough.
>> Since soft feature freeze is looming, if you intend to merge it after
>>  November 4th (likely), please add it to the feature plan on
>> http://techbase.kde.org/Schedules/KDE4/4.4_Feature_Plan
> After getting an account I added it to the section KRunner in kdebase-
> workspace. I hope that's ok.
>
> Thanks, Jan

BTW, I'm working on the new konqueror bookmarks system. I'm not sure
if it will be finally in KDE 4.4 because it still needs some work. In
this bookmarks system, bookmarks are going to be stored in Nepomuk.
Hence, I have a patch for the Nepomuk search runner that modifies it
to show the bookmarks results a bit better (patch available in
http://github.com/edulix/gsoc/blob/master/kdebase-bookmarks.patch,
take a look only at the workspace/plasma part of it). In case this new
bookmarks system ships in, I don't know if mixing the firefox and
konqueror bookmarks in nepomuk runner would be a good idea? What could
be the best way in that case?

Regards,
   Eduardo
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Firefox Bookmark runner

2009-11-02 Thread Jan Gerrit Marker
Am Montag 02 November 2009 14:48:27 schrieb Sebastian Kügler:
> No problem. You can just make the changes to the runner (and possibly give
>  it a more generic name). If you got it working, post the patch to
>  reviewboard. Assuming it's OK, we'll merge it.
I think the right runner is this one:
KDE/kdebase/workspace/plasma/generic/runners/bookmarks ?
As far as I can see, it has got the name "Bookmarks", this one should be ok. I 
would change Konqueror specific texts to "web browser" and that should be 
enough.
> Since soft feature freeze is looming, if you intend to merge it after
>  November 4th (likely), please add it to the feature plan on
> http://techbase.kde.org/Schedules/KDE4/4.4_Feature_Plan
After getting an account I added it to the section KRunner in kdebase-
workspace. I hope that's ok.

Thanks, Jan
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Firefox Bookmark runner

2009-11-02 Thread Sebastian Kügler
On Monday 02 November 2009 14:05:39 Jan Gerrit Marker wrote:
> Am Montag 02 November 2009 13:53:35 schrieb Sebastian Kügler:
> > > You could have two methods:
> > > QList firefoxBookmarks(QString& term);
> > > QList konquerorBookmarks(QString& term);
> > >
> > > The match Method tests if Firefox or Konqueror should be asked for
> > >  bookmark  information and runs the methods. Then it calls
> > >  context.addMatches() and adds the matches it got from the method.
> > >
> > > But the idea of a single bookmark runner is good. That would be much
> > >  easier.
> >
> > 
> > I (as the original developer of the konqi bookmark runner) think it's a
> >  good idea.
> > 
> 
> Oh, didn't know that you are the developer.
> In this case, are you ok with the way is suggested?
> How should we merge them? And when? (My time as KDE developer isn't that 
> long...)

No problem. You can just make the changes to the runner (and possibly give it a 
more 
generic name). If you got it working, post the patch to reviewboard. Assuming 
it's 
OK, we'll merge it.

Since soft feature freeze is looming, if you intend to merge it after November 
4th 
(likely), please add it to the feature plan on 
http://techbase.kde.org/Schedules/KDE4/4.4_Feature_Plan

If you've questions, you can just ask here.

Cheers,
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Firefox Bookmark runner

2009-11-02 Thread Jan Gerrit Marker
Am Montag 02 November 2009 13:53:35 schrieb Sebastian Kügler:
> > You could have two methods:
> > QList firefoxBookmarks(QString& term);
> > QList konquerorBookmarks(QString& term);
> >
> > The match Method tests if Firefox or Konqueror should be asked for
> >  bookmark  information and runs the methods. Then it calls
> >  context.addMatches() and adds the matches it got from the method.
> >
> > But the idea of a single bookmark runner is good. That would be much
> >  easier.
> 
> I (as the original developer of the konqi bookmark runner) think it's a
>  good idea.
> 
Oh, didn't know that you are the developer.
In this case, are you ok with the way is suggested?
How should we merge them? And when? (My time as KDE developer isn't that 
long...)

Thanks, Jan
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Firefox Bookmark runner

2009-11-02 Thread Sebastian Kügler
On Monday 02 November 2009 13:24:03 Jan Gerrit Marker wrote:
> Am Montag 02 November 2009 10:24:05 schrieb Marco Martin:
> > hmm, not sure if having something installed by default specific for
> > firefox would be a soo good idea, what would be cool is having a single
> > bookmark runner that would search in firefox if it's the default browser
> > otherwise in konqueror as usual.
> > would it have a too convoluted logic?
> 
> You could have two methods:
> QList firefoxBookmarks(QString& term);
> QList konquerorBookmarks(QString& term);
> 
> The match Method tests if Firefox or Konqueror should be asked for
>  bookmark  information and runs the methods. Then it calls
>  context.addMatches() and adds the matches it got from the method.
> 
> But the idea of a single bookmark runner is good. That would be much
>  easier.

I (as the original developer of the konqi bookmark runner) think it's a good 
idea.
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Firefox Bookmark runner

2009-11-02 Thread Jan Gerrit Marker
Am Montag 02 November 2009 12:06:29 schrieb Sebastian Kügler:
> On Monday 02 November 2009 11:38:57 Will Stephenson wrote:
> > On Sunday 01 November 2009 22:49:04 Eduardo Robles Elvira wrote:
> > > I have some questions about the runner. It seems to access to firefox
> > > places sqlite database. What happens if (much likely if you use this
> > > runner) firefox is running and thus also connected to the sqlite
> > > database, can't the database get corrupted? AFAIK sqlite does not run
> > > as external server process to which the applications can connect to,
> > > so both the runner and firefox would be accessing to the database at
> > > the same time, and that seems to ask for data corruption. I might be
> > > talking shit because I don't much about sqlite, so please enlighten
> > > me.
> >
> > Zeitgeist (for gnome) work by accessing Firefox' sqlite databases, and
> >  does  this apparently safely by taking a copy of the file before reading
> >  it.  No guarantee if this is right, I may be talking somebody else's
> > shit too.
> 
> That's probably good enough for reading, writing won't work this way...
> 
To be honest: I didn't think of data corruption, sorry :(
The tests I did didn't show anything like this, but that says nothing.
As said, I could copy the database file if the prepare signal is emitted.

-- 
Jan Gerrit Marker (jangmarker)
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Firefox Bookmark runner

2009-11-02 Thread Jan Gerrit Marker
Am Montag 02 November 2009 10:24:05 schrieb Marco Martin:
> hmm, not sure if having something installed by default specific for firefox
> would be a soo good idea, what would be cool is having a single bookmark
> runner that would search in firefox if it's the default browser otherwise
>  in konqueror as usual.
> would it have a too convoluted logic?
You could have two methods:
QList firefoxBookmarks(QString& term);
QList konquerorBookmarks(QString& term);

The match Method tests if Firefox or Konqueror should be asked for bookmark 
information and runs the methods. Then it calls context.addMatches() and adds 
the matches it got from the method.

But the idea of a single bookmark runner is good. That would be much easier.
-- 
Jan Gerrit Marker (jangmarker)
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Firefox Bookmark runner

2009-11-02 Thread Sebastian Kügler
On Monday 02 November 2009 11:38:57 Will Stephenson wrote:
> On Sunday 01 November 2009 22:49:04 Eduardo Robles Elvira wrote:
> > I have some questions about the runner. It seems to access to firefox
> > places sqlite database. What happens if (much likely if you use this
> > runner) firefox is running and thus also connected to the sqlite
> > database, can't the database get corrupted? AFAIK sqlite does not run
> > as external server process to which the applications can connect to,
> > so both the runner and firefox would be accessing to the database at
> > the same time, and that seems to ask for data corruption. I might be
> > talking shit because I don't much about sqlite, so please enlighten
> > me.
> 
> Zeitgeist (for gnome) work by accessing Firefox' sqlite databases, and
>  does  this apparently safely by taking a copy of the file before reading
>  it.  No guarantee if this is right, I may be talking somebody else's shit
>  too.

That's probably good enough for reading, writing won't work this way...
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Firefox Bookmark runner

2009-11-02 Thread Will Stephenson
On Sunday 01 November 2009 22:49:04 Eduardo Robles Elvira wrote:
> I have some questions about the runner. It seems to access to firefox
> places sqlite database. What happens if (much likely if you use this
> runner) firefox is running and thus also connected to the sqlite
> database, can't the database get corrupted? AFAIK sqlite does not run
> as external server process to which the applications can connect to,
> so both the runner and firefox would be accessing to the database at
> the same time, and that seems to ask for data corruption. I might be
> talking shit because I don't much about sqlite, so please enlighten
> me.

Zeitgeist (for gnome) work by accessing Firefox' sqlite databases, and does 
this apparently safely by taking a copy of the file before reading it.  No 
guarantee if this is right, I may be talking somebody else's shit too.

Will

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Firefox Bookmark runner

2009-11-02 Thread Marco Martin
On Sunday 01 November 2009, Jan Gerrit Marker wrote:
> Hello,
> today I moved a runner called "Firefox Bookmarks" to playground. This
>  runner allows you to search through the bookmarks of the default Firefox
>  profile. In order to get enough time to add it to KDE 4.4 I want to add it
>  to the feature plan.
> Is the runner ok?
> Is it ok, if I add it to the feature plan (or maybe someone adds it for me,
> because I haven't got a techbase account, yet?)?
> 
hmm, not sure if having something installed by default specific for firefox 
would be a soo good idea, what would be cool is having a single bookmark 
runner that would search in firefox if it's the default browser otherwise in 
konqueror as usual.
would it have a too convoluted logic?

Cheers,
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Firefox Bookmark runner

2009-11-01 Thread Eduardo Robles Elvira
On Sun, Nov 1, 2009 at 11:33 AM, Jan Gerrit Marker
 wrote:
> Hello,
> today I moved a runner called "Firefox Bookmarks" to playground. This runner
> allows you to search through the bookmarks of the default Firefox profile. In
> order to get enough time to add it to KDE 4.4 I want to add it to the feature
> plan.
> Is the runner ok?
> Is it ok, if I add it to the feature plan (or maybe someone adds it for me,
> because I haven't got a techbase account, yet?)?

Hello!

I have some questions about the runner. It seems to access to firefox
places sqlite database. What happens if (much likely if you use this
runner) firefox is running and thus also connected to the sqlite
database, can't the database get corrupted? AFAIK sqlite does not run
as external server process to which the applications can connect to,
so both the runner and firefox would be accessing to the database at
the same time, and that seems to ask for data corruption. I might be
talking shit because I don't much about sqlite, so please enlighten
me.

If this way of accessing to firefox bookmarks is viable, I wonder if
this also allows us to modify the database. I'm implementing new
konqueror bookmarks using akonadi, and if the answer is yes we could
sync konqueror and firefox bookmarks this way.

Thanks for your time,
Eduardo Robles Elvira.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel