Re: Plasma 5.7.0 tars

[Harald Sitter]

On Mon, Jul 4, 2016 at 2:29 PM, David Edmundson
 wrote:
>
>
> On Mon, Jul 4, 2016 at 1:20 PM, Sebastian Kügler  wrote:
>>
>> On Thursday, June 30, 2016 11:06:46 PM CEST Harald Sitter wrote:
>> > On Thu, Jun 30, 2016 at 4:45 PM, David Edmundson
>> >
>> >  wrote:
>> > > *sigh* seems so. Yet plasma-workspace is from the right branch and
>> > > it's
>> > > done by an automated script(!)
>> >
>> > Haven't we fixed that for beta already?
>>
> It was the cached kde_projects.xml that you fixed for the beta
> I hadn't pulled your changes as I needed some of my other local mods to get
> round some hardcoded paths. So partly my fault - though I still think it's
> very broken that we get version information from two different sources
> within the same script.

Yes. I mean no. I am confused.
If the projects.xml says that the stable branch of libkscreen is
Plasma/5.6 we can't simply override that on the release side of
things, l10n would still be generated from the wrong branch so you'd
misalign translations and source. That said, one could do a
consistency enforcement by failing if one of the things in a 'set'
(e.g. kde/workspace) is not in line with the rest.
BUT the plasma bash hell on top of releaseme bypasses most smarts of
releaseme todo with projects processing. In this particular case the
fact that releaseme can release a set (e.g kde/workspace) and handle
it as a 'set' is bypassed by the bash scripts wanting to decide what
to release and then calling tarme in a loop for each project.

So, assuming that is actually a smart way to do it (which it isn't
since it replicates information from projects.xml and allows for
additional human error and makes tarball creation slower), the bash
script would have to check consistency of the output coming out of
tarme (namely the release_data) and make sure that everything is using
the same branch.

HS
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma 5.7.0 tars

[Sebastian Kügler]

On Monday, July 4, 2016 1:59:41 PM CEST David Edmundson wrote:
> I meant "if we accidentally released libkscreen 5.6" as "libkscreen 5.7
> beta", please tell me.
> 
> We didn't.

Ok, good. Thanks for checking!
-- 
sebas

http://www.kde.org | http://vizZzion.org
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma 5.7.0 tars

[David Edmundson]

On Mon, Jul 4, 2016 at 1:45 PM, Sebastian Kügler  wrote:

> On Monday, July 4, 2016 1:29:55 PM CEST David Edmundson wrote:
> > ... and if not, I need to know, because that means that
> >
> > - nobody tested the changes in libkscreen's master in the beta
> > - the test reports that I did get from the beta are meaningless (which
> could
> > be a good thing ;))
> >
> > Could you check?
> >
> > I don't know what you mean, but the tarballs that are up are fine.
>
> I meant "if we accidentally released libkscreen 5.6" as "libkscreen 5.7
> beta",
> please tell me.
>

We didn't.

David



> --
> sebas
>
> http://www.kde.org | http://vizZzion.org
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma 5.7.0 tars

[Sebastian Kügler]

On Monday, July 4, 2016 1:29:55 PM CEST David Edmundson wrote:
> ... and if not, I need to know, because that means that
> 
> - nobody tested the changes in libkscreen's master in the beta
> - the test reports that I did get from the beta are meaningless (which could
> be a good thing ;))
> 
> Could you check?
> 
> I don't know what you mean, but the tarballs that are up are fine.

I meant "if we accidentally released libkscreen 5.6" as "libkscreen 5.7 beta", 
please tell me.
-- 
sebas

http://www.kde.org | http://vizZzion.org
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma 5.7.0 tars

[David Edmundson]

On Mon, Jul 4, 2016 at 1:20 PM, Sebastian Kügler  wrote:

> On Thursday, June 30, 2016 11:06:46 PM CEST Harald Sitter wrote:
> > On Thu, Jun 30, 2016 at 4:45 PM, David Edmundson
> >
> >  wrote:
> > > *sigh* seems so. Yet plasma-workspace is from the right branch and it's
> > > done by an automated script(!)
> >
> > Haven't we fixed that for beta already?
>
> It was the cached kde_projects.xml that you fixed for the beta
I hadn't pulled your changes as I needed some of my other local mods to get
round some hardcoded paths. So partly my fault - though I still think it's
very broken that we get version information from two different sources
within the same script.


> ... and if not, I need to know, because that means that
>
> - nobody tested the changes in libkscreen's master in the beta
> - the test reports that I did get from the beta are meaningless (which
> could
>   be a good thing ;))
>
> Could you check?
>

I don't know what you mean, but the tarballs that are up are fine.

David
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma 5.7.0 tars

[Sebastian Kügler]

On Thursday, June 30, 2016 11:06:46 PM CEST Harald Sitter wrote:
> On Thu, Jun 30, 2016 at 4:45 PM, David Edmundson
> 
>  wrote:
> > *sigh* seems so. Yet plasma-workspace is from the right branch and it's
> > done by an automated script(!)
> 
> Haven't we fixed that for beta already?

... and if not, I need to know, because that means that

- nobody tested the changes in libkscreen's master in the beta
- the test reports that I did get from the beta are meaningless (which could 
  be a good thing ;))

Could you check?
-- 
sebas

http://www.kde.org | http://vizZzion.org
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma 5.7.0 tars

[Eric Hameleers]

On Thu, 30 Jun 2016, David Edmundson wrote:


Fixed - and checked a bit more thorougly this time.
Thanks again.

David


I have two compile errors in plasma-desktop which were not there when 
I built the 5.6.95 tarballs:


...
[ 93%] Building CXX object 
applets/trash/plugin/CMakeFiles/trashplugin.dir/trash

plugin.cpp.o
[ 93%] Building CXX object 
applets/pager/CMakeFiles/pagerplugin.dir/plugin/pager

.cpp.o
[ 93%] Building CXX object 
containments/desktop/plugins/desktop/CMakeFiles/desktopplugin.dir/systemsettings.cpp.o

/tmp/kde-build/plasma/plasma-desktop-5.7.0/applets/pager/plugin/pager.cpp:52:18:
 fatal error: task.h: No such file or directory
compilation terminated.
applets/pager/CMakeFiles/pagerplugin.dir/build.make:86: recipe for 
target 'applets/pager/CMakeFiles/pagerplugin.dir/plugin/pager.cpp.o' failed
make[2]: *** 
[applets/pager/CMakeFiles/pagerplugin.dir/plugin/pager.cpp.o] Error 1
CMakeFiles/Makefile2:7980: recipe for target 
'applets/pager/CMakeFiles/pagerplugin.dir/all' failed

make[1]: *** [applets/pager/CMakeFiles/pagerplugin.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs
[ 93%] Building CXX object 
containments/desktop/plugins/desktop/CMakeFiles/desktopplugin.dir/desktopplugin_automoc.cpp.o
[ 93%] Building CXX object 
applets/trash/plugin/CMakeFiles/trashplugin.dir/trashplugin_automoc.cpp.o

...


and later:

...
[ 88%] Building CXX object 
applets/taskmanager/CMakeFiles/taskmanagerplugin.dir/

plugin/backend.cpp.o
In file included from 
/tmp/kde-build/plasma/plasma-desktop-5.7.0/applets/taskmanager/plugin/backend.cpp:22:0:

/tmp/kde-build/plasma/plasma-desktop-5.7.0/applets/taskmanager/plugin/backend.h:
26:26: fatal error: groupmanager.h: No such file or directory
compilation terminated.
applets/taskmanager/CMakeFiles/taskmanagerplugin.dir/build.make:62: 
recipe for target 
'applets/taskmanager/CMakeFiles/taskmanagerplugin.dir/plugin/backend.cpp.o

' failed
make[2]: *** 
[applets/taskmanager/CMakeFiles/taskmanagerplugin.dir/plugin/backend.cpp.o] 
Error 1
CMakeFiles/Makefile2:7874: recipe for target 
'applets/taskmanager/CMakeFiles/taskmanagerplugin.dir/all' failed
make[1]: *** 
[applets/taskmanager/CMakeFiles/taskmanagerplugin.dir/all] Error 2

Makefile:127: recipe for target 'all' failed
make: *** [all] Error 2

What's up?

Cheers, Eric

--
Eric Hameleers 
Home: http://alien.slackbook.org/blog/
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma 5.7.0 tars

[Harald Sitter]

On Thu, Jun 30, 2016 at 4:45 PM, David Edmundson
 wrote:
> *sigh* seems so. Yet plasma-workspace is from the right branch and it's done
> by an automated script(!)

Haven't we fixed that for beta already?
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma 5.7.0 tars

[David Edmundson]

Fixed - and checked a bit more thorougly this time.
Thanks again.

David
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma 5.7.0 tars

[David Edmundson]

*sigh* seems so. Yet plasma-workspace is from the right branch and it's
done by an automated script(!)
Thanks for spotting

David
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma 5.7.0 tars

[šumski]

On Thursday 30 of June 2016 16:14:18 David Edmundson wrote:
> Plasma 5.7 tars are up on depot for packagers
> 
> Release is due on Tuesday.
> 
> David
 At least libkscreen and plasma-nm seem to come from Plasma/5.6 branch...

Cheers,
Hrvoje
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel