Re: Review Request: [Patch 2/2] Fix Sliding Popups
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103367/#review8864 --- This review has been submitted with commit cbdd7295d100b19ec55d4b88f2a8113095439e26 by Martin Gräßlin to branch master. - Commit Hook On Dec. 10, 2011, 11:39 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103367/ > --- > > (Updated Dec. 10, 2011, 11:39 a.m.) > > > Review request for kwin and Plasma. > > > Description > --- > > Rework of sliding popups effect based on change to use "-1" as a default > offset. The animation is now calculated correctly (wasn't the case before) > and clipping is working again as the window quads are filtered out. > > As a side note: I think we can now even try to apply blur behind the window > during the animation. I think that all tries before failed due to the fact > that we just calculated everything in the wrong way. > > > This addresses bug 287602. > http://bugs.kde.org/show_bug.cgi?id=287602 > > > Diffs > - > > kwin/effects/slidingpopups/slidingpopups.cpp 1065bfc > > Diff: http://git.reviewboard.kde.org/r/103367/diff/diff > > > Testing > --- > > yes, works for a panel on all possible corners (including panel between > screens). Nevertheless please all try this patch. > > > Thanks, > > Martin Gräßlin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: [Patch 2/2] Fix Sliding Popups
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103367/#review8850 --- Ship it! Works for yakuake, no glitch Plasma certainly requires the other patch applied (the extender thingies aren't catched at all here) - Thomas Lübking On Dec. 10, 2011, 11:39 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103367/ > --- > > (Updated Dec. 10, 2011, 11:39 a.m.) > > > Review request for kwin and Plasma. > > > Description > --- > > Rework of sliding popups effect based on change to use "-1" as a default > offset. The animation is now calculated correctly (wasn't the case before) > and clipping is working again as the window quads are filtered out. > > As a side note: I think we can now even try to apply blur behind the window > during the animation. I think that all tries before failed due to the fact > that we just calculated everything in the wrong way. > > > This addresses bug 287602. > http://bugs.kde.org/show_bug.cgi?id=287602 > > > Diffs > - > > kwin/effects/slidingpopups/slidingpopups.cpp 1065bfc > > Diff: http://git.reviewboard.kde.org/r/103367/diff/diff > > > Testing > --- > > yes, works for a panel on all possible corners (including panel between > screens). Nevertheless please all try this patch. > > > Thanks, > > Martin Gräßlin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: [Patch 2/2] Fix Sliding Popups
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103367/ --- (Updated Dec. 10, 2011, 11:39 a.m.) Review request for kwin and Plasma. Changes --- wrong bug number Description --- Rework of sliding popups effect based on change to use "-1" as a default offset. The animation is now calculated correctly (wasn't the case before) and clipping is working again as the window quads are filtered out. As a side note: I think we can now even try to apply blur behind the window during the animation. I think that all tries before failed due to the fact that we just calculated everything in the wrong way. This addresses bug 287602. http://bugs.kde.org/show_bug.cgi?id=287602 Diffs - kwin/effects/slidingpopups/slidingpopups.cpp 1065bfc Diff: http://git.reviewboard.kde.org/r/103367/diff/diff Testing --- yes, works for a panel on all possible corners (including panel between screens). Nevertheless please all try this patch. Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: [Patch 2/2] Fix Sliding Popups
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103367/ --- (Updated Dec. 10, 2011, 7:59 a.m.) Review request for kwin and Plasma. Changes --- sanitize the offset to a reasonable value. Fixes the artifacts in Yakuake case as well as finally fixes the jump of Yakuake in the last frame of the animation if there is a top panel. Only tested on North location as Yakuake does not want to slide from other edges. Description --- Rework of sliding popups effect based on change to use "-1" as a default offset. The animation is now calculated correctly (wasn't the case before) and clipping is working again as the window quads are filtered out. As a side note: I think we can now even try to apply blur behind the window during the animation. I think that all tries before failed due to the fact that we just calculated everything in the wrong way. This addresses bug 288568. http://bugs.kde.org/show_bug.cgi?id=288568 Diffs (updated) - kwin/effects/slidingpopups/slidingpopups.cpp 1065bfc Diff: http://git.reviewboard.kde.org/r/103367/diff/diff Testing --- yes, works for a panel on all possible corners (including panel between screens). Nevertheless please all try this patch. Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: [Patch 2/2] Fix Sliding Popups
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103367/#review8832 --- Not applied the other patch, but at least with yakuake (not using libplasma - property is 0,1,300,300) I get occasional artefacts under panels (ARGB or RGB+window opacity) - sometimes the first, sometimes the second last frame. If there's another window under the panel, usually the artefacts are _above_ the panel. Otherwise below. This is NOT related to blurring, and yes: i've even completely disabled the generic effects before ;-) - Thomas Lübking On Dec. 9, 2011, 5:35 p.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103367/ > --- > > (Updated Dec. 9, 2011, 5:35 p.m.) > > > Review request for kwin and Plasma. > > > Description > --- > > Rework of sliding popups effect based on change to use "-1" as a default > offset. The animation is now calculated correctly (wasn't the case before) > and clipping is working again as the window quads are filtered out. > > As a side note: I think we can now even try to apply blur behind the window > during the animation. I think that all tries before failed due to the fact > that we just calculated everything in the wrong way. > > > This addresses bug 288568. > http://bugs.kde.org/show_bug.cgi?id=288568 > > > Diffs > - > > kwin/effects/slidingpopups/slidingpopups.cpp 1065bfc > > Diff: http://git.reviewboard.kde.org/r/103367/diff/diff > > > Testing > --- > > yes, works for a panel on all possible corners (including panel between > screens). Nevertheless please all try this patch. > > > Thanks, > > Martin Gräßlin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: [Patch 2/2] Fix Sliding Popups
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103367/ --- (Updated Dec. 9, 2011, 5:35 p.m.) Review request for kwin and Plasma. Changes --- fixed one additional artifact which happened at the end of the disappearing animation. Strange enough I could not trigger it with animation speed very slow, but with normal. Description --- Rework of sliding popups effect based on change to use "-1" as a default offset. The animation is now calculated correctly (wasn't the case before) and clipping is working again as the window quads are filtered out. As a side note: I think we can now even try to apply blur behind the window during the animation. I think that all tries before failed due to the fact that we just calculated everything in the wrong way. This addresses bug 288568. http://bugs.kde.org/show_bug.cgi?id=288568 Diffs (updated) - kwin/effects/slidingpopups/slidingpopups.cpp 1065bfc Diff: http://git.reviewboard.kde.org/r/103367/diff/diff Testing --- yes, works for a panel on all possible corners (including panel between screens). Nevertheless please all try this patch. Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
