Re: Review Request: [RFC]: Rename Configure Window Behavior to Window Manager Settings
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104284/#review11832 --- This review has been submitted with commit 828791505ee8fb38abf407d7a999fc07b07b62e5 by Martin Gräßlin to branch master. - Commit Hook On March 22, 2012, 5:59 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104284/ --- (Updated March 22, 2012, 5:59 a.m.) Review request for kwin and Plasma. Description --- Adding Plasma to get general feedback on this idea. The context menu entry to Configure Window Behavior opens the configuration of the window manager and not about the window. In the past the shown configuration dialog only contained entries affecting the window behavior but that is no longer true for the complete KDE 4.x series since Desktop Effects had been added to the menu. This change in naming reflects the situation and should help to remove confusion. This addresses bug 249486. http://bugs.kde.org/show_bug.cgi?id=249486 Diffs - kwin/useractions.cpp dfb6fd4 Diff: http://git.reviewboard.kde.org/r/104284/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: [RFC]: Rename Configure Window Behavior to Window Manager Settings
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104284/#review11767 --- Ship it! Ship It! - Richard Stockton On March 22, 2012, 5:59 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104284/ --- (Updated March 22, 2012, 5:59 a.m.) Review request for kwin and Plasma. Description --- Adding Plasma to get general feedback on this idea. The context menu entry to Configure Window Behavior opens the configuration of the window manager and not about the window. In the past the shown configuration dialog only contained entries affecting the window behavior but that is no longer true for the complete KDE 4.x series since Desktop Effects had been added to the menu. This change in naming reflects the situation and should help to remove confusion. This addresses bug 249486. http://bugs.kde.org/show_bug.cgi?id=249486 Diffs - kwin/useractions.cpp dfb6fd4 Diff: http://git.reviewboard.kde.org/r/104284/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: [RFC]: Rename Configure Window Behavior to Window Manager Settings
On March 22, 2012, 7:39 p.m., Richard Stockton wrote: Ship It! This is the best name, because that's exactly what they are (Kwin'w WINDOWS MANAGER options). This new name is much more specific and correct about the settings which are being addressed by Opening the in the items which are being purpose of the category. A+ from me! I disagree, however, with Aaron's preference for leaving out of the Desktop's context menu (Right Click) and/or the Cashew's menu : I add a new panel even LESS often than I change Window Manager Settings, and I feel that this sub-menu should be included in both menus. When you're doing Context Menu on the desktop, or opening the Cashew, it's because you want to do something with the Desktop -- and it _could_ have something to do with the number of virtual desktops, or effects, so it should be there. IMO, it's really not that much different, in scope, or in type of option, than changing wallpapers. - Richard --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104284/#review11767 --- On March 22, 2012, 5:59 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104284/ --- (Updated March 22, 2012, 5:59 a.m.) Review request for kwin and Plasma. Description --- Adding Plasma to get general feedback on this idea. The context menu entry to Configure Window Behavior opens the configuration of the window manager and not about the window. In the past the shown configuration dialog only contained entries affecting the window behavior but that is no longer true for the complete KDE 4.x series since Desktop Effects had been added to the menu. This change in naming reflects the situation and should help to remove confusion. This addresses bug 249486. http://bugs.kde.org/show_bug.cgi?id=249486 Diffs - kwin/useractions.cpp dfb6fd4 Diff: http://git.reviewboard.kde.org/r/104284/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: [RFC]: Rename Configure Window Behavior to Window Manager Settings
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104284/ --- (Updated March 22, 2012, 5:59 a.m.) Review request for kwin and Plasma. Changes --- * changed naming to Window Manager Settings inspired by Application Launcher Settings and Panel Settings * moved the entry into the advanced section of the menu. Summary (updated) - [RFC]: Rename Configure Window Behavior to Window Manager Settings Description --- Adding Plasma to get general feedback on this idea. The context menu entry to Configure Window Behavior opens the configuration of the window manager and not about the window. In the past the shown configuration dialog only contained entries affecting the window behavior but that is no longer true for the complete KDE 4.x series since Desktop Effects had been added to the menu. This change in naming reflects the situation and should help to remove confusion. This addresses bug 249486. http://bugs.kde.org/show_bug.cgi?id=249486 Diffs (updated) - kwin/useractions.cpp dfb6fd4 Diff: http://git.reviewboard.kde.org/r/104284/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
