Re: Review Request: Bugfix: Plasma::PackageMetadata::read: Match the behavior of KService
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102404/#review8923 --- This review has been submitted with commit 74c13a7335d91d944ecc661ff46bbb16f8975a08 by Kevin Kofler to branch KDE/4.7. - Commit Hook On Aug. 22, 2011, 12:49 a.m., Kevin Kofler wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102404/ --- (Updated Aug. 22, 2011, 12:49 a.m.) Review request for Plasma. Description --- Also delete the duplicate entries in PackageMetadata::write. This one is a bugfix, and so should be OK for 4.7. While testing my GSoC work, I noticed that Plasma::PackageMetadata::read only looks for X-KDE-ServiceTypes, whereas KService concatenates the contents of ServiceTypes and X-KDE-ServiceTypes. There are metadata.desktop files out there using ServiceTypes without the X-KDE prefix. I also fixed it to look for both Keywords and X-KDE-Keywords as KService does, not just Keywords. Diffs - plasma/packagemetadata.cpp 59163b2 Diff: http://git.reviewboard.kde.org/r/102404/diff/diff Testing --- Compiles on Fedora 15. Thanks, Kevin Kofler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Bugfix: Plasma::PackageMetadata::read: Match the behavior of KService
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102404/#review8748 --- Ship it! sorry this one slipped through the cracks. it looks good to go. note that in frameworks, there is no packagemetadata anymore. - Aaron J. Seigo On Aug. 22, 2011, 12:49 a.m., Kevin Kofler wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102404/ --- (Updated Aug. 22, 2011, 12:49 a.m.) Review request for Plasma. Description --- Also delete the duplicate entries in PackageMetadata::write. This one is a bugfix, and so should be OK for 4.7. While testing my GSoC work, I noticed that Plasma::PackageMetadata::read only looks for X-KDE-ServiceTypes, whereas KService concatenates the contents of ServiceTypes and X-KDE-ServiceTypes. There are metadata.desktop files out there using ServiceTypes without the X-KDE prefix. I also fixed it to look for both Keywords and X-KDE-Keywords as KService does, not just Keywords. Diffs - plasma/packagemetadata.cpp 59163b2 Diff: http://git.reviewboard.kde.org/r/102404/diff/diff Testing --- Compiles on Fedora 15. Thanks, Kevin Kofler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Bugfix: Plasma::PackageMetadata::read: Match the behavior of KService
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102404/#review6930 --- Ping? Can I commit this bugfix to the KDE/4.7 branch? - Kevin Kofler On Aug. 22, 2011, 12:49 a.m., Kevin Kofler wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102404/ --- (Updated Aug. 22, 2011, 12:49 a.m.) Review request for Plasma. Description --- Also delete the duplicate entries in PackageMetadata::write. This one is a bugfix, and so should be OK for 4.7. While testing my GSoC work, I noticed that Plasma::PackageMetadata::read only looks for X-KDE-ServiceTypes, whereas KService concatenates the contents of ServiceTypes and X-KDE-ServiceTypes. There are metadata.desktop files out there using ServiceTypes without the X-KDE prefix. I also fixed it to look for both Keywords and X-KDE-Keywords as KService does, not just Keywords. Diffs - plasma/packagemetadata.cpp 59163b2 Diff: http://git.reviewboard.kde.org/r/102404/diff/diff Testing --- Compiles on Fedora 15. Thanks, Kevin Kofler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Bugfix: Plasma::PackageMetadata::read: Match the behavior of KService
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102404/ --- (Updated Aug. 22, 2011, 12:49 a.m.) Review request for Plasma. Changes --- Also delete the duplicate entries in PackageMetadata::write. Summary (updated) --- Also delete the duplicate entries in PackageMetadata::write. This one is a bugfix, and so should be OK for 4.7. While testing my GSoC work, I noticed that Plasma::PackageMetadata::read only looks for X-KDE-ServiceTypes, whereas KService concatenates the contents of ServiceTypes and X-KDE-ServiceTypes. There are metadata.desktop files out there using ServiceTypes without the X-KDE prefix. I also fixed it to look for both Keywords and X-KDE-Keywords as KService does, not just Keywords. Diffs (updated) - plasma/packagemetadata.cpp 59163b2 Diff: http://git.reviewboard.kde.org/r/102404/diff Testing --- Compiles on Fedora 15. Thanks, Kevin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
