Re: Review Request: Fix padding in ToolButton and TabButton
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104319/#review11644 --- This review has been submitted with commit 37f04317e55b6d66b043bb74e5c50bc4b3fe1d43 by David Edmundson to branch master. - Commit Hook On March 17, 2012, 7:44 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104319/ --- (Updated March 17, 2012, 7:44 p.m.) Review request for Plasma. Description --- Fix padding in ToolButton and TabButton between icon and text. This also brings it in line with the regular button which is done properly. Diffs - plasma/declarativeimports/plasmacomponents/qml/TabButton.qml dc8d34a plasma/declarativeimports/plasmacomponents/qml/ToolButton.qml 0907a22 Diff: http://git.reviewboard.kde.org/r/104319/diff/ Testing --- Opened in Gallery. Screenshots --- Tab Before http://git.reviewboard.kde.org/r/104319/s/473/ Tab After http://git.reviewboard.kde.org/r/104319/s/474/ ToolButton Before http://git.reviewboard.kde.org/r/104319/s/475/ ToolButton After http://git.reviewboard.kde.org/r/104319/s/477/ Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Fix padding in ToolButton and TabButton
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104319/#review11509 --- Ship it! Ship It! - Marco Martin On March 17, 2012, 7:44 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104319/ --- (Updated March 17, 2012, 7:44 p.m.) Review request for Plasma. Description --- Fix padding in ToolButton and TabButton between icon and text. This also brings it in line with the regular button which is done properly. Diffs - plasma/declarativeimports/plasmacomponents/qml/TabButton.qml dc8d34a plasma/declarativeimports/plasmacomponents/qml/ToolButton.qml 0907a22 Diff: http://git.reviewboard.kde.org/r/104319/diff/ Testing --- Opened in Gallery. Screenshots --- Tab Before http://git.reviewboard.kde.org/r/104319/s/473/ Tab After http://git.reviewboard.kde.org/r/104319/s/474/ ToolButton Before http://git.reviewboard.kde.org/r/104319/s/475/ ToolButton After http://git.reviewboard.kde.org/r/104319/s/477/ Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
