---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107868/#review24886
---
how about instead of having 2 plugins, just add sessions support to this one
plugin? it can search both profiles *and* sessions and show all that match. it
can note which it is, perhaps, in the data() of the match so that run() can do
the right thing. that will mean 1 less plugin, 1 less kconf update script, 1
less translation file, etc. for the same functionality.
- Aaron J. Seigo
On Dec. 31, 2012, 7:12 p.m., Jekyll Wu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107868/
> ---
>
> (Updated Dec. 31, 2012, 7:12 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> ---
>
> What the current konquerorsessions plugin does is eventually calling
> "konqueror --profile xyz", so it is really for the profile feature of
> konqueror, not the session feature of konqueoror.
>
> The patch just contains various moving and renaming opeations to make its
> code, name and behavior being consistent. I actually have made a real
> konquerosessions plugin based upon this unreal plugin. Will post it in
> another review.
>
>
> This addresses bug 188494.
> http://bugs.kde.org/show_bug.cgi?id=188494
>
>
> Diffs
> -
>
> runners/CMakeLists.txt bb4b491
> runners/konquerorprofiles/CMakeLists.txt PRE-CREATION
> runners/konquerorprofiles/Messages.sh PRE-CREATION
> runners/konquerorprofiles/konquerorprofiles.cpp PRE-CREATION
> runners/konquerorprofiles/konquerorprofiles.desktop PRE-CREATION
> runners/konquerorprofiles/konquerorprofiles.h PRE-CREATION
>
> runners/konquerorprofiles/konquerorsessions_renamed_to_konquerorprofiles.upd
> PRE-CREATION
> runners/konquerorsessions/CMakeLists.txt be2ea9d
> runners/konquerorsessions/Messages.sh 0720e1e
> runners/konquerorsessions/konquerorsessions.cpp f2e437a
> runners/konquerorsessions/konquerorsessions.desktop df81780
> runners/konquerorsessions/konquerorsessions.h 957f976
>
> Diff: http://git.reviewboard.kde.org/r/107868/diff/
>
>
> Testing
> ---
>
>
> Thanks,
>
> Jekyll Wu
>
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
