Re: Review Request: change default config of taskmanager
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105374/#review16487
---
Was this change intended for 4.9 or just master as indicated in this request?
Branch is actually in freeze, the bug fix says "Fixed in 4.9.1", but the change
will be in 4.9.0 unless it is reverted in branch.
Additionally, I thought plasma uses kdelibs coding style. If that's the case,
there need to be braces even in single-statement if/else.
- Christoph Feck
On June 28, 2012, 7:03 p.m., Greg T wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105374/
> ---
>
> (Updated June 28, 2012, 7:03 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> ---
>
> libtaskmanager can't remove those ("browser", "preferred://browser, , , ")
> entrys, so I moved them to the Items list. I don't know why they were
> separated in the first place. That's why I'm opening this review request.
>
>
> This addresses bug 278724.
> http://bugs.kde.org/show_bug.cgi?id=278724
>
>
> Diffs
> -
>
> libs/taskmanager/groupmanager.cpp 5ca0159
>
> Diff: http://git.reviewboard.kde.org/r/105374/diff/
>
>
> Testing
> ---
>
> no regressions noted.
>
>
> Thanks,
>
> Greg T
>
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: change default config of taskmanager
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105374/#review16481
---
This review has been submitted with commit
70cd86a5eef103137e64f2e3868a5bd2d58d71d7 by Gregor Tätzner to branch KDE/4.9.
- Commit Hook
On June 28, 2012, 7:03 p.m., Greg T wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105374/
> ---
>
> (Updated June 28, 2012, 7:03 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> ---
>
> libtaskmanager can't remove those ("browser", "preferred://browser, , , ")
> entrys, so I moved them to the Items list. I don't know why they were
> separated in the first place. That's why I'm opening this review request.
>
>
> This addresses bug 278724.
> http://bugs.kde.org/show_bug.cgi?id=278724
>
>
> Diffs
> -
>
> libs/taskmanager/groupmanager.cpp 5ca0159
>
> Diff: http://git.reviewboard.kde.org/r/105374/diff/
>
>
> Testing
> ---
>
> no regressions noted.
>
>
> Thanks,
>
> Greg T
>
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: change default config of taskmanager
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105374/#review16480
---
This review has been submitted with commit
f8eb85a87846e49b10dae8170695533262011ae1 by Gregor Tätzner to branch master.
- Commit Hook
On June 28, 2012, 7:03 p.m., Greg T wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105374/
> ---
>
> (Updated June 28, 2012, 7:03 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> ---
>
> libtaskmanager can't remove those ("browser", "preferred://browser, , , ")
> entrys, so I moved them to the Items list. I don't know why they were
> separated in the first place. That's why I'm opening this review request.
>
>
> This addresses bug 278724.
> http://bugs.kde.org/show_bug.cgi?id=278724
>
>
> Diffs
> -
>
> libs/taskmanager/groupmanager.cpp 5ca0159
>
> Diff: http://git.reviewboard.kde.org/r/105374/diff/
>
>
> Testing
> ---
>
> no regressions noted.
>
>
> Thanks,
>
> Greg T
>
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: change default config of taskmanager
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105374/#review16473
---
Ship it!
- Marco Martin
On June 28, 2012, 7:03 p.m., Greg T wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105374/
> ---
>
> (Updated June 28, 2012, 7:03 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> ---
>
> libtaskmanager can't remove those ("browser", "preferred://browser, , , ")
> entrys, so I moved them to the Items list. I don't know why they were
> separated in the first place. That's why I'm opening this review request.
>
>
> This addresses bug 278724.
> http://bugs.kde.org/show_bug.cgi?id=278724
>
>
> Diffs
> -
>
> libs/taskmanager/groupmanager.cpp 5ca0159
>
> Diff: http://git.reviewboard.kde.org/r/105374/diff/
>
>
> Testing
> ---
>
> no regressions noted.
>
>
> Thanks,
>
> Greg T
>
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: change default config of taskmanager
> On June 28, 2012, 4:57 p.m., Aaron J. Seigo wrote:
> > Items= is no longer used. individual entries are. so this review is not
> > correct.
> >
> > the prefered items are also indeed removable. that was fixed a while back.
> >
> > are you using kde-workspace from master or some older branch or...?
>
> Greg T wrote:
> ah, I see.
>
> Nope, I'm using plain master and that bug is definitely *not* fixed. The
> preferred filemanager and browser icons keep reappaering on login. The
> function GroupManagerPrivate::unsaveLauncher can't remove that config entrys
> because the name of the launcher is i.e. 'firefox' but never 'browser'
well, I have updated the patch 1 week ago, +1/-1? :)
- Greg
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105374/#review15230
---
On June 28, 2012, 7:03 p.m., Greg T wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105374/
> ---
>
> (Updated June 28, 2012, 7:03 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> ---
>
> libtaskmanager can't remove those ("browser", "preferred://browser, , , ")
> entrys, so I moved them to the Items list. I don't know why they were
> separated in the first place. That's why I'm opening this review request.
>
>
> This addresses bug 278724.
> http://bugs.kde.org/show_bug.cgi?id=278724
>
>
> Diffs
> -
>
> libs/taskmanager/groupmanager.cpp 5ca0159
>
> Diff: http://git.reviewboard.kde.org/r/105374/diff/
>
>
> Testing
> ---
>
> no regressions noted.
>
>
> Thanks,
>
> Greg T
>
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: change default config of taskmanager
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105374/
---
(Updated June 28, 2012, 7:03 p.m.)
Review request for Plasma.
Changes
---
Entirely new patch...that preferred application stuff feels like a hack.
Description
---
libtaskmanager can't remove those ("browser", "preferred://browser, , , ")
entrys, so I moved them to the Items list. I don't know why they were separated
in the first place. That's why I'm opening this review request.
This addresses bug 278724.
http://bugs.kde.org/show_bug.cgi?id=278724
Diffs (updated)
-
libs/taskmanager/groupmanager.cpp 5ca0159
Diff: http://git.reviewboard.kde.org/r/105374/diff/
Testing
---
no regressions noted.
Thanks,
Greg T
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: change default config of taskmanager
> On June 28, 2012, 4:57 p.m., Aaron J. Seigo wrote:
> > Items= is no longer used. individual entries are. so this review is not
> > correct.
> >
> > the prefered items are also indeed removable. that was fixed a while back.
> >
> > are you using kde-workspace from master or some older branch or...?
ah, I see.
Nope, I'm using plain master and that bug is definitely *not* fixed. The
preferred filemanager and browser icons keep reappaering on login. The function
GroupManagerPrivate::unsaveLauncher can't remove that config entrys because the
name of the launcher is i.e. 'firefox' but never 'browser'
- Greg
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105374/#review15230
---
On June 28, 2012, 3:48 p.m., Greg T wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105374/
> ---
>
> (Updated June 28, 2012, 3:48 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> ---
>
> libtaskmanager can't remove those ("browser", "preferred://browser, , , ")
> entrys, so I moved them to the Items list. I don't know why they were
> separated in the first place. That's why I'm opening this review request.
>
>
> This addresses bug 278724.
> http://bugs.kde.org/show_bug.cgi?id=278724
>
>
> Diffs
> -
>
>
> plasma/desktop/shell/data/layouts/org.kde.plasma-desktop.defaultPanel/contents/layout.js
> afd1f2c
>
> Diff: http://git.reviewboard.kde.org/r/105374/diff/
>
>
> Testing
> ---
>
> no regressions noted.
>
>
> Thanks,
>
> Greg T
>
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: change default config of taskmanager
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105374/#review15230
---
Items= is no longer used. individual entries are. so this review is not correct.
the prefered items are also indeed removable. that was fixed a while back.
are you using kde-workspace from master or some older branch or...?
- Aaron J. Seigo
On June 28, 2012, 3:48 p.m., Greg T wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105374/
> ---
>
> (Updated June 28, 2012, 3:48 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> ---
>
> libtaskmanager can't remove those ("browser", "preferred://browser, , , ")
> entrys, so I moved them to the Items list. I don't know why they were
> separated in the first place. That's why I'm opening this review request.
>
>
> This addresses bug 278724.
> http://bugs.kde.org/show_bug.cgi?id=278724
>
>
> Diffs
> -
>
>
> plasma/desktop/shell/data/layouts/org.kde.plasma-desktop.defaultPanel/contents/layout.js
> afd1f2c
>
> Diff: http://git.reviewboard.kde.org/r/105374/diff/
>
>
> Testing
> ---
>
> no regressions noted.
>
>
> Thanks,
>
> Greg T
>
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
