Re: Review Request: icon plasmoid - http url naming
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103435/#review12735 --- This review has been submitted with commit 246d9bcc81878977d68c3cc030f1b6fd2e28cb87 by Gregor Tätzner to branch KDE/4.8. - Commit Hook On Jan. 10, 2012, 1:41 p.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103435/ --- (Updated Jan. 10, 2012, 1:41 p.m.) Review request for Plasma. Description --- I added a special case so the desktop icon gets a pretty name when you drag and drop a link onto your desktop. Additional, a regex strips out the protocol (like in firefox) I'm allowed to commit it? This addresses bug 199811. http://bugs.kde.org/show_bug.cgi?id=199811 Diffs - plasma/generic/applets/icon/icon.cpp b25e5d6 Diff: http://git.reviewboard.kde.org/r/103435/diff/ Testing --- looks good Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: icon plasmoid - http url naming
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103435/#review9741 --- Ship it! Ship It! - Aaron J. Seigo On Jan. 10, 2012, 1:41 p.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103435/ --- (Updated Jan. 10, 2012, 1:41 p.m.) Review request for Plasma. Description --- I added a special case so the desktop icon gets a pretty name when you drag and drop a link onto your desktop. Additional, a regex strips out the protocol (like in firefox) I'm allowed to commit it? This addresses bug 199811. http://bugs.kde.org/show_bug.cgi?id=199811 Diffs - plasma/generic/applets/icon/icon.cpp b25e5d6 Diff: http://git.reviewboard.kde.org/r/103435/diff/diff Testing --- looks good Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: icon plasmoid - http url naming
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103435/#review9754 --- This review has been submitted with commit a0fd4056bdb115bd74e4e50a0c5b12d2462fa92f by Gregor Tätzner to branch master. - Commit Hook On Jan. 10, 2012, 1:41 p.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103435/ --- (Updated Jan. 10, 2012, 1:41 p.m.) Review request for Plasma. Description --- I added a special case so the desktop icon gets a pretty name when you drag and drop a link onto your desktop. Additional, a regex strips out the protocol (like in firefox) I'm allowed to commit it? This addresses bug 199811. http://bugs.kde.org/show_bug.cgi?id=199811 Diffs - plasma/generic/applets/icon/icon.cpp b25e5d6 Diff: http://git.reviewboard.kde.org/r/103435/diff/diff Testing --- looks good Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: icon plasmoid - http url naming
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103435/ --- (Updated Jan. 10, 2012, 1:41 p.m.) Review request for Plasma. Changes --- bump Description (updated) --- I added a special case so the desktop icon gets a pretty name when you drag and drop a link onto your desktop. Additional, a regex strips out the protocol (like in firefox) I'm allowed to commit it? This addresses bug 199811. http://bugs.kde.org/show_bug.cgi?id=199811 Diffs - plasma/generic/applets/icon/icon.cpp b25e5d6 Diff: http://git.reviewboard.kde.org/r/103435/diff/diff Testing --- looks good Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
