Re: Review Request: make use of setClickMessage in the source textedit
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1337/#review2053 --- Ship it! Yep, nice fix for the translatoid's interaction - Sebastian On 2009-08-16 22:00:34, patcito wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1337/ --- (Updated 2009-08-16 22:00:34) Review request for Plasma. Summary --- This makes use of the recently added setClickMessage() property of ktextedit so that when the user click on the textedit, the message disappears and when the user clicks out of the textedit, the message comes back if the textedit is empty. For now, the user has to remove the text manually which is a bit annoying :) Diffs - /trunk/kdereview/plasma/applets/translatoid/ktranslatoid.cpp 1011865 Diff: http://reviewboard.kde.org/r/1337/diff Testing --- Screenshots --- translatoid message disappears on click http://reviewboard.kde.org/r/1337/s/181/ Thanks, patcito ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: make use of setClickMessage in the source textedit
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1337/#review2054 --- /trunk/kdereview/plasma/applets/translatoid/ktranslatoid.cpp http://reviewboard.kde.org/r/1337/#comment1369 Your text here sounds nicer IMO - Sebastian On 2009-08-16 22:00:34, patcito wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1337/ --- (Updated 2009-08-16 22:00:34) Review request for Plasma. Summary --- This makes use of the recently added setClickMessage() property of ktextedit so that when the user click on the textedit, the message disappears and when the user clicks out of the textedit, the message comes back if the textedit is empty. For now, the user has to remove the text manually which is a bit annoying :) Diffs - /trunk/kdereview/plasma/applets/translatoid/ktranslatoid.cpp 1011865 Diff: http://reviewboard.kde.org/r/1337/diff Testing --- Screenshots --- translatoid message disappears on click http://reviewboard.kde.org/r/1337/s/181/ Thanks, patcito ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: make use of setClickMessage in the source textedit
On Mon, Aug 17, 2009 at 8:56 AM, Sebastian Küglerse...@kde.org wrote: /trunk/kdereview/plasma/applets/translatoid/ktranslatoid.cpp http://reviewboard.kde.org/r/1337/#comment1369 Your text here sounds nicer IMO Ok, I changed the text to that, I'm sending it here because reviewboard is down. Cheers, Pat ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: make use of setClickMessage in the source textedit
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1337/ --- (Updated 2009-08-18 01:37:40.305984) Review request for Plasma. Changes --- I changed the text as suggested by Seb. Summary --- This makes use of the recently added setClickMessage() property of ktextedit so that when the user click on the textedit, the message disappears and when the user clicks out of the textedit, the message comes back if the textedit is empty. For now, the user has to remove the text manually which is a bit annoying :) Diffs (updated) - /trunk/kdereview/plasma/applets/translatoid/ktranslatoid.cpp 1011865 Diff: http://reviewboard.kde.org/r/1337/diff Testing --- Screenshots --- translatoid message disappears on click http://reviewboard.kde.org/r/1337/s/181/ Thanks, patcito ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
