Re: Review Request: use Plasma::Dialog for kmix osd
> On Jan. 7, 2013, 9:35 p.m., Kai Uwe Broulik wrote: > > What about KDE/4.10 branch? Ok, you merged. Never mind :-) - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108223/#review24946 --- On Jan. 6, 2013, 11:52 p.m., Xuetian Weng wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108223/ > --- > > (Updated Jan. 6, 2013, 11:52 p.m.) > > > Review request for Plasma, Solid, Kai Uwe Broulik, Aaron J. Seigo, and > Christian Esken. > > > Description > --- > > Similiar to https://git.reviewboard.kde.org/r/108222, this would fix the > shadow problem for kmix osd. > > > Diffs > - > > gui/osdwidget.h 9ec0100 > gui/osdwidget.cpp 2dc202e > > Diff: http://git.reviewboard.kde.org/r/108223/diff/ > > > Testing > --- > > localily tested, no problem > > > Thanks, > > Xuetian Weng > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: use Plasma::Dialog for kmix osd
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108223/#review24946 --- What about KDE/4.10 branch? - Kai Uwe Broulik On Jan. 6, 2013, 11:52 p.m., Xuetian Weng wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108223/ > --- > > (Updated Jan. 6, 2013, 11:52 p.m.) > > > Review request for Plasma, Solid, Kai Uwe Broulik, Aaron J. Seigo, and > Christian Esken. > > > Description > --- > > Similiar to https://git.reviewboard.kde.org/r/108222, this would fix the > shadow problem for kmix osd. > > > Diffs > - > > gui/osdwidget.h 9ec0100 > gui/osdwidget.cpp 2dc202e > > Diff: http://git.reviewboard.kde.org/r/108223/diff/ > > > Testing > --- > > localily tested, no problem > > > Thanks, > > Xuetian Weng > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: use Plasma::Dialog for kmix osd
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108223/#review24912 --- This review has been submitted with commit 0e9d369c573a56af94be415ff608898f8356ce1a by Weng Xuetian to branch master. - Commit Hook On Jan. 6, 2013, 11:52 p.m., Xuetian Weng wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108223/ > --- > > (Updated Jan. 6, 2013, 11:52 p.m.) > > > Review request for Plasma, Solid, Kai Uwe Broulik, Aaron J. Seigo, and > Christian Esken. > > > Description > --- > > Similiar to https://git.reviewboard.kde.org/r/108222, this would fix the > shadow problem for kmix osd. > > > Diffs > - > > gui/osdwidget.h 9ec0100 > gui/osdwidget.cpp 2dc202e > > Diff: http://git.reviewboard.kde.org/r/108223/diff/ > > > Testing > --- > > localily tested, no problem > > > Thanks, > > Xuetian Weng > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: use Plasma::Dialog for kmix osd
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108223/#review24871 --- Ship it! Ship It! - Aaron J. Seigo On Jan. 6, 2013, 11:52 p.m., Xuetian Weng wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108223/ > --- > > (Updated Jan. 6, 2013, 11:52 p.m.) > > > Review request for Plasma, Solid, Kai Uwe Broulik, Aaron J. Seigo, and > Christian Esken. > > > Description > --- > > Similiar to https://git.reviewboard.kde.org/r/108222, this would fix the > shadow problem for kmix osd. > > > Diffs > - > > gui/osdwidget.h 9ec0100 > gui/osdwidget.cpp 2dc202e > > Diff: http://git.reviewboard.kde.org/r/108223/diff/ > > > Testing > --- > > localily tested, no problem > > > Thanks, > > Xuetian Weng > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: use Plasma::Dialog for kmix osd
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108223/ --- (Updated Jan. 6, 2013, 11:52 p.m.) Review request for Plasma, Solid, Kai Uwe Broulik, Aaron J. Seigo, and Christian Esken. Description --- Similiar to https://git.reviewboard.kde.org/r/108222, this would fix the shadow problem for kmix osd. Diffs - gui/osdwidget.h 9ec0100 gui/osdwidget.cpp 2dc202e Diff: http://git.reviewboard.kde.org/r/108223/diff/ Testing --- localily tested, no problem Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: use Plasma::Dialog for kmix osd
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108223/ --- (Updated Jan. 6, 2013, 10:32 p.m.) Review request for Plasma, Kai Uwe Broulik, Aaron J. Seigo, and Christian Esken. Changes --- change the size Description --- Similiar to https://git.reviewboard.kde.org/r/108222, this would fix the shadow problem for kmix osd. Diffs (updated) - gui/osdwidget.h 9ec0100 gui/osdwidget.cpp 2dc202e Diff: http://git.reviewboard.kde.org/r/108223/diff/ Testing --- localily tested, no problem Thanks, Xuetian Weng ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
