Re: Review Request 106097: Config cleanup on removeActivity
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106097/#review27287 --- This review has been submitted with commit 8dde900c9222ef8db70dc8f834f6cae4badb26dc by Aaron Seigo to branch master. - Commit Hook On Sept. 1, 2012, 3:44 p.m., makis marimpis wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106097/ --- (Updated Sept. 1, 2012, 3:44 p.m.) Review request for KDE Runtime and Plasma. Description --- Remove the related configuration entry (which holds the current desktop) when an activity is removed. Diffs - src/service/plugins/virtualdesktopswitch/virtualdesktopswitch.cpp 568e0f9f489e19899dc73ec732488b2ee17c4e3f src/service/plugins/virtualdesktopswitch/virtualdesktopswitch.h 6bf08f0bdec32d078071edb8556a33191ba08d23 Diff: http://git.reviewboard.kde.org/r/106097/diff/ Testing --- Yes Thanks, makis marimpis ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 106097: Config cleanup on removeActivity
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106097/#review26995 --- What's the status of this? It has a ship it but reading the comment seems it doesn't really work. Are you planning to work on it? Or is it indeed working and needs a review? Or should be discarded? - Albert Astals Cid On Sept. 1, 2012, 3:44 p.m., makis marimpis wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106097/ --- (Updated Sept. 1, 2012, 3:44 p.m.) Review request for KDE Runtime and Plasma. Description --- Remove the related configuration entry (which holds the current desktop) when an activity is removed. Diffs - src/service/plugins/virtualdesktopswitch/virtualdesktopswitch.cpp 568e0f9f489e19899dc73ec732488b2ee17c4e3f src/service/plugins/virtualdesktopswitch/virtualdesktopswitch.h 6bf08f0bdec32d078071edb8556a33191ba08d23 Diff: http://git.reviewboard.kde.org/r/106097/diff/ Testing --- Yes Thanks, makis marimpis ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel