Re: Review Request 110135: Adjust to new suspend session handling

2013-04-24 Thread Commit Hook 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110135/
---

(Updated April 24, 2013, 6:05 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, Solid, Dario Freddi, and Sebastian Kügler.


Description
---

Suspend/hibernate are now longer are part of
org.kde.Solid.PowerManagement interface, so adjusting to new one.


This addresses bug 318737.
http://bugs.kde.org/show_bug.cgi?id=318737


Diffs
-

  kcontrol/randr/module/randrmonitor.cpp 5a719a4 
  ksmserver/screenlocker/greeter/greeterapp.cpp e54c216 
  ksmserver/shutdowndlg.cpp 247c877 
  plasma/desktop/applets/kickoff/core/itemhandlers.cpp 4e83c37 
  plasma/generic/dataengines/time/CMakeLists.txt 007a60a 
  plasma/generic/dataengines/time/timeengine.cpp 2f69e8f 
  plasma/generic/runners/powerdevil/PowerDevilRunner.cpp 74eb36d 

Diff: http://git.reviewboard.kde.org/r/110135/diff/


Testing
---

Compiled, actions work now.


Thanks,

Hrvoje Senjan

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 110135: Adjust to new suspend session handling

2013-04-24 Thread Commit Hook 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110135/#review31503
---


This review has been submitted with commit 
ad805b504eb3ddec063a3e9060a6d07180232a47 by Hrvoje Senjan to branch master.

- Commit Hook


On April 24, 2013, 5:41 p.m., Hrvoje Senjan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110135/
> ---
> 
> (Updated April 24, 2013, 5:41 p.m.)
> 
> 
> Review request for Plasma, Solid, Dario Freddi, and Sebastian Kügler.
> 
> 
> Description
> ---
> 
> Suspend/hibernate are now longer are part of
> org.kde.Solid.PowerManagement interface, so adjusting to new one.
> 
> 
> This addresses bug 318737.
> http://bugs.kde.org/show_bug.cgi?id=318737
> 
> 
> Diffs
> -
> 
>   kcontrol/randr/module/randrmonitor.cpp 5a719a4 
>   ksmserver/screenlocker/greeter/greeterapp.cpp e54c216 
>   ksmserver/shutdowndlg.cpp 247c877 
>   plasma/desktop/applets/kickoff/core/itemhandlers.cpp 4e83c37 
>   plasma/generic/dataengines/time/CMakeLists.txt 007a60a 
>   plasma/generic/dataengines/time/timeengine.cpp 2f69e8f 
>   plasma/generic/runners/powerdevil/PowerDevilRunner.cpp 74eb36d 
> 
> Diff: http://git.reviewboard.kde.org/r/110135/diff/
> 
> 
> Testing
> ---
> 
> Compiled, actions work now.
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 110135: Adjust to new suspend session handling

2013-04-24 Thread Dario Freddi 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110135/#review31501
---

Ship it!


Great! Thanks a lot for your efforts. Please push to master after fixing the 
small issue below.


plasma/generic/dataengines/time/timeengine.cpp


Watch out for whitespaces


- Dario Freddi


On April 24, 2013, 5:41 p.m., Hrvoje Senjan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110135/
> ---
> 
> (Updated April 24, 2013, 5:41 p.m.)
> 
> 
> Review request for Plasma, Solid, Dario Freddi, and Sebastian Kügler.
> 
> 
> Description
> ---
> 
> Suspend/hibernate are now longer are part of
> org.kde.Solid.PowerManagement interface, so adjusting to new one.
> 
> 
> This addresses bug 318737.
> http://bugs.kde.org/show_bug.cgi?id=318737
> 
> 
> Diffs
> -
> 
>   kcontrol/randr/module/randrmonitor.cpp 5a719a4 
>   ksmserver/screenlocker/greeter/greeterapp.cpp e54c216 
>   ksmserver/shutdowndlg.cpp 247c877 
>   plasma/desktop/applets/kickoff/core/itemhandlers.cpp 4e83c37 
>   plasma/generic/dataengines/time/CMakeLists.txt 007a60a 
>   plasma/generic/dataengines/time/timeengine.cpp 2f69e8f 
>   plasma/generic/runners/powerdevil/PowerDevilRunner.cpp 74eb36d 
> 
> Diff: http://git.reviewboard.kde.org/r/110135/diff/
> 
> 
> Testing
> ---
> 
> Compiled, actions work now.
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 110135: Adjust to new suspend session handling

2013-04-24 Thread Hrvoje Senjan 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110135/
---

(Updated April 24, 2013, 5:41 p.m.)


Review request for Plasma, Solid, Dario Freddi, and Sebastian Kügler.


Changes
---

Changed suspend, hibernate and ResumingfromSuspend actions from using DBus to 
Solid::PowerManagement


Description
---

Suspend/hibernate are now longer are part of
org.kde.Solid.PowerManagement interface, so adjusting to new one.


This addresses bug 318737.
http://bugs.kde.org/show_bug.cgi?id=318737


Diffs (updated)
-

  kcontrol/randr/module/randrmonitor.cpp 5a719a4 
  ksmserver/screenlocker/greeter/greeterapp.cpp e54c216 
  ksmserver/shutdowndlg.cpp 247c877 
  plasma/desktop/applets/kickoff/core/itemhandlers.cpp 4e83c37 
  plasma/generic/dataengines/time/CMakeLists.txt 007a60a 
  plasma/generic/dataengines/time/timeengine.cpp 2f69e8f 
  plasma/generic/runners/powerdevil/PowerDevilRunner.cpp 74eb36d 

Diff: http://git.reviewboard.kde.org/r/110135/diff/


Testing
---

Compiled, actions work now.


Thanks,

Hrvoje Senjan

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 110135: Adjust to new suspend session handling

2013-04-24 Thread Dario Freddi 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110135/#review31490
---


Ok, so finally we should be near a solution - we've been doing it totally wrong 
for ages, and thanks Hrvoje and Lukas for bringing up the problem.

Long story short: Using DBus interfaces is not a good idea at all as we don't 
guarantee stability for all of them. For actions such as suspend/hibernate, we 
already have a way to do this in KDELibs: 
http://api.kde.org/4.x-api/kdelibs-apidocs/tier1/solid/html/namespaceSolid_1_1PowerManagement.html#a7dfbc8eef79e2c16ccae30df6c487fcc
 . So we should use this instead of DBus.

About resumingFromSuspend, same applies. A signal from 
PowerManagement::Notifier should instead be used: 
http://api.kde.org/4.x-api/kdelibs-apidocs/tier1/solid/html/classSolid_1_1PowerManagement_1_1Notifier.html#aad2c04c80d5dcb707a1f9098bc0262bf

So we should definitely change this all over workspace (and, at the same time, 
make sure all applications do the same).

- Dario Freddi


On April 24, 2013, 11:47 a.m., Hrvoje Senjan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110135/
> ---
> 
> (Updated April 24, 2013, 11:47 a.m.)
> 
> 
> Review request for Plasma, Solid, Dario Freddi, and Sebastian Kügler.
> 
> 
> Description
> ---
> 
> Suspend/hibernate are now longer are part of
> org.kde.Solid.PowerManagement interface, so adjusting to new one.
> 
> 
> This addresses bug 318737.
> http://bugs.kde.org/show_bug.cgi?id=318737
> 
> 
> Diffs
> -
> 
>   kcontrol/randr/module/randrmonitor.cpp 5a719a4 
>   ksmserver/screenlocker/greeter/greeterapp.cpp e54c216 
>   ksmserver/shutdowndlg.cpp 247c877 
>   plasma/desktop/applets/kickoff/core/itemhandlers.cpp 4e83c37 
>   plasma/generic/dataengines/time/timeengine.cpp 2f69e8f 
>   plasma/generic/runners/powerdevil/PowerDevilRunner.cpp 74eb36d 
> 
> Diff: http://git.reviewboard.kde.org/r/110135/diff/
> 
> 
> Testing
> ---
> 
> Compiled, actions work now.
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 110135: Adjust to new suspend session handling

2013-04-24 Thread Hrvoje Senjan 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110135/
---

(Updated April 24, 2013, 11:47 a.m.)


Review request for Plasma, Solid, Dario Freddi, and Sebastian Kügler.


Changes
---

Made Kickoff, locker and Powerdevil runner use fd.o service, and adjusted 
timeengine, ksmserver and krandr for new org.Solid.PowerManagement actions.

@Lukáš, resumedFromSuspend is moved to 
org.kde.Solid.PowerManagement.Actions.SuspendSession so that is why i changed 
it.
I have checked your suggestion for Solid::PowerManagement, but seems everyone 
uses this approach, and most of them ported away from it already, and i see 
Dario already did the same adjustments for dataengine with commit 7a0a21


Description
---

Suspend/hibernate are now longer are part of
org.kde.Solid.PowerManagement interface, so adjusting to new one.


This addresses bug 318737.
http://bugs.kde.org/show_bug.cgi?id=318737


Diffs (updated)
-

  kcontrol/randr/module/randrmonitor.cpp 5a719a4 
  ksmserver/screenlocker/greeter/greeterapp.cpp e54c216 
  ksmserver/shutdowndlg.cpp 247c877 
  plasma/desktop/applets/kickoff/core/itemhandlers.cpp 4e83c37 
  plasma/generic/dataengines/time/timeengine.cpp 2f69e8f 
  plasma/generic/runners/powerdevil/PowerDevilRunner.cpp 74eb36d 

Diff: http://git.reviewboard.kde.org/r/110135/diff/


Testing
---

Compiled, actions work now.


Thanks,

Hrvoje Senjan

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 110135: Adjust to new suspend session handling

2013-04-23 Thread Lukáš Tinkl 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110135/#review31466
---



kcontrol/randr/module/randrmonitor.cpp


This is still wrong...



plasma/generic/dataengines/time/timeengine.cpp


... same as this, you even removed the final "t" from the service name


- Lukáš Tinkl


On April 23, 2013, 10:26 p.m., Hrvoje Senjan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110135/
> ---
> 
> (Updated April 23, 2013, 10:26 p.m.)
> 
> 
> Review request for Plasma, Solid, Dario Freddi, and Sebastian Kügler.
> 
> 
> Description
> ---
> 
> Suspend/hibernate are now longer are part of
> org.kde.Solid.PowerManagement interface, so adjusting to new one.
> 
> 
> This addresses bug 318737.
> http://bugs.kde.org/show_bug.cgi?id=318737
> 
> 
> Diffs
> -
> 
>   kcontrol/randr/module/randrmonitor.cpp 5a719a4 
>   ksmserver/screenlocker/greeter/greeterapp.cpp e54c216 
>   ksmserver/shutdowndlg.cpp 247c877 
>   plasma/desktop/applets/kickoff/core/itemhandlers.cpp 4e83c37 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.cpp 6f90006 
>   plasma/generic/dataengines/time/timeengine.cpp 2f69e8f 
>   plasma/generic/runners/powerdevil/PowerDevilRunner.cpp 74eb36d 
> 
> Diff: http://git.reviewboard.kde.org/r/110135/diff/
> 
> 
> Testing
> ---
> 
> Compiled, actions work now.
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 110135: Adjust to new suspend session handling

2013-04-23 Thread Hrvoje Senjan 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110135/
---

(Updated April 23, 2013, 8:26 p.m.)


Review request for Plasma, Solid, Dario Freddi, and Sebastian Kügler.


Changes
---

Changed services as per comments


Description
---

Suspend/hibernate are now longer are part of
org.kde.Solid.PowerManagement interface, so adjusting to new one.


This addresses bug 318737.
http://bugs.kde.org/show_bug.cgi?id=318737


Diffs (updated)
-

  kcontrol/randr/module/randrmonitor.cpp 5a719a4 
  ksmserver/screenlocker/greeter/greeterapp.cpp e54c216 
  ksmserver/shutdowndlg.cpp 247c877 
  plasma/desktop/applets/kickoff/core/itemhandlers.cpp 4e83c37 
  plasma/generic/dataengines/powermanagement/powermanagementjob.cpp 6f90006 
  plasma/generic/dataengines/time/timeengine.cpp 2f69e8f 
  plasma/generic/runners/powerdevil/PowerDevilRunner.cpp 74eb36d 

Diff: http://git.reviewboard.kde.org/r/110135/diff/


Testing
---

Compiled, actions work now.


Thanks,

Hrvoje Senjan

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 110135: Adjust to new suspend session handling

2013-04-23 Thread Dario Freddi 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110135/#review31464
---


The patch is ok, but the changes to the service name are wrong. It should still 
stay org.freedesktop.PowerManagement. This is not to be confused with the 
comments to the previous patch, where basic actions could be found on the fd.o 
PowerManagement service - this signal should instead come from Solid's service, 
and as I said it should actually be a signal in the PowerManagement::Notifier 
class in libsolid. I'll see if I can include that in 4.11.


kcontrol/randr/module/randrmonitor.cpp


Indeed the service should remain the same (org.kde.Solid.PowerManagement). 
Note to self: we should add an API for this to libsolid.



ksmserver/shutdowndlg.cpp


Same here, the service should be the same as before


- Dario Freddi


On April 23, 2013, 7:12 p.m., Hrvoje Senjan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110135/
> ---
> 
> (Updated April 23, 2013, 7:12 p.m.)
> 
> 
> Review request for Plasma, Solid, Dario Freddi, and Sebastian Kügler.
> 
> 
> Description
> ---
> 
> Suspend/hibernate are now longer are part of
> org.kde.Solid.PowerManagement interface, so adjusting to new one.
> 
> 
> This addresses bug 318737.
> http://bugs.kde.org/show_bug.cgi?id=318737
> 
> 
> Diffs
> -
> 
>   kcontrol/randr/module/randrmonitor.cpp 5a719a4 
>   ksmserver/screenlocker/greeter/greeterapp.cpp e54c216 
>   ksmserver/shutdowndlg.cpp 247c877 
>   plasma/desktop/applets/kickoff/core/itemhandlers.cpp 4e83c37 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.cpp 6f90006 
>   plasma/generic/dataengines/time/timeengine.cpp 2f69e8f 
>   plasma/generic/runners/powerdevil/PowerDevilRunner.cpp 74eb36d 
> 
> Diff: http://git.reviewboard.kde.org/r/110135/diff/
> 
> 
> Testing
> ---
> 
> Compiled, actions work now.
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 110135: Adjust to new suspend session handling

2013-04-23 Thread Lukáš Tinkl 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110135/#review31463
---



kcontrol/randr/module/randrmonitor.cpp


I doubt these actions exist on the FDO object, Dario?



plasma/generic/dataengines/time/timeengine.cpp


This is weird... why would you change this?


- Lukáš Tinkl


On April 23, 2013, 9:12 p.m., Hrvoje Senjan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110135/
> ---
> 
> (Updated April 23, 2013, 9:12 p.m.)
> 
> 
> Review request for Plasma, Solid, Dario Freddi, and Sebastian Kügler.
> 
> 
> Description
> ---
> 
> Suspend/hibernate are now longer are part of
> org.kde.Solid.PowerManagement interface, so adjusting to new one.
> 
> 
> This addresses bug 318737.
> http://bugs.kde.org/show_bug.cgi?id=318737
> 
> 
> Diffs
> -
> 
>   kcontrol/randr/module/randrmonitor.cpp 5a719a4 
>   ksmserver/screenlocker/greeter/greeterapp.cpp e54c216 
>   ksmserver/shutdowndlg.cpp 247c877 
>   plasma/desktop/applets/kickoff/core/itemhandlers.cpp 4e83c37 
>   plasma/generic/dataengines/powermanagement/powermanagementjob.cpp 6f90006 
>   plasma/generic/dataengines/time/timeengine.cpp 2f69e8f 
>   plasma/generic/runners/powerdevil/PowerDevilRunner.cpp 74eb36d 
> 
> Diff: http://git.reviewboard.kde.org/r/110135/diff/
> 
> 
> Testing
> ---
> 
> Compiled, actions work now.
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 110135: Adjust to new suspend session handling

2013-04-23 Thread Hrvoje Senjan 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110135/
---

(Updated April 23, 2013, 7:12 p.m.)


Review request for Plasma, Solid, Dario Freddi, and Sebastian Kügler.


Changes
---

Extended to all users of suspend handling in kde-workspace, and adjusted to FDO 
interface


Summary (updated)
-

Adjust to new suspend session handling


Description
---

Suspend/hibernate are now longer are part of
org.kde.Solid.PowerManagement interface, so adjusting to new one.


This addresses bug 318737.
http://bugs.kde.org/show_bug.cgi?id=318737


Diffs (updated)
-

  kcontrol/randr/module/randrmonitor.cpp 5a719a4 
  ksmserver/screenlocker/greeter/greeterapp.cpp e54c216 
  ksmserver/shutdowndlg.cpp 247c877 
  plasma/desktop/applets/kickoff/core/itemhandlers.cpp 4e83c37 
  plasma/generic/dataengines/powermanagement/powermanagementjob.cpp 6f90006 
  plasma/generic/dataengines/time/timeengine.cpp 2f69e8f 
  plasma/generic/runners/powerdevil/PowerDevilRunner.cpp 74eb36d 

Diff: http://git.reviewboard.kde.org/r/110135/diff/


Testing
---

Compiled, actions work now.


Thanks,

Hrvoje Senjan

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel