Re: Review Request 112073: Partially revert commit 83d3018
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112073/ --- (Updated Aug. 20, 2013, 11:37 a.m.) Status -- This change has been marked as submitted. Review request for Plasma and David Faure. Description --- While the commit may be technically correct, it breaks ksplash for 4.11 release... I've changed unique to multi, if there is a better solution, please hint it ;-) (maybe actually someone meant multi, when typing wait :-) This addresses bug 321695. http://bugs.kde.org/show_bug.cgi?id=321695 Diffs - plasma/desktop/shell/data/plasma-desktop.desktop f37dc57 Diff: http://git.reviewboard.kde.org/r/112073/diff/ Testing --- Yes... starts "normally" as previously/ksplash isn't interupted Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 112073: Partially revert commit 83d3018
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112073/#review38201 --- Ship it! OK. Weird, but I don't have time to debug it. Please commit. - David Faure On Aug. 14, 2013, 12:01 a.m., Hrvoje Senjan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112073/ > --- > > (Updated Aug. 14, 2013, 12:01 a.m.) > > > Review request for Plasma and David Faure. > > > Description > --- > > While the commit may be technically correct, it breaks ksplash for 4.11 > release... > I've changed unique to multi, if there is a better solution, please hint it > ;-) > (maybe actually someone meant multi, when typing wait :-) > > > This addresses bug 321695. > http://bugs.kde.org/show_bug.cgi?id=321695 > > > Diffs > - > > plasma/desktop/shell/data/plasma-desktop.desktop f37dc57 > > Diff: http://git.reviewboard.kde.org/r/112073/diff/ > > > Testing > --- > > Yes... starts "normally" as previously/ksplash isn't interupted > > > Thanks, > > Hrvoje Senjan > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 112073: Partially revert commit 83d3018
> On Aug. 19, 2013, 9:10 a.m., David Faure wrote: > > This is ... extremely surprising. > > plasma-desktop registers to DBus as "org.kde.plasma-desktop", doesn't it? > > That's what "unique" expects (while "multi" expects the PID appended). > > > > In addition, I didn't experience any problems with startup and the splash > > screen... > > > > Are you really sure this change fixes anything? I could be wrong, but I'm > > rather surprised. > > Hrvoje Senjan wrote: > Yes, see https://bugs.kde.org/show_bug.cgi?id=321695#c13 and c17. Or in > c5 and c6 there's confirmation restoring to "wait" also works as expected/as > was before. (In comment 2 there's video which illustrates the issue clearly). > I've validated the issue and the "fix" also myself on two installs. > Tbh, i have also no idea why it breaks it, but looks it does... Can confirm issue too and this patch fix it. - Cedric --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112073/#review38112 --- On Aug. 14, 2013, 12:01 a.m., Hrvoje Senjan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112073/ > --- > > (Updated Aug. 14, 2013, 12:01 a.m.) > > > Review request for Plasma and David Faure. > > > Description > --- > > While the commit may be technically correct, it breaks ksplash for 4.11 > release... > I've changed unique to multi, if there is a better solution, please hint it > ;-) > (maybe actually someone meant multi, when typing wait :-) > > > This addresses bug 321695. > http://bugs.kde.org/show_bug.cgi?id=321695 > > > Diffs > - > > plasma/desktop/shell/data/plasma-desktop.desktop f37dc57 > > Diff: http://git.reviewboard.kde.org/r/112073/diff/ > > > Testing > --- > > Yes... starts "normally" as previously/ksplash isn't interupted > > > Thanks, > > Hrvoje Senjan > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 112073: Partially revert commit 83d3018
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112073/#review38112 --- This is ... extremely surprising. plasma-desktop registers to DBus as "org.kde.plasma-desktop", doesn't it? That's what "unique" expects (while "multi" expects the PID appended). In addition, I didn't experience any problems with startup and the splash screen... Are you really sure this change fixes anything? I could be wrong, but I'm rather surprised. - David Faure On Aug. 14, 2013, 12:01 a.m., Hrvoje Senjan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112073/ > --- > > (Updated Aug. 14, 2013, 12:01 a.m.) > > > Review request for Plasma and David Faure. > > > Description > --- > > While the commit may be technically correct, it breaks ksplash for 4.11 > release... > I've changed unique to multi, if there is a better solution, please hint it > ;-) > (maybe actually someone meant multi, when typing wait :-) > > > This addresses bug 321695. > http://bugs.kde.org/show_bug.cgi?id=321695 > > > Diffs > - > > plasma/desktop/shell/data/plasma-desktop.desktop f37dc57 > > Diff: http://git.reviewboard.kde.org/r/112073/diff/ > > > Testing > --- > > Yes... starts "normally" as previously/ksplash isn't interupted > > > Thanks, > > Hrvoje Senjan > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
