Re: Review Request 112888: Roughly port icon applet to plasma2

[Bhushan Shah]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112888/
---

(Updated Sept. 23, 2013, 3:39 p.m.)


Review request for Plasma, Marco Martin and Sebastian Kügler.


Description
---

Port Icon applet to plasma2

Some issues..

-> Can be resized to 1x1.
-> Still doesn't work for folder, and external URLs.
-> Configuration dialog


Diffs (updated)
-

  plasma/generic/applets/CMakeLists.txt 4ace449 
  plasma/generic/applets/icon/CMakeLists.txt 1094666 
  plasma/generic/applets/icon/package/contents/config/main.xml PRE-CREATION 
  plasma/generic/applets/icon/package/contents/ui/main.qml PRE-CREATION 
  plasma/generic/applets/icon/package/metadata.desktop PRE-CREATION 
  plasma/generic/applets/icon/plugin/icon_p.h PRE-CREATION 
  plasma/generic/applets/icon/plugin/icon_p.cpp PRE-CREATION 
  plasma/generic/applets/icon/plugin/iconplugin.h PRE-CREATION 
  plasma/generic/applets/icon/plugin/iconplugin.cpp PRE-CREATION 
  plasma/generic/applets/icon/plugin/qmldir PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/112888/diff/


Testing
---

1) Compiles
2) Installs
3) Loads

-> Dropping application icon from KickOff - creates icon
-> Dropping files from Dolphin, both executable and normal files - creates icon
-> Dropping folder from Dolphin - creates icon applet but neither icon nor text 
because folder handling is not added yet.

4) Opens URL - Clicking on the icon applet opens url with kfmclient


File Attachments


icons in panel
  http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot1.png
icons as launcher
  http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot2.png
files
  http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot3.png
folders
  http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot4.png


Thanks,

Bhushan Shah

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 112888: Roughly port icon applet to plasma2

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112888/#review40584
---


This review has been submitted with commit 
86473b939a8a485ab6f34e6cbdee916b5fd40c3c by Bhushan Shah to branch 
frameworks-scratch.

- Commit Hook


On Sept. 23, 2013, 3:39 p.m., Bhushan Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112888/
> ---
> 
> (Updated Sept. 23, 2013, 3:39 p.m.)
> 
> 
> Review request for Plasma, Marco Martin and Sebastian Kügler.
> 
> 
> Description
> ---
> 
> Port Icon applet to plasma2
> 
> Some issues..
> 
> -> Can be resized to 1x1.
> -> Still doesn't work for folder, and external URLs.
> -> Configuration dialog
> 
> 
> Diffs
> -
> 
>   plasma/generic/applets/CMakeLists.txt 4ace449 
>   plasma/generic/applets/icon/CMakeLists.txt 1094666 
>   plasma/generic/applets/icon/package/contents/config/main.xml PRE-CREATION 
>   plasma/generic/applets/icon/package/contents/ui/main.qml PRE-CREATION 
>   plasma/generic/applets/icon/package/metadata.desktop PRE-CREATION 
>   plasma/generic/applets/icon/plugin/icon_p.h PRE-CREATION 
>   plasma/generic/applets/icon/plugin/icon_p.cpp PRE-CREATION 
>   plasma/generic/applets/icon/plugin/iconplugin.h PRE-CREATION 
>   plasma/generic/applets/icon/plugin/iconplugin.cpp PRE-CREATION 
>   plasma/generic/applets/icon/plugin/qmldir PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112888/diff/
> 
> 
> Testing
> ---
> 
> 1) Compiles
> 2) Installs
> 3) Loads
> 
> -> Dropping application icon from KickOff - creates icon
> -> Dropping files from Dolphin, both executable and normal files - creates 
> icon
> -> Dropping folder from Dolphin - creates icon applet but neither icon nor 
> text because folder handling is not added yet.
> 
> 4) Opens URL - Clicking on the icon applet opens url with kfmclient
> 
> 
> File Attachments
> 
> 
> icons in panel
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot1.png
> icons as launcher
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot2.png
> files
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot3.png
> folders
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot4.png
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 112888: Roughly port icon applet to plasma2

[Bhushan Shah]

> On Sept. 23, 2013, 3:49 p.m., Sebastian Kügler wrote:
> > plasma/generic/applets/icon/package/contents/ui/main.qml, line 86
> > 
> >
> > You can remove / comment the print statements here I think

keeping it for now.


- Bhushan


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112888/#review40580
---


On Sept. 23, 2013, 3:39 p.m., Bhushan Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112888/
> ---
> 
> (Updated Sept. 23, 2013, 3:39 p.m.)
> 
> 
> Review request for Plasma, Marco Martin and Sebastian Kügler.
> 
> 
> Description
> ---
> 
> Port Icon applet to plasma2
> 
> Some issues..
> 
> -> Can be resized to 1x1.
> -> Still doesn't work for folder, and external URLs.
> -> Configuration dialog
> 
> 
> Diffs
> -
> 
>   plasma/generic/applets/CMakeLists.txt 4ace449 
>   plasma/generic/applets/icon/CMakeLists.txt 1094666 
>   plasma/generic/applets/icon/package/contents/config/main.xml PRE-CREATION 
>   plasma/generic/applets/icon/package/contents/ui/main.qml PRE-CREATION 
>   plasma/generic/applets/icon/package/metadata.desktop PRE-CREATION 
>   plasma/generic/applets/icon/plugin/icon_p.h PRE-CREATION 
>   plasma/generic/applets/icon/plugin/icon_p.cpp PRE-CREATION 
>   plasma/generic/applets/icon/plugin/iconplugin.h PRE-CREATION 
>   plasma/generic/applets/icon/plugin/iconplugin.cpp PRE-CREATION 
>   plasma/generic/applets/icon/plugin/qmldir PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112888/diff/
> 
> 
> Testing
> ---
> 
> 1) Compiles
> 2) Installs
> 3) Loads
> 
> -> Dropping application icon from KickOff - creates icon
> -> Dropping files from Dolphin, both executable and normal files - creates 
> icon
> -> Dropping folder from Dolphin - creates icon applet but neither icon nor 
> text because folder handling is not added yet.
> 
> 4) Opens URL - Clicking on the icon applet opens url with kfmclient
> 
> 
> File Attachments
> 
> 
> icons in panel
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot1.png
> icons as launcher
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot2.png
> files
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot3.png
> folders
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot4.png
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 112888: Roughly port icon applet to plasma2

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112888/
---

(Updated Sept. 23, 2013, 3:59 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, Marco Martin and Sebastian Kügler.


Description
---

Port Icon applet to plasma2

Some issues..

-> Can be resized to 1x1.
-> Still doesn't work for folder, and external URLs.
-> Configuration dialog


Diffs
-

  plasma/generic/applets/CMakeLists.txt 4ace449 
  plasma/generic/applets/icon/CMakeLists.txt 1094666 
  plasma/generic/applets/icon/package/contents/config/main.xml PRE-CREATION 
  plasma/generic/applets/icon/package/contents/ui/main.qml PRE-CREATION 
  plasma/generic/applets/icon/package/metadata.desktop PRE-CREATION 
  plasma/generic/applets/icon/plugin/icon_p.h PRE-CREATION 
  plasma/generic/applets/icon/plugin/icon_p.cpp PRE-CREATION 
  plasma/generic/applets/icon/plugin/iconplugin.h PRE-CREATION 
  plasma/generic/applets/icon/plugin/iconplugin.cpp PRE-CREATION 
  plasma/generic/applets/icon/plugin/qmldir PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/112888/diff/


Testing
---

1) Compiles
2) Installs
3) Loads

-> Dropping application icon from KickOff - creates icon
-> Dropping files from Dolphin, both executable and normal files - creates icon
-> Dropping folder from Dolphin - creates icon applet but neither icon nor text 
because folder handling is not added yet.

4) Opens URL - Clicking on the icon applet opens url with kfmclient


File Attachments


icons in panel
  http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot1.png
icons as launcher
  http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot2.png
files
  http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot3.png
folders
  http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot4.png


Thanks,

Bhushan Shah

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 112888: Roughly port icon applet to plasma2

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112888/#review40580
---

Ship it!


Looking good. :)


plasma/generic/applets/icon/package/contents/ui/main.qml


You can remove / comment the print statements here I think


- Sebastian Kügler


On Sept. 23, 2013, 3:39 p.m., Bhushan Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112888/
> ---
> 
> (Updated Sept. 23, 2013, 3:39 p.m.)
> 
> 
> Review request for Plasma, Marco Martin and Sebastian Kügler.
> 
> 
> Description
> ---
> 
> Port Icon applet to plasma2
> 
> Some issues..
> 
> -> Can be resized to 1x1.
> -> Still doesn't work for folder, and external URLs.
> -> Configuration dialog
> 
> 
> Diffs
> -
> 
>   plasma/generic/applets/CMakeLists.txt 4ace449 
>   plasma/generic/applets/icon/CMakeLists.txt 1094666 
>   plasma/generic/applets/icon/package/contents/config/main.xml PRE-CREATION 
>   plasma/generic/applets/icon/package/contents/ui/main.qml PRE-CREATION 
>   plasma/generic/applets/icon/package/metadata.desktop PRE-CREATION 
>   plasma/generic/applets/icon/plugin/icon_p.h PRE-CREATION 
>   plasma/generic/applets/icon/plugin/icon_p.cpp PRE-CREATION 
>   plasma/generic/applets/icon/plugin/iconplugin.h PRE-CREATION 
>   plasma/generic/applets/icon/plugin/iconplugin.cpp PRE-CREATION 
>   plasma/generic/applets/icon/plugin/qmldir PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112888/diff/
> 
> 
> Testing
> ---
> 
> 1) Compiles
> 2) Installs
> 3) Loads
> 
> -> Dropping application icon from KickOff - creates icon
> -> Dropping files from Dolphin, both executable and normal files - creates 
> icon
> -> Dropping folder from Dolphin - creates icon applet but neither icon nor 
> text because folder handling is not added yet.
> 
> 4) Opens URL - Clicking on the icon applet opens url with kfmclient
> 
> 
> File Attachments
> 
> 
> icons in panel
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot1.png
> icons as launcher
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot2.png
> files
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot3.png
> folders
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot4.png
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 112888: Roughly port icon applet to plasma2

[Bhushan Shah]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112888/
---

(Updated Sept. 23, 2013, 2:56 p.m.)


Review request for Plasma, Marco Martin and Sebastian Kügler.


Changes
---

Q_INVOKABLE -> Q_PROPERTY


Description
---

Port Icon applet to plasma2

Some issues..

-> Can be resized to 1x1.
-> Still doesn't work for folder, and external URLs.
-> Configuration dialog


Diffs (updated)
-

  plasma/generic/applets/CMakeLists.txt 4ace449 
  plasma/generic/applets/icon/CMakeLists.txt 1094666 
  plasma/generic/applets/icon/icon.h 45fa07c 
  plasma/generic/applets/icon/icon.cpp 8288850 
  plasma/generic/applets/icon/package/contents/config/main.xml PRE-CREATION 
  plasma/generic/applets/icon/package/contents/ui/main.qml PRE-CREATION 
  plasma/generic/applets/icon/package/metadata.desktop PRE-CREATION 
  plasma/generic/applets/icon/plasma-applet-icon.desktop 8275ddd 
  plasma/generic/applets/icon/plugin/icon_p.h PRE-CREATION 
  plasma/generic/applets/icon/plugin/icon_p.cpp PRE-CREATION 
  plasma/generic/applets/icon/plugin/iconplugin.h PRE-CREATION 
  plasma/generic/applets/icon/plugin/iconplugin.cpp PRE-CREATION 
  plasma/generic/applets/icon/plugin/qmldir PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/112888/diff/


Testing
---

1) Compiles
2) Installs
3) Loads

-> Dropping application icon from KickOff - creates icon
-> Dropping files from Dolphin, both executable and normal files - creates icon
-> Dropping folder from Dolphin - creates icon applet but neither icon nor text 
because folder handling is not added yet.

4) Opens URL - Clicking on the icon applet opens url with kfmclient


File Attachments


icons in panel
  http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot1.png
icons as launcher
  http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot2.png
files
  http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot3.png
folders
  http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot4.png


Thanks,

Bhushan Shah

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 112888: Roughly port icon applet to plasma2

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112888/#review40573
---



plasma/generic/applets/icon/plugin/icon_p.h


the getters should all be const



plasma/generic/applets/icon/plugin/icon_p.h


arguments should begin with lowercase letters, url, name, icon, genericName 
(or if you want to make the distinction between the arg and the method name 
more clear, use newUrlm newName, etc., or something telling.



plasma/generic/applets/icon/plugin/icon_p.cpp


this is only used in the !fi.isDir() branch, move it there for more narrow 
scoping.



plasma/generic/applets/icon/plugin/icon_p.cpp


I'd prefer to move this to the other signal emissions, just to make sure 
we're done with everything at the same time. Semantically, we're only done 
setting the url once all internal data is updated.



plasma/generic/applets/icon/plugin/icon_p.cpp


space after if



plasma/generic/applets/icon/plugin/icon_p.cpp


const



plasma/generic/applets/icon/plugin/icon_p.cpp


const



plasma/generic/applets/icon/plugin/icon_p.cpp


space after if


- Sebastian Kügler


On Sept. 23, 2013, 2:56 p.m., Bhushan Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112888/
> ---
> 
> (Updated Sept. 23, 2013, 2:56 p.m.)
> 
> 
> Review request for Plasma, Marco Martin and Sebastian Kügler.
> 
> 
> Description
> ---
> 
> Port Icon applet to plasma2
> 
> Some issues..
> 
> -> Can be resized to 1x1.
> -> Still doesn't work for folder, and external URLs.
> -> Configuration dialog
> 
> 
> Diffs
> -
> 
>   plasma/generic/applets/CMakeLists.txt 4ace449 
>   plasma/generic/applets/icon/CMakeLists.txt 1094666 
>   plasma/generic/applets/icon/icon.h 45fa07c 
>   plasma/generic/applets/icon/icon.cpp 8288850 
>   plasma/generic/applets/icon/package/contents/config/main.xml PRE-CREATION 
>   plasma/generic/applets/icon/package/contents/ui/main.qml PRE-CREATION 
>   plasma/generic/applets/icon/package/metadata.desktop PRE-CREATION 
>   plasma/generic/applets/icon/plasma-applet-icon.desktop 8275ddd 
>   plasma/generic/applets/icon/plugin/icon_p.h PRE-CREATION 
>   plasma/generic/applets/icon/plugin/icon_p.cpp PRE-CREATION 
>   plasma/generic/applets/icon/plugin/iconplugin.h PRE-CREATION 
>   plasma/generic/applets/icon/plugin/iconplugin.cpp PRE-CREATION 
>   plasma/generic/applets/icon/plugin/qmldir PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112888/diff/
> 
> 
> Testing
> ---
> 
> 1) Compiles
> 2) Installs
> 3) Loads
> 
> -> Dropping application icon from KickOff - creates icon
> -> Dropping files from Dolphin, both executable and normal files - creates 
> icon
> -> Dropping folder from Dolphin - creates icon applet but neither icon nor 
> text because folder handling is not added yet.
> 
> 4) Opens URL - Clicking on the icon applet opens url with kfmclient
> 
> 
> File Attachments
> 
> 
> icons in panel
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot1.png
> icons as launcher
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot2.png
> files
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot3.png
> folders
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot4.png
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 112888: Roughly port icon applet to plasma2

[Bhushan Shah]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112888/
---

(Updated Sept. 23, 2013, 12:53 p.m.)


Review request for Plasma, Marco Martin and Sebastian Kügler.


Description
---

Port Icon applet to plasma2

Some issues..

-> Can be resized to 1x1.
-> Still doesn't work for folder, and external URLs.
-> Configuration dialog


Diffs (updated)
-

  plasma/generic/applets/CMakeLists.txt 4ace449 
  plasma/generic/applets/icon/CMakeLists.txt 1094666 
  plasma/generic/applets/icon/icon.h 45fa07c 
  plasma/generic/applets/icon/icon.cpp 8288850 
  plasma/generic/applets/icon/package/contents/config/main.xml PRE-CREATION 
  plasma/generic/applets/icon/package/contents/ui/main.qml PRE-CREATION 
  plasma/generic/applets/icon/package/metadata.desktop PRE-CREATION 
  plasma/generic/applets/icon/plasma-applet-icon.desktop 8275ddd 
  plasma/generic/applets/icon/plugin/icon_p.h PRE-CREATION 
  plasma/generic/applets/icon/plugin/icon_p.cpp PRE-CREATION 
  plasma/generic/applets/icon/plugin/iconplugin.h PRE-CREATION 
  plasma/generic/applets/icon/plugin/iconplugin.cpp PRE-CREATION 
  plasma/generic/applets/icon/plugin/qmldir PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/112888/diff/


Testing
---

1) Compiles
2) Installs
3) Loads

-> Dropping application icon from KickOff - creates icon
-> Dropping files from Dolphin, both executable and normal files - creates icon
-> Dropping folder from Dolphin - creates icon applet but neither icon nor text 
because folder handling is not added yet.

4) Opens URL - Clicking on the icon applet opens url with kfmclient


File Attachments


icons in panel
  http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot1.png
icons as launcher
  http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot2.png
files
  http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot3.png
folders
  http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot4.png


Thanks,

Bhushan Shah

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 112888: Roughly port icon applet to plasma2

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112888/#review40557
---



plasma/generic/applets/icon/package/contents/ui/main.qml


spaces around == and || make it more readable


- Sebastian Kügler


On Sept. 23, 2013, 12:37 p.m., Bhushan Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112888/
> ---
> 
> (Updated Sept. 23, 2013, 12:37 p.m.)
> 
> 
> Review request for Plasma, Marco Martin and Sebastian Kügler.
> 
> 
> Description
> ---
> 
> Port Icon applet to plasma2
> 
> Some issues..
> 
> -> Can be resized to 1x1.
> -> Still doesn't work for folder, and external URLs.
> -> Configuration dialog
> 
> 
> Diffs
> -
> 
>   plasma/generic/applets/CMakeLists.txt 4ace449 
>   plasma/generic/applets/icon/CMakeLists.txt 1094666 
>   plasma/generic/applets/icon/icon.h 45fa07c 
>   plasma/generic/applets/icon/icon.cpp 8288850 
>   plasma/generic/applets/icon/package/contents/config/main.xml PRE-CREATION 
>   plasma/generic/applets/icon/package/contents/ui/main.qml PRE-CREATION 
>   plasma/generic/applets/icon/package/metadata.desktop PRE-CREATION 
>   plasma/generic/applets/icon/plasma-applet-icon.desktop 8275ddd 
>   plasma/generic/applets/icon/plugin/icon_p.h PRE-CREATION 
>   plasma/generic/applets/icon/plugin/icon_p.cpp PRE-CREATION 
>   plasma/generic/applets/icon/plugin/iconplugin.h PRE-CREATION 
>   plasma/generic/applets/icon/plugin/iconplugin.cpp PRE-CREATION 
>   plasma/generic/applets/icon/plugin/qmldir PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112888/diff/
> 
> 
> Testing
> ---
> 
> 1) Compiles
> 2) Installs
> 3) Loads
> 
> -> Dropping application icon from KickOff - creates icon
> -> Dropping files from Dolphin, both executable and normal files - creates 
> icon
> -> Dropping folder from Dolphin - creates icon applet but neither icon nor 
> text because folder handling is not added yet.
> 
> 4) Opens URL - Clicking on the icon applet opens url with kfmclient
> 
> 
> File Attachments
> 
> 
> icons in panel
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot1.png
> icons as launcher
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot2.png
> files
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot3.png
> folders
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot4.png
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 112888: Roughly port icon applet to plasma2

[Sebastian Kügler]

> On Sept. 23, 2013, 9:47 a.m., Sebastian Kügler wrote:
> > plasma/generic/applets/icon/plugin/icon_p.h, line 31
> > 
> >
> > Why Q_INVOKABLE, and not Q_PROPERTIES here? (For all three accessors). 
> > That would seem more declarative.
> > 
> > This would also make the "remote" case easier, when you have to stat a 
> > remote file asynchronously and only know details after the network request.
> 
> Bhushan Shah wrote:
> Passing url is my main problem here..
> 
> Sebastian Kügler wrote:
> I'd add a writable property url, which then updates all the other 
> properties via property bindings.
> 
> Bhushan Shah wrote:
> But I don't have url at the time of applet creation.. keeping it for 
> later..

That's fine. As soon as you have it, you can set it, and thanks to property 
bindings, all users will update automatically. :)


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112888/#review40507
---


On Sept. 23, 2013, 12:37 p.m., Bhushan Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112888/
> ---
> 
> (Updated Sept. 23, 2013, 12:37 p.m.)
> 
> 
> Review request for Plasma, Marco Martin and Sebastian Kügler.
> 
> 
> Description
> ---
> 
> Port Icon applet to plasma2
> 
> Some issues..
> 
> -> Can be resized to 1x1.
> -> Still doesn't work for folder, and external URLs.
> -> Configuration dialog
> 
> 
> Diffs
> -
> 
>   plasma/generic/applets/CMakeLists.txt 4ace449 
>   plasma/generic/applets/icon/CMakeLists.txt 1094666 
>   plasma/generic/applets/icon/icon.h 45fa07c 
>   plasma/generic/applets/icon/icon.cpp 8288850 
>   plasma/generic/applets/icon/package/contents/config/main.xml PRE-CREATION 
>   plasma/generic/applets/icon/package/contents/ui/main.qml PRE-CREATION 
>   plasma/generic/applets/icon/package/metadata.desktop PRE-CREATION 
>   plasma/generic/applets/icon/plasma-applet-icon.desktop 8275ddd 
>   plasma/generic/applets/icon/plugin/icon_p.h PRE-CREATION 
>   plasma/generic/applets/icon/plugin/icon_p.cpp PRE-CREATION 
>   plasma/generic/applets/icon/plugin/iconplugin.h PRE-CREATION 
>   plasma/generic/applets/icon/plugin/iconplugin.cpp PRE-CREATION 
>   plasma/generic/applets/icon/plugin/qmldir PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112888/diff/
> 
> 
> Testing
> ---
> 
> 1) Compiles
> 2) Installs
> 3) Loads
> 
> -> Dropping application icon from KickOff - creates icon
> -> Dropping files from Dolphin, both executable and normal files - creates 
> icon
> -> Dropping folder from Dolphin - creates icon applet but neither icon nor 
> text because folder handling is not added yet.
> 
> 4) Opens URL - Clicking on the icon applet opens url with kfmclient
> 
> 
> File Attachments
> 
> 
> icons in panel
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot1.png
> icons as launcher
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot2.png
> files
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot3.png
> folders
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot4.png
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 112888: Roughly port icon applet to plasma2

[Bhushan Shah]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112888/
---

(Updated Sept. 23, 2013, 12:37 p.m.)


Review request for Plasma, Marco Martin and Sebastian Kügler.


Changes
---

fix issues, license


Description
---

Port Icon applet to plasma2

Some issues..

-> Can be resized to 1x1.
-> Still doesn't work for folder, and external URLs.
-> Configuration dialog


Diffs (updated)
-

  plasma/generic/applets/CMakeLists.txt 4ace449 
  plasma/generic/applets/icon/CMakeLists.txt 1094666 
  plasma/generic/applets/icon/icon.h 45fa07c 
  plasma/generic/applets/icon/icon.cpp 8288850 
  plasma/generic/applets/icon/package/contents/config/main.xml PRE-CREATION 
  plasma/generic/applets/icon/package/contents/ui/main.qml PRE-CREATION 
  plasma/generic/applets/icon/package/metadata.desktop PRE-CREATION 
  plasma/generic/applets/icon/plasma-applet-icon.desktop 8275ddd 
  plasma/generic/applets/icon/plugin/icon_p.h PRE-CREATION 
  plasma/generic/applets/icon/plugin/icon_p.cpp PRE-CREATION 
  plasma/generic/applets/icon/plugin/iconplugin.h PRE-CREATION 
  plasma/generic/applets/icon/plugin/iconplugin.cpp PRE-CREATION 
  plasma/generic/applets/icon/plugin/qmldir PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/112888/diff/


Testing
---

1) Compiles
2) Installs
3) Loads

-> Dropping application icon from KickOff - creates icon
-> Dropping files from Dolphin, both executable and normal files - creates icon
-> Dropping folder from Dolphin - creates icon applet but neither icon nor text 
because folder handling is not added yet.

4) Opens URL - Clicking on the icon applet opens url with kfmclient


File Attachments


icons in panel
  http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot1.png
icons as launcher
  http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot2.png
files
  http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot3.png
folders
  http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot4.png


Thanks,

Bhushan Shah

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 112888: Roughly port icon applet to plasma2

[Bhushan Shah]

> On Sept. 23, 2013, 9:47 a.m., Sebastian Kügler wrote:
> > plasma/generic/applets/icon/plugin/icon_p.h, line 31
> > 
> >
> > Why Q_INVOKABLE, and not Q_PROPERTIES here? (For all three accessors). 
> > That would seem more declarative.
> > 
> > This would also make the "remote" case easier, when you have to stat a 
> > remote file asynchronously and only know details after the network request.
> 
> Bhushan Shah wrote:
> Passing url is my main problem here..
> 
> Sebastian Kügler wrote:
> I'd add a writable property url, which then updates all the other 
> properties via property bindings.

But I don't have url at the time of applet creation.. keeping it for later..


- Bhushan


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112888/#review40507
---


On Sept. 23, 2013, 8:26 a.m., Bhushan Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112888/
> ---
> 
> (Updated Sept. 23, 2013, 8:26 a.m.)
> 
> 
> Review request for Plasma, Marco Martin and Sebastian Kügler.
> 
> 
> Description
> ---
> 
> Port Icon applet to plasma2
> 
> Some issues..
> 
> -> Can be resized to 1x1.
> -> Still doesn't work for folder, and external URLs.
> -> Configuration dialog
> 
> 
> Diffs
> -
> 
>   plasma/generic/applets/CMakeLists.txt 4ace449 
>   plasma/generic/applets/icon/CMakeLists.txt 1094666 
>   plasma/generic/applets/icon/icon.h 45fa07c 
>   plasma/generic/applets/icon/icon.cpp 8288850 
>   plasma/generic/applets/icon/package/contents/config/main.xml PRE-CREATION 
>   plasma/generic/applets/icon/package/contents/ui/main.qml PRE-CREATION 
>   plasma/generic/applets/icon/package/metadata.desktop PRE-CREATION 
>   plasma/generic/applets/icon/plasma-applet-icon.desktop 8275ddd 
>   plasma/generic/applets/icon/plugin/icon_p.h PRE-CREATION 
>   plasma/generic/applets/icon/plugin/icon_p.cpp PRE-CREATION 
>   plasma/generic/applets/icon/plugin/iconplugin.h PRE-CREATION 
>   plasma/generic/applets/icon/plugin/iconplugin.cpp PRE-CREATION 
>   plasma/generic/applets/icon/plugin/qmldir PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112888/diff/
> 
> 
> Testing
> ---
> 
> 1) Compiles
> 2) Installs
> 3) Loads
> 
> -> Dropping application icon from KickOff - creates icon
> -> Dropping files from Dolphin, both executable and normal files - creates 
> icon
> -> Dropping folder from Dolphin - creates icon applet but neither icon nor 
> text because folder handling is not added yet.
> 
> 4) Opens URL - Clicking on the icon applet opens url with kfmclient
> 
> 
> File Attachments
> 
> 
> icons in panel
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot1.png
> icons as launcher
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot2.png
> files
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot3.png
> folders
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot4.png
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 112888: Roughly port icon applet to plasma2

[Sebastian Kügler]

> On Sept. 23, 2013, 9:47 a.m., Sebastian Kügler wrote:
> > plasma/generic/applets/icon/plugin/icon_p.h, line 31
> > 
> >
> > Why Q_INVOKABLE, and not Q_PROPERTIES here? (For all three accessors). 
> > That would seem more declarative.
> > 
> > This would also make the "remote" case easier, when you have to stat a 
> > remote file asynchronously and only know details after the network request.
> 
> Bhushan Shah wrote:
> Passing url is my main problem here..

I'd add a writable property url, which then updates all the other properties 
via property bindings. 


> On Sept. 23, 2013, 9:47 a.m., Sebastian Kügler wrote:
> > plasma/generic/applets/icon/plugin/icon_p.cpp, line 76
> > 
> >
> > no new line
> 
> Bhushan Shah wrote:
> ??

} else {

not 

}
else {


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112888/#review40507
---


On Sept. 23, 2013, 8:26 a.m., Bhushan Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112888/
> ---
> 
> (Updated Sept. 23, 2013, 8:26 a.m.)
> 
> 
> Review request for Plasma, Marco Martin and Sebastian Kügler.
> 
> 
> Description
> ---
> 
> Port Icon applet to plasma2
> 
> Some issues..
> 
> -> Can be resized to 1x1.
> -> Still doesn't work for folder, and external URLs.
> -> Configuration dialog
> 
> 
> Diffs
> -
> 
>   plasma/generic/applets/CMakeLists.txt 4ace449 
>   plasma/generic/applets/icon/CMakeLists.txt 1094666 
>   plasma/generic/applets/icon/icon.h 45fa07c 
>   plasma/generic/applets/icon/icon.cpp 8288850 
>   plasma/generic/applets/icon/package/contents/config/main.xml PRE-CREATION 
>   plasma/generic/applets/icon/package/contents/ui/main.qml PRE-CREATION 
>   plasma/generic/applets/icon/package/metadata.desktop PRE-CREATION 
>   plasma/generic/applets/icon/plasma-applet-icon.desktop 8275ddd 
>   plasma/generic/applets/icon/plugin/icon_p.h PRE-CREATION 
>   plasma/generic/applets/icon/plugin/icon_p.cpp PRE-CREATION 
>   plasma/generic/applets/icon/plugin/iconplugin.h PRE-CREATION 
>   plasma/generic/applets/icon/plugin/iconplugin.cpp PRE-CREATION 
>   plasma/generic/applets/icon/plugin/qmldir PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112888/diff/
> 
> 
> Testing
> ---
> 
> 1) Compiles
> 2) Installs
> 3) Loads
> 
> -> Dropping application icon from KickOff - creates icon
> -> Dropping files from Dolphin, both executable and normal files - creates 
> icon
> -> Dropping folder from Dolphin - creates icon applet but neither icon nor 
> text because folder handling is not added yet.
> 
> 4) Opens URL - Clicking on the icon applet opens url with kfmclient
> 
> 
> File Attachments
> 
> 
> icons in panel
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot1.png
> icons as launcher
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot2.png
> files
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot3.png
> folders
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot4.png
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 112888: Roughly port icon applet to plasma2

[Sebastian Kügler]

> On Sept. 23, 2013, 8:30 a.m., Bhushan Shah wrote:
> > File Attachment: icons as launcher
> > 
> >
> > I am missing glow as of older icons.. how to get it?

I think we had custom painting routine for that. This most likely will need to 
be rethought for Plasma 2. Maybe add a rounded lozenge around the text for now? 
You could also ask Eike Hein (Sho on IRC) what he used for the text in the 
taskbar.


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112888/#review40500
---


On Sept. 23, 2013, 8:26 a.m., Bhushan Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112888/
> ---
> 
> (Updated Sept. 23, 2013, 8:26 a.m.)
> 
> 
> Review request for Plasma, Marco Martin and Sebastian Kügler.
> 
> 
> Description
> ---
> 
> Port Icon applet to plasma2
> 
> Some issues..
> 
> -> Can be resized to 1x1.
> -> Still doesn't work for folder, and external URLs.
> -> Configuration dialog
> 
> 
> Diffs
> -
> 
>   plasma/generic/applets/CMakeLists.txt 4ace449 
>   plasma/generic/applets/icon/CMakeLists.txt 1094666 
>   plasma/generic/applets/icon/icon.h 45fa07c 
>   plasma/generic/applets/icon/icon.cpp 8288850 
>   plasma/generic/applets/icon/package/contents/config/main.xml PRE-CREATION 
>   plasma/generic/applets/icon/package/contents/ui/main.qml PRE-CREATION 
>   plasma/generic/applets/icon/package/metadata.desktop PRE-CREATION 
>   plasma/generic/applets/icon/plasma-applet-icon.desktop 8275ddd 
>   plasma/generic/applets/icon/plugin/icon_p.h PRE-CREATION 
>   plasma/generic/applets/icon/plugin/icon_p.cpp PRE-CREATION 
>   plasma/generic/applets/icon/plugin/iconplugin.h PRE-CREATION 
>   plasma/generic/applets/icon/plugin/iconplugin.cpp PRE-CREATION 
>   plasma/generic/applets/icon/plugin/qmldir PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112888/diff/
> 
> 
> Testing
> ---
> 
> 1) Compiles
> 2) Installs
> 3) Loads
> 
> -> Dropping application icon from KickOff - creates icon
> -> Dropping files from Dolphin, both executable and normal files - creates 
> icon
> -> Dropping folder from Dolphin - creates icon applet but neither icon nor 
> text because folder handling is not added yet.
> 
> 4) Opens URL - Clicking on the icon applet opens url with kfmclient
> 
> 
> File Attachments
> 
> 
> icons in panel
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot1.png
> icons as launcher
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot2.png
> files
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot3.png
> folders
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot4.png
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 112888: Roughly port icon applet to plasma2

[Bhushan Shah]

> On Sept. 23, 2013, 9:47 a.m., Sebastian Kügler wrote:
> > plasma/generic/applets/icon/plugin/icon_p.h, line 31
> > 
> >
> > Why Q_INVOKABLE, and not Q_PROPERTIES here? (For all three accessors). 
> > That would seem more declarative.
> > 
> > This would also make the "remote" case easier, when you have to stat a 
> > remote file asynchronously and only know details after the network request.

Passing url is my main problem here..


- Bhushan


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112888/#review40507
---


On Sept. 23, 2013, 8:26 a.m., Bhushan Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112888/
> ---
> 
> (Updated Sept. 23, 2013, 8:26 a.m.)
> 
> 
> Review request for Plasma, Marco Martin and Sebastian Kügler.
> 
> 
> Description
> ---
> 
> Port Icon applet to plasma2
> 
> Some issues..
> 
> -> Can be resized to 1x1.
> -> Still doesn't work for folder, and external URLs.
> -> Configuration dialog
> 
> 
> Diffs
> -
> 
>   plasma/generic/applets/CMakeLists.txt 4ace449 
>   plasma/generic/applets/icon/CMakeLists.txt 1094666 
>   plasma/generic/applets/icon/icon.h 45fa07c 
>   plasma/generic/applets/icon/icon.cpp 8288850 
>   plasma/generic/applets/icon/package/contents/config/main.xml PRE-CREATION 
>   plasma/generic/applets/icon/package/contents/ui/main.qml PRE-CREATION 
>   plasma/generic/applets/icon/package/metadata.desktop PRE-CREATION 
>   plasma/generic/applets/icon/plasma-applet-icon.desktop 8275ddd 
>   plasma/generic/applets/icon/plugin/icon_p.h PRE-CREATION 
>   plasma/generic/applets/icon/plugin/icon_p.cpp PRE-CREATION 
>   plasma/generic/applets/icon/plugin/iconplugin.h PRE-CREATION 
>   plasma/generic/applets/icon/plugin/iconplugin.cpp PRE-CREATION 
>   plasma/generic/applets/icon/plugin/qmldir PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112888/diff/
> 
> 
> Testing
> ---
> 
> 1) Compiles
> 2) Installs
> 3) Loads
> 
> -> Dropping application icon from KickOff - creates icon
> -> Dropping files from Dolphin, both executable and normal files - creates 
> icon
> -> Dropping folder from Dolphin - creates icon applet but neither icon nor 
> text because folder handling is not added yet.
> 
> 4) Opens URL - Clicking on the icon applet opens url with kfmclient
> 
> 
> File Attachments
> 
> 
> icons in panel
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot1.png
> icons as launcher
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot2.png
> files
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot3.png
> folders
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot4.png
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 112888: Roughly port icon applet to plasma2

[Bhushan Shah]

> On Sept. 23, 2013, 9:47 a.m., Sebastian Kügler wrote:
> > plasma/generic/applets/icon/plugin/icon_p.cpp, line 76
> > 
> >
> > no new line

??


- Bhushan


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112888/#review40507
---


On Sept. 23, 2013, 8:26 a.m., Bhushan Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112888/
> ---
> 
> (Updated Sept. 23, 2013, 8:26 a.m.)
> 
> 
> Review request for Plasma, Marco Martin and Sebastian Kügler.
> 
> 
> Description
> ---
> 
> Port Icon applet to plasma2
> 
> Some issues..
> 
> -> Can be resized to 1x1.
> -> Still doesn't work for folder, and external URLs.
> -> Configuration dialog
> 
> 
> Diffs
> -
> 
>   plasma/generic/applets/CMakeLists.txt 4ace449 
>   plasma/generic/applets/icon/CMakeLists.txt 1094666 
>   plasma/generic/applets/icon/icon.h 45fa07c 
>   plasma/generic/applets/icon/icon.cpp 8288850 
>   plasma/generic/applets/icon/package/contents/config/main.xml PRE-CREATION 
>   plasma/generic/applets/icon/package/contents/ui/main.qml PRE-CREATION 
>   plasma/generic/applets/icon/package/metadata.desktop PRE-CREATION 
>   plasma/generic/applets/icon/plasma-applet-icon.desktop 8275ddd 
>   plasma/generic/applets/icon/plugin/icon_p.h PRE-CREATION 
>   plasma/generic/applets/icon/plugin/icon_p.cpp PRE-CREATION 
>   plasma/generic/applets/icon/plugin/iconplugin.h PRE-CREATION 
>   plasma/generic/applets/icon/plugin/iconplugin.cpp PRE-CREATION 
>   plasma/generic/applets/icon/plugin/qmldir PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112888/diff/
> 
> 
> Testing
> ---
> 
> 1) Compiles
> 2) Installs
> 3) Loads
> 
> -> Dropping application icon from KickOff - creates icon
> -> Dropping files from Dolphin, both executable and normal files - creates 
> icon
> -> Dropping folder from Dolphin - creates icon applet but neither icon nor 
> text because folder handling is not added yet.
> 
> 4) Opens URL - Clicking on the icon applet opens url with kfmclient
> 
> 
> File Attachments
> 
> 
> icons in panel
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot1.png
> icons as launcher
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot2.png
> files
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot3.png
> folders
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot4.png
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 112888: Roughly port icon applet to plasma2

[Sebastian Kügler]

> On Sept. 23, 2013, 8:28 a.m., Bhushan Shah wrote:
> > File Attachment: files
> > 
> >
> > Show extension or not?

This is a bit of a complicated topic, actually. Quick explanation. Not showing 
the extension bears some security risk. You could have a nasty executable, that 
uses an image as icon. When clicking on it, you're running a programme, rather 
than opening an image. (Now this is not downloaded content, so it's not *that* 
bad, but we'll probably still need to take this into account.

Have you looked at the original Icon widget what it does here?


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112888/#review40498
---


On Sept. 23, 2013, 8:26 a.m., Bhushan Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112888/
> ---
> 
> (Updated Sept. 23, 2013, 8:26 a.m.)
> 
> 
> Review request for Plasma, Marco Martin and Sebastian Kügler.
> 
> 
> Description
> ---
> 
> Port Icon applet to plasma2
> 
> Some issues..
> 
> -> Can be resized to 1x1.
> -> Still doesn't work for folder, and external URLs.
> -> Configuration dialog
> 
> 
> Diffs
> -
> 
>   plasma/generic/applets/CMakeLists.txt 4ace449 
>   plasma/generic/applets/icon/CMakeLists.txt 1094666 
>   plasma/generic/applets/icon/icon.h 45fa07c 
>   plasma/generic/applets/icon/icon.cpp 8288850 
>   plasma/generic/applets/icon/package/contents/config/main.xml PRE-CREATION 
>   plasma/generic/applets/icon/package/contents/ui/main.qml PRE-CREATION 
>   plasma/generic/applets/icon/package/metadata.desktop PRE-CREATION 
>   plasma/generic/applets/icon/plasma-applet-icon.desktop 8275ddd 
>   plasma/generic/applets/icon/plugin/icon_p.h PRE-CREATION 
>   plasma/generic/applets/icon/plugin/icon_p.cpp PRE-CREATION 
>   plasma/generic/applets/icon/plugin/iconplugin.h PRE-CREATION 
>   plasma/generic/applets/icon/plugin/iconplugin.cpp PRE-CREATION 
>   plasma/generic/applets/icon/plugin/qmldir PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112888/diff/
> 
> 
> Testing
> ---
> 
> 1) Compiles
> 2) Installs
> 3) Loads
> 
> -> Dropping application icon from KickOff - creates icon
> -> Dropping files from Dolphin, both executable and normal files - creates 
> icon
> -> Dropping folder from Dolphin - creates icon applet but neither icon nor 
> text because folder handling is not added yet.
> 
> 4) Opens URL - Clicking on the icon applet opens url with kfmclient
> 
> 
> File Attachments
> 
> 
> icons in panel
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot1.png
> icons as launcher
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot2.png
> files
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot3.png
> folders
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot4.png
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 112888: Roughly port icon applet to plasma2

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112888/#review40507
---



plasma/generic/applets/icon/package/contents/ui/main.qml


For license, we prefer the GPL with KDE e.V. exception. I'll leave this up 
to you whether you think this is OK for this code or not. (As long as it's GPL 
or LGPL (or more liberal), we'll accept it.)

The preferred one would be the second option here:
http://techbase.kde.org/Policies/Licensing_Policy#GPL_Header



plasma/generic/applets/icon/package/contents/ui/main.qml


Use 16 here, I'd say. 1x1 icons don't make sense.



plasma/generic/applets/icon/package/contents/ui/main.qml


This will not work well for 
iconswithlongnamebutwithoutspacesinthename.extension. :)



plasma/generic/applets/icon/package/metadata.desktop


This should probably be 32,32 or 48,48. 100 is not among the standard icon 
sizes.



plasma/generic/applets/icon/plugin/icon_p.h


Why Q_INVOKABLE, and not Q_PROPERTIES here? (For all three accessors). That 
would seem more declarative.

This would also make the "remote" case easier, when you have to stat a 
remote file asynchronously and only know details after the network request.



plasma/generic/applets/icon/plugin/icon_p.cpp


m_ is for members



plasma/generic/applets/icon/plugin/icon_p.cpp


url.fileName(); is not enough here?



plasma/generic/applets/icon/plugin/icon_p.cpp


m_ is for members, use icon or iconName here.



plasma/generic/applets/icon/plugin/icon_p.cpp


trailing whitespace



plasma/generic/applets/icon/plugin/icon_p.cpp


} else ...

(no new line)



plasma/generic/applets/icon/plugin/icon_p.cpp


m_ prefix is used for member variables. Rename it to genericName for 
example.



plasma/generic/applets/icon/plugin/icon_p.cpp


no new line


Definitely going in the right direction. Let's get a few issues I've pointed 
out inside fixed, then merge it into frameworks-scratch and finish it up there.

- Sebastian Kügler


On Sept. 23, 2013, 8:26 a.m., Bhushan Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112888/
> ---
> 
> (Updated Sept. 23, 2013, 8:26 a.m.)
> 
> 
> Review request for Plasma, Marco Martin and Sebastian Kügler.
> 
> 
> Description
> ---
> 
> Port Icon applet to plasma2
> 
> Some issues..
> 
> -> Can be resized to 1x1.
> -> Still doesn't work for folder, and external URLs.
> -> Configuration dialog
> 
> 
> Diffs
> -
> 
>   plasma/generic/applets/CMakeLists.txt 4ace449 
>   plasma/generic/applets/icon/CMakeLists.txt 1094666 
>   plasma/generic/applets/icon/icon.h 45fa07c 
>   plasma/generic/applets/icon/icon.cpp 8288850 
>   plasma/generic/applets/icon/package/contents/config/main.xml PRE-CREATION 
>   plasma/generic/applets/icon/package/contents/ui/main.qml PRE-CREATION 
>   plasma/generic/applets/icon/package/metadata.desktop PRE-CREATION 
>   plasma/generic/applets/icon/plasma-applet-icon.desktop 8275ddd 
>   plasma/generic/applets/icon/plugin/icon_p.h PRE-CREATION 
>   plasma/generic/applets/icon/plugin/icon_p.cpp PRE-CREATION 
>   plasma/generic/applets/icon/plugin/iconplugin.h PRE-CREATION 
>   plasma/generic/applets/icon/plugin/iconplugin.cpp PRE-CREATION 
>   plasma/generic/applets/icon/plugin/qmldir PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112888/diff/
> 
> 
> Testing
> ---
> 
> 1) Compiles
> 2) Installs
> 3) Loads
> 
> -> Dropping application icon from KickOff - creates icon
> -> Dropping files from Dolphin, both executable and normal files - creates 
> icon
> -> Dropping folder from Dolphin - creates icon applet but neither icon nor 
> text because folder handling is not added yet.
> 
> 4) Opens URL - Clicking on the icon applet opens url with kfmclient
> 
> 
> File Attachments
> 
> 
> icons in panel
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot1.png
> icons as launcher
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot2.png
> files
>   http://git.r

Re: Review Request 112888: Roughly port icon applet to plasma2

[Bhushan Shah]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112888/#review40500
---



File Attachment: icons as launcher

I am missing glow as of older icons.. how to get it?

- Bhushan Shah


On Sept. 23, 2013, 8:26 a.m., Bhushan Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112888/
> ---
> 
> (Updated Sept. 23, 2013, 8:26 a.m.)
> 
> 
> Review request for Plasma, Marco Martin and Sebastian Kügler.
> 
> 
> Description
> ---
> 
> Port Icon applet to plasma2
> 
> Some issues..
> 
> -> Can be resized to 1x1.
> -> Still doesn't work for folder, and external URLs.
> -> Configuration dialog
> 
> 
> Diffs
> -
> 
>   plasma/generic/applets/CMakeLists.txt 4ace449 
>   plasma/generic/applets/icon/CMakeLists.txt 1094666 
>   plasma/generic/applets/icon/icon.h 45fa07c 
>   plasma/generic/applets/icon/icon.cpp 8288850 
>   plasma/generic/applets/icon/package/contents/config/main.xml PRE-CREATION 
>   plasma/generic/applets/icon/package/contents/ui/main.qml PRE-CREATION 
>   plasma/generic/applets/icon/package/metadata.desktop PRE-CREATION 
>   plasma/generic/applets/icon/plasma-applet-icon.desktop 8275ddd 
>   plasma/generic/applets/icon/plugin/icon_p.h PRE-CREATION 
>   plasma/generic/applets/icon/plugin/icon_p.cpp PRE-CREATION 
>   plasma/generic/applets/icon/plugin/iconplugin.h PRE-CREATION 
>   plasma/generic/applets/icon/plugin/iconplugin.cpp PRE-CREATION 
>   plasma/generic/applets/icon/plugin/qmldir PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112888/diff/
> 
> 
> Testing
> ---
> 
> 1) Compiles
> 2) Installs
> 3) Loads
> 
> -> Dropping application icon from KickOff - creates icon
> -> Dropping files from Dolphin, both executable and normal files - creates 
> icon
> -> Dropping folder from Dolphin - creates icon applet but neither icon nor 
> text because folder handling is not added yet.
> 
> 4) Opens URL - Clicking on the icon applet opens url with kfmclient
> 
> 
> File Attachments
> 
> 
> icons in panel
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot1.png
> icons as launcher
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot2.png
> files
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot3.png
> folders
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot4.png
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 112888: Roughly port icon applet to plasma2

[Bhushan Shah]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112888/#review40499
---



File Attachment: folders

Will fix this

- Bhushan Shah


On Sept. 23, 2013, 8:26 a.m., Bhushan Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112888/
> ---
> 
> (Updated Sept. 23, 2013, 8:26 a.m.)
> 
> 
> Review request for Plasma, Marco Martin and Sebastian Kügler.
> 
> 
> Description
> ---
> 
> Port Icon applet to plasma2
> 
> Some issues..
> 
> -> Can be resized to 1x1.
> -> Still doesn't work for folder, and external URLs.
> -> Configuration dialog
> 
> 
> Diffs
> -
> 
>   plasma/generic/applets/CMakeLists.txt 4ace449 
>   plasma/generic/applets/icon/CMakeLists.txt 1094666 
>   plasma/generic/applets/icon/icon.h 45fa07c 
>   plasma/generic/applets/icon/icon.cpp 8288850 
>   plasma/generic/applets/icon/package/contents/config/main.xml PRE-CREATION 
>   plasma/generic/applets/icon/package/contents/ui/main.qml PRE-CREATION 
>   plasma/generic/applets/icon/package/metadata.desktop PRE-CREATION 
>   plasma/generic/applets/icon/plasma-applet-icon.desktop 8275ddd 
>   plasma/generic/applets/icon/plugin/icon_p.h PRE-CREATION 
>   plasma/generic/applets/icon/plugin/icon_p.cpp PRE-CREATION 
>   plasma/generic/applets/icon/plugin/iconplugin.h PRE-CREATION 
>   plasma/generic/applets/icon/plugin/iconplugin.cpp PRE-CREATION 
>   plasma/generic/applets/icon/plugin/qmldir PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112888/diff/
> 
> 
> Testing
> ---
> 
> 1) Compiles
> 2) Installs
> 3) Loads
> 
> -> Dropping application icon from KickOff - creates icon
> -> Dropping files from Dolphin, both executable and normal files - creates 
> icon
> -> Dropping folder from Dolphin - creates icon applet but neither icon nor 
> text because folder handling is not added yet.
> 
> 4) Opens URL - Clicking on the icon applet opens url with kfmclient
> 
> 
> File Attachments
> 
> 
> icons in panel
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot1.png
> icons as launcher
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot2.png
> files
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot3.png
> folders
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot4.png
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 112888: Roughly port icon applet to plasma2

[Bhushan Shah]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112888/#review40498
---



File Attachment: files

Show extension or not?

- Bhushan Shah


On Sept. 23, 2013, 8:26 a.m., Bhushan Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112888/
> ---
> 
> (Updated Sept. 23, 2013, 8:26 a.m.)
> 
> 
> Review request for Plasma, Marco Martin and Sebastian Kügler.
> 
> 
> Description
> ---
> 
> Port Icon applet to plasma2
> 
> Some issues..
> 
> -> Can be resized to 1x1.
> -> Still doesn't work for folder, and external URLs.
> -> Configuration dialog
> 
> 
> Diffs
> -
> 
>   plasma/generic/applets/CMakeLists.txt 4ace449 
>   plasma/generic/applets/icon/CMakeLists.txt 1094666 
>   plasma/generic/applets/icon/icon.h 45fa07c 
>   plasma/generic/applets/icon/icon.cpp 8288850 
>   plasma/generic/applets/icon/package/contents/config/main.xml PRE-CREATION 
>   plasma/generic/applets/icon/package/contents/ui/main.qml PRE-CREATION 
>   plasma/generic/applets/icon/package/metadata.desktop PRE-CREATION 
>   plasma/generic/applets/icon/plasma-applet-icon.desktop 8275ddd 
>   plasma/generic/applets/icon/plugin/icon_p.h PRE-CREATION 
>   plasma/generic/applets/icon/plugin/icon_p.cpp PRE-CREATION 
>   plasma/generic/applets/icon/plugin/iconplugin.h PRE-CREATION 
>   plasma/generic/applets/icon/plugin/iconplugin.cpp PRE-CREATION 
>   plasma/generic/applets/icon/plugin/qmldir PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112888/diff/
> 
> 
> Testing
> ---
> 
> 1) Compiles
> 2) Installs
> 3) Loads
> 
> -> Dropping application icon from KickOff - creates icon
> -> Dropping files from Dolphin, both executable and normal files - creates 
> icon
> -> Dropping folder from Dolphin - creates icon applet but neither icon nor 
> text because folder handling is not added yet.
> 
> 4) Opens URL - Clicking on the icon applet opens url with kfmclient
> 
> 
> File Attachments
> 
> 
> icons in panel
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot1.png
> icons as launcher
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot2.png
> files
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot3.png
> folders
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot4.png
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel