Re: Review Request 113504: Fix krunner calculator letter check
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113504/#review42695 --- Ship it! Ship It! - Sebastian Kügler On Oct. 30, 2013, 12:25 a.m., Christoph Feck wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113504/ > --- > > (Updated Oct. 30, 2013, 12:25 a.m.) > > > Review request for kde-workspace and Plasma. > > > Bugs: 326059 > http://bugs.kde.org/show_bug.cgi?id=326059 > > > Repository: kde-workspace > > > Description > --- > > The calculator runner now supports the syntax without the '=', so you can > simply type in '3+5' and have the result. An additional commit added a letter > check, so that it will not try to compute with normal text input, but this > broke any calculations with any functions, such as '=6*asin 0.5' etc. > > This commit removes the letter check in case the user had explicitly typed > the '=', restoring 4.10 behavior. If I understand the letter check correctly, > it is very hard to support functions in the case the user had omitted the '=' > > > Diffs > - > > plasma/generic/runners/calculator/calculatorrunner.cpp 0d52301 > > Diff: http://git.reviewboard.kde.org/r/113504/diff/ > > > Testing > --- > > > Thanks, > > Christoph Feck > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 113504: Fix krunner calculator letter check
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113504/#review42697 --- This review has been submitted with commit ceb3114fc6f7db0c5571e1d7c4e1c2a8a8bf3dd0 by Christoph Feck to branch KDE/4.11. - Commit Hook On Oct. 30, 2013, 12:25 a.m., Christoph Feck wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113504/ > --- > > (Updated Oct. 30, 2013, 12:25 a.m.) > > > Review request for kde-workspace and Plasma. > > > Bugs: 326059 > http://bugs.kde.org/show_bug.cgi?id=326059 > > > Repository: kde-workspace > > > Description > --- > > The calculator runner now supports the syntax without the '=', so you can > simply type in '3+5' and have the result. An additional commit added a letter > check, so that it will not try to compute with normal text input, but this > broke any calculations with any functions, such as '=6*asin 0.5' etc. > > This commit removes the letter check in case the user had explicitly typed > the '=', restoring 4.10 behavior. If I understand the letter check correctly, > it is very hard to support functions in the case the user had omitted the '=' > > > Diffs > - > > plasma/generic/runners/calculator/calculatorrunner.cpp 0d52301 > > Diff: http://git.reviewboard.kde.org/r/113504/diff/ > > > Testing > --- > > > Thanks, > > Christoph Feck > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 113504: Fix krunner calculator letter check
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113504/ --- (Updated Oct. 30, 2013, 9:33 a.m.) Status -- This change has been marked as submitted. Review request for kde-workspace and Plasma. Bugs: 326059 http://bugs.kde.org/show_bug.cgi?id=326059 Repository: kde-workspace Description --- The calculator runner now supports the syntax without the '=', so you can simply type in '3+5' and have the result. An additional commit added a letter check, so that it will not try to compute with normal text input, but this broke any calculations with any functions, such as '=6*asin 0.5' etc. This commit removes the letter check in case the user had explicitly typed the '=', restoring 4.10 behavior. If I understand the letter check correctly, it is very hard to support functions in the case the user had omitted the '=' Diffs - plasma/generic/runners/calculator/calculatorrunner.cpp 0d52301 Diff: http://git.reviewboard.kde.org/r/113504/diff/ Testing --- Thanks, Christoph Feck ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel