Re: Review Request 117876: rename kuiserver to kuiserver5 for coinstallability
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117876/#review57628 --- This review has been submitted with commit 6a7ba4115b0a05b93eab0dffec78be9132a89e9d by Jonathan Riddell to branch master. - Commit Hook On April 30, 2014, 9:20 a.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117876/ --- (Updated April 30, 2014, 9:20 a.m.) Review request for Plasma. Repository: plasma-workspace Description --- kuiserver in kde 4 land is from kde-runtime so needs to be co-installable with plasma next. rename to kuiserver5. Diffs - kuiserver/CMakeLists.txt 6d79b41 kuiserver/kuiserver.desktop 2dec197 Diff: https://git.reviewboard.kde.org/r/117876/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117876: rename kuiserver to kuiserver5 for coinstallability
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117876/ --- (Updated May 9, 2014, 7:35 a.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasma-workspace Description --- kuiserver in kde 4 land is from kde-runtime so needs to be co-installable with plasma next. rename to kuiserver5. Diffs - kuiserver/CMakeLists.txt 6d79b41 kuiserver/kuiserver.desktop 2dec197 Diff: https://git.reviewboard.kde.org/r/117876/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117876: rename kuiserver to kuiserver5 for coinstallability
On April 29, 2014, 10:56 p.m., Hrvoje Senjan wrote: kuiserver/CMakeLists.txt, line 73 https://git.reviewboard.kde.org/r/117876/diff/2/?file=269233#file269233line73 i guess also org.kde.kuiserver.service would need adjusting ... shouldn't the services maintain their name? i don't think we want co-runnability no? (if changed everybody using them should be adapted, leading to things breaking with no obvious reasons) - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117876/#review56933 --- On April 29, 2014, 3:29 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117876/ --- (Updated April 29, 2014, 3:29 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- kuiserver in kde 4 land is from kde-runtime so needs to be co-installable with plasma next. rename to kuiserver5. Diffs - kuiserver/CMakeLists.txt 6d79b41 kuiserver/kuiserver.desktop 2dec197 Diff: https://git.reviewboard.kde.org/r/117876/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117876: rename kuiserver to kuiserver5 for coinstallability
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117876/ --- (Updated April 30, 2014, 9:20 a.m.) Review request for Plasma. Changes --- fix renaming target Repository: plasma-workspace Description --- kuiserver in kde 4 land is from kde-runtime so needs to be co-installable with plasma next. rename to kuiserver5. Diffs (updated) - kuiserver/CMakeLists.txt 6d79b41 kuiserver/kuiserver.desktop 2dec197 Diff: https://git.reviewboard.kde.org/r/117876/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117876: rename kuiserver to kuiserver5 for coinstallability
On April 29, 2014, 10:56 p.m., Hrvoje Senjan wrote: kuiserver/CMakeLists.txt, line 73 https://git.reviewboard.kde.org/r/117876/diff/2/?file=269233#file269233line73 i guess also org.kde.kuiserver.service would need adjusting ... Marco Martin wrote: shouldn't the services maintain their name? i don't think we want co-runnability no? (if changed everybody using them should be adapted, leading to things breaking with no obvious reasons) The patch does rename org.kde.kuiserver.service. From http://www.freedesktop.org/wiki/IntroductionToDBus/ write a service file bankcounter.service (the name is arbitrary, so long as it ends with .service) - Jonathan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117876/#review56933 --- On April 30, 2014, 9:20 a.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117876/ --- (Updated April 30, 2014, 9:20 a.m.) Review request for Plasma. Repository: plasma-workspace Description --- kuiserver in kde 4 land is from kde-runtime so needs to be co-installable with plasma next. rename to kuiserver5. Diffs - kuiserver/CMakeLists.txt 6d79b41 kuiserver/kuiserver.desktop 2dec197 Diff: https://git.reviewboard.kde.org/r/117876/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117876: rename kuiserver to kuiserver5 for coinstallability
On April 30, 2014, 12:56 a.m., Hrvoje Senjan wrote: kuiserver/CMakeLists.txt, line 73 https://git.reviewboard.kde.org/r/117876/diff/2/?file=269233#file269233line73 i guess also org.kde.kuiserver.service would need adjusting ... Marco Martin wrote: shouldn't the services maintain their name? i don't think we want co-runnability no? (if changed everybody using them should be adapted, leading to things breaking with no obvious reasons) Jonathan Riddell wrote: The patch does rename org.kde.kuiserver.service. From http://www.freedesktop.org/wiki/IntroductionToDBus/ write a service file bankcounter.service (the name is arbitrary, so long as it ends with .service) i meant more the exec line in the service =) - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117876/#review56933 --- On April 30, 2014, 11:20 a.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117876/ --- (Updated April 30, 2014, 11:20 a.m.) Review request for Plasma. Repository: plasma-workspace Description --- kuiserver in kde 4 land is from kde-runtime so needs to be co-installable with plasma next. rename to kuiserver5. Diffs - kuiserver/CMakeLists.txt 6d79b41 kuiserver/kuiserver.desktop 2dec197 Diff: https://git.reviewboard.kde.org/r/117876/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117876: rename kuiserver to kuiserver5 for coinstallability
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117876/ --- (Updated April 29, 2014, 3:29 p.m.) Review request for Plasma. Changes --- rename dbus service file too Repository: plasma-workspace Description --- kuiserver in kde 4 land is from kde-runtime so needs to be co-installable with plasma next. rename to kuiserver5. Diffs (updated) - kuiserver/CMakeLists.txt 6d79b41 kuiserver/kuiserver.desktop 2dec197 Diff: https://git.reviewboard.kde.org/r/117876/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117876: rename kuiserver to kuiserver5 for coinstallability
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117876/#review56933 --- kuiserver/CMakeLists.txt https://git.reviewboard.kde.org/r/117876/#comment39694 i guess also org.kde.kuiserver.service would need adjusting ... - Hrvoje Senjan On April 29, 2014, 5:29 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117876/ --- (Updated April 29, 2014, 5:29 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- kuiserver in kde 4 land is from kde-runtime so needs to be co-installable with plasma next. rename to kuiserver5. Diffs - kuiserver/CMakeLists.txt 6d79b41 kuiserver/kuiserver.desktop 2dec197 Diff: https://git.reviewboard.kde.org/r/117876/diff/ Testing --- Thanks, Jonathan Riddell ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
