Re: Review Request 118387: Bump systemsettingsview SOVERSION to 5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118387/ --- (Updated July 17, 2014, 4:53 a.m.) Status -- This change has been marked as submitted. Review request for Plasma and Ben Cooksley. Repository: systemsettings Description --- otherwise if KF5's is in LD_LIBRARY_PATH, there's no way to start 4.x version Diffs - core/CMakeLists.txt 9752ad7 Diff: https://git.reviewboard.kde.org/r/118387/diff/ Testing --- Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118387: Bump systemsettingsview SOVERSION to 5
> On June 16, 2014, 6:54 a.m., Ben Cooksley wrote: > > As systemsettingsview is unlikely to break BC any further in the 4.x > > series, could the bump be to SOVERSION 3 instead please? > > Otherwise, this looks fine to go in from my perspective. > > Hrvoje Senjan wrote: > off course, i've just used 5, as the rest of the Workspace 'umbrella' > uses it. > > Ben Cooksley wrote: > Any movement on this change Hrvoje? Once the change to SOVERSION 3 is > made i'm happy for this to go in - unless there is a compelling reason why it > should be 5. > > Hrvoje Senjan wrote: > i can push as soon as i know which branches to touch. only master makes > sense, but want to confirm. I'm not aware of what the policy is from distributions on bumping SOVERSION in minor releases, however as it will probably improve co-installability I suspect including this in the release/stable branch would be welcome. I've no objections to it - all depends on the policies set by the release-team and distributions. - Ben --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118387/#review60161 --- On May 28, 2014, 7:26 p.m., Hrvoje Senjan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118387/ > --- > > (Updated May 28, 2014, 7:26 p.m.) > > > Review request for Plasma and Ben Cooksley. > > > Repository: systemsettings > > > Description > --- > > otherwise if KF5's is in LD_LIBRARY_PATH, there's no way to start 4.x version > > > Diffs > - > > core/CMakeLists.txt 9752ad7 > > Diff: https://git.reviewboard.kde.org/r/118387/diff/ > > > Testing > --- > > > Thanks, > > Hrvoje Senjan > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118387: Bump systemsettingsview SOVERSION to 5
> On June 16, 2014, 8:54 a.m., Ben Cooksley wrote: > > As systemsettingsview is unlikely to break BC any further in the 4.x > > series, could the bump be to SOVERSION 3 instead please? > > Otherwise, this looks fine to go in from my perspective. > > Hrvoje Senjan wrote: > off course, i've just used 5, as the rest of the Workspace 'umbrella' > uses it. > > Ben Cooksley wrote: > Any movement on this change Hrvoje? Once the change to SOVERSION 3 is > made i'm happy for this to go in - unless there is a compelling reason why it > should be 5. i can push as soon as i know which branches to touch. only master makes sense, but want to confirm. - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118387/#review60161 --- On May 28, 2014, 9:26 p.m., Hrvoje Senjan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118387/ > --- > > (Updated May 28, 2014, 9:26 p.m.) > > > Review request for Plasma and Ben Cooksley. > > > Repository: systemsettings > > > Description > --- > > otherwise if KF5's is in LD_LIBRARY_PATH, there's no way to start 4.x version > > > Diffs > - > > core/CMakeLists.txt 9752ad7 > > Diff: https://git.reviewboard.kde.org/r/118387/diff/ > > > Testing > --- > > > Thanks, > > Hrvoje Senjan > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118387: Bump systemsettingsview SOVERSION to 5
> On June 16, 2014, 6:54 a.m., Ben Cooksley wrote: > > As systemsettingsview is unlikely to break BC any further in the 4.x > > series, could the bump be to SOVERSION 3 instead please? > > Otherwise, this looks fine to go in from my perspective. > > Hrvoje Senjan wrote: > off course, i've just used 5, as the rest of the Workspace 'umbrella' > uses it. Any movement on this change Hrvoje? Once the change to SOVERSION 3 is made i'm happy for this to go in - unless there is a compelling reason why it should be 5. - Ben --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118387/#review60161 --- On May 28, 2014, 7:26 p.m., Hrvoje Senjan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118387/ > --- > > (Updated May 28, 2014, 7:26 p.m.) > > > Review request for Plasma and Ben Cooksley. > > > Repository: systemsettings > > > Description > --- > > otherwise if KF5's is in LD_LIBRARY_PATH, there's no way to start 4.x version > > > Diffs > - > > core/CMakeLists.txt 9752ad7 > > Diff: https://git.reviewboard.kde.org/r/118387/diff/ > > > Testing > --- > > > Thanks, > > Hrvoje Senjan > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118387: Bump systemsettingsview SOVERSION to 5
> On June 16, 2014, 8:54 a.m., Ben Cooksley wrote: > > As systemsettingsview is unlikely to break BC any further in the 4.x > > series, could the bump be to SOVERSION 3 instead please? > > Otherwise, this looks fine to go in from my perspective. off course, i've just used 5, as the rest of the Workspace 'umbrella' uses it. - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118387/#review60161 --- On May 28, 2014, 9:26 p.m., Hrvoje Senjan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118387/ > --- > > (Updated May 28, 2014, 9:26 p.m.) > > > Review request for Plasma and Ben Cooksley. > > > Repository: systemsettings > > > Description > --- > > otherwise if KF5's is in LD_LIBRARY_PATH, there's no way to start 4.x version > > > Diffs > - > > core/CMakeLists.txt 9752ad7 > > Diff: https://git.reviewboard.kde.org/r/118387/diff/ > > > Testing > --- > > > Thanks, > > Hrvoje Senjan > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118387: Bump systemsettingsview SOVERSION to 5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118387/#review60161 --- As systemsettingsview is unlikely to break BC any further in the 4.x series, could the bump be to SOVERSION 3 instead please? Otherwise, this looks fine to go in from my perspective. - Ben Cooksley On May 28, 2014, 7:26 p.m., Hrvoje Senjan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118387/ > --- > > (Updated May 28, 2014, 7:26 p.m.) > > > Review request for Plasma and Ben Cooksley. > > > Repository: systemsettings > > > Description > --- > > otherwise if KF5's is in LD_LIBRARY_PATH, there's no way to start 4.x version > > > Diffs > - > > core/CMakeLists.txt 9752ad7 > > Diff: https://git.reviewboard.kde.org/r/118387/diff/ > > > Testing > --- > > > Thanks, > > Hrvoje Senjan > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118387: Bump systemsettingsview SOVERSION to 5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118387/#review60158 --- What's the status here? - Sebastian Kügler On May 28, 2014, 7:26 p.m., Hrvoje Senjan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118387/ > --- > > (Updated May 28, 2014, 7:26 p.m.) > > > Review request for Plasma and Ben Cooksley. > > > Repository: systemsettings > > > Description > --- > > otherwise if KF5's is in LD_LIBRARY_PATH, there's no way to start 4.x version > > > Diffs > - > > core/CMakeLists.txt 9752ad7 > > Diff: https://git.reviewboard.kde.org/r/118387/diff/ > > > Testing > --- > > > Thanks, > > Hrvoje Senjan > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
