Re: Review Request 122008: Disable Intel swap interval for 5.2
On Jan. 12, 2015, 10:23 a.m., Àlex Fiestas wrote: Would it be interesting to have a CMake option for this so people can test it out? Or is it so horribly broken? Besides that, if you think this should be disabled until +1 then so be it! if you want to test, just run master. I only want to disable on 5.2 branch. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122008/#review73816 --- On Jan. 12, 2015, 8:57 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122008/ --- (Updated Jan. 12, 2015, 8:57 a.m.) Review request for kwin and Plasma. Repository: kwin Description --- The feature is pretty much untested as it depends on Qt 5.4 and this was not a requirement during the development of 5.2. On the other hand regressions in this feature are very severe as it can freeze the screen and by that render the system unusable. Given that it is better to disable for the 5.2 release as we don't know what could happen when distros start enabling Qt 5.4. It's better to stabilize the feature in the master branch for the 5.3 release which will hopefully have Qt 5.4 as a mandatory requirement. CCBUG: 342582 Diffs - glxbackend.cpp 78efa4ebc30dbad04e92129b643f27b67f59a3c7 Diff: https://git.reviewboard.kde.org/r/122008/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122008: Disable Intel swap interval for 5.2
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122008/#review73816 --- Ship it! Would it be interesting to have a CMake option for this so people can test it out? Or is it so horribly broken? Besides that, if you think this should be disabled until +1 then so be it! - Àlex Fiestas On gen. 12, 2015, 7:57 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122008/ --- (Updated gen. 12, 2015, 7:57 a.m.) Review request for kwin and Plasma. Repository: kwin Description --- The feature is pretty much untested as it depends on Qt 5.4 and this was not a requirement during the development of 5.2. On the other hand regressions in this feature are very severe as it can freeze the screen and by that render the system unusable. Given that it is better to disable for the 5.2 release as we don't know what could happen when distros start enabling Qt 5.4. It's better to stabilize the feature in the master branch for the 5.3 release which will hopefully have Qt 5.4 as a mandatory requirement. CCBUG: 342582 Diffs - glxbackend.cpp 78efa4ebc30dbad04e92129b643f27b67f59a3c7 Diff: https://git.reviewboard.kde.org/r/122008/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122008: Disable Intel swap interval for 5.2
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122008/#review73819 --- Yeah, I think it's needed :( Plasma5.2 branch too. Add a link to the bug report in the code, we should try again for 5.3. - David Edmundson On Jan. 12, 2015, 7:57 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122008/ --- (Updated Jan. 12, 2015, 7:57 a.m.) Review request for kwin and Plasma. Repository: kwin Description --- The feature is pretty much untested as it depends on Qt 5.4 and this was not a requirement during the development of 5.2. On the other hand regressions in this feature are very severe as it can freeze the screen and by that render the system unusable. Given that it is better to disable for the 5.2 release as we don't know what could happen when distros start enabling Qt 5.4. It's better to stabilize the feature in the master branch for the 5.3 release which will hopefully have Qt 5.4 as a mandatory requirement. CCBUG: 342582 Diffs - glxbackend.cpp 78efa4ebc30dbad04e92129b643f27b67f59a3c7 Diff: https://git.reviewboard.kde.org/r/122008/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
