Re: Review Request 122865: Reduce OSD text's font size instead of eliding it
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122865/#review77208 --- Ship it! Ship It! - Martin Klapetek On March 9, 2015, 9:23 a.m., Mika Allan Rauhala wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122865/ > --- > > (Updated March 9, 2015, 9:23 a.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > --- > > This fixes volume muted OSD's text getting elided in some languages. > > Since I currently don't have a commit access, could someone commit this after > reviewing it? > > > Diffs > - > > lookandfeel/contents/osd/OsdItem.qml > 43d9e864231d445f84c677cba4a0bce24805ea74 > > Diff: https://git.reviewboard.kde.org/r/122865/diff/ > > > Testing > --- > > > File Attachments > > > Before > > https://git.reviewboard.kde.org/media/uploaded/files/2015/03/09/9c3cc78c-cead-4054-a004-1468f70ad3cb__before.png > After > > https://git.reviewboard.kde.org/media/uploaded/files/2015/03/09/bf54bf88-c8f0-4561-af5a-848298ea579b__after.png > > > Thanks, > > Mika Allan Rauhala > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122865: Reduce OSD text's font size instead of eliding it
> On March 9, 2015, 12:05 p.m., Martin Klapetek wrote: > > Ship It! I'll ship it later afternoon - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122865/#review77208 --- On March 9, 2015, 9:23 a.m., Mika Allan Rauhala wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122865/ > --- > > (Updated March 9, 2015, 9:23 a.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > --- > > This fixes volume muted OSD's text getting elided in some languages. > > Since I currently don't have a commit access, could someone commit this after > reviewing it? > > > Diffs > - > > lookandfeel/contents/osd/OsdItem.qml > 43d9e864231d445f84c677cba4a0bce24805ea74 > > Diff: https://git.reviewboard.kde.org/r/122865/diff/ > > > Testing > --- > > > File Attachments > > > Before > > https://git.reviewboard.kde.org/media/uploaded/files/2015/03/09/9c3cc78c-cead-4054-a004-1468f70ad3cb__before.png > After > > https://git.reviewboard.kde.org/media/uploaded/files/2015/03/09/bf54bf88-c8f0-4561-af5a-848298ea579b__after.png > > > Thanks, > > Mika Allan Rauhala > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122865: Reduce OSD text's font size instead of eliding it
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122865/#review77210 --- Thanks! I commited this on behalf of you. - Kai Uwe Broulik On März 9, 2015, 8:23 vorm., Mika Allan Rauhala wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122865/ > --- > > (Updated März 9, 2015, 8:23 vorm.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > --- > > This fixes volume muted OSD's text getting elided in some languages. > > Since I currently don't have a commit access, could someone commit this after > reviewing it? > > > Diffs > - > > lookandfeel/contents/osd/OsdItem.qml > 43d9e864231d445f84c677cba4a0bce24805ea74 > > Diff: https://git.reviewboard.kde.org/r/122865/diff/ > > > Testing > --- > > > File Attachments > > > Before > > https://git.reviewboard.kde.org/media/uploaded/files/2015/03/09/9c3cc78c-cead-4054-a004-1468f70ad3cb__before.png > After > > https://git.reviewboard.kde.org/media/uploaded/files/2015/03/09/bf54bf88-c8f0-4561-af5a-848298ea579b__after.png > > > Thanks, > > Mika Allan Rauhala > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122865: Reduce OSD text's font size instead of eliding it
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122865/ --- (Updated March 9, 2015, 11:28 a.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasma-workspace Description --- This fixes volume muted OSD's text getting elided in some languages. Since I currently don't have a commit access, could someone commit this after reviewing it? Diffs - lookandfeel/contents/osd/OsdItem.qml 43d9e864231d445f84c677cba4a0bce24805ea74 Diff: https://git.reviewboard.kde.org/r/122865/diff/ Testing --- File Attachments Before https://git.reviewboard.kde.org/media/uploaded/files/2015/03/09/9c3cc78c-cead-4054-a004-1468f70ad3cb__before.png After https://git.reviewboard.kde.org/media/uploaded/files/2015/03/09/bf54bf88-c8f0-4561-af5a-848298ea579b__after.png Thanks, Mika Allan Rauhala ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel