Re: Review Request 124236: More sensible sizing for containment configuration

2015-07-06 Thread Kai Uwe Broulik

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124236/
---

(Updated July 6, 2015, 4:58 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 3d87a19d282c51271b17a60ea17c4f9f3f5a4462 by Kai Uwe 
Broulik to branch master.


Repository: plasma-desktop


Description
---

That dialog is pretty tall on laptops and can hardly be resized any smaller. 
This gives it a sensible minimum size and keeps the preferred at the old value


Diffs
-

  desktoppackage/contents/configuration/ContainmentConfiguration.qml 09a4d22 

Diff: https://git.reviewboard.kde.org/r/124236/diff/


Testing
---

Nuked my plasma config, dialog looked nice initially but I could make it 
smaller for my preference. Please #lowdpi people test


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 124236: More sensible sizing for containment configuration

2015-07-06 Thread Bhushan Shah

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124236/#review82138
---

Ship it!


Ship It!

- Bhushan Shah


On July 3, 2015, 12:24 a.m., Kai Uwe Broulik wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124236/
 ---
 
 (Updated July 3, 2015, 12:24 a.m.)
 
 
 Review request for Plasma.
 
 
 Repository: plasma-desktop
 
 
 Description
 ---
 
 That dialog is pretty tall on laptops and can hardly be resized any smaller. 
 This gives it a sensible minimum size and keeps the preferred at the old value
 
 
 Diffs
 -
 
   desktoppackage/contents/configuration/ContainmentConfiguration.qml 09a4d22 
 
 Diff: https://git.reviewboard.kde.org/r/124236/diff/
 
 
 Testing
 ---
 
 Nuked my plasma config, dialog looked nice initially but I could make it 
 smaller for my preference. Please #lowdpi people test
 
 
 Thanks,
 
 Kai Uwe Broulik
 


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel