Re: Review Request 125006: Add individual monitor for each cpu option for system load viewer

2015-11-02 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125006/#review87872
---

Ship it!


Ship It!

- Marco Martin


On Nov. 2, 2015, 11:49 a.m., Kåre Särs wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125006/
> ---
> 
> (Updated Nov. 2, 2015, 11:49 a.m.)
> 
> 
> Review request for Plasma, David Edmundson, Dominik Haumann, and Martin 
> Yrjölä.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> When compact-bar monitos are selected the "show: CPUs separately" is enabled. 
> When activated every cpu gets it's own monitor. The individual monitors try 
> to fit in the space of two bars but when the number of cpus are too high the 
> widht of the cpu monitors grow proportionally.
> 
> 
> Diffs
> -
> 
>   applets/systemloadviewer/package/contents/config/main.xml 0edfd89 
>   applets/systemloadviewer/package/contents/ui/GeneralSettings.qml a577b1a 
>   applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 3a805b5 
> 
> Diff: https://git.reviewboard.kde.org/r/125006/diff/
> 
> 
> Testing
> ---
> 
> Running it on my own computer ;)
> 
> 
> Thanks,
> 
> Kåre Särs
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125006: Add individual monitor for each cpu option for system load viewer

2015-11-02 Thread Kåre Särs 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125006/
---

(Updated Nov. 3, 2015, 6:50 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, David Edmundson, Dominik Haumann, and Martin Yrjölä.


Changes
---

Submitted with commit 1c0cf92208b8a7589e1d6103f3fd5640840509c8 by Kåre Särs to 
branch master.


Repository: kdeplasma-addons


Description
---

When compact-bar monitos are selected the "show: CPUs separately" is enabled. 
When activated every cpu gets it's own monitor. The individual monitors try to 
fit in the space of two bars but when the number of cpus are too high the widht 
of the cpu monitors grow proportionally.


Diffs
-

  applets/systemloadviewer/package/contents/config/main.xml 0edfd89 
  applets/systemloadviewer/package/contents/ui/GeneralSettings.qml a577b1a 
  applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 3a805b5 

Diff: https://git.reviewboard.kde.org/r/125006/diff/


Testing
---

Running it on my own computer ;)


Thanks,

Kåre Särs

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125006: Add individual monitor for each cpu option for system load viewer

2015-11-02 Thread Kåre Särs 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125006/
---

(Updated Nov. 2, 2015, 11:49 a.m.)


Review request for Plasma, David Edmundson, Dominik Haumann, and Martin Yrjölä.


Changes
---

Add Layout.minimumWidth to prevent overlapping, remove a hardcoded pixelWidth, 
rebase on master and minor code cleanup


Repository: kdeplasma-addons


Description
---

When compact-bar monitos are selected the "show: CPUs separately" is enabled. 
When activated every cpu gets it's own monitor. The individual monitors try to 
fit in the space of two bars but when the number of cpus are too high the widht 
of the cpu monitors grow proportionally.


Diffs (updated)
-

  applets/systemloadviewer/package/contents/config/main.xml 0edfd89 
  applets/systemloadviewer/package/contents/ui/GeneralSettings.qml a577b1a 
  applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 3a805b5 

Diff: https://git.reviewboard.kde.org/r/125006/diff/


Testing
---

Running it on my own computer ;)


Thanks,

Kåre Särs

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125006: Add individual monitor for each cpu option for system load viewer

2015-10-09 Thread Kåre Särs 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125006/
---

(Updated Oct. 9, 2015, 1:18 p.m.)


Review request for Plasma, David Edmundson, Dominik Haumann, and Martin Yrjölä.


Changes
---

Fix the minimum/preffered width calculation


Repository: kdeplasma-addons


Description
---

When compact-bar monitos are selected the "show: CPUs separately" is enabled. 
When activated every cpu gets it's own monitor. The individual monitors try to 
fit in the space of two bars but when the number of cpus are too high the widht 
of the cpu monitors grow proportionally.


Diffs (updated)
-

  applets/systemloadviewer/package/contents/config/main.xml 0edfd89 
  applets/systemloadviewer/package/contents/ui/GeneralSettings.qml a577b1a 
  applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 8023b44 

Diff: https://git.reviewboard.kde.org/r/125006/diff/


Testing
---

Running it on my own computer ;)


Thanks,

Kåre Särs

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125006: Add individual monitor for each cpu option for system load viewer

2015-10-09 Thread Kåre Särs 


> On Sept. 18, 2015, 5:07 p.m., Marco Martin wrote:
> >

Thanks for revieweing! :) I don't know how I missed your review this long (even 
when I added dominik)


- Kåre


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125006/#review85629
---


On Oct. 9, 2015, 1:07 p.m., Kåre Särs wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125006/
> ---
> 
> (Updated Oct. 9, 2015, 1:07 p.m.)
> 
> 
> Review request for Plasma, David Edmundson, Dominik Haumann, and Martin 
> Yrjölä.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> When compact-bar monitos are selected the "show: CPUs separately" is enabled. 
> When activated every cpu gets it's own monitor. The individual monitors try 
> to fit in the space of two bars but when the number of cpus are too high the 
> widht of the cpu monitors grow proportionally.
> 
> 
> Diffs
> -
> 
>   applets/systemloadviewer/package/contents/config/main.xml 0edfd89 
>   applets/systemloadviewer/package/contents/ui/GeneralSettings.qml a577b1a 
>   applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 8023b44 
> 
> Diff: https://git.reviewboard.kde.org/r/125006/diff/
> 
> 
> Testing
> ---
> 
> Running it on my own computer ;)
> 
> 
> Thanks,
> 
> Kåre Särs
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125006: Add individual monitor for each cpu option for system load viewer

2015-10-09 Thread Kåre Särs 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125006/
---

(Updated Oct. 9, 2015, 1:07 p.m.)


Review request for Plasma, David Edmundson, Dominik Haumann, and Martin Yrjölä.


Changes
---

-Use units.gridUnit in stead of pixels
-propert if () {}
-Add preffered sizes so that the layouts look good without restarting
-Add a custom tool-tip widget if there are more than 6 cpus (the standard 
tooltip text is restricted to lines)
-Uncheck "cpus separately" if cpu monitor is unchecked


Repository: kdeplasma-addons


Description
---

When compact-bar monitos are selected the "show: CPUs separately" is enabled. 
When activated every cpu gets it's own monitor. The individual monitors try to 
fit in the space of two bars but when the number of cpus are too high the widht 
of the cpu monitors grow proportionally.


Diffs (updated)
-

  applets/systemloadviewer/package/contents/config/main.xml 0edfd89 
  applets/systemloadviewer/package/contents/ui/GeneralSettings.qml a577b1a 
  applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 8023b44 

Diff: https://git.reviewboard.kde.org/r/125006/diff/


Testing (updated)
---

Running it on my own computer ;)


Thanks,

Kåre Särs

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125006: Add individual monitor for each cpu option for system load viewer

2015-09-18 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125006/#review85629
---



applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml (line 87)


what is the logic of preferredwidth here?
don't use sizes in pixels

should be done in worst case with units.gridUnit



applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml (line 275)


as style guidelines is always used the long notation
if () {

}


- Marco Martin


On Aug. 31, 2015, 8:13 p.m., Kåre Särs wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125006/
> ---
> 
> (Updated Aug. 31, 2015, 8:13 p.m.)
> 
> 
> Review request for Plasma, David Edmundson and Martin Yrjölä.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> When compact-bar monitos are selected the "show: CPUs separately" is enabled. 
> When activated every cpu gets it's own monitor. The individual monitors try 
> to fit in the space of two bars but when the number of cpus are too high the 
> widht of the cpu monitors grow proportionally.
> 
> 
> Diffs
> -
> 
>   applets/systemloadviewer/package/contents/config/main.xml 0edfd89 
>   applets/systemloadviewer/package/contents/ui/GeneralSettings.qml a577b1a 
>   applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml cb63fed 
> 
> Diff: https://git.reviewboard.kde.org/r/125006/diff/
> 
> 
> Testing
> ---
> 
> Running it on my own computer ;)
> 
> Issues:
> 1) When changing the CPUs separately setting the cpu column(s) size(s) are 
> set to minimal and a restart of the applet is needed to get good loking 
> layouts.
> 2) The tooltip does not fit all the cpu rows if the number of cpus are over 4 
> (6?).
> 
> 
> Thanks,
> 
> Kåre Särs
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125006: Add individual monitor for each cpu option for system load viewer

2015-09-17 Thread Kåre Särs 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125006/#review85603
---


Ping?

- Kåre Särs


On Aug. 31, 2015, 8:13 p.m., Kåre Särs wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125006/
> ---
> 
> (Updated Aug. 31, 2015, 8:13 p.m.)
> 
> 
> Review request for Plasma, David Edmundson and Martin Yrjölä.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> When compact-bar monitos are selected the "show: CPUs separately" is enabled. 
> When activated every cpu gets it's own monitor. The individual monitors try 
> to fit in the space of two bars but when the number of cpus are too high the 
> widht of the cpu monitors grow proportionally.
> 
> 
> Diffs
> -
> 
>   applets/systemloadviewer/package/contents/config/main.xml 0edfd89 
>   applets/systemloadviewer/package/contents/ui/GeneralSettings.qml a577b1a 
>   applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml cb63fed 
> 
> Diff: https://git.reviewboard.kde.org/r/125006/diff/
> 
> 
> Testing
> ---
> 
> Running it on my own computer ;)
> 
> Issues:
> 1) When changing the CPUs separately setting the cpu column(s) size(s) are 
> set to minimal and a restart of the applet is needed to get good loking 
> layouts.
> 2) The tooltip does not fit all the cpu rows if the number of cpus are over 4 
> (6?).
> 
> 
> Thanks,
> 
> Kåre Särs
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel