Re: Review Request 125174: Plasma 5 Quicklaunch applet

2015-09-14 Thread David Rosca 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125174/
---

(Updated Sept. 14, 2015, 11:11 a.m.)


Status
--

This change has been discarded.


Review request for Plasma.


Repository: plasma-workspace


Description
---

This is a reimplementation of Quicklaunch applet in QML.

I have tried to make it as similar to the original applet as possible.

Missing features: 
 - popup drawer for launchers
 - option for automatically determining number of rows/cols (must be set 
manually)


For the review purposes, I have generated diff with code in "quicklaunch-qml" 
directory, but it should go to the original "quicklaunch" dir.


Diffs
-

  applets/CMakeLists.txt 40c2e05 
  applets/quicklaunch-qml/CMakeLists.txt PRE-CREATION 
  applets/quicklaunch-qml/Messages.sh PRE-CREATION 
  applets/quicklaunch-qml/package/contents/code/layout.js PRE-CREATION 
  applets/quicklaunch-qml/package/contents/config/config.qml PRE-CREATION 
  applets/quicklaunch-qml/package/contents/config/main.xml PRE-CREATION 
  applets/quicklaunch-qml/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
  applets/quicklaunch-qml/package/contents/ui/IconItem.qml PRE-CREATION 
  applets/quicklaunch-qml/package/contents/ui/main.qml PRE-CREATION 
  applets/quicklaunch-qml/package/metadata.desktop PRE-CREATION 
  applets/quicklaunch-qml/plugin/CMakeLists.txt PRE-CREATION 
  applets/quicklaunch-qml/plugin/qmldir PRE-CREATION 
  applets/quicklaunch-qml/plugin/quicklaunch_p.h PRE-CREATION 
  applets/quicklaunch-qml/plugin/quicklaunch_p.cpp PRE-CREATION 
  applets/quicklaunch-qml/plugin/quicklaunchplugin.h PRE-CREATION 
  applets/quicklaunch-qml/plugin/quicklaunchplugin.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/125174/diff/


Testing
---


File Attachments


Empty applet
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/555b9762-e399-42f2-9a85-380f55749132__empty.png
On desktop (2 rows)
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/2874569c-3a2e-44f7-a537-021046226789__desktop-2-rows.png
On desktop with names + dragging
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/1bce2c1f-91e8-4300-81fa-fd1334e8c281__desktop-1row-drag.png
In vertical panel
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/9f55dc04-1aae-4a5a-a70c-7158c527f0e7__panel-vertical.png
Context menu
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/7fe10753-5d23-4480-8701-4022dc162943__context-menu.png


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125174: Plasma 5 Quicklaunch applet

2015-09-14 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125174/#review85351
---


Provided this gets maintained, I'm in favor of this (perhaps in 
kdeplasma-addons instead of a main workspace feature).
Since the behavior of a pure launcher is quite different from both a taskbar 
entry or a dock icon, so some people may prefer that behavior instead (I kindof 
do :p).

- Marco Martin


On Sept. 11, 2015, 7:48 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125174/
> ---
> 
> (Updated Sept. 11, 2015, 7:48 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This is a reimplementation of Quicklaunch applet in QML.
> 
> I have tried to make it as similar to the original applet as possible.
> 
> Missing features: 
>  - popup drawer for launchers
>  - option for automatically determining number of rows/cols (must be set 
> manually)
> 
> 
> For the review purposes, I have generated diff with code in "quicklaunch-qml" 
> directory, but it should go to the original "quicklaunch" dir.
> 
> 
> Diffs
> -
> 
>   applets/CMakeLists.txt 40c2e05 
>   applets/quicklaunch-qml/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch-qml/Messages.sh PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/code/layout.js PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/config/config.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/config/main.xml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/IconItem.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/main.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/metadata.desktop PRE-CREATION 
>   applets/quicklaunch-qml/plugin/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch-qml/plugin/qmldir PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunch_p.h PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunch_p.cpp PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunchplugin.h PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunchplugin.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125174/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Empty applet
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/555b9762-e399-42f2-9a85-380f55749132__empty.png
> On desktop (2 rows)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/2874569c-3a2e-44f7-a537-021046226789__desktop-2-rows.png
> On desktop with names + dragging
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/1bce2c1f-91e8-4300-81fa-fd1334e8c281__desktop-1row-drag.png
> In vertical panel
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/9f55dc04-1aae-4a5a-a70c-7158c527f0e7__panel-vertical.png
> Context menu
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/7fe10753-5d23-4480-8701-4022dc162943__context-menu.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125174: Plasma 5 Quicklaunch applet

2015-09-14 Thread David Rosca 


> On Sept. 14, 2015, 8:24 a.m., Marco Martin wrote:
> > Provided this gets maintained, I'm in favor of this (perhaps in 
> > kdeplasma-addons instead of a main workspace feature).
> > Since the behavior of a pure launcher is quite different from both a 
> > taskbar entry or a dock icon, so some people may prefer that behavior 
> > instead (I kindof do :p).

Sure, having this in kdeplasma-addons is fine. I made this review against 
plasma-workspace because it originally was there (and still is, not buildable).
I'm willing to maintain it, so should I open a new RR against kdeplasma-addons?


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125174/#review85351
---


On Sept. 11, 2015, 7:48 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125174/
> ---
> 
> (Updated Sept. 11, 2015, 7:48 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This is a reimplementation of Quicklaunch applet in QML.
> 
> I have tried to make it as similar to the original applet as possible.
> 
> Missing features: 
>  - popup drawer for launchers
>  - option for automatically determining number of rows/cols (must be set 
> manually)
> 
> 
> For the review purposes, I have generated diff with code in "quicklaunch-qml" 
> directory, but it should go to the original "quicklaunch" dir.
> 
> 
> Diffs
> -
> 
>   applets/CMakeLists.txt 40c2e05 
>   applets/quicklaunch-qml/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch-qml/Messages.sh PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/code/layout.js PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/config/config.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/config/main.xml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/IconItem.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/main.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/metadata.desktop PRE-CREATION 
>   applets/quicklaunch-qml/plugin/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch-qml/plugin/qmldir PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunch_p.h PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunch_p.cpp PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunchplugin.h PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunchplugin.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125174/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Empty applet
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/555b9762-e399-42f2-9a85-380f55749132__empty.png
> On desktop (2 rows)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/2874569c-3a2e-44f7-a537-021046226789__desktop-2-rows.png
> On desktop with names + dragging
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/1bce2c1f-91e8-4300-81fa-fd1334e8c281__desktop-1row-drag.png
> In vertical panel
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/9f55dc04-1aae-4a5a-a70c-7158c527f0e7__panel-vertical.png
> Context menu
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/7fe10753-5d23-4480-8701-4022dc162943__context-menu.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125174: Plasma 5 Quicklaunch applet

2015-09-14 Thread Marco Martin 


> On Sept. 14, 2015, 8:24 a.m., Marco Martin wrote:
> > Provided this gets maintained, I'm in favor of this (perhaps in 
> > kdeplasma-addons instead of a main workspace feature).
> > Since the behavior of a pure launcher is quite different from both a 
> > taskbar entry or a dock icon, so some people may prefer that behavior 
> > instead (I kindof do :p).
> 
> David Rosca wrote:
> Sure, having this in kdeplasma-addons is fine. I made this review against 
> plasma-workspace because it originally was there (and still is, not 
> buildable).
> I'm willing to maintain it, so should I open a new RR against 
> kdeplasma-addons?

yep, that would be great :)


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125174/#review85351
---


On Sept. 11, 2015, 7:48 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125174/
> ---
> 
> (Updated Sept. 11, 2015, 7:48 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This is a reimplementation of Quicklaunch applet in QML.
> 
> I have tried to make it as similar to the original applet as possible.
> 
> Missing features: 
>  - popup drawer for launchers
>  - option for automatically determining number of rows/cols (must be set 
> manually)
> 
> 
> For the review purposes, I have generated diff with code in "quicklaunch-qml" 
> directory, but it should go to the original "quicklaunch" dir.
> 
> 
> Diffs
> -
> 
>   applets/CMakeLists.txt 40c2e05 
>   applets/quicklaunch-qml/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch-qml/Messages.sh PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/code/layout.js PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/config/config.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/config/main.xml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/IconItem.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/main.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/metadata.desktop PRE-CREATION 
>   applets/quicklaunch-qml/plugin/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch-qml/plugin/qmldir PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunch_p.h PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunch_p.cpp PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunchplugin.h PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunchplugin.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125174/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Empty applet
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/555b9762-e399-42f2-9a85-380f55749132__empty.png
> On desktop (2 rows)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/2874569c-3a2e-44f7-a537-021046226789__desktop-2-rows.png
> On desktop with names + dragging
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/1bce2c1f-91e8-4300-81fa-fd1334e8c281__desktop-1row-drag.png
> In vertical panel
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/9f55dc04-1aae-4a5a-a70c-7158c527f0e7__panel-vertical.png
> Context menu
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/7fe10753-5d23-4480-8701-4022dc162943__context-menu.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125174: Plasma 5 Quicklaunch applet

2015-09-14 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125174/#review85360
---



applets/quicklaunch-qml/package/contents/code/layout.js (line 23)


I guess the spacing here is half because it's used as margins for the items 
instead, so ends up being half+half..
Maybe should be called itemPadding()?

second, those being functions buried in a js file won't be updated in case 
one of the properties chnge..
should they be in  qml file exposed as properties instead?


- Marco Martin


On Sept. 11, 2015, 7:48 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125174/
> ---
> 
> (Updated Sept. 11, 2015, 7:48 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This is a reimplementation of Quicklaunch applet in QML.
> 
> I have tried to make it as similar to the original applet as possible.
> 
> Missing features: 
>  - popup drawer for launchers
>  - option for automatically determining number of rows/cols (must be set 
> manually)
> 
> 
> For the review purposes, I have generated diff with code in "quicklaunch-qml" 
> directory, but it should go to the original "quicklaunch" dir.
> 
> 
> Diffs
> -
> 
>   applets/CMakeLists.txt 40c2e05 
>   applets/quicklaunch-qml/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch-qml/Messages.sh PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/code/layout.js PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/config/config.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/config/main.xml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/IconItem.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/main.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/metadata.desktop PRE-CREATION 
>   applets/quicklaunch-qml/plugin/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch-qml/plugin/qmldir PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunch_p.h PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunch_p.cpp PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunchplugin.h PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunchplugin.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125174/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Empty applet
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/555b9762-e399-42f2-9a85-380f55749132__empty.png
> On desktop (2 rows)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/2874569c-3a2e-44f7-a537-021046226789__desktop-2-rows.png
> On desktop with names + dragging
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/1bce2c1f-91e8-4300-81fa-fd1334e8c281__desktop-1row-drag.png
> In vertical panel
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/9f55dc04-1aae-4a5a-a70c-7158c527f0e7__panel-vertical.png
> Context menu
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/7fe10753-5d23-4480-8701-4022dc162943__context-menu.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125174: Plasma 5 Quicklaunch applet

2015-09-14 Thread David Rosca 


> On Sept. 14, 2015, 9:35 a.m., Marco Martin wrote:
> > applets/quicklaunch-qml/package/contents/code/layout.js, line 23
> > 
> >
> > I guess the spacing here is half because it's used as margins for the 
> > items instead, so ends up being half+half..
> > Maybe should be called itemPadding()?
> > 
> > second, those being functions buried in a js file won't be updated in 
> > case one of the properties chnge..
> > should they be in  qml file exposed as properties instead?

The code seems to work fine though, it correctly resize the launchers when size 
of applet is changed.

I'll rename the spacing() function.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125174/#review85360
---


On Sept. 11, 2015, 7:48 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125174/
> ---
> 
> (Updated Sept. 11, 2015, 7:48 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This is a reimplementation of Quicklaunch applet in QML.
> 
> I have tried to make it as similar to the original applet as possible.
> 
> Missing features: 
>  - popup drawer for launchers
>  - option for automatically determining number of rows/cols (must be set 
> manually)
> 
> 
> For the review purposes, I have generated diff with code in "quicklaunch-qml" 
> directory, but it should go to the original "quicklaunch" dir.
> 
> 
> Diffs
> -
> 
>   applets/CMakeLists.txt 40c2e05 
>   applets/quicklaunch-qml/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch-qml/Messages.sh PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/code/layout.js PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/config/config.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/config/main.xml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/IconItem.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/main.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/metadata.desktop PRE-CREATION 
>   applets/quicklaunch-qml/plugin/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch-qml/plugin/qmldir PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunch_p.h PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunch_p.cpp PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunchplugin.h PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunchplugin.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125174/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Empty applet
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/555b9762-e399-42f2-9a85-380f55749132__empty.png
> On desktop (2 rows)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/2874569c-3a2e-44f7-a537-021046226789__desktop-2-rows.png
> On desktop with names + dragging
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/1bce2c1f-91e8-4300-81fa-fd1334e8c281__desktop-1row-drag.png
> In vertical panel
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/9f55dc04-1aae-4a5a-a70c-7158c527f0e7__panel-vertical.png
> Context menu
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/7fe10753-5d23-4480-8701-4022dc162943__context-menu.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125174: Plasma 5 Quicklaunch applet

2015-09-12 Thread David Rosca 


> On Sept. 12, 2015, 12:42 a.m., Martin Klapetek wrote:
> > Is there any disadvantage to using Icon-only task manager and adding 
> > launchers in there? It seems like this applet would do exactly the same 
> > minus the task switching, so perhaps some portions of the code could be 
> > shared?

You can't force number of rows/columns in icon-only task manager. Icon-only 
task manager is auto-expanding, so it will only use another row/column when 
there is not enough space. 

Also, it is a task manager and not a launcher. This is more like an Icon 
applet, but with more options.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125174/#review85224
---


On Sept. 11, 2015, 7:48 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125174/
> ---
> 
> (Updated Sept. 11, 2015, 7:48 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This is a reimplementation of Quicklaunch applet in QML.
> 
> I have tried to make it as similar to the original applet as possible.
> 
> Missing features: 
>  - popup drawer for launchers
>  - option for automatically determining number of rows/cols (must be set 
> manually)
> 
> 
> For the review purposes, I have generated diff with code in "quicklaunch-qml" 
> directory, but it should go to the original "quicklaunch" dir.
> 
> 
> Diffs
> -
> 
>   applets/CMakeLists.txt 40c2e05 
>   applets/quicklaunch-qml/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch-qml/Messages.sh PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/code/layout.js PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/config/config.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/config/main.xml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/IconItem.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/main.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/metadata.desktop PRE-CREATION 
>   applets/quicklaunch-qml/plugin/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch-qml/plugin/qmldir PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunch_p.h PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunch_p.cpp PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunchplugin.h PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunchplugin.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125174/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Empty applet
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/555b9762-e399-42f2-9a85-380f55749132__empty.png
> On desktop (2 rows)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/2874569c-3a2e-44f7-a537-021046226789__desktop-2-rows.png
> On desktop with names + dragging
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/1bce2c1f-91e8-4300-81fa-fd1334e8c281__desktop-1row-drag.png
> In vertical panel
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/9f55dc04-1aae-4a5a-a70c-7158c527f0e7__panel-vertical.png
> Context menu
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/7fe10753-5d23-4480-8701-4022dc162943__context-menu.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125174: Plasma 5 Quicklaunch applet

2015-09-11 Thread Martin Klapetek 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125174/#review85224
---


Is there any disadvantage to using Icon-only task manager and adding launchers 
in there? It seems like this applet would do exactly the same minus the task 
switching, so perhaps some portions of the code could be shared?

- Martin Klapetek


On Sept. 11, 2015, 9:48 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125174/
> ---
> 
> (Updated Sept. 11, 2015, 9:48 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This is a reimplementation of Quicklaunch applet in QML.
> 
> I have tried to make it as similar to the original applet as possible.
> 
> Missing features: 
>  - popup drawer for launchers
>  - option for automatically determining number of rows/cols (must be set 
> manually)
> 
> 
> For the review purposes, I have generated diff with code in "quicklaunch-qml" 
> directory, but it should go to the original "quicklaunch" dir.
> 
> 
> Diffs
> -
> 
>   applets/CMakeLists.txt 40c2e05 
>   applets/quicklaunch-qml/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch-qml/Messages.sh PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/code/layout.js PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/config/config.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/config/main.xml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/IconItem.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/contents/ui/main.qml PRE-CREATION 
>   applets/quicklaunch-qml/package/metadata.desktop PRE-CREATION 
>   applets/quicklaunch-qml/plugin/CMakeLists.txt PRE-CREATION 
>   applets/quicklaunch-qml/plugin/qmldir PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunch_p.h PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunch_p.cpp PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunchplugin.h PRE-CREATION 
>   applets/quicklaunch-qml/plugin/quicklaunchplugin.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125174/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Empty applet
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/555b9762-e399-42f2-9a85-380f55749132__empty.png
> On desktop (2 rows)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/2874569c-3a2e-44f7-a537-021046226789__desktop-2-rows.png
> On desktop with names + dragging
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/1bce2c1f-91e8-4300-81fa-fd1334e8c281__desktop-1row-drag.png
> In vertical panel
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/9f55dc04-1aae-4a5a-a70c-7158c527f0e7__panel-vertical.png
> Context menu
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/11/7fe10753-5d23-4480-8701-4022dc162943__context-menu.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel