Re: Review Request 125805: Improve lockwindow test
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125805/#review87412 --- please verify that the background is colored at the expected places. - Martin Gräßlin On Oct. 26, 2015, 10:18 a.m., Bhushan Shah wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125805/ > --- > > (Updated Oct. 26, 2015, 10:18 a.m.) > > > Review request for Plasma and Martin Gräßlin. > > > Repository: plasma-workspace > > > Description > --- > > Earlier we were creating dummy window but it was just black/transperant, so > given that isBlack check would succeed even if lockwindow is not shown in > some cases. > > > Diffs > - > > ksmserver/screenlocker/autotests/lockwindowtest.cpp 444c44f > > Diff: https://git.reviewboard.kde.org/r/125805/diff/ > > > Testing > --- > > tests pass > > > Thanks, > > Bhushan Shah > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125805: Improve lockwindow test
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125805/ --- (Updated Oct. 26, 2015, 9:57 a.m.) Status -- This change has been marked as submitted. Review request for Plasma and Martin Gräßlin. Changes --- Submitted with commit 9bf61a335b06b94aae642518bbe1d7f671880061 by Bhushan Shah to branch master. Repository: plasma-workspace Description --- Earlier we were creating dummy window but it was just black/transperant, so given that isBlack check would succeed even if lockwindow is not shown in some cases. Diffs - ksmserver/screenlocker/autotests/lockwindowtest.cpp 444c44f Diff: https://git.reviewboard.kde.org/r/125805/diff/ Testing --- tests pass Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125805: Improve lockwindow test
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125805/ --- (Updated Oct. 26, 2015, 3:13 p.m.) Review request for Plasma and Martin Gräßlin. Changes --- now verifies if 0,0,100,100 is red Repository: plasma-workspace Description --- Earlier we were creating dummy window but it was just black/transperant, so given that isBlack check would succeed even if lockwindow is not shown in some cases. Diffs (updated) - ksmserver/screenlocker/autotests/lockwindowtest.cpp 444c44f Diff: https://git.reviewboard.kde.org/r/125805/diff/ Testing --- tests pass Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125805: Improve lockwindow test
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125805/#review87413 --- Ship it! Ship It! - Martin Gräßlin On Oct. 26, 2015, 10:43 a.m., Bhushan Shah wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125805/ > --- > > (Updated Oct. 26, 2015, 10:43 a.m.) > > > Review request for Plasma and Martin Gräßlin. > > > Repository: plasma-workspace > > > Description > --- > > Earlier we were creating dummy window but it was just black/transperant, so > given that isBlack check would succeed even if lockwindow is not shown in > some cases. > > > Diffs > - > > ksmserver/screenlocker/autotests/lockwindowtest.cpp 444c44f > > Diff: https://git.reviewboard.kde.org/r/125805/diff/ > > > Testing > --- > > tests pass > > > Thanks, > > Bhushan Shah > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
