Re: Review Request 125975: X11 build system cleanup

2015-11-09 Thread Martin Gräßlin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125975/
---

(Updated Nov. 9, 2015, 10:11 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Plasma and Marco Martin.


Changes
---

Submitted with commit 9030405089bd9cc5ac663913d828e70939c69716 by Martin 
Gräßlin to branch master.


Repository: plasma-framework


Description
---

Use newer cmake syntax for XCB dependencies


[declarativeimports/core] Specify HAVE_XCB_COMPOSITE in config-x11.h


[plasmaquick] Drop XCB::COMPOSITE and DAMAGE dependency

Not used

[plasmaquick] Don't link OpenGL explicitly

Not needed and anyway pulled in from Qt.


Diffs
-

  src/declarativeimports/core/CMakeLists.txt 
0265d5999dcec533b04f6b38ac2f345ea57f966d 
  src/declarativeimports/core/config-x11.h.cmake 
89858d17de239cfc7eed1f40a8b828803de3299c 
  src/declarativeimports/core/windowthumbnail.h 
576b053229a8cfc15b6fadd8d4e6ff07f937565d 
  src/plasma/CMakeLists.txt 73f308cf5ac8371c1d259c335edcb069117c5c11 
  src/plasmaquick/CMakeLists.txt 1ddc61123e2a061b42d14cbd1065a70458fdd2d7 

Diff: https://git.reviewboard.kde.org/r/125975/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 125975: X11 build system cleanup

2015-11-06 Thread Aleix Pol Gonzalez

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125975/#review88092
---

Ship it!


Ship It!

- Aleix Pol Gonzalez


On Nov. 6, 2015, 10:42 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125975/
> ---
> 
> (Updated Nov. 6, 2015, 10:42 a.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Marco Martin.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Use newer cmake syntax for XCB dependencies
> 
> 
> [declarativeimports/core] Specify HAVE_XCB_COMPOSITE in config-x11.h
> 
> 
> [plasmaquick] Drop XCB::COMPOSITE and DAMAGE dependency
> 
> Not used
> 
> [plasmaquick] Don't link OpenGL explicitly
> 
> Not needed and anyway pulled in from Qt.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/CMakeLists.txt 
> 0265d5999dcec533b04f6b38ac2f345ea57f966d 
>   src/declarativeimports/core/config-x11.h.cmake 
> 89858d17de239cfc7eed1f40a8b828803de3299c 
>   src/declarativeimports/core/windowthumbnail.h 
> 576b053229a8cfc15b6fadd8d4e6ff07f937565d 
>   src/plasma/CMakeLists.txt 73f308cf5ac8371c1d259c335edcb069117c5c11 
>   src/plasmaquick/CMakeLists.txt 1ddc61123e2a061b42d14cbd1065a70458fdd2d7 
> 
> Diff: https://git.reviewboard.kde.org/r/125975/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel