Re: Review Request 126083: [hwcomposer] Don't waitVsync if we haven't activated vsync yet
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126083/ --- (Updated Nov. 17, 2015, 1:46 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit e71a230213db70cd834565002ebda48853145146 by Martin Gräßlin to branch master. Repository: kwin Description --- Would just hit the timeout, no need to wait 16 msec for nothing. [hwcomposer] Add support for backlight through light_device_t We use the hw module's backlight and set the color to either 0 or FF depending on whetehr we want to have the screen on or off. This turns the backlight off properly. It is bound to the toggleBlank functionality so that we always turn on/off the backlight depending on whether our compositor is on or off. In addition we listen to key release events on the power button to toggle the state. Diffs - backends/hwcomposer/hwcomposer_backend.cpp a4c83d8346b38e284037925a09048da81c1b2056 backends/hwcomposer/hwcomposer_backend.h a6d85ea35f15626e6df3776b96e68ba5c9b14c66 Diff: https://git.reviewboard.kde.org/r/126083/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126083: [hwcomposer] Don't waitVsync if we haven't activated vsync yet
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126083/#review88474 --- Ship it! Ship It! - Bhushan Shah On Nov. 16, 2015, 5:13 p.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126083/ > --- > > (Updated Nov. 16, 2015, 5:13 p.m.) > > > Review request for Plasma. > > > Repository: kwin > > > Description > --- > > Would just hit the timeout, no need to wait 16 msec for nothing. > > [hwcomposer] Add support for backlight through light_device_t > > We use the hw module's backlight and set the color to either 0 > or FF depending on whetehr we want to have the screen on or off. > This turns the backlight off properly. It is bound to the toggleBlank > functionality so that we always turn on/off the backlight depending > on whether our compositor is on or off. > > In addition we listen to key release events on the power button to > toggle the state. > > > Diffs > - > > backends/hwcomposer/hwcomposer_backend.cpp > a4c83d8346b38e284037925a09048da81c1b2056 > backends/hwcomposer/hwcomposer_backend.h > a6d85ea35f15626e6df3776b96e68ba5c9b14c66 > > Diff: https://git.reviewboard.kde.org/r/126083/diff/ > > > Testing > --- > > > Thanks, > > Martin Gräßlin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126083: [hwcomposer] Don't waitVsync if we haven't activated vsync yet
> On Nov. 16, 2015, 12:49 p.m., Bhushan Shah wrote: > > It includes another random change? > > Marco Martin wrote: > if (!m_hasVsync) ? no, these are two commits. The first one is the change in waitVSync, the other one the backlight handling - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126083/#review88413 --- On Nov. 16, 2015, 12:43 p.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126083/ > --- > > (Updated Nov. 16, 2015, 12:43 p.m.) > > > Review request for Plasma. > > > Repository: kwin > > > Description > --- > > Would just hit the timeout, no need to wait 16 msec for nothing. > > [hwcomposer] Add support for backlight through light_device_t > > We use the hw module's backlight and set the color to either 0 > or FF depending on whetehr we want to have the screen on or off. > This turns the backlight off properly. It is bound to the toggleBlank > functionality so that we always turn on/off the backlight depending > on whether our compositor is on or off. > > In addition we listen to key release events on the power button to > toggle the state. > > > Diffs > - > > backends/hwcomposer/hwcomposer_backend.cpp > a4c83d8346b38e284037925a09048da81c1b2056 > backends/hwcomposer/hwcomposer_backend.h > a6d85ea35f15626e6df3776b96e68ba5c9b14c66 > > Diff: https://git.reviewboard.kde.org/r/126083/diff/ > > > Testing > --- > > > Thanks, > > Martin Gräßlin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126083: [hwcomposer] Don't waitVsync if we haven't activated vsync yet
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126083/#review88416 --- +1 - Marco Martin On Nov. 16, 2015, 11:43 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126083/ > --- > > (Updated Nov. 16, 2015, 11:43 a.m.) > > > Review request for Plasma. > > > Repository: kwin > > > Description > --- > > Would just hit the timeout, no need to wait 16 msec for nothing. > > [hwcomposer] Add support for backlight through light_device_t > > We use the hw module's backlight and set the color to either 0 > or FF depending on whetehr we want to have the screen on or off. > This turns the backlight off properly. It is bound to the toggleBlank > functionality so that we always turn on/off the backlight depending > on whether our compositor is on or off. > > In addition we listen to key release events on the power button to > toggle the state. > > > Diffs > - > > backends/hwcomposer/hwcomposer_backend.cpp > a4c83d8346b38e284037925a09048da81c1b2056 > backends/hwcomposer/hwcomposer_backend.h > a6d85ea35f15626e6df3776b96e68ba5c9b14c66 > > Diff: https://git.reviewboard.kde.org/r/126083/diff/ > > > Testing > --- > > > Thanks, > > Martin Gräßlin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126083: [hwcomposer] Don't waitVsync if we haven't activated vsync yet
> On Nov. 16, 2015, 11:49 a.m., Bhushan Shah wrote: > > It includes another random change? if (!m_hasVsync) ? - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126083/#review88413 --- On Nov. 16, 2015, 11:43 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126083/ > --- > > (Updated Nov. 16, 2015, 11:43 a.m.) > > > Review request for Plasma. > > > Repository: kwin > > > Description > --- > > Would just hit the timeout, no need to wait 16 msec for nothing. > > [hwcomposer] Add support for backlight through light_device_t > > We use the hw module's backlight and set the color to either 0 > or FF depending on whetehr we want to have the screen on or off. > This turns the backlight off properly. It is bound to the toggleBlank > functionality so that we always turn on/off the backlight depending > on whether our compositor is on or off. > > In addition we listen to key release events on the power button to > toggle the state. > > > Diffs > - > > backends/hwcomposer/hwcomposer_backend.cpp > a4c83d8346b38e284037925a09048da81c1b2056 > backends/hwcomposer/hwcomposer_backend.h > a6d85ea35f15626e6df3776b96e68ba5c9b14c66 > > Diff: https://git.reviewboard.kde.org/r/126083/diff/ > > > Testing > --- > > > Thanks, > > Martin Gräßlin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126083: [hwcomposer] Don't waitVsync if we haven't activated vsync yet
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126083/#review88413 --- It includes another random change? - Bhushan Shah On Nov. 16, 2015, 5:13 p.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126083/ > --- > > (Updated Nov. 16, 2015, 5:13 p.m.) > > > Review request for Plasma. > > > Repository: kwin > > > Description > --- > > Would just hit the timeout, no need to wait 16 msec for nothing. > > [hwcomposer] Add support for backlight through light_device_t > > We use the hw module's backlight and set the color to either 0 > or FF depending on whetehr we want to have the screen on or off. > This turns the backlight off properly. It is bound to the toggleBlank > functionality so that we always turn on/off the backlight depending > on whether our compositor is on or off. > > In addition we listen to key release events on the power button to > toggle the state. > > > Diffs > - > > backends/hwcomposer/hwcomposer_backend.cpp > a4c83d8346b38e284037925a09048da81c1b2056 > backends/hwcomposer/hwcomposer_backend.h > a6d85ea35f15626e6df3776b96e68ba5c9b14c66 > > Diff: https://git.reviewboard.kde.org/r/126083/diff/ > > > Testing > --- > > > Thanks, > > Martin Gräßlin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
