Re: Review Request 126464: [compactApplet] Read ToolTipArea.mainItem from plasmoid.toolTipItem

2016-01-04 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126464/#review90580
---

Ship it!


Ship It!

- Kai Uwe Broulik


On Jan. 4, 2016, 5:39 nachm., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126464/
> ---
> 
> (Updated Jan. 4, 2016, 5:39 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This is a part 2 patch for https://git.reviewboard.kde.org/r/126463/
> 
> This actaully sets the tooltip item to the main ToolTipArea.
> 
> 
> Diffs
> -
> 
>   desktoppackage/contents/applet/CompactApplet.qml f9c29a5 
> 
> Diff: https://git.reviewboard.kde.org/r/126464/diff/
> 
> 
> Testing
> ---
> 
> All works as expected.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126464: [compactApplet] Read ToolTipArea.mainItem from plasmoid.toolTipItem

2016-01-04 Thread Martin Klapetek 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126464/
---

(Updated Jan. 4, 2016, 5:55 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 6e0d0c49a3cf5881757b57f55c60033efd6cb3d1 by Martin 
Klapetek to branch master.


Repository: plasma-desktop


Description
---

This is a part 2 patch for https://git.reviewboard.kde.org/r/126463/

This actaully sets the tooltip item to the main ToolTipArea.


Diffs
-

  desktoppackage/contents/applet/CompactApplet.qml f9c29a5 

Diff: https://git.reviewboard.kde.org/r/126464/diff/


Testing
---

All works as expected.


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126464: [compactApplet] Read ToolTipArea.mainItem from plasmoid.toolTipItem

2016-01-04 Thread Martin Klapetek 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126464/
---

(Updated Jan. 4, 2016, 6:39 p.m.)


Review request for Plasma.


Changes
---

Use null rather than undefined


Repository: plasma-desktop


Description
---

This is a part 2 patch for https://git.reviewboard.kde.org/r/126463/

This actaully sets the tooltip item to the main ToolTipArea.


Diffs (updated)
-

  desktoppackage/contents/applet/CompactApplet.qml f9c29a5 

Diff: https://git.reviewboard.kde.org/r/126464/diff/


Testing
---

All works as expected.


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126464: [compactApplet] Read ToolTipArea.mainItem from plasmoid.toolTipItem

2016-01-04 Thread Martin Klapetek 


> On Dec. 21, 2015, 11:28 p.m., Kai Uwe Broulik wrote:
> > desktoppackage/contents/applet/CompactApplet.qml, line 37
> > 
> >
> > Doesn't it complain about "Cannot assign [undefined] to something"? If 
> > not, awesome.

It did, so I changed it to null, now it doesn't ^_^


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126464/#review89866
---


On Dec. 21, 2015, 11:12 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126464/
> ---
> 
> (Updated Dec. 21, 2015, 11:12 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This is a part 2 patch for https://git.reviewboard.kde.org/r/126463/
> 
> This actaully sets the tooltip item to the main ToolTipArea.
> 
> 
> Diffs
> -
> 
>   desktoppackage/contents/applet/CompactApplet.qml f9c29a5 
> 
> Diff: https://git.reviewboard.kde.org/r/126464/diff/
> 
> 
> Testing
> ---
> 
> All works as expected.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126464: [compactApplet] Read ToolTipArea.mainItem from plasmoid.toolTipItem

2015-12-22 Thread Martin Klapetek 


> On Dec. 22, 2015, 1:43 p.m., Marco Martin wrote:
> > Did you test all plasmoids with standard tooltip still work as expected? 
> > (and quinckly move the mouse back and forth between plsmoid with standard 
> > tooltip and custom)

Yeah, all looks fine. --> 
https://www.dropbox.com/s/dgzulltsk6g7pwk/vokoscreen-2015-12-22_11-21-59.mkv?dl=0

The clock has the custom tooltip item.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126464/#review89910
---


On Dec. 21, 2015, 11:12 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126464/
> ---
> 
> (Updated Dec. 21, 2015, 11:12 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This is a part 2 patch for https://git.reviewboard.kde.org/r/126463/
> 
> This actaully sets the tooltip item to the main ToolTipArea.
> 
> 
> Diffs
> -
> 
>   desktoppackage/contents/applet/CompactApplet.qml f9c29a5 
> 
> Diff: https://git.reviewboard.kde.org/r/126464/diff/
> 
> 
> Testing
> ---
> 
> All works as expected.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126464: [compactApplet] Read ToolTipArea.mainItem from plasmoid.toolTipItem

2015-12-22 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126464/#review89910
---


Did you test all plasmoids with standard tooltip still work as expected? (and 
quinckly move the mouse back and forth between plsmoid with standard tooltip 
and custom)

- Marco Martin


On Dic. 21, 2015, 10:12 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126464/
> ---
> 
> (Updated Dic. 21, 2015, 10:12 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This is a part 2 patch for https://git.reviewboard.kde.org/r/126463/
> 
> This actaully sets the tooltip item to the main ToolTipArea.
> 
> 
> Diffs
> -
> 
>   desktoppackage/contents/applet/CompactApplet.qml f9c29a5 
> 
> Diff: https://git.reviewboard.kde.org/r/126464/diff/
> 
> 
> Testing
> ---
> 
> All works as expected.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126464: [compactApplet] Read ToolTipArea.mainItem from plasmoid.toolTipItem

2015-12-21 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126464/#review89866
---



desktoppackage/contents/applet/CompactApplet.qml (line 37)


Doesn't it complain about "Cannot assign [undefined] to something"? If not, 
awesome.


- Kai Uwe Broulik


On Dez. 21, 2015, 10:12 nachm., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126464/
> ---
> 
> (Updated Dez. 21, 2015, 10:12 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This is a part 2 patch for https://git.reviewboard.kde.org/r/126463/
> 
> This actaully sets the tooltip item to the main ToolTipArea.
> 
> 
> Diffs
> -
> 
>   desktoppackage/contents/applet/CompactApplet.qml f9c29a5 
> 
> Diff: https://git.reviewboard.kde.org/r/126464/diff/
> 
> 
> Testing
> ---
> 
> All works as expected.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel