Re: Review Request 127460: Fix drawing QtQuickControls ComboBox popups

2016-03-22 Thread David Rosca 


> On March 22, 2016, 5:28 p.m., Anthony Fieroni wrote:
> > Ty. This is also needed for Oxygen. Also notice incorrect positioning 
> > systemsettings -> multimedia
> > http://store.picbg.net/pubpic/8F/19/c92e06333aff8f19.png

Incorrect positioning is another issue. It happens only when used from 
QQuickWidget afaik (so from system settings).


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127460/#review93875
---


On March 22, 2016, 3:25 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127460/
> ---
> 
> (Updated March 22, 2016, 3:25 p.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Bugs: 343369
> https://bugs.kde.org/show_bug.cgi?id=343369
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> Implement drawing QStyleOptionFrame QFrame::StyledPanel shape.
> Also expand CT_ItemViewItem size for QtQuickControls too.
> 
> BUG: 343369
> 
> 
> Diffs
> -
> 
>   kstyle/breezestyle.cpp 9a4b674 
> 
> Diff: https://git.reviewboard.kde.org/r/127460/diff/
> 
> 
> Testing
> ---
> 
> QtQuickControls ComboBox popups now use palette colors and have correct 
> spacing.
> 
> 
> File Attachments
> 
> 
> popup-light.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/22/ff3643e8-1aa3-46d6-bf61-5b84c7eb11cc__popup-light.png
> popup-dark.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/22/c534f049-0712-490f-8107-13b3670e2318__popup-dark.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127460: Fix drawing QtQuickControls ComboBox popups

2016-03-22 Thread Anthony Fieroni 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127460/#review93875
---



Ty. This is also needed for Oxygen. Also notice incorrect positioning 
systemsettings -> multimedia
http://store.picbg.net/pubpic/8F/19/c92e06333aff8f19.png

- Anthony Fieroni


On Март 22, 2016, 5:25 след обяд, David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127460/
> ---
> 
> (Updated Март 22, 2016, 5:25 след обяд)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Bugs: 343369
> https://bugs.kde.org/show_bug.cgi?id=343369
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> Implement drawing QStyleOptionFrame QFrame::StyledPanel shape.
> Also expand CT_ItemViewItem size for QtQuickControls too.
> 
> BUG: 343369
> 
> 
> Diffs
> -
> 
>   kstyle/breezestyle.cpp 9a4b674 
> 
> Diff: https://git.reviewboard.kde.org/r/127460/diff/
> 
> 
> Testing
> ---
> 
> QtQuickControls ComboBox popups now use palette colors and have correct 
> spacing.
> 
> 
> File Attachments
> 
> 
> popup-light.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/22/ff3643e8-1aa3-46d6-bf61-5b84c7eb11cc__popup-light.png
> popup-dark.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/22/c534f049-0712-490f-8107-13b3670e2318__popup-dark.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127460: Fix drawing QtQuickControls ComboBox popups

2016-03-22 Thread David Rosca 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127460/
---

(Updated March 22, 2016, 4:25 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and Hugo Pereira Da Costa.


Changes
---

Submitted with commit c2008d6d3a62b3f7f6e5198e047d39b4a40ecf7e by David Rosca 
to branch Plasma/5.6.


Bugs: 343369
https://bugs.kde.org/show_bug.cgi?id=343369


Repository: breeze


Description
---

Implement drawing QStyleOptionFrame QFrame::StyledPanel shape.
Also expand CT_ItemViewItem size for QtQuickControls too.

BUG: 343369


Diffs
-

  kstyle/breezestyle.cpp 9a4b674 

Diff: https://git.reviewboard.kde.org/r/127460/diff/


Testing
---

QtQuickControls ComboBox popups now use palette colors and have correct spacing.


File Attachments


popup-light.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/03/22/ff3643e8-1aa3-46d6-bf61-5b84c7eb11cc__popup-light.png
popup-dark.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/03/22/c534f049-0712-490f-8107-13b3670e2318__popup-dark.png


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127460: Fix drawing QtQuickControls ComboBox popups

2016-03-22 Thread Hugo Pereira Da Costa 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127460/#review93869
---


Ship it!




Ship It!

- Hugo Pereira Da Costa


On March 22, 2016, 3:05 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127460/
> ---
> 
> (Updated March 22, 2016, 3:05 p.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Bugs: 343369
> https://bugs.kde.org/show_bug.cgi?id=343369
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> Implement drawing QStyleOptionFrame QFrame::StyledPanel shape.
> Also expand CT_ItemViewItem size for QtQuickControls too.
> 
> BUG: 343369
> 
> 
> Diffs
> -
> 
>   kstyle/breezestyle.cpp 9a4b674 
> 
> Diff: https://git.reviewboard.kde.org/r/127460/diff/
> 
> 
> Testing
> ---
> 
> QtQuickControls ComboBox popups now use palette colors and have correct 
> spacing.
> 
> 
> File Attachments
> 
> 
> popup-light.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/22/ff3643e8-1aa3-46d6-bf61-5b84c7eb11cc__popup-light.png
> popup-dark.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/22/c534f049-0712-490f-8107-13b3670e2318__popup-dark.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127460: Fix drawing QtQuickControls ComboBox popups

2016-03-22 Thread David Rosca 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127460/
---

(Updated March 22, 2016, 3:05 p.m.)


Review request for Plasma and Hugo Pereira Da Costa.


Bugs: 343369
https://bugs.kde.org/show_bug.cgi?id=343369


Repository: breeze


Description
---

Implement drawing QStyleOptionFrame QFrame::StyledPanel shape.
Also expand CT_ItemViewItem size for QtQuickControls too.

BUG: 343369


Diffs (updated)
-

  kstyle/breezestyle.cpp 9a4b674 

Diff: https://git.reviewboard.kde.org/r/127460/diff/


Testing
---

QtQuickControls ComboBox popups now use palette colors and have correct spacing.


File Attachments


popup-light.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/03/22/ff3643e8-1aa3-46d6-bf61-5b84c7eb11cc__popup-light.png
popup-dark.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/03/22/c534f049-0712-490f-8107-13b3670e2318__popup-dark.png


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127460: Fix drawing QtQuickControls ComboBox popups

2016-03-22 Thread Hugo Pereira Da Costa 


> On March 22, 2016, 2:54 p.m., Hugo Pereira Da Costa wrote:
> > kstyle/breezestyle.cpp, line 5059
> > 
> >
> > For clarity I would rather put it the other way around:
> > 
> > if( isQtQuickControl())
> > {
> >   
> >   ...
> >   return true;
> >   
> > } else return false;
> 
> David Rosca wrote:
> Ok, `return false` or `break` (as used few lines above) in the else 
> branch?

ha 
break is good
Thanks for the patch, by the way !


- Hugo


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127460/#review93866
---


On March 22, 2016, 2:35 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127460/
> ---
> 
> (Updated March 22, 2016, 2:35 p.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Bugs: 343369
> https://bugs.kde.org/show_bug.cgi?id=343369
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> Implement drawing QStyleOptionFrame QFrame::StyledPanel shape.
> Also expand CT_ItemViewItem size for QtQuickControls too.
> 
> BUG: 343369
> 
> 
> Diffs
> -
> 
>   kstyle/breezestyle.cpp 9a4b674 
> 
> Diff: https://git.reviewboard.kde.org/r/127460/diff/
> 
> 
> Testing
> ---
> 
> QtQuickControls ComboBox popups now use palette colors and have correct 
> spacing.
> 
> 
> File Attachments
> 
> 
> popup-light.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/22/ff3643e8-1aa3-46d6-bf61-5b84c7eb11cc__popup-light.png
> popup-dark.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/22/c534f049-0712-490f-8107-13b3670e2318__popup-dark.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127460: Fix drawing QtQuickControls ComboBox popups

2016-03-22 Thread David Rosca 


> On March 22, 2016, 2:54 p.m., Hugo Pereira Da Costa wrote:
> > kstyle/breezestyle.cpp, line 5059
> > 
> >
> > For clarity I would rather put it the other way around:
> > 
> > if( isQtQuickControl())
> > {
> >   
> >   ...
> >   return true;
> >   
> > } else return false;

Ok, `return false` or `break` (as used few lines above) in the else branch?


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127460/#review93866
---


On March 22, 2016, 2:35 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127460/
> ---
> 
> (Updated March 22, 2016, 2:35 p.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Bugs: 343369
> https://bugs.kde.org/show_bug.cgi?id=343369
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> Implement drawing QStyleOptionFrame QFrame::StyledPanel shape.
> Also expand CT_ItemViewItem size for QtQuickControls too.
> 
> BUG: 343369
> 
> 
> Diffs
> -
> 
>   kstyle/breezestyle.cpp 9a4b674 
> 
> Diff: https://git.reviewboard.kde.org/r/127460/diff/
> 
> 
> Testing
> ---
> 
> QtQuickControls ComboBox popups now use palette colors and have correct 
> spacing.
> 
> 
> File Attachments
> 
> 
> popup-light.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/22/ff3643e8-1aa3-46d6-bf61-5b84c7eb11cc__popup-light.png
> popup-dark.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/22/c534f049-0712-490f-8107-13b3670e2318__popup-dark.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127460: Fix drawing QtQuickControls ComboBox popups

2016-03-22 Thread Hugo Pereira Da Costa 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127460/#review93866
---




kstyle/breezestyle.cpp (line 2905)


Nice that it now works.

In the past I had to introduce the isQtQuickControl test here because 
expanding the size was resulting into buggy item selection ...

This to say: this might create regression against older versions of Qt

... in fact: this change is somewhat unrelated to the second fix (which is 
more critical)
I would put it in a separate commit, in case it needs revert.



kstyle/breezestyle.cpp (line 5059)


For clarity I would rather put it the other way around:

if( isQtQuickControl())
{
  
  ...
  return true;
  
} else return false;


- Hugo Pereira Da Costa


On March 22, 2016, 2:35 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127460/
> ---
> 
> (Updated March 22, 2016, 2:35 p.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Bugs: 343369
> https://bugs.kde.org/show_bug.cgi?id=343369
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> Implement drawing QStyleOptionFrame QFrame::StyledPanel shape.
> Also expand CT_ItemViewItem size for QtQuickControls too.
> 
> BUG: 343369
> 
> 
> Diffs
> -
> 
>   kstyle/breezestyle.cpp 9a4b674 
> 
> Diff: https://git.reviewboard.kde.org/r/127460/diff/
> 
> 
> Testing
> ---
> 
> QtQuickControls ComboBox popups now use palette colors and have correct 
> spacing.
> 
> 
> File Attachments
> 
> 
> popup-light.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/22/ff3643e8-1aa3-46d6-bf61-5b84c7eb11cc__popup-light.png
> popup-dark.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/22/c534f049-0712-490f-8107-13b3670e2318__popup-dark.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127460: Fix drawing QtQuickControls ComboBox popups

2016-03-22 Thread David Rosca 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127460/
---

(Updated March 22, 2016, 2:35 p.m.)


Review request for Plasma and Hugo Pereira Da Costa.


Bugs: 343369
https://bugs.kde.org/show_bug.cgi?id=343369


Repository: breeze


Description
---

Implement drawing QStyleOptionFrame QFrame::StyledPanel shape.
Also expand CT_ItemViewItem size for QtQuickControls too.

BUG: 343369


Diffs
-

  kstyle/breezestyle.cpp 9a4b674 

Diff: https://git.reviewboard.kde.org/r/127460/diff/


Testing
---

QtQuickControls ComboBox popups now use palette colors and have correct spacing.


File Attachments (updated)


popup-light.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/03/22/ff3643e8-1aa3-46d6-bf61-5b84c7eb11cc__popup-light.png
popup-dark.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/03/22/c534f049-0712-490f-8107-13b3670e2318__popup-dark.png


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127460: Fix drawing QtQuickControls ComboBox popups

2016-03-22 Thread David Rosca 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127460/
---

(Updated March 22, 2016, 2:28 p.m.)


Review request for Plasma and Hugo Pereira Da Costa.


Changes
---

Coding style


Bugs: 343369
https://bugs.kde.org/show_bug.cgi?id=343369


Repository: breeze


Description
---

Implement drawing QStyleOptionFrame QFrame::StyledPanel shape.
Also expand CT_ItemViewItem size for QtQuickControls too.

BUG: 343369


Diffs (updated)
-

  kstyle/breezestyle.cpp 9a4b674 

Diff: https://git.reviewboard.kde.org/r/127460/diff/


Testing
---

QtQuickControls ComboBox popups now use palette colors and have correct spacing.


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127460: Fix drawing QtQuickControls ComboBox popups

2016-03-22 Thread David Rosca 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127460/
---

(Updated March 22, 2016, 2:24 p.m.)


Review request for Plasma and Hugo Pereira Da Costa.


Changes
---

Only for QtQuickControls


Bugs: 343369
https://bugs.kde.org/show_bug.cgi?id=343369


Repository: breeze


Description
---

Implement drawing QStyleOptionFrame QFrame::StyledPanel shape.
Also expand CT_ItemViewItem size for QtQuickControls too.

BUG: 343369


Diffs (updated)
-

  kstyle/breezestyle.cpp 9a4b674 

Diff: https://git.reviewboard.kde.org/r/127460/diff/


Testing
---

QtQuickControls ComboBox popups now use palette colors and have correct spacing.


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel