Re: Review Request 127586: [calendar] Add a mark to days containing events

[Martin Klapetek]

> On April 28, 2016, 8:44 p.m., Kai Uwe Broulik wrote:
> > You broke the zoomed out view, ie. in the year/decade overview you now get 
> > a tick at *every* cell...
> 
> Martin Klapetek wrote:
> Oops, I'll fix, thanks.

This is now fixed.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127586/#review94987
---


On April 21, 2016, 5:41 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127586/
> ---
> 
> (Updated April 21, 2016, 5:41 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Simple triangle at the bottom right corner, see screenshot.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/calendar.h 1849ada 
>   src/declarativeimports/calendar/calendar.cpp 0c525b7 
>   src/declarativeimports/calendar/daysmodel.h 8ab232e 
>   src/declarativeimports/calendar/daysmodel.cpp bf99874 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6353827 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml d4b8fe4 
> 
> Diff: https://git.reviewboard.kde.org/r/127586/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127586: [calendar] Add a mark to days containing events

[Martin Klapetek]

> On April 28, 2016, 8:44 p.m., Kai Uwe Broulik wrote:
> > You broke the zoomed out view, ie. in the year/decade overview you now get 
> > a tick at *every* cell...

Oops, I'll fix, thanks.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127586/#review94987
---


On April 21, 2016, 5:41 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127586/
> ---
> 
> (Updated April 21, 2016, 5:41 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Simple triangle at the bottom right corner, see screenshot.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/calendar.h 1849ada 
>   src/declarativeimports/calendar/calendar.cpp 0c525b7 
>   src/declarativeimports/calendar/daysmodel.h 8ab232e 
>   src/declarativeimports/calendar/daysmodel.cpp bf99874 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6353827 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml d4b8fe4 
> 
> Diff: https://git.reviewboard.kde.org/r/127586/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127586: [calendar] Add a mark to days containing events

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127586/#review94987
---



You broke the zoomed out view, ie. in the year/decade overview you now get a 
tick at *every* cell...

- Kai Uwe Broulik


On April 21, 2016, 3:41 vorm., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127586/
> ---
> 
> (Updated April 21, 2016, 3:41 vorm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Simple triangle at the bottom right corner, see screenshot.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/calendar.h 1849ada 
>   src/declarativeimports/calendar/calendar.cpp 0c525b7 
>   src/declarativeimports/calendar/daysmodel.h 8ab232e 
>   src/declarativeimports/calendar/daysmodel.cpp bf99874 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6353827 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml d4b8fe4 
> 
> Diff: https://git.reviewboard.kde.org/r/127586/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127586: [calendar] Add a mark to days containing events

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127586/
---

(Updated April 21, 2016, 3:41 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit 08312b2e340e10d640131c0186e81a0b9f0f2505 by Martin 
Klapetek to branch master.


Repository: plasma-framework


Description
---

Simple triangle at the bottom right corner, see screenshot.


Diffs
-

  src/declarativeimports/calendar/calendar.h 1849ada 
  src/declarativeimports/calendar/calendar.cpp 0c525b7 
  src/declarativeimports/calendar/daysmodel.h 8ab232e 
  src/declarativeimports/calendar/daysmodel.cpp bf99874 
  src/declarativeimports/calendar/qml/DayDelegate.qml 6353827 
  src/declarativeimports/calendar/qml/DaysCalendar.qml d4b8fe4 

Diff: https://git.reviewboard.kde.org/r/127586/diff/


Testing
---


File Attachments


Screenshot
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127586: [calendar] Add a mark to days containing events

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127586/#review94703
---


Ship it!




Ship It!

- Marco Martin


On April 19, 2016, 3:23 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127586/
> ---
> 
> (Updated April 19, 2016, 3:23 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Simple triangle at the bottom right corner, see screenshot.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/calendar.h 1849ada 
>   src/declarativeimports/calendar/calendar.cpp 0c525b7 
>   src/declarativeimports/calendar/daysmodel.h 8ab232e 
>   src/declarativeimports/calendar/daysmodel.cpp bf99874 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6353827 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml d4b8fe4 
> 
> Diff: https://git.reviewboard.kde.org/r/127586/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127586: [calendar] Add a mark to days containing events

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127586/
---

(Updated April 19, 2016, 5:23 a.m.)


Review request for KDE Frameworks and Plasma.


Changes
---

Avoid reordering issue


Repository: plasma-framework


Description
---

Simple triangle at the bottom right corner, see screenshot.


Diffs (updated)
-

  src/declarativeimports/calendar/calendar.h 1849ada 
  src/declarativeimports/calendar/calendar.cpp 0c525b7 
  src/declarativeimports/calendar/daysmodel.h 8ab232e 
  src/declarativeimports/calendar/daysmodel.cpp bf99874 
  src/declarativeimports/calendar/qml/DayDelegate.qml 6353827 
  src/declarativeimports/calendar/qml/DaysCalendar.qml d4b8fe4 

Diff: https://git.reviewboard.kde.org/r/127586/diff/


Testing
---


File Attachments


Screenshot
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127586: [calendar] Add a mark to days containing events

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127586/#review94624
---



Looks good!


src/declarativeimports/calendar/daysmodel.h (lines 76 - 77)


maybe move m_lastRequestedEventsStartDate below m_agendaNeedsUpdate? Then 
you don't have the reordering in the cpp file.


- Martin Gräßlin


On April 15, 2016, 4:28 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127586/
> ---
> 
> (Updated April 15, 2016, 4:28 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Simple triangle at the bottom right corner, see screenshot.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/daysmodel.h 8ab232e 
>   src/declarativeimports/calendar/daysmodel.cpp bf99874 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6353827 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml d4b8fe4 
> 
> Diff: https://git.reviewboard.kde.org/r/127586/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127586: [calendar] Add a mark to days containing events

[Martin Klapetek]

> On April 13, 2016, 10:28 a.m., Marco Martin wrote:
> > what's the status of this?
> 
> Martin Klapetek wrote:
> Working on it.
> 
> Martin Klapetek wrote:
> Ok so I'm unable to render that svg, it is properly installed
> and everything, but this doesn't show anything (not even error):
> 
> ```
> PlasmaCore.Svg {
> id: calendarSvg
> imagePath: "widgets/calendar"
> }
> 
> PlasmaCore.SvgItem {
> id: eventsMarker
> width: parent.width / 3
> height: parent.height / 3
> svg: calendarSvg
> elementId: "event"
> }
> ```
> 
> ...is it missing anything? If I use say "widgets/clock" and "ClockFace", 
> it works fine.
> 
> Marco Martin wrote:
> tried to delete the cache?
> 
> Martin Klapetek wrote:
> Yes, in fact, after deleting the cache, I see this:
> 
> QtQmlViewer(9862) unknown: Couldn't find node event. Skipping rendering.
> 
> On a second run, it doesn't show anymore.
> 
> Is the code above working for you?

*insert double-facepalm image here*

So after some more investigation, I found out why it won't
work - I'm running the "Breeze 5.4" theme, which, obviously,
does not have that element. Sigh.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127586/#review94567
---


On April 6, 2016, 5:53 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127586/
> ---
> 
> (Updated April 6, 2016, 5:53 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Simple triangle at the bottom right corner, see screenshot.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/daysmodel.h 8ab232e 
>   src/declarativeimports/calendar/daysmodel.cpp bf99874 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6353827 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml d4b8fe4 
> 
> Diff: https://git.reviewboard.kde.org/r/127586/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127586: [calendar] Add a mark to days containing events

[Martin Klapetek]

> On April 13, 2016, 10:28 a.m., Marco Martin wrote:
> > what's the status of this?
> 
> Martin Klapetek wrote:
> Working on it.
> 
> Martin Klapetek wrote:
> Ok so I'm unable to render that svg, it is properly installed
> and everything, but this doesn't show anything (not even error):
> 
> ```
> PlasmaCore.Svg {
> id: calendarSvg
> imagePath: "widgets/calendar"
> }
> 
> PlasmaCore.SvgItem {
> id: eventsMarker
> width: parent.width / 3
> height: parent.height / 3
> svg: calendarSvg
> elementId: "event"
> }
> ```
> 
> ...is it missing anything? If I use say "widgets/clock" and "ClockFace", 
> it works fine.
> 
> Marco Martin wrote:
> tried to delete the cache?

Yes, in fact, after deleting the cache, I see this:

QtQmlViewer(9862) unknown: Couldn't find node event. Skipping rendering.

On a second run, it doesn't show anymore.

Is the code above working for you?


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127586/#review94567
---


On April 6, 2016, 5:53 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127586/
> ---
> 
> (Updated April 6, 2016, 5:53 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Simple triangle at the bottom right corner, see screenshot.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/daysmodel.h 8ab232e 
>   src/declarativeimports/calendar/daysmodel.cpp bf99874 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6353827 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml d4b8fe4 
> 
> Diff: https://git.reviewboard.kde.org/r/127586/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127586: [calendar] Add a mark to days containing events

[Marco Martin]

> On April 13, 2016, 8:28 a.m., Marco Martin wrote:
> > what's the status of this?
> 
> Martin Klapetek wrote:
> Working on it.
> 
> Martin Klapetek wrote:
> Ok so I'm unable to render that svg, it is properly installed
> and everything, but this doesn't show anything (not even error):
> 
> ```
> PlasmaCore.Svg {
> id: calendarSvg
> imagePath: "widgets/calendar"
> }
> 
> PlasmaCore.SvgItem {
> id: eventsMarker
> width: parent.width / 3
> height: parent.height / 3
> svg: calendarSvg
> elementId: "event"
> }
> ```
> 
> ...is it missing anything? If I use say "widgets/clock" and "ClockFace", 
> it works fine.

tried to delete the cache?


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127586/#review94567
---


On April 6, 2016, 3:53 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127586/
> ---
> 
> (Updated April 6, 2016, 3:53 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Simple triangle at the bottom right corner, see screenshot.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/daysmodel.h 8ab232e 
>   src/declarativeimports/calendar/daysmodel.cpp bf99874 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6353827 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml d4b8fe4 
> 
> Diff: https://git.reviewboard.kde.org/r/127586/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127586: [calendar] Add a mark to days containing events

[Martin Klapetek]

> On April 13, 2016, 10:28 a.m., Marco Martin wrote:
> > what's the status of this?
> 
> Martin Klapetek wrote:
> Working on it.

Ok so I'm unable to render that svg, it is properly installed
and everything, but this doesn't show anything (not even error):

```
PlasmaCore.Svg {
id: calendarSvg
imagePath: "widgets/calendar"
}

PlasmaCore.SvgItem {
id: eventsMarker
width: parent.width / 3
height: parent.height / 3
svg: calendarSvg
elementId: "event"
}
```

...is it missing anything? If I use say "widgets/clock" and "ClockFace", it 
works fine.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127586/#review94567
---


On April 6, 2016, 5:53 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127586/
> ---
> 
> (Updated April 6, 2016, 5:53 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Simple triangle at the bottom right corner, see screenshot.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/daysmodel.h 8ab232e 
>   src/declarativeimports/calendar/daysmodel.cpp bf99874 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6353827 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml d4b8fe4 
> 
> Diff: https://git.reviewboard.kde.org/r/127586/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127586: [calendar] Add a mark to days containing events

[Martin Klapetek]

> On April 13, 2016, 10:28 a.m., Marco Martin wrote:
> > what's the status of this?

Working on it.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127586/#review94567
---


On April 6, 2016, 5:53 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127586/
> ---
> 
> (Updated April 6, 2016, 5:53 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Simple triangle at the bottom right corner, see screenshot.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/daysmodel.h 8ab232e 
>   src/declarativeimports/calendar/daysmodel.cpp bf99874 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6353827 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml d4b8fe4 
> 
> Diff: https://git.reviewboard.kde.org/r/127586/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127586: [calendar] Add a mark to days containing events

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127586/#review94567
---



what's the status of this?

- Marco Martin


On April 6, 2016, 3:53 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127586/
> ---
> 
> (Updated April 6, 2016, 3:53 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Simple triangle at the bottom right corner, see screenshot.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/daysmodel.h 8ab232e 
>   src/declarativeimports/calendar/daysmodel.cpp bf99874 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6353827 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml d4b8fe4 
> 
> Diff: https://git.reviewboard.kde.org/r/127586/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127586: [calendar] Add a mark to days containing events

[Marco Martin]

> On April 6, 2016, 7:03 a.m., Kai Uwe Broulik wrote:
> > You really don't want to create more Canvas elements than neccessary, they 
> > all have their own FBO.
> > 
> > Can't you make the grid canvas draw the triangles, too? Or make a simple 
> > item with a triangle shaped QSGGeometryNode?
> 
> Kai Uwe Broulik wrote:
> There's even exactly that on WikiBooks :D 
> https://en.wikibooks.org/wiki/Qt/Qt_Quick_Overview#Triangle_implementation
> 
> Martin Klapetek wrote:
> Ah, that's handy. Now I wonder though - it's under CC-BY-SA licence, can 
> I just copy that directly and put that licence in the header and ship this in 
> frameworks?
> 
> Martin Gräßlin wrote:
> I would say that is not copyrightable, it's too trivial.
> 
> Marco Martin wrote:
> I would prefer adding it to the svg theme.
> there used to be elements for the calendar in the theme, they could get 
> back
> 
> Martin Klapetek wrote:
> Oooh that would be nice. Who's in charge of the theme these days?
> 
> Marco Martin wrote:
> I can add the needed item, is just needed a single item as that triangle?
> 
> Martin Klapetek wrote:
> Yes. Make it the highlight color of the theme (or I guess I'll be able to 
> color it from the code right?)
> 
> Marco Martin wrote:
> the svg would be always "highlight color" whatever is the theme. 
> you would need other colors?
> i'll sooner or later add some api to manipulate the stylesheet from the 
> code, but that's not available yet
> 
> Martin Klapetek wrote:
> I considered having different colors by event type (holiday vs calendar 
> event), but I guess a single color will do for now.
> 
> Marco Martin wrote:
> done.
> widgets/calendar, loaded in a SvgItem
> the element id is "event" that is just a triangle like in the screenshots
> 
> David Edmundson wrote:
> FYI that's in mart/plasmasvgicons not master.
> (I don't know if that's intentional or not?)

aw, crap, sorry, was not intentional thanks for noticing :/
moved it to the right branch now


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127586/#review94325
---


On April 6, 2016, 3:53 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127586/
> ---
> 
> (Updated April 6, 2016, 3:53 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Simple triangle at the bottom right corner, see screenshot.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/daysmodel.h 8ab232e 
>   src/declarativeimports/calendar/daysmodel.cpp bf99874 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6353827 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml d4b8fe4 
> 
> Diff: https://git.reviewboard.kde.org/r/127586/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127586: [calendar] Add a mark to days containing events

[David Edmundson]

> On April 6, 2016, 7:03 a.m., Kai Uwe Broulik wrote:
> > You really don't want to create more Canvas elements than neccessary, they 
> > all have their own FBO.
> > 
> > Can't you make the grid canvas draw the triangles, too? Or make a simple 
> > item with a triangle shaped QSGGeometryNode?
> 
> Kai Uwe Broulik wrote:
> There's even exactly that on WikiBooks :D 
> https://en.wikibooks.org/wiki/Qt/Qt_Quick_Overview#Triangle_implementation
> 
> Martin Klapetek wrote:
> Ah, that's handy. Now I wonder though - it's under CC-BY-SA licence, can 
> I just copy that directly and put that licence in the header and ship this in 
> frameworks?
> 
> Martin Gräßlin wrote:
> I would say that is not copyrightable, it's too trivial.
> 
> Marco Martin wrote:
> I would prefer adding it to the svg theme.
> there used to be elements for the calendar in the theme, they could get 
> back
> 
> Martin Klapetek wrote:
> Oooh that would be nice. Who's in charge of the theme these days?
> 
> Marco Martin wrote:
> I can add the needed item, is just needed a single item as that triangle?
> 
> Martin Klapetek wrote:
> Yes. Make it the highlight color of the theme (or I guess I'll be able to 
> color it from the code right?)
> 
> Marco Martin wrote:
> the svg would be always "highlight color" whatever is the theme. 
> you would need other colors?
> i'll sooner or later add some api to manipulate the stylesheet from the 
> code, but that's not available yet
> 
> Martin Klapetek wrote:
> I considered having different colors by event type (holiday vs calendar 
> event), but I guess a single color will do for now.
> 
> Marco Martin wrote:
> done.
> widgets/calendar, loaded in a SvgItem
> the element id is "event" that is just a triangle like in the screenshots

FYI that's in mart/plasmasvgicons not master.
(I don't know if that's intentional or not?)


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127586/#review94325
---


On April 6, 2016, 3:53 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127586/
> ---
> 
> (Updated April 6, 2016, 3:53 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Simple triangle at the bottom right corner, see screenshot.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/daysmodel.h 8ab232e 
>   src/declarativeimports/calendar/daysmodel.cpp bf99874 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6353827 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml d4b8fe4 
> 
> Diff: https://git.reviewboard.kde.org/r/127586/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127586: [calendar] Add a mark to days containing events

[Marco Martin]

> On April 6, 2016, 7:03 a.m., Kai Uwe Broulik wrote:
> > You really don't want to create more Canvas elements than neccessary, they 
> > all have their own FBO.
> > 
> > Can't you make the grid canvas draw the triangles, too? Or make a simple 
> > item with a triangle shaped QSGGeometryNode?
> 
> Kai Uwe Broulik wrote:
> There's even exactly that on WikiBooks :D 
> https://en.wikibooks.org/wiki/Qt/Qt_Quick_Overview#Triangle_implementation
> 
> Martin Klapetek wrote:
> Ah, that's handy. Now I wonder though - it's under CC-BY-SA licence, can 
> I just copy that directly and put that licence in the header and ship this in 
> frameworks?
> 
> Martin Gräßlin wrote:
> I would say that is not copyrightable, it's too trivial.
> 
> Marco Martin wrote:
> I would prefer adding it to the svg theme.
> there used to be elements for the calendar in the theme, they could get 
> back
> 
> Martin Klapetek wrote:
> Oooh that would be nice. Who's in charge of the theme these days?
> 
> Marco Martin wrote:
> I can add the needed item, is just needed a single item as that triangle?
> 
> Martin Klapetek wrote:
> Yes. Make it the highlight color of the theme (or I guess I'll be able to 
> color it from the code right?)
> 
> Marco Martin wrote:
> the svg would be always "highlight color" whatever is the theme. 
> you would need other colors?
> i'll sooner or later add some api to manipulate the stylesheet from the 
> code, but that's not available yet
> 
> Martin Klapetek wrote:
> I considered having different colors by event type (holiday vs calendar 
> event), but I guess a single color will do for now.

done.
widgets/calendar, loaded in a SvgItem
the element id is "event" that is just a triangle like in the screenshots


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127586/#review94325
---


On April 6, 2016, 3:53 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127586/
> ---
> 
> (Updated April 6, 2016, 3:53 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Simple triangle at the bottom right corner, see screenshot.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/daysmodel.h 8ab232e 
>   src/declarativeimports/calendar/daysmodel.cpp bf99874 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6353827 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml d4b8fe4 
> 
> Diff: https://git.reviewboard.kde.org/r/127586/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127586: [calendar] Add a mark to days containing events

[Martin Klapetek]

> On April 6, 2016, 9:03 a.m., Kai Uwe Broulik wrote:
> > You really don't want to create more Canvas elements than neccessary, they 
> > all have their own FBO.
> > 
> > Can't you make the grid canvas draw the triangles, too? Or make a simple 
> > item with a triangle shaped QSGGeometryNode?
> 
> Kai Uwe Broulik wrote:
> There's even exactly that on WikiBooks :D 
> https://en.wikibooks.org/wiki/Qt/Qt_Quick_Overview#Triangle_implementation
> 
> Martin Klapetek wrote:
> Ah, that's handy. Now I wonder though - it's under CC-BY-SA licence, can 
> I just copy that directly and put that licence in the header and ship this in 
> frameworks?
> 
> Martin Gräßlin wrote:
> I would say that is not copyrightable, it's too trivial.
> 
> Marco Martin wrote:
> I would prefer adding it to the svg theme.
> there used to be elements for the calendar in the theme, they could get 
> back
> 
> Martin Klapetek wrote:
> Oooh that would be nice. Who's in charge of the theme these days?
> 
> Marco Martin wrote:
> I can add the needed item, is just needed a single item as that triangle?
> 
> Martin Klapetek wrote:
> Yes. Make it the highlight color of the theme (or I guess I'll be able to 
> color it from the code right?)
> 
> Marco Martin wrote:
> the svg would be always "highlight color" whatever is the theme. 
> you would need other colors?
> i'll sooner or later add some api to manipulate the stylesheet from the 
> code, but that's not available yet

I considered having different colors by event type (holiday vs calendar event), 
but I guess a single color will do for now.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127586/#review94325
---


On April 6, 2016, 5:53 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127586/
> ---
> 
> (Updated April 6, 2016, 5:53 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Simple triangle at the bottom right corner, see screenshot.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/daysmodel.h 8ab232e 
>   src/declarativeimports/calendar/daysmodel.cpp bf99874 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6353827 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml d4b8fe4 
> 
> Diff: https://git.reviewboard.kde.org/r/127586/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127586: [calendar] Add a mark to days containing events

[Marco Martin]

> On April 6, 2016, 7:03 a.m., Kai Uwe Broulik wrote:
> > You really don't want to create more Canvas elements than neccessary, they 
> > all have their own FBO.
> > 
> > Can't you make the grid canvas draw the triangles, too? Or make a simple 
> > item with a triangle shaped QSGGeometryNode?
> 
> Kai Uwe Broulik wrote:
> There's even exactly that on WikiBooks :D 
> https://en.wikibooks.org/wiki/Qt/Qt_Quick_Overview#Triangle_implementation
> 
> Martin Klapetek wrote:
> Ah, that's handy. Now I wonder though - it's under CC-BY-SA licence, can 
> I just copy that directly and put that licence in the header and ship this in 
> frameworks?
> 
> Martin Gräßlin wrote:
> I would say that is not copyrightable, it's too trivial.
> 
> Marco Martin wrote:
> I would prefer adding it to the svg theme.
> there used to be elements for the calendar in the theme, they could get 
> back
> 
> Martin Klapetek wrote:
> Oooh that would be nice. Who's in charge of the theme these days?
> 
> Marco Martin wrote:
> I can add the needed item, is just needed a single item as that triangle?
> 
> Martin Klapetek wrote:
> Yes. Make it the highlight color of the theme (or I guess I'll be able to 
> color it from the code right?)

the svg would be always "highlight color" whatever is the theme. 
you would need other colors?
i'll sooner or later add some api to manipulate the stylesheet from the code, 
but that's not available yet


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127586/#review94325
---


On April 6, 2016, 3:53 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127586/
> ---
> 
> (Updated April 6, 2016, 3:53 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Simple triangle at the bottom right corner, see screenshot.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/daysmodel.h 8ab232e 
>   src/declarativeimports/calendar/daysmodel.cpp bf99874 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6353827 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml d4b8fe4 
> 
> Diff: https://git.reviewboard.kde.org/r/127586/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127586: [calendar] Add a mark to days containing events

[Martin Klapetek]

> On April 6, 2016, 9:03 a.m., Kai Uwe Broulik wrote:
> > You really don't want to create more Canvas elements than neccessary, they 
> > all have their own FBO.
> > 
> > Can't you make the grid canvas draw the triangles, too? Or make a simple 
> > item with a triangle shaped QSGGeometryNode?
> 
> Kai Uwe Broulik wrote:
> There's even exactly that on WikiBooks :D 
> https://en.wikibooks.org/wiki/Qt/Qt_Quick_Overview#Triangle_implementation
> 
> Martin Klapetek wrote:
> Ah, that's handy. Now I wonder though - it's under CC-BY-SA licence, can 
> I just copy that directly and put that licence in the header and ship this in 
> frameworks?
> 
> Martin Gräßlin wrote:
> I would say that is not copyrightable, it's too trivial.
> 
> Marco Martin wrote:
> I would prefer adding it to the svg theme.
> there used to be elements for the calendar in the theme, they could get 
> back
> 
> Martin Klapetek wrote:
> Oooh that would be nice. Who's in charge of the theme these days?
> 
> Marco Martin wrote:
> I can add the needed item, is just needed a single item as that triangle?

Yes. Make it the highlight color of the theme (or I guess I'll be able to color 
it from the code right?)


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127586/#review94325
---


On April 6, 2016, 5:53 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127586/
> ---
> 
> (Updated April 6, 2016, 5:53 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Simple triangle at the bottom right corner, see screenshot.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/daysmodel.h 8ab232e 
>   src/declarativeimports/calendar/daysmodel.cpp bf99874 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6353827 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml d4b8fe4 
> 
> Diff: https://git.reviewboard.kde.org/r/127586/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127586: [calendar] Add a mark to days containing events

[Marco Martin]

> On April 6, 2016, 7:03 a.m., Kai Uwe Broulik wrote:
> > You really don't want to create more Canvas elements than neccessary, they 
> > all have their own FBO.
> > 
> > Can't you make the grid canvas draw the triangles, too? Or make a simple 
> > item with a triangle shaped QSGGeometryNode?
> 
> Kai Uwe Broulik wrote:
> There's even exactly that on WikiBooks :D 
> https://en.wikibooks.org/wiki/Qt/Qt_Quick_Overview#Triangle_implementation
> 
> Martin Klapetek wrote:
> Ah, that's handy. Now I wonder though - it's under CC-BY-SA licence, can 
> I just copy that directly and put that licence in the header and ship this in 
> frameworks?
> 
> Martin Gräßlin wrote:
> I would say that is not copyrightable, it's too trivial.
> 
> Marco Martin wrote:
> I would prefer adding it to the svg theme.
> there used to be elements for the calendar in the theme, they could get 
> back
> 
> Martin Klapetek wrote:
> Oooh that would be nice. Who's in charge of the theme these days?

I can add the needed item, is just needed a single item as that triangle?


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127586/#review94325
---


On April 6, 2016, 3:53 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127586/
> ---
> 
> (Updated April 6, 2016, 3:53 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Simple triangle at the bottom right corner, see screenshot.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/daysmodel.h 8ab232e 
>   src/declarativeimports/calendar/daysmodel.cpp bf99874 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6353827 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml d4b8fe4 
> 
> Diff: https://git.reviewboard.kde.org/r/127586/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127586: [calendar] Add a mark to days containing events

[Martin Klapetek]

> On April 6, 2016, 9:03 a.m., Kai Uwe Broulik wrote:
> > You really don't want to create more Canvas elements than neccessary, they 
> > all have their own FBO.
> > 
> > Can't you make the grid canvas draw the triangles, too? Or make a simple 
> > item with a triangle shaped QSGGeometryNode?
> 
> Kai Uwe Broulik wrote:
> There's even exactly that on WikiBooks :D 
> https://en.wikibooks.org/wiki/Qt/Qt_Quick_Overview#Triangle_implementation
> 
> Martin Klapetek wrote:
> Ah, that's handy. Now I wonder though - it's under CC-BY-SA licence, can 
> I just copy that directly and put that licence in the header and ship this in 
> frameworks?
> 
> Martin Gräßlin wrote:
> I would say that is not copyrightable, it's too trivial.
> 
> Marco Martin wrote:
> I would prefer adding it to the svg theme.
> there used to be elements for the calendar in the theme, they could get 
> back

Oooh that would be nice. Who's in charge of the theme these days?


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127586/#review94325
---


On April 6, 2016, 5:53 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127586/
> ---
> 
> (Updated April 6, 2016, 5:53 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Simple triangle at the bottom right corner, see screenshot.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/daysmodel.h 8ab232e 
>   src/declarativeimports/calendar/daysmodel.cpp bf99874 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6353827 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml d4b8fe4 
> 
> Diff: https://git.reviewboard.kde.org/r/127586/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127586: [calendar] Add a mark to days containing events

[Marco Martin]

> On April 6, 2016, 7:03 a.m., Kai Uwe Broulik wrote:
> > You really don't want to create more Canvas elements than neccessary, they 
> > all have their own FBO.
> > 
> > Can't you make the grid canvas draw the triangles, too? Or make a simple 
> > item with a triangle shaped QSGGeometryNode?
> 
> Kai Uwe Broulik wrote:
> There's even exactly that on WikiBooks :D 
> https://en.wikibooks.org/wiki/Qt/Qt_Quick_Overview#Triangle_implementation
> 
> Martin Klapetek wrote:
> Ah, that's handy. Now I wonder though - it's under CC-BY-SA licence, can 
> I just copy that directly and put that licence in the header and ship this in 
> frameworks?
> 
> Martin Gräßlin wrote:
> I would say that is not copyrightable, it's too trivial.

I would prefer adding it to the svg theme.
there used to be elements for the calendar in the theme, they could get back


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127586/#review94325
---


On April 6, 2016, 3:53 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127586/
> ---
> 
> (Updated April 6, 2016, 3:53 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Simple triangle at the bottom right corner, see screenshot.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/daysmodel.h 8ab232e 
>   src/declarativeimports/calendar/daysmodel.cpp bf99874 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6353827 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml d4b8fe4 
> 
> Diff: https://git.reviewboard.kde.org/r/127586/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127586: [calendar] Add a mark to days containing events

[Martin Gräßlin]

> On April 6, 2016, 9:03 a.m., Kai Uwe Broulik wrote:
> > You really don't want to create more Canvas elements than neccessary, they 
> > all have their own FBO.
> > 
> > Can't you make the grid canvas draw the triangles, too? Or make a simple 
> > item with a triangle shaped QSGGeometryNode?
> 
> Kai Uwe Broulik wrote:
> There's even exactly that on WikiBooks :D 
> https://en.wikibooks.org/wiki/Qt/Qt_Quick_Overview#Triangle_implementation
> 
> Martin Klapetek wrote:
> Ah, that's handy. Now I wonder though - it's under CC-BY-SA licence, can 
> I just copy that directly and put that licence in the header and ship this in 
> frameworks?

I would say that is not copyrightable, it's too trivial.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127586/#review94325
---


On April 6, 2016, 5:53 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127586/
> ---
> 
> (Updated April 6, 2016, 5:53 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Simple triangle at the bottom right corner, see screenshot.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/daysmodel.h 8ab232e 
>   src/declarativeimports/calendar/daysmodel.cpp bf99874 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6353827 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml d4b8fe4 
> 
> Diff: https://git.reviewboard.kde.org/r/127586/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127586: [calendar] Add a mark to days containing events

[Martin Klapetek]

> On April 6, 2016, 9:03 a.m., Kai Uwe Broulik wrote:
> > You really don't want to create more Canvas elements than neccessary, they 
> > all have their own FBO.
> > 
> > Can't you make the grid canvas draw the triangles, too? Or make a simple 
> > item with a triangle shaped QSGGeometryNode?
> 
> Kai Uwe Broulik wrote:
> There's even exactly that on WikiBooks :D 
> https://en.wikibooks.org/wiki/Qt/Qt_Quick_Overview#Triangle_implementation

Ah, that's handy. Now I wonder though - it's under CC-BY-SA licence, can I just 
copy that directly and put that licence in the header and ship this in 
frameworks?


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127586/#review94325
---


On April 6, 2016, 5:53 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127586/
> ---
> 
> (Updated April 6, 2016, 5:53 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Simple triangle at the bottom right corner, see screenshot.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/daysmodel.h 8ab232e 
>   src/declarativeimports/calendar/daysmodel.cpp bf99874 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6353827 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml d4b8fe4 
> 
> Diff: https://git.reviewboard.kde.org/r/127586/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127586: [calendar] Add a mark to days containing events

[Kai Uwe Broulik]

> On April 6, 2016, 7:03 vorm., Kai Uwe Broulik wrote:
> > You really don't want to create more Canvas elements than neccessary, they 
> > all have their own FBO.
> > 
> > Can't you make the grid canvas draw the triangles, too? Or make a simple 
> > item with a triangle shaped QSGGeometryNode?

There's even exactly that on WikiBooks :D 
https://en.wikibooks.org/wiki/Qt/Qt_Quick_Overview#Triangle_implementation


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127586/#review94325
---


On April 6, 2016, 3:53 vorm., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127586/
> ---
> 
> (Updated April 6, 2016, 3:53 vorm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Simple triangle at the bottom right corner, see screenshot.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/daysmodel.h 8ab232e 
>   src/declarativeimports/calendar/daysmodel.cpp bf99874 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6353827 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml d4b8fe4 
> 
> Diff: https://git.reviewboard.kde.org/r/127586/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127586: [calendar] Add a mark to days containing events

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127586/#review94326
---



a canvas element for a triangle seems a little bit too much from OpenGL point 
of rendering. Rendering a triangle is the basic function of OpenGL, it't the 
one primitive all other are build up with ;-)

- Martin Gräßlin


On April 6, 2016, 5:53 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127586/
> ---
> 
> (Updated April 6, 2016, 5:53 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Simple triangle at the bottom right corner, see screenshot.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/daysmodel.h 8ab232e 
>   src/declarativeimports/calendar/daysmodel.cpp bf99874 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6353827 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml d4b8fe4 
> 
> Diff: https://git.reviewboard.kde.org/r/127586/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127586: [calendar] Add a mark to days containing events

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127586/#review94325
---



You really don't want to create more Canvas elements than neccessary, they all 
have their own FBO.

Can't you make the grid canvas draw the triangles, too? Or make a simple item 
with a triangle shaped QSGGeometryNode?

- Kai Uwe Broulik


On April 6, 2016, 3:53 vorm., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127586/
> ---
> 
> (Updated April 6, 2016, 3:53 vorm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Simple triangle at the bottom right corner, see screenshot.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/daysmodel.h 8ab232e 
>   src/declarativeimports/calendar/daysmodel.cpp bf99874 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 6353827 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml d4b8fe4 
> 
> Diff: https://git.reviewboard.kde.org/r/127586/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel