Re: another Kirigami issue - overlap of header and listview
On Wed, Apr 20, 2016 at 07:32:04PM +0200, Marco Martin wrote: > On Wednesday 20 April 2016 09:44:43 Dirk Hohndel wrote: > > On Wed, Apr 20, 2016 at 10:36:05AM +0200, Marco Martin wrote: > > > On Tuesday 19 April 2016, Dirk Hohndel wrote: > > > > go). The latter always appears to have the top item aligned with the > > > > header, but when I tap on the header and have scrollTopAnimation run to: > > > > 0, then the header overlaps the top element in the ListView. > > > > > > > > A patch like this seems to fix the problem > > > > > > thanks, i pushed it plus some fixes on top of it (using topPadding instead > > > of the height) > > > > Did you have a chance to look at making the "badge" for the two and three > > button case a little wider? If you're too busy, I'll be happy to try my > > hands on that bit of QML :-) > > in latest master should be a bit larger, if needed more can be further > tweaked > or if needed made different with 3 circles I think this looks good. Will have to look at it across a number of different devices tonight, but I think this strikes a nice balance in size and position. /D ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: another Kirigami issue - overlap of header and listview
On Wednesday 20 April 2016 09:44:43 Dirk Hohndel wrote: > On Wed, Apr 20, 2016 at 10:36:05AM +0200, Marco Martin wrote: > > On Tuesday 19 April 2016, Dirk Hohndel wrote: > > > go). The latter always appears to have the top item aligned with the > > > header, but when I tap on the header and have scrollTopAnimation run to: > > > 0, then the header overlaps the top element in the ListView. > > > > > > A patch like this seems to fix the problem > > > > thanks, i pushed it plus some fixes on top of it (using topPadding instead > > of the height) > > Did you have a chance to look at making the "badge" for the two and three > button case a little wider? If you're too busy, I'll be happy to try my > hands on that bit of QML :-) in latest master should be a bit larger, if needed more can be further tweaked or if needed made different with 3 circles -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: another Kirigami issue - overlap of header and listview
On Wed, Apr 20, 2016 at 10:36:05AM +0200, Marco Martin wrote: > On Tuesday 19 April 2016, Dirk Hohndel wrote: > > go). The latter always appears to have the top item aligned with the > > header, but when I tap on the header and have scrollTopAnimation run to: > > 0, then the header overlaps the top element in the ListView. > > > > A patch like this seems to fix the problem > > thanks, i pushed it plus some fixes on top of it (using topPadding instead of > the height) Did you have a chance to look at making the "badge" for the two and three button case a little wider? If you're too busy, I'll be happy to try my hands on that bit of QML :-) /D ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: another Kirigami issue - overlap of header and listview
On Tuesday 19 April 2016, Dirk Hohndel wrote: > go). The latter always appears to have the top item aligned with the > header, but when I tap on the header and have scrollTopAnimation run to: > 0, then the header overlaps the top element in the ListView. > > A patch like this seems to fix the problem thanks, i pushed it plus some fixes on top of it (using topPadding instead of the height) -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: another Kirigami issue - overlap of header and listview
> On Apr 19, 2016, at 2:34 PM, Kai Uwe Broulik wrote: > > I don't know the code by heart but doesn't the ScrollView set a top margin? > If so, contentY should be set to it rather than assuming it's based on the > header height. I searched for just that margin and couldn't find it. I don't think my patch is the right fix, but it seems to be a fix. /D ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: another Kirigami issue - overlap of header and listview
I don't know the code by heart but doesn't the ScrollView set a top margin? If so, contentY should be set to it rather than assuming it's based on the header height. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
