Re: kde-workspace 4.10.90 ABI breakage in libtaskmanager
El Dilluns, 22 de juliol de 2013, a les 13:03:23, Sebastian Kügler va escriure: > On Sunday, July 21, 2013 17:20:13 Aaron J. Seigo wrote: > > On Sunday, July 21, 2013 15:50:52 Sebastian Kügler wrote: > > > We have a release blocker here. If nobody steps up to look into this, > > > I'll > > > use git log / git blame and a long pointy stick. > > > > What we have is a change in policy. To recap: > > > > * the libraries in kde-workspace have no ABI or API commitments. none. > > * the libraries in kde-workspace have changed ABI and API multiple times > > in > > the past, and this has not always (ever?) been accompanied by changes of > > the .so version > > * modules outside of kde-workspace should NOT be using these libraries, > > but > > though several do, in particular libkworkspace [1] > > > > there are a number of things that could be done to improve this situation: > > > > * not installing headers; unfortunately there are users of these libraries > > and they will likely complain if we stop installing headers. still, this > > may be wise to do > > * bumping .so versions on every single API/ABI incompatible release (which > > has been numerous in the 4.x series); given the lack of ABI/API > > committment, this seems a little academic in nature > > > > personally i’d vote for not installing headers and let builds break. > > > > i’m fine with bumping the .so number of the library as well, though i > > don’t > > consider that a compelling solution to the real problem of using libraries > > outside of kde-workspace that are specifically not intended to be used > > outside of kde-workspace. > > > > [1] there is one weak exception to this: kdeplasma-addons which is for all > > intents and purposes a kde-workspaces sub-module > > I suppose we had installed the header already in previous releases? In that > case, it's probably wiser (given that we're at RC stage) to just bump the > .so version and revisit this situation for Plasma2? Agreed, let's either: a) Fix it by bumping the soname b) Ignore it Don't break other people's code at RC2 stage. Cheers, Albert ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: kde-workspace 4.10.90 ABI breakage in libtaskmanager
On Monday 22 July 2013, Sebastian Kügler wrote: > > i’m fine with bumping the .so number of the library as well, though i > > don’t consider that a compelling solution to the real problem of using > > libraries outside of kde-workspace that are specifically not intended to > > be used outside of kde-workspace. > > > > [1] there is one weak exception to this: kdeplasma-addons which is for > > all intents and purposes a kde-workspaces sub-module > > I suppose we had installed the header already in previous releases? In that > case, it's probably wiser (given that we're at RC stage) to just bump the > .so version and revisit this situation for Plasma2? it probably have to be be just a qml import (c++-usable library could even not be exported anymore), that will raise the future question, do we guarantee source compatibility for all qml imports, or under what circumstances? at least will be easier since only source compatibility is needed (and javascript is so type unsafe that can swallow pretty significant changes in signature...) -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: kde-workspace 4.10.90 ABI breakage in libtaskmanager
On Sunday, July 21, 2013 17:20:13 Aaron J. Seigo wrote: > On Sunday, July 21, 2013 15:50:52 Sebastian Kügler wrote: > > We have a release blocker here. If nobody steps up to look into this, I'll > > use git log / git blame and a long pointy stick. > > What we have is a change in policy. To recap: > > * the libraries in kde-workspace have no ABI or API commitments. none. > * the libraries in kde-workspace have changed ABI and API multiple times in > the past, and this has not always (ever?) been accompanied by changes of > the .so version > * modules outside of kde-workspace should NOT be using these libraries, but > though several do, in particular libkworkspace [1] > > there are a number of things that could be done to improve this situation: > > * not installing headers; unfortunately there are users of these libraries > and they will likely complain if we stop installing headers. still, this > may be wise to do > * bumping .so versions on every single API/ABI incompatible release (which > has been numerous in the 4.x series); given the lack of ABI/API > committment, this seems a little academic in nature > > personally i’d vote for not installing headers and let builds break. > > i’m fine with bumping the .so number of the library as well, though i don’t > consider that a compelling solution to the real problem of using libraries > outside of kde-workspace that are specifically not intended to be used > outside of kde-workspace. > > [1] there is one weak exception to this: kdeplasma-addons which is for all > intents and purposes a kde-workspaces sub-module I suppose we had installed the header already in previous releases? In that case, it's probably wiser (given that we're at RC stage) to just bump the .so version and revisit this situation for Plasma2? -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: kde-workspace 4.10.90 ABI breakage in libtaskmanager
On Sunday, July 21, 2013 15:50:52 Sebastian Kügler wrote: > We have a release blocker here. If nobody steps up to look into this, I'll > use git log / git blame and a long pointy stick. :-) What we have is a change in policy. To recap: * the libraries in kde-workspace have no ABI or API commitments. none. * the libraries in kde-workspace have changed ABI and API multiple times in the past, and this has not always (ever?) been accompanied by changes of the .so version * modules outside of kde-workspace should NOT be using these libraries, but though several do, in particular libkworkspace [1] there are a number of things that could be done to improve this situation: * not installing headers; unfortunately there are users of these libraries and they will likely complain if we stop installing headers. still, this may be wise to do * bumping .so versions on every single API/ABI incompatible release (which has been numerous in the 4.x series); given the lack of ABI/API committment, this seems a little academic in nature personally i’d vote for not installing headers and let builds break. i’m fine with bumping the .so number of the library as well, though i don’t consider that a compelling solution to the real problem of using libraries outside of kde-workspace that are specifically not intended to be used outside of kde-workspace. [1] there is one weak exception to this: kdeplasma-addons which is for all intents and purposes a kde-workspaces sub-module -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: kde-workspace 4.10.90 ABI breakage in libtaskmanager
On Sunday 21 July 2013 16:10:02 Marco Martin wrote: > yes, would be good that it retains compatibility, so if it can be quickly > adapted it should (if)... > however, we never promised any abi compatibility in kde-workspace libraries > (headers are not even installed) Interestingly the two ABI changes were actually not caused by the merge of the rewrite, but by unrelated changes after ... the good news is that it means the rewrite doesn't need them, but the question of whether the changes or the ABI are more important remains. Also means I can't really answer it since I didn't make them ... Cheers, Eike ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: kde-workspace 4.10.90 ABI breakage in libtaskmanager
On Sunday 21 July 2013, Sebastian Kügler wrote: > Hey Plasmoids, > > We have a release blocker here. If nobody steps up to look into this, I'll > use git log / git blame and a long pointy stick. :-) yes, would be good that it retains compatibility, so if it can be quickly adapted it should (if)... however, we never promised any abi compatibility in kde-workspace libraries (headers are not even installed) -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: kde-workspace 4.10.90 ABI breakage in libtaskmanager
Hey Plasmoids, We have a release blocker here. If nobody steps up to look into this, I'll use git log / git blame and a long pointy stick. :-) On Thursday, June 27, 2013 19:44:07 Albert Astals Cid wrote: > El Dijous, 27 de juny de 2013, a les 15:52:13, Philip Muskovac va escriure: > > Hi, > > > > b7e30e489f21e09f31e04dab6e8f130764e63671 from Aaron > > > > #MISSING: 4:4.10.90# > > > > _ZN11TaskManager4Task12addTransientEmRK10NETWinInfo@ABI_4_3 4:4.8.3 -> > > TaskManager::Task::addTransient(unsigned long, NETWinInfo const&) > > > > > > and 42c8fde45cfde9cb594d7468c5a91b372cca3664 from Gregor Tätzner > > > > #MISSING: 4:4.10.90# > > > > _ZN11TaskManager9BasicMenuC1EP7QWidgetPNS_8TaskItemEPNS_12GroupManagerE5QL > > i > > stIP7QActionESA_@ABI_4_3 4:4.8.3 -> > > TaskManager::BasicMenu::BasicMenu(QWidget*, TaskManager::TaskItem*, > > TaskManager::GroupManager*, QList, QList) > > > > #MISSING: 4:4.10.90# > > > > _ZN11TaskManager9BasicMenuC1EP7QWidgetPNS_9TaskGroupEPNS_12GroupManagerE5Q > > L > > istIP7QActionESA_@ABI_4_3 4:4.8.3 -> > > TaskManager::BasicMenu::BasicMenu(QWidget*, TaskManager::TaskGroup*, > > TaskManager::GroupManager*, QList, QList) > > > > break the ABI of libtaskmanager.so.4 in 4.10.90. > > > > Could we please get those back as KDE_DEPRECATED or instead get the > > SOVERSION bumped? Thanks! > > Since this a ABI break in a private library outside kdelibs and kdepimlibs > i'm going ahead with the beta2 release. Whatever needs to be fixed can be > done for RC1. > > Cheers, > Albert -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
