Re: kde-workspace and plasma2
Hey, On Thursday, May 16, 2013 11:37:18 Marco Martin wrote: how we want to end up shipping PW2-based images (either ourselves or our downstreams) is going to influence these re-arrangements. and so i go back to asking: what is making re-arranging the source tree so important right now? plasma/sebas/desktop-qml-plasma2 has not be re-arranged, so we'll continue there for now We had this discussion already, I've for this reason created the frameworks- scratch branch in kde-workspace and kdeplasma-addons. See my email from 1st May, Plasma2 porting framework-scratch branches about that. The plasma/sebas/desktop-qml-plasma2 branch is in there (in its current state, merged that one last night), and master is also fully merged. The frameworks-scratch branch is only ported code and minimal cmake foo at this point, no repository rearrangements. I'm working on cleaning up the cmake files there right now. For Plasma2 hacking, that branch should be used. Cheers, -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: kde-workspace and plasma2
On Wednesday, May 15, 2013 18:36:27 Marco Martin wrote: On Tuesday 14 May 2013, Aaron J. Seigo wrote: Even porting a few of the plasmoids wouldn't be the worst of ideas. (I expect the icon one to be interesting ...) Not everything needs to be ported right now, however, especially not components that get frequent activity. And what I really don't want to see is the whole repository turned upside down right now. Let's keep sebas' branch focused on a minimal set of ported components to test the new shell with. ok, so now that branch does build and the plasma subdirectory can build by itself having now a complete cmake why another branch (plasma2/imageWallpaper)? how does it relate to plasma/sebas/desktop-qml-plasma2? the directory structure is as untouched as possible that's obviously not quite accurate. you re-arranged the plasma directory structure when it could just as easily have been limited to CMakeLists.txt changes. that the branch is named plasma2/imageWallpaper really doesn't help, as it does not imply at all that such changes are contained in it. in any case, open questions remain such as do we want to be able to have form-factor focused builds, such as being able to easily build the plasma plugins/components in kde-workspace just for touch and skipping any obviously desktop plugins? how we want to end up shipping PW2-based images (either ourselves or our downstreams) is going to influence these re-arrangements. and so i go back to asking: what is making re-arranging the source tree so important right now? -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: kde-workspace and plasma2
On Thu, May 16, 2013 at 10:35 AM, Aaron J. Seigo ase...@kde.org wrote: On Wednesday, May 15, 2013 18:36:27 Marco Martin wrote: On Tuesday 14 May 2013, Aaron J. Seigo wrote: Even porting a few of the plasmoids wouldn't be the worst of ideas. (I expect the icon one to be interesting ...) Not everything needs to be ported right now, however, especially not components that get frequent activity. And what I really don't want to see is the whole repository turned upside down right now. Let's keep sebas' branch focused on a minimal set of ported components to test the new shell with. ok, so now that branch does build and the plasma subdirectory can build by itself having now a complete cmake why another branch (plasma2/imageWallpaper)? how does it relate to plasma/sebas/desktop-qml-plasma2? I started the wallpaper porting there, but that branch had the filesystem reworked, so now i moved all the work in plasma/sebas/desktop-qml-plasma2, and i'm going to delete plasma2/imageWallpaper) the directory structure is as untouched as possible that's obviously not quite accurate. you re-arranged the plasma directory structure when it could just as easily have been limited to CMakeLists.txt changes. that the branch is named plasma2/imageWallpaper really doesn't help, as it does not imply at all that such changes are contained in it yeah, ignore that branch :) how we want to end up shipping PW2-based images (either ourselves or our downstreams) is going to influence these re-arrangements. and so i go back to asking: what is making re-arranging the source tree so important right now? plasma/sebas/desktop-qml-plasma2 has not be re-arranged, so we'll continue there for now Cheers, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: kde-workspace and plasma2
On Tuesday 14 May 2013, Aaron J. Seigo wrote: Even porting a few of the plasmoids wouldn't be the worst of ideas. (I expect the icon one to be interesting ...) Not everything needs to be ported right now, however, especially not components that get frequent activity. And what I really don't want to see is the whole repository turned upside down right now. Let's keep sebas' branch focused on a minimal set of ported components to test the new shell with. ok, so now that branch does build and the plasma subdirectory can build by itself having now a complete cmake the directory structure is as untouched as possible as everything outside the plasma subdirectory is untouched -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: kde-workspace and plasma2
On Monday, May 13, 2013 15:10:41 Marco Martin wrote: * a kded that says what formfactor we are running on in the end the plasma part of kde-workspace should look like http://community.kde.org/Plasma/KdeWorkspaceRepoStructure (at least so was discussed in nuremberg) this is currently in the plasma-framework repository in the kded_platformstatus branch. it is part of the runtime (applications will also want it), and as such i put it there. i'll merge it into master as nobody seems to notice it in the branch which means i'm the only one who has tried it at all :) I would propose to make the branch plasma/sebas/desktop-qml-plasma2 that is now hosting the desktop containment and the toolboxes to host the if you saw that branch in the repo, would you ever guess that this is the general PW2 porting branch? i doubt it :) i'm very much *against* branching kde-workspace for PW2 before 4.11 is out. for one thing, it means having to forward-port all commits made in kde- workspace between now and 4.11 (which won't happen, knowing how people are). you want to have the image wallpaper ported, and you can do it in sebas' branch (or make another branch, but i don't see any purpose to that) as for changing the source tree layout in kde-workspace ... i don't understand why you and sebas keep pushing for us to do that as if that is the next important thing on our roadmap. then the other parts (like kwin, ksysguard etc) can work on ports in their own branches (or own repo, their choice) and merge when is ready (or stay on different repo) so do whatever you want. this runs a high chance of a mess with some things in a repo, some things not, something in branch A and others in branch B. remember that many of these components share libraries. not all have active maintainers. (*sigh*) we haven't decided yet on the final repository split strategy (each app in its own repo? the plasma components? where do the libraries go?) please do not try and rush this. let's do it right, and do a little planning. there is no this has to be done yesterday rush. i don't want to put up with people yelling at us (or: me) because we do a slap-dash job of migrating kde- workspace to frameworks. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: kde-workspace and plasma2
On Tuesday 14 May 2013 15:28:27 Aaron J. Seigo wrote: On Monday, May 13, 2013 15:10:41 Marco Martin wrote: * a kded that says what formfactor we are running on in the end the plasma part of kde-workspace should look like http://community.kde.org/Plasma/KdeWorkspaceRepoStructure (at least so was discussed in nuremberg) this is currently in the plasma-framework repository in the kded_platformstatus branch. it is part of the runtime (applications will also want it), and as such i put it there. i'll merge it into master as nobody seems to notice it in the branch which means i'm the only one who has tried it at all :) no, i didn't (i assumed it was in workspace, sorry) I would propose to make the branch plasma/sebas/desktop-qml-plasma2 that is now hosting the desktop containment and the toolboxes to host the if you saw that branch in the repo, would you ever guess that this is the general PW2 porting branch? i doubt it :) i'm very much *against* branching kde-workspace for PW2 before 4.11 is out. for one thing, it means having to forward-port all commits made in kde- workspace between now and 4.11 (which won't happen, knowing how people are). you want to have the image wallpaper ported, and you can do it in sebas' branch (or make another branch, but i don't see any purpose to that) ok, i'll put it there as for changing the source tree layout in kde-workspace ... i don't understand why you and sebas keep pushing for us to do that as if that is the next important thing on our roadmap. ok, yes, i can see why it probably does not make sense to di it now, since it may cause problems later indeed. now, short explanation of the reason for this hurry we had. the library/shell and scriptengine parts are growing to have the features needed to have a complete shell. but for me is a bit different to do it blindly, i find a bit difficult to work on a framework without making at the same time something that is using that framework, that's probably a methodology bug (of which i can easily see some quality issues coming out of). Ie to see if on the lower level we have everything we need to have a complete containment, or a complete toolbox, or a wallpaper with a c++ part (we still need everything of the image wallpaper that is not painting that does things like the models, the randomization of the slideshow and such, and yeah, i pretty much finished the porting to a qml import) so i wanted to have some real code to see what we still need on the shell side. For git history purposes seemed to make more sense to do this stuff in kde- workspace, but then of course causes the problems you outlined. As to how to proceed, i can see various ways, like a small repo that would then merged back in kde-worspace, or: Pausing the work on real components like the containment and the image wallpapers and using instead only components in plasma-framework that are dummy and intended to stay dummy. This way ensures most of the work atually goes in the framework, even tough risks to make the dummy components quite big, almost as real... but in general plugins such as applets, containments and wallpapers should stay pretty much at the level of visual testcase please do not try and rush this. let's do it right, and do a little planning. there is no this has to be done yesterday rush. i don't want to put up with people yelling at us (or: me) because we do a slap-dash job of migrating kde- workspace to frameworks. ok, so now i'll move the work on the toolbox and the image wallpaper i did in sebas/desktop-qml-plasma2 branch and then it'll stay there frozen until will be time to restart work on kde-workspace porting. Cheers, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: kde-workspace and plasma2
On Tuesday, May 14, 2013 16:58:10 Marco Martin wrote: the library/shell and scriptengine parts are growing to have the features needed to have a complete shell. but for me is a bit different to do it blindly, i find a bit difficult to work on a framework without making at the same time something that is using that framework, that's probably a methodology bug (of which i can easily see some quality issues coming out You're right that until kde-workspace is fully ported we won't know for certain if anything is missing from plasma-frameworks. However, given that we're not starting from complete zero, we know that it has at least most of what we need, if not everything. It is fine imho to port a few things in kde-workspace to test the new shell. That was the point of sebas' branch as far as I understood it. So porting the two wallpapers in there is not a bad idea. This should be easily mergable later on as those components really don't get much work anymore as they are pretty much done. Even porting a few of the plasmoids wouldn't be the worst of ideas. (I expect the icon one to be interesting ...) Not everything needs to be ported right now, however, especially not components that get frequent activity. And what I really don't want to see is the whole repository turned upside down right now. Let's keep sebas' branch focused on a minimal set of ported components to test the new shell with. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: kde-workspace and plasma2
On Tuesday 14 May 2013 20:25:58 Aaron J. Seigo wrote: Even porting a few of the plasmoids wouldn't be the worst of ideas. (I expect the icon one to be interesting ...) Not everything needs to be ported right now, however, especially not components that get frequent activity. ok, so i'll keep all in the plasma/sebas/desktop-qml-plasma2 branch (and make it build) And what I really don't want to see is the whole repository turned upside down right now. Let's keep sebas' branch focused on a minimal set of ported components to test the new shell with. yep, +100 -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
