Re: removing dependencies from kactivitymanagerd
On Tuesday, October 4, 2011 18:29:33 Ivan Cukic wrote: General question - do you want to create a fw5 branch or something like that? Aaron KUniqueApplication: this lives in kdeui ... just to provide a way to have only one instance of the app. ugh. in Frameworks there is libkdbus which has a KDBusService which provides the same capabilities. porting to that proved quite simple and straightforward and let ActivityManager become a QCoreApplication subclass. Do we even need KDBusService? Just a check of QDBusConnectionInterface::isServiceRegistered can be used for this. yes, we could use that .. it's what KDBusService essentially does. however, that tends to, ime, lead to unnecessarily fragile code as classes like KDBusService usually end up accumulating odd bug fixes and work-arounds for edge cases. it's one line of code to use KDBusService, and more than that to use isServiceRegistered directly. the downside of KDBusService is under Frameworks we'll pull in one more library .. though a very small one with no deps. i really recommend KDBusService. Well for Wayland we need to change KWindowSystem anyway and I don't want to low level protocols. So who wants to Is that going to be kwin-only, or we have a hope it will be picked up by others? i'd prefer something not over dbus tied to one window manager if at all possible. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: removing dependencies from kactivitymanagerd
i really recommend KDBusService. Ok, so that means this will be a brang of kamd for kf5? ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: removing dependencies from kactivitymanagerd
On Tuesday 04 October 2011 16:33:03 Aaron J. Seigo wrote: hi all... i experimented a bit this morning with cutting the fat from kactivitymanagerd. in particular i focussed on the following. KUniqueApplication: this lives in kdeui ... just to provide a way to have only one instance of the app. ugh. in Frameworks there is libkdbus which has a KDBusService which provides the same capabilities. porting to that proved quite simple and straightforward and let ActivityManager become a QCoreApplication subclass. KWindowSystem: this one is more difficult. it is used only to track the comings and goings of windows. no other features are used. and it ends up causing a QWidget to be created, which KWindowSystem uses to filter x11 events. i don't have a great solution for this one .. but it would be very nice to have something that doesn't pull in such a heavy set of dependencies just to watch window states. i don't know if this would be general-purpose enough to end up in Frameworks (my gut says no) but writing a simple class that can have a window-system-specific implementation that alerts when the window focus changes and windows are closed would make a lot of sense for kactivitymanagerd. so, i have a patch for the former, but nothing for the latter. any takers? :) Well for Wayland we need to change KWindowSystem anyway and I don't want to low level protocols. So who wants to design a D-Bus interface for broadcasting such methods and add a nice wrapper around it? Adding support for it in KWin should be simple. What do you think? Cheers Martin signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: removing dependencies from kactivitymanagerd
General question - do you want to create a fw5 branch or something like that? Aaron KUniqueApplication: this lives in kdeui ... just to provide a way to have only one instance of the app. ugh. in Frameworks there is libkdbus which has a KDBusService which provides the same capabilities. porting to that proved quite simple and straightforward and let ActivityManager become a QCoreApplication subclass. Do we even need KDBusService? Just a check of QDBusConnectionInterface::isServiceRegistered can be used for this. Martin Well for Wayland we need to change KWindowSystem anyway and I don't want to low level protocols. So who wants to Is that going to be kwin-only, or we have a hope it will be picked up by others? Cheerio -- Prediction is very difficult, especially about the future. -- Niels Bohr ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Re: removing dependencies from kactivitymanagerd
On Tuesday 04 October 2011 18:29:33 Ivan Cukic wrote: General question - do you want to create a fw5 branch or something like that? Aaron KUniqueApplication: this lives in kdeui ... just to provide a way to have only one instance of the app. ugh. in Frameworks there is libkdbus which has a KDBusService which provides the same capabilities. porting to that proved quite simple and straightforward and let ActivityManager become a QCoreApplication subclass. Do we even need KDBusService? Just a check of QDBusConnectionInterface::isServiceRegistered can be used for this. Martin Well for Wayland we need to change KWindowSystem anyway and I don't want to low level protocols. So who wants to Is that going to be kwin-only, or we have a hope it will be picked up by others? Given the low interest of other window managers to collaborate recently, I doubt that. But do we care, if not? And we still can just open our own watch service to use if KWin is not running. Cheers Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: removing dependencies from kactivitymanagerd
Given the low interest of other window managers to collaborate recently, I doubt that. But do we care, if not? I don't know really. Sometimes I want to say hey, this is a hard dep, deal with it, but then I see people who use rather quirky setups. But, yeah, we can do it kwin only, and if we get enough bug reports, go for the: And we still can just open our own watch service to use if KWin is not running. Ch -- There are no such things as applied sciences, only applications of science. -- Louis Pasteur ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: removing dependencies from kactivitymanagerd
On Tuesday 04 October 2011 18:29:33 Ivan Cukic wrote: Do we even need KDBusService? Just a check of QDBusConnectionInterface::isServiceRegistered can be used for this. Well, you need to add the fact that you also have to verify the connection to the bus to trigger it if necessary, register the proper service name, and also make the various cases of error handling... then the resulting code will be pretty much what a one liner like KDBusService service(KDBusService::Unique); does. Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud patron of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
