Re: Review Request: Add "Show Icon only" option to the tasks applet

2010-09-11 Thread Björn Ruberg


> On 2010-08-23 09:00:48, Marco Martin wrote:
> > this very patch appeared here for several times already.
> > and as usual, the question is: what real value gives over auto hiding the 
> > text when there is not enough space?
> 
> Markus Slopianka wrote:
> If this patch works with the other one that implements launcher support, 
> a Mac OS X-like Dock (AFAIK it's similar in Win7) can be implemented without 
> the need to get 3rd party widgets.
> With a Dock-like setup I wouldn't want text other than tooltips.
> 
> Beat Wolf wrote:
> i would actually agree on adding it from the feedback i get when i show 
> kde to people used to windows. it's one of the first things they ask for.
> 
> Aaron Seigo wrote:
> the number of such features that have appeared over the years is immense, 
> and always people ask for those features ... as long as they are new in 
> Windows. there is no point in chasing taillights just to chase taillights. if 
> the idea is a good one, let's do it; if it isn't, let's not.
> 
> Beat Wolf wrote:
> sure. i was just mentioning it because i for myself think its a good idea 
> and other people want it, so from my point of view if the patch has a good 
> quality, and it's actually using a feature that is there anyway, why not have 
> it.
> But i see the other point of views too and all have their merit i think.
> 
> Todd wrote:
> I think that the question is not so much a question of why we shouldn't 
> have titles in the task manager, the question is why we need them.  With 
> grouping and the ability in 4.5 to change between grouped windows by clicking 
> on their thumbnail, at least for me titles are just wasted space.  I 
> understand that for people without compositing they are needed, and some 
> people may still prefer them, but personally they don't contribute anything, 
> and they are huge relative to just the icons.
> 
> I agree that the the current configuration interface for the task manager 
> is getting a bit crowded.  However, there is a way to add the feature without 
> increasing the complexity of the dialog.  Currently there are three grouping 
> options: "Do not group", "Manually", and "By Program Name".  There is also an 
> checkox "Only when taskbar is full".  The problem is that this option is only 
> meaningful in "By Program Name" mode, and in fact the checkbox is disabled 
> when the other two modes.  So I would suggest getting rid of the checkbox and 
> adding a fourth option in the dropdown "When taskbar is full", or something 
> along those lines. 
> 
> Also, since plasma supports multiple categories in the configuration 
> dialog, it may be worthwhile splitting the current options into categories.
> 
> Marco Martin wrote:
> > With grouping and the ability in 4.5 to change between grouped windows 
> by clicking on their thumbnail, at least for me titles are just wasted space.
> 
> well, i think in this case is really fake "wasted space" because i would 
> agree if the text would let to have less icons in the taskbar.
> but since when there is not enough room the text gets disabled 
> automatically, this is a no issue.
> without that i really don't see use cases except making it look like 
> windows
> 
> Todd wrote:
> It isn't fake wasted space, there is still a bunch of text on there that 
> fills up the area while contributing nothing to me.  I don't think it looks 
> good.  This has nothing whatsoever to do with making it look like windows, I 
> couldn't care less what windows does.  It has to do with not making it look 
> cluttered and inelegant.  
> 
> The text also contributes to the resizing of the panel, making the panel 
> much larger than it has to be.  I could, of course, force the panel to be 
> small, but that works against me when I do have a lot of open windows, since 
> it drastically limits the number of windows I can work with easily.  
> 
> Further, when the text is removed the tasks still expand to fill the 
> available space, which looks really bad in my opinion.  It makes sense when 
> you want to show the text is hidden, but not when you don't want to deal with 
> the text at all.
> 
> Aaron Seigo wrote:
> "contributing nothing to me"
> 
> * a larger target (Fitt's "Law")
> * disambiguation from other similar items
> 
> that may not matter to you, and i fully grant that. it matters to others, 
> and we (the maintainers of this item) do not see enough value in option to 
> turn the items into icons-only to include it in the tasks plasmoid directly.
> 
> i have, however, already described a way that you (and whomever else) can 
> accomplish your goals. we aren't exclusive, plasma has been designed to allow 
> differences of opinion, differences of goals. others have taken advantage of 
> this with stasks, fancytasks, etc. you can do the same without having to 
> convince anyone or ask anyone's permission. so instead of continuin

Re: Review Request: Add "Show Icon only" option to the tasks applet

2010-09-11 Thread Björn Ruberg


> On 2010-08-23 09:00:48, Marco Martin wrote:
> > this very patch appeared here for several times already.
> > and as usual, the question is: what real value gives over auto hiding the 
> > text when there is not enough space?
> 
> Markus Slopianka wrote:
> If this patch works with the other one that implements launcher support, 
> a Mac OS X-like Dock (AFAIK it's similar in Win7) can be implemented without 
> the need to get 3rd party widgets.
> With a Dock-like setup I wouldn't want text other than tooltips.
> 
> Beat Wolf wrote:
> i would actually agree on adding it from the feedback i get when i show 
> kde to people used to windows. it's one of the first things they ask for.
> 
> Aaron Seigo wrote:
> the number of such features that have appeared over the years is immense, 
> and always people ask for those features ... as long as they are new in 
> Windows. there is no point in chasing taillights just to chase taillights. if 
> the idea is a good one, let's do it; if it isn't, let's not.
> 
> Beat Wolf wrote:
> sure. i was just mentioning it because i for myself think its a good idea 
> and other people want it, so from my point of view if the patch has a good 
> quality, and it's actually using a feature that is there anyway, why not have 
> it.
> But i see the other point of views too and all have their merit i think.
> 
> Todd wrote:
> I think that the question is not so much a question of why we shouldn't 
> have titles in the task manager, the question is why we need them.  With 
> grouping and the ability in 4.5 to change between grouped windows by clicking 
> on their thumbnail, at least for me titles are just wasted space.  I 
> understand that for people without compositing they are needed, and some 
> people may still prefer them, but personally they don't contribute anything, 
> and they are huge relative to just the icons.
> 
> I agree that the the current configuration interface for the task manager 
> is getting a bit crowded.  However, there is a way to add the feature without 
> increasing the complexity of the dialog.  Currently there are three grouping 
> options: "Do not group", "Manually", and "By Program Name".  There is also an 
> checkox "Only when taskbar is full".  The problem is that this option is only 
> meaningful in "By Program Name" mode, and in fact the checkbox is disabled 
> when the other two modes.  So I would suggest getting rid of the checkbox and 
> adding a fourth option in the dropdown "When taskbar is full", or something 
> along those lines. 
> 
> Also, since plasma supports multiple categories in the configuration 
> dialog, it may be worthwhile splitting the current options into categories.
> 
> Marco Martin wrote:
> > With grouping and the ability in 4.5 to change between grouped windows 
> by clicking on their thumbnail, at least for me titles are just wasted space.
> 
> well, i think in this case is really fake "wasted space" because i would 
> agree if the text would let to have less icons in the taskbar.
> but since when there is not enough room the text gets disabled 
> automatically, this is a no issue.
> without that i really don't see use cases except making it look like 
> windows
> 
> Todd wrote:
> It isn't fake wasted space, there is still a bunch of text on there that 
> fills up the area while contributing nothing to me.  I don't think it looks 
> good.  This has nothing whatsoever to do with making it look like windows, I 
> couldn't care less what windows does.  It has to do with not making it look 
> cluttered and inelegant.  
> 
> The text also contributes to the resizing of the panel, making the panel 
> much larger than it has to be.  I could, of course, force the panel to be 
> small, but that works against me when I do have a lot of open windows, since 
> it drastically limits the number of windows I can work with easily.  
> 
> Further, when the text is removed the tasks still expand to fill the 
> available space, which looks really bad in my opinion.  It makes sense when 
> you want to show the text is hidden, but not when you don't want to deal with 
> the text at all.
> 
> Aaron Seigo wrote:
> "contributing nothing to me"
> 
> * a larger target (Fitt's "Law")
> * disambiguation from other similar items
> 
> that may not matter to you, and i fully grant that. it matters to others, 
> and we (the maintainers of this item) do not see enough value in option to 
> turn the items into icons-only to include it in the tasks plasmoid directly.
> 
> i have, however, already described a way that you (and whomever else) can 
> accomplish your goals. we aren't exclusive, plasma has been designed to allow 
> differences of opinion, differences of goals. others have taken advantage of 
> this with stasks, fancytasks, etc. you can do the same without having to 
> convince anyone or ask anyone's permission. so instead of continuin

Re: Review Request: Add "Show Icon only" option to the tasks applet

2010-08-24 Thread Aaron Seigo


> On 2010-08-23 09:00:48, Marco Martin wrote:
> > this very patch appeared here for several times already.
> > and as usual, the question is: what real value gives over auto hiding the 
> > text when there is not enough space?
> 
> Markus Slopianka wrote:
> If this patch works with the other one that implements launcher support, 
> a Mac OS X-like Dock (AFAIK it's similar in Win7) can be implemented without 
> the need to get 3rd party widgets.
> With a Dock-like setup I wouldn't want text other than tooltips.
> 
> Beat Wolf wrote:
> i would actually agree on adding it from the feedback i get when i show 
> kde to people used to windows. it's one of the first things they ask for.
> 
> Aaron Seigo wrote:
> the number of such features that have appeared over the years is immense, 
> and always people ask for those features ... as long as they are new in 
> Windows. there is no point in chasing taillights just to chase taillights. if 
> the idea is a good one, let's do it; if it isn't, let's not.
> 
> Beat Wolf wrote:
> sure. i was just mentioning it because i for myself think its a good idea 
> and other people want it, so from my point of view if the patch has a good 
> quality, and it's actually using a feature that is there anyway, why not have 
> it.
> But i see the other point of views too and all have their merit i think.
> 
> Todd wrote:
> I think that the question is not so much a question of why we shouldn't 
> have titles in the task manager, the question is why we need them.  With 
> grouping and the ability in 4.5 to change between grouped windows by clicking 
> on their thumbnail, at least for me titles are just wasted space.  I 
> understand that for people without compositing they are needed, and some 
> people may still prefer them, but personally they don't contribute anything, 
> and they are huge relative to just the icons.
> 
> I agree that the the current configuration interface for the task manager 
> is getting a bit crowded.  However, there is a way to add the feature without 
> increasing the complexity of the dialog.  Currently there are three grouping 
> options: "Do not group", "Manually", and "By Program Name".  There is also an 
> checkox "Only when taskbar is full".  The problem is that this option is only 
> meaningful in "By Program Name" mode, and in fact the checkbox is disabled 
> when the other two modes.  So I would suggest getting rid of the checkbox and 
> adding a fourth option in the dropdown "When taskbar is full", or something 
> along those lines. 
> 
> Also, since plasma supports multiple categories in the configuration 
> dialog, it may be worthwhile splitting the current options into categories.
> 
> Marco Martin wrote:
> > With grouping and the ability in 4.5 to change between grouped windows 
> by clicking on their thumbnail, at least for me titles are just wasted space.
> 
> well, i think in this case is really fake "wasted space" because i would 
> agree if the text would let to have less icons in the taskbar.
> but since when there is not enough room the text gets disabled 
> automatically, this is a no issue.
> without that i really don't see use cases except making it look like 
> windows
> 
> Todd wrote:
> It isn't fake wasted space, there is still a bunch of text on there that 
> fills up the area while contributing nothing to me.  I don't think it looks 
> good.  This has nothing whatsoever to do with making it look like windows, I 
> couldn't care less what windows does.  It has to do with not making it look 
> cluttered and inelegant.  
> 
> The text also contributes to the resizing of the panel, making the panel 
> much larger than it has to be.  I could, of course, force the panel to be 
> small, but that works against me when I do have a lot of open windows, since 
> it drastically limits the number of windows I can work with easily.  
> 
> Further, when the text is removed the tasks still expand to fill the 
> available space, which looks really bad in my opinion.  It makes sense when 
> you want to show the text is hidden, but not when you don't want to deal with 
> the text at all.

"contributing nothing to me"

* a larger target (Fitt's "Law")
* disambiguation from other similar items

that may not matter to you, and i fully grant that. it matters to others, and 
we (the maintainers of this item) do not see enough value in option to turn the 
items into icons-only to include it in the tasks plasmoid directly.

i have, however, already described a way that you (and whomever else) can 
accomplish your goals. we aren't exclusive, plasma has been designed to allow 
differences of opinion, differences of goals. others have taken advantage of 
this with stasks, fancytasks, etc. you can do the same without having to 
convince anyone or ask anyone's permission. so instead of continuing this 
conversation which is going to lead nowhere other than to find out what we 

Re: Review Request: Add "Show Icon only" option to the tasks applet

2010-08-24 Thread Todd


> On 2010-08-23 09:00:48, Marco Martin wrote:
> > this very patch appeared here for several times already.
> > and as usual, the question is: what real value gives over auto hiding the 
> > text when there is not enough space?
> 
> Markus Slopianka wrote:
> If this patch works with the other one that implements launcher support, 
> a Mac OS X-like Dock (AFAIK it's similar in Win7) can be implemented without 
> the need to get 3rd party widgets.
> With a Dock-like setup I wouldn't want text other than tooltips.
> 
> Beat Wolf wrote:
> i would actually agree on adding it from the feedback i get when i show 
> kde to people used to windows. it's one of the first things they ask for.
> 
> Aaron Seigo wrote:
> the number of such features that have appeared over the years is immense, 
> and always people ask for those features ... as long as they are new in 
> Windows. there is no point in chasing taillights just to chase taillights. if 
> the idea is a good one, let's do it; if it isn't, let's not.
> 
> Beat Wolf wrote:
> sure. i was just mentioning it because i for myself think its a good idea 
> and other people want it, so from my point of view if the patch has a good 
> quality, and it's actually using a feature that is there anyway, why not have 
> it.
> But i see the other point of views too and all have their merit i think.
> 
> Todd wrote:
> I think that the question is not so much a question of why we shouldn't 
> have titles in the task manager, the question is why we need them.  With 
> grouping and the ability in 4.5 to change between grouped windows by clicking 
> on their thumbnail, at least for me titles are just wasted space.  I 
> understand that for people without compositing they are needed, and some 
> people may still prefer them, but personally they don't contribute anything, 
> and they are huge relative to just the icons.
> 
> I agree that the the current configuration interface for the task manager 
> is getting a bit crowded.  However, there is a way to add the feature without 
> increasing the complexity of the dialog.  Currently there are three grouping 
> options: "Do not group", "Manually", and "By Program Name".  There is also an 
> checkox "Only when taskbar is full".  The problem is that this option is only 
> meaningful in "By Program Name" mode, and in fact the checkbox is disabled 
> when the other two modes.  So I would suggest getting rid of the checkbox and 
> adding a fourth option in the dropdown "When taskbar is full", or something 
> along those lines. 
> 
> Also, since plasma supports multiple categories in the configuration 
> dialog, it may be worthwhile splitting the current options into categories.
> 
> Marco Martin wrote:
> > With grouping and the ability in 4.5 to change between grouped windows 
> by clicking on their thumbnail, at least for me titles are just wasted space.
> 
> well, i think in this case is really fake "wasted space" because i would 
> agree if the text would let to have less icons in the taskbar.
> but since when there is not enough room the text gets disabled 
> automatically, this is a no issue.
> without that i really don't see use cases except making it look like 
> windows

It isn't fake wasted space, there is still a bunch of text on there that fills 
up the area while contributing nothing to me.  I don't think it looks good.  
This has nothing whatsoever to do with making it look like windows, I couldn't 
care less what windows does.  It has to do with not making it look cluttered 
and inelegant.  

The text also contributes to the resizing of the panel, making the panel much 
larger than it has to be.  I could, of course, force the panel to be small, but 
that works against me when I do have a lot of open windows, since it 
drastically limits the number of windows I can work with easily.  

Further, when the text is removed the tasks still expand to fill the available 
space, which looks really bad in my opinion.  It makes sense when you want to 
show the text is hidden, but not when you don't want to deal with the text at 
all.


- Todd


---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5078/#review7162
---


On 2010-08-22 13:52:33, Björn Ruberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5078/
> ---
> 
> (Updated 2010-08-22 13:52:33)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> ---
> 
> This patch adds the option to put the taskbar in an icon-only mode - similar 
> as in Windows 7 . This is an much requested feature in bugzilla.
> It is fairly simple and just using features already existing in the code, 
> adding an m_showIconOnly

Re: Review Request: Add "Show Icon only" option to the tasks applet

2010-08-24 Thread Marco Martin


> On 2010-08-23 09:00:48, Marco Martin wrote:
> > this very patch appeared here for several times already.
> > and as usual, the question is: what real value gives over auto hiding the 
> > text when there is not enough space?
> 
> Markus Slopianka wrote:
> If this patch works with the other one that implements launcher support, 
> a Mac OS X-like Dock (AFAIK it's similar in Win7) can be implemented without 
> the need to get 3rd party widgets.
> With a Dock-like setup I wouldn't want text other than tooltips.
> 
> Beat Wolf wrote:
> i would actually agree on adding it from the feedback i get when i show 
> kde to people used to windows. it's one of the first things they ask for.
> 
> Aaron Seigo wrote:
> the number of such features that have appeared over the years is immense, 
> and always people ask for those features ... as long as they are new in 
> Windows. there is no point in chasing taillights just to chase taillights. if 
> the idea is a good one, let's do it; if it isn't, let's not.
> 
> Beat Wolf wrote:
> sure. i was just mentioning it because i for myself think its a good idea 
> and other people want it, so from my point of view if the patch has a good 
> quality, and it's actually using a feature that is there anyway, why not have 
> it.
> But i see the other point of views too and all have their merit i think.
> 
> Todd wrote:
> I think that the question is not so much a question of why we shouldn't 
> have titles in the task manager, the question is why we need them.  With 
> grouping and the ability in 4.5 to change between grouped windows by clicking 
> on their thumbnail, at least for me titles are just wasted space.  I 
> understand that for people without compositing they are needed, and some 
> people may still prefer them, but personally they don't contribute anything, 
> and they are huge relative to just the icons.
> 
> I agree that the the current configuration interface for the task manager 
> is getting a bit crowded.  However, there is a way to add the feature without 
> increasing the complexity of the dialog.  Currently there are three grouping 
> options: "Do not group", "Manually", and "By Program Name".  There is also an 
> checkox "Only when taskbar is full".  The problem is that this option is only 
> meaningful in "By Program Name" mode, and in fact the checkbox is disabled 
> when the other two modes.  So I would suggest getting rid of the checkbox and 
> adding a fourth option in the dropdown "When taskbar is full", or something 
> along those lines. 
> 
> Also, since plasma supports multiple categories in the configuration 
> dialog, it may be worthwhile splitting the current options into categories.

> With grouping and the ability in 4.5 to change between grouped windows by 
> clicking on their thumbnail, at least for me titles are just wasted space.

well, i think in this case is really fake "wasted space" because i would agree 
if the text would let to have less icons in the taskbar.
but since when there is not enough room the text gets disabled automatically, 
this is a no issue.
without that i really don't see use cases except making it look like windows


- Marco


---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5078/#review7162
---


On 2010-08-22 13:52:33, Björn Ruberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5078/
> ---
> 
> (Updated 2010-08-22 13:52:33)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> ---
> 
> This patch adds the option to put the taskbar in an icon-only mode - similar 
> as in Windows 7 . This is an much requested feature in bugzilla.
> It is fairly simple and just using features already existing in the code, 
> adding an m_showIconOnly member to the layout and the abstractitem plus the 
> adaption of the config ui.
> 
> 
> This addresses bug 159480.
> https://bugs.kde.org/show_bug.cgi?id=159480
> 
> 
> Diffs
> -
> 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/tasksConfig.ui 
> 1166313 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/tasks.cpp 1166313 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskitemlayout.h 
> 1166313 
>   
> /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskitemlayout.cpp 
> 1166313 
>   
> /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/abstracttaskitem.h 
> 1166313 
>   
> /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/abstracttaskitem.cpp
>  1166313 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskgroupitem.h 
> 1166313 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskgroupitem.cpp 
> 1166313 
> 
> Diff: 

Re: Review Request: Add "Show Icon only" option to the tasks applet

2010-08-24 Thread Todd


> On 2010-08-23 09:00:48, Marco Martin wrote:
> > this very patch appeared here for several times already.
> > and as usual, the question is: what real value gives over auto hiding the 
> > text when there is not enough space?
> 
> Markus Slopianka wrote:
> If this patch works with the other one that implements launcher support, 
> a Mac OS X-like Dock (AFAIK it's similar in Win7) can be implemented without 
> the need to get 3rd party widgets.
> With a Dock-like setup I wouldn't want text other than tooltips.
> 
> Beat Wolf wrote:
> i would actually agree on adding it from the feedback i get when i show 
> kde to people used to windows. it's one of the first things they ask for.
> 
> Aaron Seigo wrote:
> the number of such features that have appeared over the years is immense, 
> and always people ask for those features ... as long as they are new in 
> Windows. there is no point in chasing taillights just to chase taillights. if 
> the idea is a good one, let's do it; if it isn't, let's not.
> 
> Beat Wolf wrote:
> sure. i was just mentioning it because i for myself think its a good idea 
> and other people want it, so from my point of view if the patch has a good 
> quality, and it's actually using a feature that is there anyway, why not have 
> it.
> But i see the other point of views too and all have their merit i think.

I think that the question is not so much a question of why we shouldn't have 
titles in the task manager, the question is why we need them.  With grouping 
and the ability in 4.5 to change between grouped windows by clicking on their 
thumbnail, at least for me titles are just wasted space.  I understand that for 
people without compositing they are needed, and some people may still prefer 
them, but personally they don't contribute anything, and they are huge relative 
to just the icons.

I agree that the the current configuration interface for the task manager is 
getting a bit crowded.  However, there is a way to add the feature without 
increasing the complexity of the dialog.  Currently there are three grouping 
options: "Do not group", "Manually", and "By Program Name".  There is also an 
checkox "Only when taskbar is full".  The problem is that this option is only 
meaningful in "By Program Name" mode, and in fact the checkbox is disabled when 
the other two modes.  So I would suggest getting rid of the checkbox and adding 
a fourth option in the dropdown "When taskbar is full", or something along 
those lines. 

Also, since plasma supports multiple categories in the configuration dialog, it 
may be worthwhile splitting the current options into categories.


- Todd


---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5078/#review7162
---


On 2010-08-22 13:52:33, Björn Ruberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5078/
> ---
> 
> (Updated 2010-08-22 13:52:33)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> ---
> 
> This patch adds the option to put the taskbar in an icon-only mode - similar 
> as in Windows 7 . This is an much requested feature in bugzilla.
> It is fairly simple and just using features already existing in the code, 
> adding an m_showIconOnly member to the layout and the abstractitem plus the 
> adaption of the config ui.
> 
> 
> This addresses bug 159480.
> https://bugs.kde.org/show_bug.cgi?id=159480
> 
> 
> Diffs
> -
> 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/tasksConfig.ui 
> 1166313 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/tasks.cpp 1166313 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskitemlayout.h 
> 1166313 
>   
> /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskitemlayout.cpp 
> 1166313 
>   
> /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/abstracttaskitem.h 
> 1166313 
>   
> /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/abstracttaskitem.cpp
>  1166313 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskgroupitem.h 
> 1166313 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskgroupitem.cpp 
> 1166313 
> 
> Diff: http://reviewboard.kde.org/r/5078/diff
> 
> 
> Testing
> ---
> 
> Moved panel around and made sure it works. Looks actually pretty good this 
> icon-only mode!
> 
> 
> Thanks,
> 
> Björn
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: Add "Show Icon only" option to the tasks applet

2010-08-24 Thread Beat Wolf


> On 2010-08-23 09:00:48, Marco Martin wrote:
> > this very patch appeared here for several times already.
> > and as usual, the question is: what real value gives over auto hiding the 
> > text when there is not enough space?
> 
> Markus Slopianka wrote:
> If this patch works with the other one that implements launcher support, 
> a Mac OS X-like Dock (AFAIK it's similar in Win7) can be implemented without 
> the need to get 3rd party widgets.
> With a Dock-like setup I wouldn't want text other than tooltips.
> 
> Beat Wolf wrote:
> i would actually agree on adding it from the feedback i get when i show 
> kde to people used to windows. it's one of the first things they ask for.
> 
> Aaron Seigo wrote:
> the number of such features that have appeared over the years is immense, 
> and always people ask for those features ... as long as they are new in 
> Windows. there is no point in chasing taillights just to chase taillights. if 
> the idea is a good one, let's do it; if it isn't, let's not.

sure. i was just mentioning it because i for myself think its a good idea and 
other people want it, so from my point of view if the patch has a good quality, 
and it's actually using a feature that is there anyway, why not have it.
But i see the other point of views too and all have their merit i think.


- Beat


---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5078/#review7162
---


On 2010-08-22 13:52:33, Björn Ruberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5078/
> ---
> 
> (Updated 2010-08-22 13:52:33)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> ---
> 
> This patch adds the option to put the taskbar in an icon-only mode - similar 
> as in Windows 7 . This is an much requested feature in bugzilla.
> It is fairly simple and just using features already existing in the code, 
> adding an m_showIconOnly member to the layout and the abstractitem plus the 
> adaption of the config ui.
> 
> 
> This addresses bug 159480.
> https://bugs.kde.org/show_bug.cgi?id=159480
> 
> 
> Diffs
> -
> 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/tasksConfig.ui 
> 1166313 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/tasks.cpp 1166313 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskitemlayout.h 
> 1166313 
>   
> /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskitemlayout.cpp 
> 1166313 
>   
> /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/abstracttaskitem.h 
> 1166313 
>   
> /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/abstracttaskitem.cpp
>  1166313 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskgroupitem.h 
> 1166313 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskgroupitem.cpp 
> 1166313 
> 
> Diff: http://reviewboard.kde.org/r/5078/diff
> 
> 
> Testing
> ---
> 
> Moved panel around and made sure it works. Looks actually pretty good this 
> icon-only mode!
> 
> 
> Thanks,
> 
> Björn
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: Add "Show Icon only" option to the tasks applet

2010-08-23 Thread Aaron J. Seigo
(please keep future discussions on reviewboard, so we aren't chasing half the 
thread here via email and half on reviewboard... :)

On Monday, August 23, 2010, Björn Ruberg wrote:
> > this very patch appeared here for several times already.
> > and as usual, the question is: what real value gives over auto hiding the
> > text when there is not enough space?
> 
> It makes grouping - what increases the amount of clicks you need to get to
> your application by one - unnecessary. 

or you could turn grouping off.

> You can usually see what
> applications are running because you have to look at some icons only
> instead of having to look at the whole panel width.

which some will be happy with, but certainly doesn't help me with my four 
kontact windows, three konsole windows and two firefox windows. :)

> The later often needs
> eye movements (depends on your screen). It's much more appealing to have
> just an icon instead of a task- item with a much shortened window title in
> it.

yes, it's mostly aesthetic. which isn't a bad thing in-and-of-itself. but in 
this case it means requiring another option in the default user interface, and 
this dialog is already fairly full. i'd rather reserve future additions to it 
for actually useful things.

for more dock-like behaviour, i completely agree with Martin G.: use a 
different widget.

i'd personally even be happy with a different style of tasks widget in 
kdeplasma-addons that did funky things like "icons only" or other fun things, 
as long as it was reasonably well done from a user's POV (so: not a random 
collection of dozens of configuration items, no half-baked presentation in the 
widget itself). it would require thinking about the design of the thing: what 
would make it unique, interesting, compelling to use?

kasbar was a good example of such a "outside the regular box" applet back in 
kicker's day. i'd much rather see more separate widgets tuned to different 
kinds of workflows than us try to cram every possible feature into just one 
widget, turning it into a usability and maintenance nightmare than nobody is 
ever 100% happy with.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: Add "Show Icon only" option to the tasks applet

2010-08-23 Thread Aaron Seigo


> On 2010-08-23 09:00:48, Marco Martin wrote:
> > this very patch appeared here for several times already.
> > and as usual, the question is: what real value gives over auto hiding the 
> > text when there is not enough space?
> 
> Markus Slopianka wrote:
> If this patch works with the other one that implements launcher support, 
> a Mac OS X-like Dock (AFAIK it's similar in Win7) can be implemented without 
> the need to get 3rd party widgets.
> With a Dock-like setup I wouldn't want text other than tooltips.
> 
> Beat Wolf wrote:
> i would actually agree on adding it from the feedback i get when i show 
> kde to people used to windows. it's one of the first things they ask for.

the number of such features that have appeared over the years is immense, and 
always people ask for those features ... as long as they are new in Windows. 
there is no point in chasing taillights just to chase taillights. if the idea 
is a good one, let's do it; if it isn't, let's not.


- Aaron


---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5078/#review7162
---


On 2010-08-22 13:52:33, Björn Ruberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5078/
> ---
> 
> (Updated 2010-08-22 13:52:33)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> ---
> 
> This patch adds the option to put the taskbar in an icon-only mode - similar 
> as in Windows 7 . This is an much requested feature in bugzilla.
> It is fairly simple and just using features already existing in the code, 
> adding an m_showIconOnly member to the layout and the abstractitem plus the 
> adaption of the config ui.
> 
> 
> This addresses bug 159480.
> https://bugs.kde.org/show_bug.cgi?id=159480
> 
> 
> Diffs
> -
> 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/tasksConfig.ui 
> 1166313 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/tasks.cpp 1166313 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskitemlayout.h 
> 1166313 
>   
> /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskitemlayout.cpp 
> 1166313 
>   
> /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/abstracttaskitem.h 
> 1166313 
>   
> /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/abstracttaskitem.cpp
>  1166313 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskgroupitem.h 
> 1166313 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskgroupitem.cpp 
> 1166313 
> 
> Diff: http://reviewboard.kde.org/r/5078/diff
> 
> 
> Testing
> ---
> 
> Moved panel around and made sure it works. Looks actually pretty good this 
> icon-only mode!
> 
> 
> Thanks,
> 
> Björn
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: Add "Show Icon only" option to the tasks applet

2010-08-23 Thread Martin Gräßlin
On Monday 23 August 2010 11:53:03 Markus Slopianka wrote:
> > On 2010-08-23 09:00:48, Marco Martin wrote:
> > > this very patch appeared here for several times already.
> > > and as usual, the question is: what real value gives over auto hiding
> > > the text when there is not enough space?
> 
> If this patch works with the other one that implements launcher support, a
> Mac OS X-like Dock (AFAIK it's similar in Win7) can be implemented without
> the need to get 3rd party widgets. With a Dock-like setup I wouldn't want
> text other than tooltips.
Please note that we cannot do proper docks in KDE yet (for various reasons 
related to the way we have X and windows and apps as totally different 
concepts). Windows can't do it as well. They ended up with something horrible 
broken in Win7. So for me it is clear: KDE *must* not ship a dock like 
implementation in the default set. For every body coming from Mac and knowing 
the "real" dock  it will just be: "that sucks" and for everybody coming from 
Windows it's "they copied". Both is bad and gives us no additional value 
except making a vocal minority quiet.

I think we went quite good up to now with "use stasks/fancytasks when you want 
dock". For me it's natural that we don't include broken concepts by default 
and that we ask the user to install the broken concept explicitly when they 
want to.


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: Add "Show Icon only" option to the tasks applet

2010-08-23 Thread Beat Wolf


> On 2010-08-23 09:00:48, Marco Martin wrote:
> > this very patch appeared here for several times already.
> > and as usual, the question is: what real value gives over auto hiding the 
> > text when there is not enough space?
> 
> Markus Slopianka wrote:
> If this patch works with the other one that implements launcher support, 
> a Mac OS X-like Dock (AFAIK it's similar in Win7) can be implemented without 
> the need to get 3rd party widgets.
> With a Dock-like setup I wouldn't want text other than tooltips.

i would actually agree on adding it from the feedback i get when i show kde to 
people used to windows. it's one of the first things they ask for.


- Beat


---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5078/#review7162
---


On 2010-08-22 13:52:33, Björn Ruberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5078/
> ---
> 
> (Updated 2010-08-22 13:52:33)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> ---
> 
> This patch adds the option to put the taskbar in an icon-only mode - similar 
> as in Windows 7 . This is an much requested feature in bugzilla.
> It is fairly simple and just using features already existing in the code, 
> adding an m_showIconOnly member to the layout and the abstractitem plus the 
> adaption of the config ui.
> 
> 
> This addresses bug 159480.
> https://bugs.kde.org/show_bug.cgi?id=159480
> 
> 
> Diffs
> -
> 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/tasksConfig.ui 
> 1166313 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/tasks.cpp 1166313 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskitemlayout.h 
> 1166313 
>   
> /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskitemlayout.cpp 
> 1166313 
>   
> /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/abstracttaskitem.h 
> 1166313 
>   
> /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/abstracttaskitem.cpp
>  1166313 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskgroupitem.h 
> 1166313 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskgroupitem.cpp 
> 1166313 
> 
> Diff: http://reviewboard.kde.org/r/5078/diff
> 
> 
> Testing
> ---
> 
> Moved panel around and made sure it works. Looks actually pretty good this 
> icon-only mode!
> 
> 
> Thanks,
> 
> Björn
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: Add "Show Icon only" option to the tasks applet

2010-08-23 Thread Markus Slopianka


> On 2010-08-23 09:00:48, Marco Martin wrote:
> > this very patch appeared here for several times already.
> > and as usual, the question is: what real value gives over auto hiding the 
> > text when there is not enough space?

If this patch works with the other one that implements launcher support, a Mac 
OS X-like Dock (AFAIK it's similar in Win7) can be implemented without the need 
to get 3rd party widgets.
With a Dock-like setup I wouldn't want text other than tooltips.


- Markus


---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5078/#review7162
---


On 2010-08-22 13:52:33, Björn Ruberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5078/
> ---
> 
> (Updated 2010-08-22 13:52:33)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> ---
> 
> This patch adds the option to put the taskbar in an icon-only mode - similar 
> as in Windows 7 . This is an much requested feature in bugzilla.
> It is fairly simple and just using features already existing in the code, 
> adding an m_showIconOnly member to the layout and the abstractitem plus the 
> adaption of the config ui.
> 
> 
> This addresses bug 159480.
> https://bugs.kde.org/show_bug.cgi?id=159480
> 
> 
> Diffs
> -
> 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/tasksConfig.ui 
> 1166313 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/tasks.cpp 1166313 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskitemlayout.h 
> 1166313 
>   
> /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskitemlayout.cpp 
> 1166313 
>   
> /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/abstracttaskitem.h 
> 1166313 
>   
> /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/abstracttaskitem.cpp
>  1166313 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskgroupitem.h 
> 1166313 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskgroupitem.cpp 
> 1166313 
> 
> Diff: http://reviewboard.kde.org/r/5078/diff
> 
> 
> Testing
> ---
> 
> Moved panel around and made sure it works. Looks actually pretty good this 
> icon-only mode!
> 
> 
> Thanks,
> 
> Björn
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: Add "Show Icon only" option to the tasks applet

2010-08-23 Thread Björn Ruberg
An Montag, 23. August 2010 11:00:46 schrieben Sie:
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5078/#review7162
> ---
> 
> 
> this very patch appeared here for several times already.
> and as usual, the question is: what real value gives over auto hiding the
> text when there is not enough space?

It makes grouping - what increases the amount of clicks you need to get to 
your application by one - unnecessary. You can usually see what applications 
are running because you have to look at some icons only instead of having to 
look at the whole panel width. The later often needs eye movements (depends on 
your screen). It's much more appealing to have just an icon instead of a task-
item with a much shortened window title in it.

It it is on place six of the most wanted plasma features. 

> On 2010-08-22 13:52:33, Björn Ruberg wrote:
> > ---
> > This is an automatically generated e-mail. To reply, visit:
> > http://reviewboard.kde.org/r/5078/
> > ---
> > 
> > (Updated 2010-08-22 13:52:33)
> > 
> > 
> > Review request for Plasma.
> > 
> > 
> > Summary
> > ---
> > 
> > This patch adds the option to put the taskbar in an icon-only mode -
> > similar as in Windows 7 . This is an much requested feature in bugzilla.
> > It is fairly simple and just using features already existing in the
> > code, adding an m_showIconOnly member to the layout and the abstractitem
> > plus the adaption of the config ui.
> > 
> > 
> > This addresses bug 159480.
> > 
> > https://bugs.kde.org/show_bug.cgi?id=159480
> > 
> > Diffs
> > -
> > 
> >   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/tasksConfig.u
> >   i 1166313
> >   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/tasks.cpp
> >   1166313
> >   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskitemlayo
> >   ut.h 1166313
> >   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskitemlayo
> >   ut.cpp 1166313
> >   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/abstracttask
> >   item.h 1166313
> >   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/abstracttask
> >   item.cpp 1166313
> >   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskgroupite
> >   m.h 1166313
> >   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskgroupite
> >   m.cpp 1166313
> > 
> > Diff: http://reviewboard.kde.org/r/5078/diff
> > 
> > 
> > Testing
> > ---
> > 
> > Moved panel around and made sure it works. Looks actually pretty good
> > this icon-only mode!
> > 
> > 
> > Thanks,
> > 
> > Björn
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: Add "Show Icon only" option to the tasks applet

2010-08-23 Thread Marco Martin

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5078/#review7162
---


this very patch appeared here for several times already.
and as usual, the question is: what real value gives over auto hiding the text 
when there is not enough space?

- Marco


On 2010-08-22 13:52:33, Björn Ruberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5078/
> ---
> 
> (Updated 2010-08-22 13:52:33)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> ---
> 
> This patch adds the option to put the taskbar in an icon-only mode - similar 
> as in Windows 7 . This is an much requested feature in bugzilla.
> It is fairly simple and just using features already existing in the code, 
> adding an m_showIconOnly member to the layout and the abstractitem plus the 
> adaption of the config ui.
> 
> 
> This addresses bug 159480.
> https://bugs.kde.org/show_bug.cgi?id=159480
> 
> 
> Diffs
> -
> 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/tasksConfig.ui 
> 1166313 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/tasks.cpp 1166313 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskitemlayout.h 
> 1166313 
>   
> /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskitemlayout.cpp 
> 1166313 
>   
> /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/abstracttaskitem.h 
> 1166313 
>   
> /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/abstracttaskitem.cpp
>  1166313 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskgroupitem.h 
> 1166313 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskgroupitem.cpp 
> 1166313 
> 
> Diff: http://reviewboard.kde.org/r/5078/diff
> 
> 
> Testing
> ---
> 
> Moved panel around and made sure it works. Looks actually pretty good this 
> icon-only mode!
> 
> 
> Thanks,
> 
> Björn
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: Add "Show Icon only" option to the tasks applet

2010-08-22 Thread Björn Ruberg

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5078/
---

(Updated 2010-08-22 13:52:33.870330)


Review request for Plasma.


Changes
---

Corrected patch. This shows the labels in the expander menu of grouped items 
again.


Summary
---

This patch adds the option to put the taskbar in an icon-only mode - similar as 
in Windows 7 . This is an much requested feature in bugzilla.
It is fairly simple and just using features already existing in the code, 
adding an m_showIconOnly member to the layout and the abstractitem plus the 
adaption of the config ui.


This addresses bug 159480.
https://bugs.kde.org/show_bug.cgi?id=159480


Diffs (updated)
-

  /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/tasksConfig.ui 
1166313 
  /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/tasks.cpp 1166313 
  /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskitemlayout.h 
1166313 
  /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskitemlayout.cpp 
1166313 
  /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/abstracttaskitem.h 
1166313 
  
/trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/abstracttaskitem.cpp 
1166313 
  /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskgroupitem.h 
1166313 
  /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskgroupitem.cpp 
1166313 

Diff: http://reviewboard.kde.org/r/5078/diff


Testing
---

Moved panel around and made sure it works. Looks actually pretty good this 
icon-only mode!


Thanks,

Björn

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Review Request: Add "Show Icon only" option to the tasks applet

2010-08-22 Thread Björn Ruberg

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5078/
---

Review request for Plasma.


Summary
---

This patch adds the option to put the taskbar in an icon-only mode - similar as 
in Windows 7 . This is an much requested feature in bugzilla.
It is fairly simple and just using features already existing in the code, 
adding an m_showIconOnly member to the layout and the abstractitem plus the 
adaption of the config ui.


This addresses bug 159480.
https://bugs.kde.org/show_bug.cgi?id=159480


Diffs
-

  /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/abstracttaskitem.h 
1166313 
  
/trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/abstracttaskitem.cpp 
1166313 
  /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskgroupitem.h 
1166313 
  /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskgroupitem.cpp 
1166313 
  /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskitemlayout.h 
1166313 
  /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskitemlayout.cpp 
1166313 
  /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/tasks.cpp 1166313 
  /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/tasksConfig.ui 
1166313 

Diff: http://reviewboard.kde.org/r/5078/diff


Testing
---

Moved panel around and made sure it works. Looks actually pretty good this 
icon-only mode!


Thanks,

Björn

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel