Review Request: Add the plasmagik icon into the plasmate's repo

2012-11-22 Thread Giorgos Tsiapaliokas

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107419/
---

Review request for Plasma.


Description
---

This patch adds the plasmagik icon into plasmate and installs it in the 
"hicolor" directory.

Should we also remove the plasmagik icon from the svn tree?


Diffs
-

  plasmate/CMakeLists.txt 111c402 
  plasmate/icons/CMakeLists.txt PRE-CREATION 
  plasmate/icons/hi128-app-plasmagik.png PRE-CREATION 
  plasmate/icons/hi16-app-plasmagik.png PRE-CREATION 
  plasmate/icons/hi22-app-plasmagik.png PRE-CREATION 
  plasmate/icons/hi32-app-plasmagik.png PRE-CREATION 
  plasmate/icons/hi48-app-plasmagik.png PRE-CREATION 
  plasmate/icons/hi64-app-plasmagik.png PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/107419/diff/


Testing
---


Thanks,

Giorgos Tsiapaliokas

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: Add the plasmagik icon into the plasmate's repo

2012-11-22 Thread Aaron J. Seigo

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107419/#review22380
---

Ship it!


we can't remove it from oxygen as it is used elsewhere now. no point in 
needlessly breaking things.

see: http://lxr.kde.org/search?filestring=&string=plasmagik

- Aaron J. Seigo


On Nov. 22, 2012, 1:03 p.m., Giorgos Tsiapaliokas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107419/
> ---
> 
> (Updated Nov. 22, 2012, 1:03 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> This patch adds the plasmagik icon into plasmate and installs it in the 
> "hicolor" directory.
> 
> Should we also remove the plasmagik icon from the svn tree?
> 
> 
> Diffs
> -
> 
>   plasmate/CMakeLists.txt 111c402 
>   plasmate/icons/CMakeLists.txt PRE-CREATION 
>   plasmate/icons/hi128-app-plasmagik.png PRE-CREATION 
>   plasmate/icons/hi16-app-plasmagik.png PRE-CREATION 
>   plasmate/icons/hi22-app-plasmagik.png PRE-CREATION 
>   plasmate/icons/hi32-app-plasmagik.png PRE-CREATION 
>   plasmate/icons/hi48-app-plasmagik.png PRE-CREATION 
>   plasmate/icons/hi64-app-plasmagik.png PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/107419/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliokas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: Add the plasmagik icon into the plasmate's repo

2012-11-23 Thread Commit Hook

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107419/#review22429
---


This review has been submitted with commit 
ffa051910ff6658bae9bc9ad92b85eedd8f645d6 by Giorgos Tsiapaliokas to branch 
master.

- Commit Hook


On Nov. 22, 2012, 1:03 p.m., Giorgos Tsiapaliokas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107419/
> ---
> 
> (Updated Nov. 22, 2012, 1:03 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> This patch adds the plasmagik icon into plasmate and installs it in the 
> "hicolor" directory.
> 
> Should we also remove the plasmagik icon from the svn tree?
> 
> 
> Diffs
> -
> 
>   plasmate/CMakeLists.txt 111c402 
>   plasmate/icons/CMakeLists.txt PRE-CREATION 
>   plasmate/icons/hi128-app-plasmagik.png PRE-CREATION 
>   plasmate/icons/hi16-app-plasmagik.png PRE-CREATION 
>   plasmate/icons/hi22-app-plasmagik.png PRE-CREATION 
>   plasmate/icons/hi32-app-plasmagik.png PRE-CREATION 
>   plasmate/icons/hi48-app-plasmagik.png PRE-CREATION 
>   plasmate/icons/hi64-app-plasmagik.png PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/107419/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliokas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel